[PATCH v4 5/8] Staging: kpc2000: kpc_dma: Resolve checkpath errors Macros in paranthesis & trailing statements on next line.

This patch fixes below errors reported by checkpath ERROR: Macros with complex values should be enclosed in parentheses CHECK: Prefer using the BIT macro ERROR: trailing statements should be on next line ERROR: trailing statements should be on next line Signed-off-by: Vandana BN --- v2 - split

[PATCH v4 7/8] Staging: kpc2000: kpc_dma: Resolve warning to use __func__ insted of funtion name reported by checkpatch.

This patch resolves warnings to use __func__ insted of funtion name. WARNING: Prefer using '"%s...", __func__' to using 'setup_dma_engine', this function's name, in a string Signed-off-by: Vandana BN --- v2 - split changes to multiple patches v3 - edit com

[PATCH v4 8/8] Staging: kpc2000: kpc_dma: Resolve cast warning and use const for file_operation

This Patch resolves unnecessary cast warning and const file_operations reported by checkpath.pl WARNING: unnecessary cast may hide bugs WARNING: struct file_operations should normally be const Signed-off-by: Vandana BN --- v2 - split changes to multiple patches v3 - edit commit message, subject

[PATCH v4 6/8] Staging: kpc2000: kpc_dma: Resolve warning Missing blank line after declarations & labels not to be indented.

ff-by: Vandana BN --- v2 - split changes to multiple patches v3 - edit commit message, subject line v4 - edit commit message drivers/staging/kpc2000/kpc_dma/dma.c| 8 +--- drivers/staging/kpc2000/kpc_dma/fileops.c| 11 ++- drivers/staging/kpc2000/kpc_dma/kpc_dma_dri

[PATCH v4 3/8] Staging: kpc2000: kpc_dma: Resolve checkpatch space errors around brace '{', '!' and open paranthesis '('.

This patch resolves below errors reported by checkpath ERROR: space required before the open brace '{' ERROR: space prohibited after that '!' (ctx:BxW) ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Vandana BN --- v2 - split changes to mul

[PATCH v4 4/8] Staging: kpc2000: kpc_dma: Resolve code indent and trailing statements on next line errors reported by checkpatch.

This patch fixes code indentaion error reported by checkpath ERROR: switch and case should be at the same indent ERROR: trailing statements should be on next line Signed-off-by: Vandana BN --- v2 - split changes to multiple patches v3 - edit commit message, subject line v4 - edit commit message

[PATCH v4 1/8] Staging: kpc2000: kpc_dma: Resolve trailing whitespace error reported by checkpatch

Resolve trailing whitespace error from checkpatch.pl ERROR: trailing whitespace Signed-off-by: Vandana BN --- v2 - split changes to multiple patches v3 - edit commit message, subject line v4 - edit commit message drivers/staging/kpc2000/kpc_dma/dma.c | 86 ++--- drivers

[PATCH v4 2/8] Staging: kpc2000: kpc_dma: Resolve space errors around pointers and function declarations reported by checkpatch.

This patch resolves below errors reported by checkpatch ERROR: "(foo*)" should be "(foo *)" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo __init bar" should be "foo __init bar" ERROR: "foo __exit bar" should be "foo

Re: [PATCH v3 1/8] Staging: kpc2000: kpc_dma: Resolve trailing whitespace error reported by checkpatch

oh ok.. thanks i will correct it. On 13/05/19 4:19 PM, Dan Carpenter wrote: > The Signed off by has to be before the first --- cut off line. > Everything after the cut off is removed from the commit message. ___ devel mailing list de...@linuxdriverprojec

Re: [PATCH v2 2/8] Staging: kpc2000: kpc_dma: Resolve coding style errors reported by checkpatch.

On 13/05/19 2:12 PM, Greg KH wrote: > On Mon, May 13, 2019 at 05:09:54AM +0530, Vandana BN wrote: >> This patch resolves below errors reported by checkpatch >> ERROR: "(foo*)" should be "(foo *)" >> ERROR: "foo * bar" should be "foo *ba

[PATCH v3 8/8] Staging: kpc2000: kpc_dma: Resolve cast warning and use const for file_operation

This Patch resolves unnecessary cast warning and const file_operations reported by checkpath.pl WARNING: unnecessary cast may hide bugs WARNING: struct file_operations should normally be const --- v2 - split changes to multiple patches v3 - edit commit message --- Signed-off-by: Vandana BN

[PATCH v3 4/8] Staging: kpc2000: kpc_dma: Resolve code indent and trailing statements on next line errors reported by checkpatch.

This patch fixes code indentaion error reported by checkpath ERROR: switch and case should be at the same indent ERROR: trailing statements should be on next line --- v2 - split changes to multiple patches v3 - edit commit message --- Signed-off-by: Vandana BN --- drivers/staging/kpc2000

[PATCH v3 3/8] Staging: kpc2000: kpc_dma: Resolve checkpatch space errors around brace '{', '!' and open paranthesis '('.

mit message --- Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_dma/dma.c | 28 +- drivers/staging/kpc2000/kpc_dma/fileops.c | 56 +-- .../staging/kpc2000/kpc_dma/kpc_dma_driver.c | 20 +++ 3 files changed, 52 insertions(+), 52 deletions(-) diff -

[PATCH v3 7/8] Staging: kpc2000: kpc_dma: Resolve warning to use __func__ insted of funtion name reported by checkpatch.

This patch resolves warnings to use __func__ insted of funtion name. WARNING: Prefer using '"%s...", __func__' to using 'setup_dma_engine', this function's name, in a string --- v2 - split changes to multiple patches v3 - edit commit message --- Signed-off-b

[PATCH v3 2/8] Staging: kpc2000: kpc_dma: Resolve space errors around pointers and function declarations reported by checkpatch.

foo __exit bar" --- v2 - split changes to multiple patches v3 - edit commit message --- Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_dma/dma.c| 8 drivers/staging/kpc2000/kpc_dma/fileops.c| 2 +- drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c |

[PATCH v3 6/8] Staging: kpc2000: kpc_dma: Resolve warning Missing blank line after declarations & labels not to be indented.

split changes to multiple patches v3 - edit commit message --- Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_dma/dma.c| 8 +--- drivers/staging/kpc2000/kpc_dma/fileops.c| 11 ++- drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 15 --- dr

[PATCH v3 5/8] Staging: kpc2000: kpc_dma: Resolve checkpath errors Macros in paranthesis & trailing statements on next line.

v3 - edit commit message --- Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c index

[PATCH v3 1/8] Staging: kpc2000: kpc_dma: Resolve trailing whitespace error reported by checkpatch

Resolve trailing whitespace error from checkpatch.pl ERROR: trailing whitespace --- v2-split changes to multiple patches v3 - edit commit message --- Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_dma/dma.c | 86 ++--- drivers/staging/kpc2000/kpc_dma/fileops.c

[PATCH v2 1/8] Staging: kpc2000: kpc_dma: resolve trailing whitespace error reported by checkpatch

Resolve trailing whitespace error from checkpatch.pl ERROR: trailing whitespace Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_dma/dma.c | 86 ++--- drivers/staging/kpc2000/kpc_dma/fileops.c | 114 +- .../staging/kpc2000/kpc_dma/kpc_dma_driver.c

[PATCH v2 7/8] Staging: kpc2000: kpc_dma: Resolve coding style warning reported by checkpatch

This patch resolves warnings to use __func__ insted of funtion name. WARNING: Prefer using '"%s...", __func__' to using 'setup_dma_engine', this function's name, in a string Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_dma/dma.c | 6 ++-

[PATCH v2 2/8] Staging: kpc2000: kpc_dma: Resolve coding style errors reported by checkpatch.

This patch resolves below errors reported by checkpatch ERROR: "(foo*)" should be "(foo *)" ERROR: "foo * bar" should be "foo *bar" ERROR: "foo __init bar" should be "foo __init bar" ERROR: "foo __exit bar" should be &qu

[PATCH v2 5/8] Staging: kpc2000: kpc_dma: Resolve coding style error reported by checkpatch

This patch fixes below errors reported by checkpath ERROR: Macros with complex values should be enclosed in parentheses CHECK: Prefer using the BIT macro ERROR: trailing statements should be on next line ERROR: trailing statements should be on next line Signed-off-by: Vandana BN --- drivers

[PATCH v2 8/8] Staging: kpc2000: kpc_dma: Resolve coding style warning reported by checkpatch

This Patch resolves unnecessary cast warning and const file_operations WARNING: unnecessary cast may hide bugs WARNING: struct file_operations should normally be const Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_dma/fileops.c| 4 ++-- drivers/staging/kpc2000/kpc_dma

[PATCH v2 6/8] Staging: kpc2000: kpc_dma: Resolve coding style warning reported by checkpatch

ff-by: Vandana BN --- drivers/staging/kpc2000/kpc_dma/dma.c| 8 +--- drivers/staging/kpc2000/kpc_dma/fileops.c| 11 ++- drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 15 --- drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.h | 8 ++-- 4 files change

[PATCH v2 3/8] Staging: kpc2000: kpc_dma: Resolve coding style errors reported by checkpatch

This patch resolves below errors reported by checkpath ERROR: space required before the open brace '{' ERROR: space prohibited after that '!' (ctx:BxW) ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Vandana BN --- drivers/staging/kpc2

[PATCH v2 4/8] Staging: kpc2000: kpc_dma: Resolve code indent error reported by checkpatch

This patch fixes code indentaion error reported by checkpath ERROR: switch and case should be at the same indent ERROR: trailing statements should be on next line Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_dma/fileops.c | 12 1 file changed, 8 insertions(+), 4

Re: [Linux-kernel-mentees] [PATCH] Staging: kpc2000: kpc_dma: resolve checkpath errors and warnings

On 11/05/19 2:04 AM, Lukas Bulwahn wrote: > On Fri, May 10, 2019 at 9:39 PM Vandana BN wrote: >> This patch resolves coding style errors and warnings reported by chechpatch >> > I did not look at the patch in detail, but you might want to also > consider to replace the Caml

[PATCH] Staging: kpc2000: kpc_dma: resolve checkpath errors and warnings

are not necessary for any arm of this statement WARNING: unnecessary cast may hide bugs WARNING: braces {} are not necessary for single statement WARNING: struct file_operations should normally be const WARNING: labels should not be indented Signed-off-by: Vandana BN --- drivers/staging/kpc2000/kpc_d

[PATCH] staging: rtl8192u: ieee80211: Resolve ERROR reported by checkpatch

7; (ctx:VxV) ERROR: spaces required around that '=' (ctx:VxW) ERROR: space required before the open parenthesis '(' ERROR: spaces required around that '?' (ctx:VxE) ERROR: spaces required around that ':' (ctx:VxE) ERROR: spaces required around that '==&#

[PATCH v4] staging: rtl8723bs: Fix checkpatch.pl warnings

This patch resolves coding style brace warning and constant on right warning. WARNING: Comparisons should place the constant on the right side of the test WARNING: braces {} are not necessary for single statement blocks CHECK: Comparison to NULL could be written "!pbuf" Signed-off-by: