[PATCH] staging: exfat: convert WARN to a pr_info

syzbot took a nosedive because it runs with panic_on_warn set. And it's quite correct, it shouldn't have been a WARN in the first place. Other locations just use a pr_info(), so do that here too. Signed-off-by: Valdis Kletnieks Reported-by: syzbot+787bcbef9b5fec619...@syzkaller.appsp

[PATCH] staging: exfat: Update the TODO file

Updating with the current laundry list of things that need attention. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/TODO | 70 -- 1 file changed, 59 insertions(+), 11 deletions(-) diff --git a/drivers/staging/exfat/TODO b/drivers/staging/exfat

[PATCH 11/12] staging: exfat: Clean up the namespace pollution part 7

Global functions called 'buf*' are a linkage editor disaster waiting to happen. Rename our buf_* functions to exfat_buf_* Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 18 +++--- drivers/staging/exfat/exfat_cache.c | 22 +++ drivers/staging/exfat/ex

[PATCH 12/12] staging: exfat: Clean up the namespace pollution part 8

Rename all the FAT_* functions to exfat_fat_*. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 12 +- drivers/staging/exfat/exfat_cache.c | 26 +++--- drivers/staging/exfat/exfat_core.c | 34 ++--- drivers/staging/exfat

[PATCH 03/12] staging: exfat: Remove FAT/VFAT mount support, part 3

In this patch, we straighten out most of the cases where the code was testing 'p_fs->vol_type == EXFAT' and '!= EXFAT' There's still some ?: ops and a few places where the code is doing checks for '.' and '..' that require looking at, but those are

[PATCH 01/12] staging: exfat: Remove FAT/VFAT mount support, part 1

Remove the top-level mount functionality, to make this driver handle only exfat file systems. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/Kconfig | 9 -- drivers/staging/exfat/exfat.h | 2 - drivers/staging/exfat/exfat_core.c | 193

[PATCH 07/12] staging: exfat: Clean up the namespace pollution part 3

These functions are only used in the local file, make them static Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 6 -- drivers/staging/exfat/exfat_core.c | 8 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b

[PATCH 05/12] staging: exfat: Clean up the namespace pollution part 1

Everything referenced in the struct fs_func exfat_fs_func is located in that same .c file. Make them static and remove from exfat.h Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 32 --- drivers/staging/exfat/exfat_core.c | 42

[PATCH 10/12] staging: exfat: Clean up the namespace pollution part 6

y probably *should* be getting called someplace Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 8 -- drivers/staging/exfat/exfat_core.c | 170 ++--- 2 files changed, 85 insertions(+), 93 deletions(-) diff --git a/drivers/staging/exfat/exfat.h

[PATCH 04/12] staging: exfat: Remove FAT/VFAT mount support, part 4

The code simplification from the previous patch rendered a few more routines unreferenced, so heave them over the side as well. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 19 --- drivers/staging/exfat/exfat_core.c | 137 drivers/staging/exfat

[PATCH 06/12] staging: exfat: Clean up the namespace pollution part 2

Rename all the bdev_* to exfat_bdev_* Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h| 10 +- drivers/staging/exfat/exfat_blkdev.c | 10 +- drivers/staging/exfat/exfat_core.c | 8 drivers/staging/exfat/exfat_super.c | 16 4

[PATCH 08/12] staging: exfat: Clean up the namespace pollution part 4

Relocating these functions to before first use lets us make them static Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 4 -- drivers/staging/exfat/exfat_core.c | 78 +++--- 2 files changed, 39 insertions(+), 43 deletions(-) diff --git a

[PATCH 09/12] staging: exfat: Clean up the namespace pollution part 5

Some more functions that can be moved and made static Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 3 - drivers/staging/exfat/exfat_core.c | 182 ++--- 2 files changed, 91 insertions(+), 94 deletions(-) diff --git a/drivers/staging/exfat

[PATCH 00/12] staging: exfat: Heave FAT/VFAT over the side

The first 4 patches iteratively remove more and more of the FAT/VFAT code. The second 8 patches make a lot of functions static, and renames many of the rest to avoid namespace pollution. Valdis Kletnieks (12): staging: exfat: Remove FAT/VFAT mount support, part 1 staging: exfat: Remove FAT

[PATCH 02/12] staging: exfat: Remove FAT/VFAT mount support, part 2

Remove no longer referenced FAT/VFAT routines. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 44 -- drivers/staging/exfat/exfat_core.c | 619 - 2 files changed, 663 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging

[PATCH v3 0/9] staging: exfat: Clean up return codes

-next tree. Valdis Kletnieks (9): staging: exfat: Clean up return codes - FFS_FORMATERR staging: exfat: Clean up return codes - FFS_MEDIAERR staging: exfat: Clean up return codes - FFS_EOF staging: exfat: Clean up return codes - FFS_INVALIDFID staging: exfat: Clean up return codes - FFS_ERROR

[PATCH v3 9/9] staging: exfat: Correct return code

Use -ENOTEMPTY rather than -EEXIST for attempting to remove a directory that still has files in it. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat_super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging

[PATCH v3 7/9] staging: exfat: Clean up return codes - FFS_SUCCESS

Convert FFS_SUCCESS to 0. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 3 - drivers/staging/exfat/exfat_cache.c | 4 +- drivers/staging/exfat/exfat_core.c | 104 ++-- drivers/staging/exfat/exfat_super.c | 50 ++--- 4 files

[PATCH v3 1/9] staging: exfat: Clean up return codes - FFS_FORMATERR

Convert FFS_FORMATERR to -EFSCORRUPTED Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 3 ++- drivers/staging/exfat/exfat_core.c | 8 drivers/staging/exfat/exfat_super.c | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging

[PATCH v3 6/9] staging: exfat: Clean up return codes - remove unused codes

There are 6 FFS_* error values not used at all. Remove them. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h index 443fafe1d89d..b3fc9bb06c24 100644 --- a

[PATCH v3 4/9] staging: exfat: Clean up return codes - FFS_INVALIDFID

Covert FFS_INVALIDFID to -EINVAL Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_super.c | 10 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h

[PATCH v3 8/9] staging: exfat: Collapse redundant return code translations

Now that we no longer use odd internal return codes, we can heave the translation code over the side, and just pass the error code back up the call chain. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat_super.c | 92 + 1 file changed, 14 insertions

[PATCH v3 5/9] staging: exfat: Clean up return codes - FFS_ERROR

Convert FFS_ERROR to -EINVAL Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_core.c | 10 +- drivers/staging/exfat/exfat_super.c | 20 ++-- 3 files changed, 15 insertions(+), 16 deletions(-) diff --git a

[PATCH v3 2/9] staging: exfat: Clean up return codes - FFS_MEDIAERR

Convert FFS_MEDIAERR to (mostly) -ENOENT and -EIO. Some additional code surgery needed to propogate correct error codes upwards. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h| 1 - drivers/staging/exfat/exfat_blkdev.c | 18 ++--- drivers/staging/exfat

[PATCH v3 3/9] staging: exfat: Clean up return codes - FFS_EOF

Convert FFS_EOF to return 0 for a zero-length read() as per 'man 2 read'. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_super.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/exfat

[PATCH v2 06/10] staging: exfat: Clean up return codes - remove unused codes

There are 6 FFS_* error values not used at all. Remove them. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h index 443fafe1d89d..b3fc9bb06c24 100644 --- a

[PATCH v2 09/10] staging: exfat: Correct return code

Use -ENOTEMPTY rather than -EEXIST for attempting to remove a directory that still has files in it. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat_super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging

[PATCH v2 05/10] staging: exfat: Clean up return codes - FFS_ERROR

Convert FFS_ERROR to -EINVAL Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_core.c | 10 +- drivers/staging/exfat/exfat_super.c | 20 ++-- 3 files changed, 15 insertions(+), 16 deletions(-) diff --git a

[PATCH v2 07/10] staging: exfat: Clean up return codes - FFS_SUCCESS

Convert FFS_SUCCESS to 0. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 3 - drivers/staging/exfat/exfat_cache.c | 4 +- drivers/staging/exfat/exfat_core.c | 104 ++-- drivers/staging/exfat/exfat_super.c | 50 ++--- 4 files

[PATCH v2 08/10] staging: exfat: Collapse redundant return code translations

Now that we no longer use odd internal return codes, we can heave the translation code over the side, and just pass the error code back up the call chain. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat_super.c | 92 + 1 file changed, 14 insertions

[PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody

There's currently 6 filesystems that have the same #define. Move it into errno.h so it's defined in just one place. Signed-off-by: Valdis Kletnieks Acked-by: Darrick J. Wong Reviewed-by: Jan Kara Acked-by: Theodore Ts'o --- drivers/staging/exfat/exfat.h| 2 -- fs/e

[PATCH v2 04/10] staging: exfat: Clean up return codes - FFS_INVALIDFID

Covert FFS_INVALIDFID to -EINVAL Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_super.c | 10 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h

[PATCH v2 03/10] staging: exfat: Clean up return codes - FFS_EOF

Convert FFS_EOF to return 0 for a zero-length read() as per 'man 2 read'. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_super.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/exfat

[PATCH v2 02/10] staging: exfat: Clean up return codes - FFS_MEDIAERR

Convert FFS_MEDIAERR to (mostly) -ENOENT and -EIO. Some additional code surgery needed to propogate correct error codes upwards. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h| 1 - drivers/staging/exfat/exfat_blkdev.c | 18 ++--- drivers/staging/exfat

[PATCH v2 01/10] staging: exfat: Clean up return codes - FFS_FORMATERR

Convert FFS_FORMATERR to -EFSCORRUPTED Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 3 ++- drivers/staging/exfat/exfat_core.c | 8 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h

[PATCH v2 00/10] staging: exfat: Clean up return codes, revisited

The rest of the conversion from internal error numbers to the standard values used in the rest of the kernel. Patch 10/10 is logically separate, merging multiple #defines into one place in errno.h. It's included in the series because it depends on patch 1/10. Valdis Kletnieks (10): st

[RFC] errno.h: Provide EFSCORRUPTED for everybody

defined in just one place. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h| 2 -- fs/erofs/internal.h | 2 -- fs/ext4/ext4.h | 1 - fs/f2fs/f2fs.h | 1 - fs/xfs/xfs_linux.h | 1 - include/linux/jbd2.h

[PATCH 14/15] staging: exfat: Clean up return codes - remove unused codes

There are 6 FFS_* error values not used at all. Remove them. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h index 2ca2710601ae..819a21d72c67 100644 --- a

[PATCH 15/15] staging: exfat: Clean up return codes - FFS_SUCCESS

Just replace FFS_SUCCESS with a literal 0. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 3 - drivers/staging/exfat/exfat_cache.c | 4 +- drivers/staging/exfat/exfat_core.c | 90 ++--- drivers/staging/exfat/exfat_super.c | 50

[PATCH 13/15] staging: exfat: Clean up return codes - FFS_ERROR

Convert FFS_ERROR to -EINVAL Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_core.c | 8 drivers/staging/exfat/exfat_super.c | 20 ++-- 3 files changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers

[PATCH 08/15] staging: exfat: Clean up return code - FFS_MEMORYERR

Convert FFS_MEMORYERR to -ENOMEM Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_core.c | 10 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h index

[PATCH 11/15] staging: exfat: Clean up return codes - FFS_EOF

Convert FFS_EOF to return 0 for a zero-length read() as per 'man 2 read'. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_super.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/exfat

[PATCH 09/15] staging: exfat: Clean up return codes - FFS_FORMATERR

Convert FFS_FORMATERR to -EFSCORRUPTED Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 3 ++- drivers/staging/exfat/exfat_core.c | 4 ++-- drivers/staging/exfat/exfat_super.c | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/exfat

[PATCH 10/15] staging: exfat: Clean up return codes - FFS_MEDIAERR

Convert FFS_MEDIAERR to (mostly) -ENOENT and -EIO. Some additional code surgery needed to propogate correct error codes upwards. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h| 1 - drivers/staging/exfat/exfat_blkdev.c | 18 ++--- drivers/staging/exfat

[PATCH 04/15] staging: exfat: Clean up return codes - FFS_PERMISSIONERR

Convert FFS_PERMISSIONERR to -EPERM Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_super.c | 20 ++-- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging

[PATCH 12/15] staging: exfat: Clean up return codes - FFS_INVALIDFID

Covert FFS_INVALIDFID to -EINVAL Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_super.c | 10 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h

[PATCH 06/15] staging: exfat: Clean up return codes - FFS_FILEEXIST

Convert FFS_FILEEXIST to -EEXIST Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_core.c | 2 +- drivers/staging/exfat/exfat_super.c | 14 +++--- 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging

[PATCH 05/15] staging: exfat: Clean up return codes - FFS_NAMETOOLONG

Convert FFS_NOTNAMETOOLONG to -ENAMETOOLONG Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_super.c | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h

[PATCH 02/15] staging: exfat: Clean up return codes - FFS_NOTFOUND

Convert FFS_NOTFOUND to -ENOENT Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_super.c | 6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h index

[PATCH 07/15] staging: exfat: Clean up return codes - FFS_INVALIDPATH

Convert FFS_INVALIDPATH to -EINVAL Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_core.c | 10 +- drivers/staging/exfat/exfat_super.c | 10 +- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers

[PATCH 03/15] staging: exfat: Clean up return codes - FFS_DIRBUSY

Convert FFS_DIRBUSY to -EBUSY Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_super.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h index 1d82de4e1a5c

[PATCH 01/15] staging: exfat: Clean up return codes - FFS_FULL

Start cleaning up the odd scheme of return codes, starting with FFS_FULL Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 1 - drivers/staging/exfat/exfat_core.c | 10 +- drivers/staging/exfat/exfat_super.c | 16 3 files changed, 13 insertions

[PATCH 00/15] staging: exfat: Clean up return codes

The code had its own non-standard FFS_FOO return codes. Go through and convert them all the kernel standard -EFOO codes. Valdis Kletnieks (15): staging: exfat: Clean up return codes - FFS_FULL staging: exfat: Clean up return codes - FFS_NOTFOUND staging: exfat: Clean up return codes

[PATCH 7/8] staging: exfat: Finished code movement for static cleanups in exfat_core.c

Move static function bodies before first use, remove the definition in exfat.h Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 10 - drivers/staging/exfat/exfat_core.c | 661 ++--- 2 files changed, 330 insertions(+), 341 deletions(-) diff --git

[PATCH 2/8] staging: exfat: Remove FAT/VFAT mount support, part 1

Remove the top-level mount functionality, to make this driver handle only exfat file systems. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/Kconfig | 9 -- drivers/staging/exfat/exfat.h | 2 - drivers/staging/exfat/exfat_core.c | 142

[PATCH 5/8] staging: exfat: Clean up static definitions in exfat_cache.c

Move static function bodies before first use, remove the definition in exfat.h Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 4 -- drivers/staging/exfat/exfat_cache.c | 94 +++-- 2 files changed, 48 insertions(+), 50 deletions(-) diff --git

[PATCH 8/8] staging: exfat: Update TODO

Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/TODO | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/staging/exfat/TODO b/drivers/staging/exfat/TODO index b60e50b9cf4e..110c30834bd2 100644 --- a/drivers/staging/exfat/TODO +++ b/drivers

[PATCH 1/8] staging: exfat: Clean up namespace pollution, part 1

Make as much as possible static. We're over-exuberant here for the benefit of a following patch, as the compiler will flag now-unused static code Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 156 ++--- drivers/staging/exfat/exfat_core.c

[PATCH 4/8] staging: exfat: Cleanup static entries in exfat.h

Many of the static definitions that remain are not needed, as the function definition is already before the first use. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 53 --- 1 file changed, 53 deletions(-) diff --git a/drivers/staging/exfat

[PATCH 6/8] staging: exfat: More static cleanups for exfat_core.c

Move static function bodies before first use, remove the definition in exfat.h Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 6 - drivers/staging/exfat/exfat_core.c | 500 ++--- 2 files changed, 250 insertions(+), 256 deletions(-) diff --git

[PATCH 3/8] staging: exfat: Remove FAT/VFAT mount support, part 2

Remove no longer referenced FAT/VFAT routines. Signed-off-by: Valdis Kletnieks --- drivers/staging/exfat/exfat.h | 49 +- drivers/staging/exfat/exfat_core.c | 755 - 2 files changed, 2 insertions(+), 802 deletions(-) diff --git a/drivers/staging/exfat/exfat.h

[PATCH 0/8] staging: exfat: Code cleanups

Two main goals here - remove the code to mount FAT and VFAT filesystes, and make a lot of functions static to reduce namespace pollution. Valdis Kletnieks (8): staging: exfat: Clean up namespace pollution, part 1 staging: exfat: Remove FAT/VFAT mount support, part 1 staging: exfat: Remove

Re: [PATCH] staging:iio:ad7152: Rename misspelled RESEVERD -> RESERVED

On Fri, 25 Jan 2019 22:14:32 -0200, Rodrigo Ribeiro said: > Maybe, one checkstyle patch is enough, right? Which drivers can I truly > contribute to? I'll give you a pointer to the "How to contribute" the Kernel Newbies list and IRC channel uses: https://lists.kernelnewbies.org/pipermail/kernelne

[PATCH] fix error handling in drivers/staging/rtl8192u/ieee80211/ieee80211_module.c

John notes that if the kzalloc of ieee->pHTInfo fails, we fail to call ieee80211_networks_free(). In addition, that function has an un-needed check before kfree(). Reported-by: John Whitmore Signed-off-by: Valdis Kletnieks --- diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_modul

Re: [PATCH] staging: wilc1000: Remove unnecessary pointer check

On Thu, 20 Sep 2018 14:26:49 -0700, Nathan Chancellor said: > Clang warns that the address of a pointer will always evaluated as true > in a boolean context: > > drivers/staging/wilc1000/linux_wlan.c:267:20: warning: address of > 'vif->ndev->dev' will always evaluate to 'true' > [-Wpointer-bool-con

Re: [PATCH] staging: rtl8192u: fix line over 80 characters

On Sat, 16 Jun 2018 15:00:31 +0900, Hyunil Kim said: > *fix checkpatch.pl warnings: > WARNING: line over 80 characters > + if (((ieee->wpa_ie[0] == 0xdd) && > + (!memcmp(&(ieee->wpa_ie[14]), ccmp_ie, 4))) || > + ((ieee->wpa_ie[0] == 0x30) && > +

Re: [PATCH] staging: pi433: add rw semaphore fixing concurrency issues

On Fri, 01 Jun 2018 08:50:37 -0400, Hugo Lefeuvre said: > @@ -805,9 +809,11 @@ pi433_read(struct file *filp, char __user *buf, size_t > size, loff_t *f_pos) > if (bytes_received > 0) { > retval = copy_to_user(buf, device->rx_buffer, bytes_received); > if (retval)

Re: [PATCH v3] staging: netlogic: Fixed alignment of parentheseis checkpatch warning

On Sat, 19 Mar 2016 19:22:09 -0700, Joe Perches said: > On Sun, 2016-03-20 at 07:48 +0530, Parth Sane wrote: > > Hi, > > Thanks for pointing out that the changes have been done. Nevertheless > > this was a good learning exercise. How do I check which changes have > > already been done? > > Use this

[PATCH v3 2/6] drivers/staging/lustre: Fix set-but-unused whinge.

of it. It says it's test code - it should be *more* bulletproof than production, not less. Signed-off-by: Valdis Kletnieks --- drivers/staging/lustre/lustre/fid/lproc_fid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lustre/fid/lproc_fid.c b/drivers/staging/lust

[PATCH v3 5/6] drivers/staging/lustre: Nuke an unsigned >= 0 assert

ng/lustre/lustre/llite/../include/linux/../../../include/linux/libcfs/libcfs_private.h:58:6: note: in expansion of macro 'unlikely' if (unlikely(!(cond))) { \ ^ drivers/staging/lustre/lustre/llite/rw.c:763:2: note: in expansion of macro 'LASSERTF' LASSERTF(reserved >=

[PATCH v3 1/6] drivers/staging/lustre: Silence warning about 'inline'

ine struct lu_device_operations * ^ So we just swap inline and const. 272 warnings gone. :) Signed-off-by: Valdis Kletnieks --- drivers/staging/lustre/lustre/include/lu_object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/include/lu_object.h b/drivers/stag

[PATCH v3 0/6] Patch series to make lustre safe(r) for W=1 compiles

Start of a batch series to clean up the Lustre tree. Other people have done some sparse and checkpatch cleanups, but I found a bunch of stuff building with W=1. There's probably more, but this was the really low-hanging obvious fruit. Valdis Kletnieks (6): drivers/staging/lustre: Si

[PATCH v3 6/6] drivers/staging/lustre: Nuke another unsigned >= 0 assert

save a page of compiler spew. Signed-off-by: Valdis Kletnieks --- drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c b/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c index cd8a9987f7ac..1f326673f089

[PATCH v3 4/6] drivers/staging/lustre: Fix another C compiler whine: set but not used

struct dentry *entry; ^ Just ignore the dentry returned, and add a comment that we *know* we're not really leaking the dentry because something else will be able to reap it via recursion. Signed-off-by: Valdis Kletnieks --- drivers/staging/lustre/lustre/libcfs/module.c | 1

[PATCH v3 3/6] drivers/staging/lustre: Clean up another C warnining: set but not used

no need to calculate len. Bye-bye. Signed-off-by: Valdis Kletnieks --- drivers/staging/lustre/lustre/include/lustre_cfg.h | 4 -- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/lustre_cfg.h b/drivers/staging/lustre/lustre/include/lustre_cfg.h index eb6b292b

[PATCH v2 3/6] Clean up another C warnining: set but not used

no need to calculate len. Bye-bye. Signed-off-by: Valdis Kletnieks --- drivers/staging/lustre/lustre/include/lustre_cfg.h | 4 -- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/lustre_cfg.h b/drivers/staging/lustre/lustre/include/lustre_cfg.h index eb6b292b

[PATCH v2 6/6] Nuke another unsigned >= 0 assert

save a page of compiler spew. Signed-off-by: Valdis Kletnieks --- drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c b/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c index cd8a9987f7ac..1f326673f089

[PATCH v2 0/6] Patch series to make lustre safe(r) for W=1 compiles

Start of a batch series to clean up the Lustre tree. Other people have done some sparse and checkpatch cleanups, but I found a bunch of stuff building with W=1. There's probably more, but this was the really low-hanging obvious fruit. Valdis Kletnieks (6): staging/lustre: Silence warning

[PATCH v2 2/6] Fix set-but-unused whinge.

of it. It says it's test code - it should be *more* bulletproof than production, not less. Signed-off-by: Valdis Kletnieks --- drivers/staging/lustre/lustre/fid/lproc_fid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lustre/fid/lproc_fid.c b/drivers/staging/lust

[PATCH v2 5/6] Nuke an unsigned >= 0 assert

ng/lustre/lustre/llite/../include/linux/../../../include/linux/libcfs/libcfs_private.h:58:6: note: in expansion of macro 'unlikely' if (unlikely(!(cond))) { \ ^ drivers/staging/lustre/lustre/llite/rw.c:763:2: note: in expansion of macro 'LASSERTF' LASSERTF(reserved >=

[PATCH v2 4/6] Fix another C compiler whine: set but not used

struct dentry *entry; ^ Just ignore the dentry returned, and add a comment that we *know* we're not really leaking the dentry because something else will be able to reap it via recursion. Signed-off-by: Valdis Kletnieks --- drivers/staging/lustre/lustre/libcfs/module.c | 1

[PATCH v2 1/6] staging/lustre: Silence warning about 'inline'

ine struct lu_device_operations * ^ So we just swap inline and const. 272 warnings gone. :) Signed-off-by: Valdis Kletnieks --- drivers/staging/lustre/lustre/include/lu_object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/include/lu_object.h b/drivers/stag

Re: [PATCH] Warnings : Fixed 80 character length warning in rtw_ap.c

On Tue, 07 Jul 2015 13:38:47 -0700, Joe Perches said: > The longest line in this file is 158 chars, that's > probably excessive, awk shows 35 lines > 80 chars. That doesn't count tabs. Checkpatch throws 98 warnings. pgpyA7aIF0_ni.pgp Description: PGP signature _

Re: [PATCH] Warnings : Fixed 80 character length warning in rtw_ap.c

On Tue, 07 Jul 2015 21:08:10 -0400, Sreenath Madasu said: > The kernelnewbies.org guide said "For your first patch, only pick one > warning". That is the reason why I fixed one warning. They mean "don't fix lines over 80 characters *and* missing-blank warnings in the same patch". pgpoBhFQVf2aM.p

Re: [PATCH] Warnings : Fixed 80 character length warning in rtw_ap.c

On Mon, 06 Jul 2015 21:53:26 -0400, Sreenath Madasu said: > When the checkpatch.pl script was run, it showed lines with length > more than 80 characters in rtw_ap.c file. Fixed line number 382 by > breaking it up into two lines within 80 characters. > - stainfo_offset

Re: [PATCH] staging: dgnc: Replace macro with flow control statement by a function

On Mon, 06 Jul 2015 18:50:12 +0530, Ravi Teja Darbha said: > Why would you use a macro to avoid code duplication? The macro does end up putting code in each place it's used. However, the actual code is in one place rather than open-coded in multiple places that can diverge over time (somebody patc

Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said: > > > - if (ir == NULL) { > > > - dev_err(ir->l.dev, "close: no private_data attached to the file !\n"); > > > > Yes, the dev_err() call is an obvious thinko. > > > > However, I'm not sure whether removing it entirely is right either.

Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

On Thu, 29 Jan 2015 19:48:08 +0100, Rickard Strandqvist said: > Fix a possible null pointer dereference, there is > otherwise a risk of a possible null pointer dereference. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- > drive

Re: [PATCH] Staging: dgnc: Fix long line coding style issues in dgnc_cls.h

On Wed, 03 Dec 2014 17:07:28 +, Sean Cleator said: > A patch to fix the rest of the long line warnings in the dgnc_cls.h file > found by the checkpatch.pl tool > struct cls_uart_struct { > u8 txrx;/* WR RHR/THR - Holding Reg */ > u8 ier; /* WR IER - Inter

[PATCH] staging/rtl8192u - check for skb alloc failure

It's possible for dev_alloc_skb() to fail. Propagate the error to the caller, so it can clean up and drop the packet. The sender should end up retransmitting the packet, hopefully at a time we're prepared to allocate skb's again. Reported-By: Nicholas Krause Signed-Off-By: V

Re: [PATCH 89/94] Linux 3.16-rc5

On Tue, 15 Jul 2014 20:01:44 +0300, Sam Asadi said: > From: Linus Torvalds > > > Signed-off-by: sam-the-6 > --- > Makefile |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 2167084..f3c543d 100644 > --- a/Makefile > +++ b/Makefile > @@ -1,7 +