Re: [PATCH] staging: greybus: arche-apb-ctrl: fix unused warnings on resume/suspend

2017-01-03 Thread Vaibhav Hiremath
trl_suspend(struct device *dev) > ^~ > > Adding __maybe_unused to the declaration of these functions removes the > warnings. > > Signed-off-by: Jérémy Lefaure > --- Sorry for delayed response. Acked-by: Vaibhav Hiremath Thanks, Vaibhav > drive

Re: [PATCH] staging: greybus: fix line over 80 characters style warnings

2016-11-29 Thread Vaibhav Hiremath
On Tue, Nov 29, 2016 at 12:12 AM, Andrea Ghittino wrote: > Fixes greybus "line over 80 characters" style warnings > found by checkpatch.pl tool > Since you would be resubmitting your patche after Greg's comment, can you also fix the subject line to staging: greybus: arche-platform: fix line ov

Re: [PATCH] staging: greybuis: fix line over 80 characters style warnings

2016-11-27 Thread Vaibhav Hiremath
On Sun, Nov 27, 2016 at 3:43 AM, Andrea Ghittino wrote: > Fixes greybus "line over 80 characters" style warnings > found by checkpatch.pl tool > It is always trade-off between readability vs 80 character restriction. I give preference and precedence to readability, so I kept it as is during devel

Re: [PATCH] staging: greybus: arche-platform: fix device reference leak

2016-11-03 Thread Vaibhav Hiremath
e, > exit: > spin_unlock_irqrestore(&arche_pdata->wake_lock, flags); > mutex_unlock(&arche_pdata->platform_state_mutex); > + put_device(&pdev->dev); > of_node_put(np); > return ret; > } > -- > 2.7.3 > Thanks for the fix J