Re: [PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text

On Wed, Jan 31, 2018 at 9:46 AM, Dan Carpenter wrote: > On Wed, Jan 31, 2018 at 09:41:24AM +0100, Ulf Magnusson wrote: >> On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter >> wrote: >> > On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote: >> >>

[PATCH 05/11] Staging: rtl8192e: kconfig: Remove blank help text

Blank help texts are probably either a typo, a Kconfig misunderstanding, or some kind of half-committing to adding a help text (in which case a TODO comment would be clearer, if the help text really can't be added right away). Best to remove them, IMO. Signed-off-by: Ulf Magnusson --- dr

[PATCH 04/11] Staging: rtl8192u: kconfig: Remove blank help text

Blank help texts are probably either a typo, a Kconfig misunderstanding, or some kind of half-committing to adding a help text (in which case a TODO comment would be clearer, if the help text really can't be added right away). Best to remove them, IMO. Signed-off-by: Ulf Magnusson --- dr

Re: [PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text

On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter wrote: > On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote: >> In preparation for adding a warning ("kconfig: Warn if help text is >> blank"): https://lkml.org/lkml/2018/1/30/516 >> > > Please don&

[PATCH v2 05/10] Staging: rtl8192e: kconfig: Remove empty help text

In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516 Signed-off-by: Ulf Magnusson --- drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/Kconfig

[PATCH v2 04/10] Staging: rtl8192u: kconfig: Remove empty help text

In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516 Signed-off-by: Ulf Magnusson --- drivers/staging/rtl8192u/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192u/Kconfig b/drivers/stagin

[PATCH 05/10] Staging: rtl8192e: kconfig: Remove empty help text

In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516 Signed-off-by: Ulf Magnusson --- drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/Kconfig

[PATCH 04/10] Staging: rtl8192u: kconfig: Remove empty help text

In preparation for adding a warning ("kconfig: Warn if help text is blank"): https://lkml.org/lkml/2018/1/30/516 Signed-off-by: Ulf Magnusson --- drivers/staging/rtl8192u/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192u/Kconfig b/drivers/stagin