[PATCH 7/7] staging: vc04_services: Drop no longer needed headers

2018-10-04 Thread Tuomas Tynkkynen
Previously, connection.h was only required for the definition of VCHI_CONNECTION_T, but now all usages of it are gone. Remove this unused header. After connection.h is gone, message.h and vchi_cfg_internal.h are no longer referenced by anything either. Drop them as well. Signed-off-by: Tuomas

[PATCH 6/7] staging: vc04_services: Drop unused parameters from vchi_connect()

2018-10-04 Thread Tuomas Tynkkynen
Remove two parameters which are never used and all where all callers just pass in dummy values anyway. Signed-off-by: Tuomas Tynkkynen --- .../vc04_services/bcm2835-audio/bcm2835-vchiq.c | 2 +- .../staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 2 +- drivers/staging/vc04_services

[PATCH 5/7] staging: vc04_services: Drop VCHI_SERVICE_INIT and SERVICE_INFO_T

2018-10-04 Thread Tuomas Tynkkynen
These types are not used anywhere, remove them. Signed-off-by: Tuomas Tynkkynen --- drivers/staging/vc04_services/interface/vchi/vchi.h | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h b/drivers/staging/vc04_services/interface/vchi

[PATCH 4/7] staging: vc04_services: Drop declaration of vchi_crc_control()

2018-10-04 Thread Tuomas Tynkkynen
There is no definition for this unused function, so drop its prototype. Signed-off-by: Tuomas Tynkkynen --- drivers/staging/vc04_services/interface/vchi/vchi.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h b/drivers/staging

[PATCH 0/7] staging: vc04_services: Some dead code removal

2018-10-04 Thread Tuomas Tynkkynen
fine. Tuomas Tynkkynen (7): staging: vc04_services: Drop pointless stub functions staging: vc04_services: Drop 'connection' field from SERVICE_CREATION_T staging: vc04_services: Drop trivially unused fields from SERVICE_CREATION_T staging: vc04_services: Drop declaration of v

[PATCH 3/7] staging: vc04_services: Drop trivially unused fields from SERVICE_CREATION_T

2018-10-04 Thread Tuomas Tynkkynen
These fields are only initialized with constants and never read. Drop them. Signed-off-by: Tuomas Tynkkynen --- .../vc04_services/bcm2835-audio/bcm2835-vchiq.c | 5 - .../staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 5 - drivers/staging/vc04_services/interface/vchi/vchi.h

[PATCH 1/7] staging: vc04_services: Drop pointless stub functions

2018-10-04 Thread Tuomas Tynkkynen
These functions do nothing besides returning NULL and are unused. Just drop them. Signed-off-by: Tuomas Tynkkynen --- .../vc04_services/interface/vchi/vchi.h | 11 .../interface/vchiq_arm/vchiq_shim.c | 27 --- 2 files changed, 38 deletions(-) diff --git

[PATCH 2/7] staging: vc04_services: Drop 'connection' field from SERVICE_CREATION_T

2018-10-04 Thread Tuomas Tynkkynen
The connection field of SERVICE_CREATION_T is assigned to but its value is never read. Drop the field and the resulting no longer needed code from bcm2835-audio and bcm2835-camera. Signed-off-by: Tuomas Tynkkynen --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 3 --- drivers

[PATCH] staging: vc04_services: Remove unused vchiq_genversion script

2018-09-21 Thread Tuomas Tynkkynen
As far as I can tell, this has never been used. Signed-off-by: Tuomas Tynkkynen --- .../interface/vchiq_arm/vchiq_genversion | 88 -- 1 file changed, 88 deletions(-) delete mode 100644 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_genversion diff --git

[PATCH 2/2] staging: bcm2835-audio: Don't leak workqueue if open fails

2018-07-12 Thread Tuomas Tynkkynen
Currently, if bcm2835_audio_open() fails partway, the allocated workqueue is leaked. Avoid that. While at it, propagate the return value of bcm2835_audio_open_connection() on failure instead of returning -1. Signed-off-by: Tuomas Tynkkynen --- .../staging/vc04_services/bcm2835-audio/bcm2835

[PATCH 1/2] staging: bcm2835-audio: Check if workqueue allocation failed

2018-07-12 Thread Tuomas Tynkkynen
rid of the rather pointless one-line function my_workqueue_init(). Signed-off-by: Tuomas Tynkkynen --- .../vc04_services/bcm2835-audio/bcm2835-vchiq.c| 111 ++--- 1 file changed, 50 insertions(+), 61 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835

[PATCH v2] staging: lirc: Fix sparse warnings

2014-05-08 Thread Tuomas Tynkkynen
Fix sparse warnings by adding __user and __iomem annotations where necessary and removing certain unnecessary casts. While at it, also use u32 in place of __u32. Signed-off-by: Tuomas Tynkkynen --- Compile tested only. v2 changes: - introduce variable 'uptr' instead of open-cod

[PATCH] staging: lirc: Fix sparse warnings

2014-05-08 Thread Tuomas Tynkkynen
Fix sparse warnings by adding __user and __iomem annotations where necessary and removing certain unnecessary casts. Signed-off-by: Tuomas Tynkkynen --- Compile tested only. drivers/staging/media/lirc/lirc_bt829.c|6 +++--- drivers/staging/media/lirc/lirc_parallel.c | 17

[PATCH] staging: goldfish: Call free_irq in error path

2014-04-07 Thread Tuomas Tynkkynen
If misc_register failed in goldfish_audio_probe, the already requested IRQ wouldn't get freed. Add a call to free_irq() like there is in goldfish_audio_remove(). Signed-off-by: Tuomas Tynkkynen --- Only compile tested. For the Eudyptula Challenge. drivers/staging/goldfish/goldfish_au