[PATCH v5 2/2] staging: android: Remove BUG from ion_system_heap.c

Remove BUG() from ion_sytem_heap.c this fix the following checkpatch issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_system_heap.c | 2 +- 1 file changed, 1 insertion(+

[PATCH v5 1/2] staging: android: Remove BUG_ON from ion_page_pool.c

BUG_ON() is removed at ion_page_pool.c Fixes the following issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_page_pool.c | 6 -- 1 file changed, 6 deletions(-) diff --g

[PATCH v5 0/2] staging: android: Remove BUG/BUG_ON

order_to_index callers Tomer Samara (2): staging: android: Remove BUG_ON from ion_page_pool.c staging: android: Remove BUG from ion_system_heap.c drivers/staging/android/ion/ion_page_pool.c | 6 -- drivers/staging/android/ion/ion_system_heap.c | 2 +- 2 files changed, 1 insertion(+), 7

Re: [PATCH v4 2/2] staging: android: Remove BUG from ion_system_heap.c

On Fri, Aug 21, 2020 at 09:25:26AM -0700, Randy Dunlap wrote: > On 8/21/20 8:28 AM, Tomer Samara wrote: > > Remove BUG() from ion_sytem_heap.c > > > > this fix the following checkpatch issue: > > Avoid crashing the kernel - try using WARN_ON & > > rec

[PATCH v4 2/2] staging: android: Remove BUG from ion_system_heap.c

Remove BUG() from ion_sytem_heap.c this fix the following checkpatch issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_system_heap.c | 2 +- 1 file changed, 1 insertion(+

[PATCH v4 1/2] staging: android: Remove BUG_ON from ion_page_pool.c

BUG_ON() is removed at ion_page_pool.c Fixes the following issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_page_pool.c | 6 +- 1 file changed, 1 insertion(+), 5 delet

[PATCH v4 0/2] staging: android: Remove BUG/BUG_ON from ion

unnecessary error check at ion_page_pool_shrink - Add /* This is impossible. */ comment at order_to_index - Remove error handling of order_to_index -v3: remove WARN/WARN_ON as Gerg KH suggests -v2: add error check to order_to_index callers Tomer Samara (2): staging

[PATCH v3 2/2] staging: android: Remove BUG from ion_system_heap.c

Remove BUG() at ion_sytem_heap.c and error handling to: - free_buffer_page - alloc_buffer_page this fix the following checkpatch issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android

[PATCH v3 1/2] staging: android: Remove BUG_ON from ion_page_pool.c

BUG_ON() is removed at ion_page_pool.c and add error handleing to ion_page_pool_shrink Fixes the following issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_page_pool.c

[PATCH v3 0/2] staging: android: Remove BUG/BUG_ONs

Remove BUG/BUG_ONs from androind/ion allocator and add error handling to calling functions Tomer Samara (2): staging: android: Remove BUG_ON from ion_page_pool.c staging: android: Remove BUG from ion_system_heap.c drivers/staging/android/ion/ion_page_pool.c | 14 ++ drivers

[PATCH v3 0/2] staging: android: Remove BUG/BUG_ON from ion

Removeing BUG/BUG_ON from androind/ion and add error handle to calling functions Tomer Samara (2): staging: android: Remove BUG_ON from ion_page_pool.c staging: android: Remove BUG from ion_system_heap.c drivers/staging/android/ion/ion_page_pool.c | 14 ++ drivers/staging

Re: [PATCH v2 1/4] staging: android: Replace BUG_ON with WARN_ON

On Tue, Aug 18, 2020 at 04:11:06PM +0200, Greg Kroah-Hartman wrote: > On Sun, Aug 16, 2020 at 10:23:25PM +0300, Tomer Samara wrote: > > BUG_ON() is replaced with WARN_ON at ion_page_pool.c > > Why? > > > Fixes the following issue: > > Avoid crashing the kernel - try

Re: [PATCH 0/4] *** SUBJECT HERE ***

On Tue, Aug 18, 2020 at 11:50:35AM +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 18, 2020 at 12:17:08PM +0300, Tomer Samara wrote: > > *** BLURB HERE *** > > Really? > > And your subject line could use some work too :( > sorry for that, i've made a script for se

[PATCH 0/4] *** SUBJECT HERE ***

*** BLURB HERE *** Tomer Samara (4): staging: android: Replace BUG_ON with WARN_ON staging: android: Add error handling to ion_page_pool_shrink staging: android: Convert BUG to WARN staging: android: Add error handling to order_to_index callers drivers/staging/android/ion

[PATCH 0/4] *** SUBJECT HERE ***

*** BLURB HERE *** Tomer Samara (4): staging: android: Replace BUG_ON with WARN_ON staging: android: Add error handling to ion_page_pool_shrink staging: android: Convert BUG to WARN staging: android: Add error handling to order_to_index callers drivers/staging/android/ion

[PATCH 0/4] *** SUBJECT HERE ***

*** BLURB HERE *** Tomer Samara (4): staging: android: Replace BUG_ON with WARN_ON staging: android: Add error handling to ion_page_pool_shrink staging: android: Convert BUG to WARN staging: android: Add error handling to order_to_index callers drivers/staging/android/ion

[PATCH 0/4] *** SUBJECT HERE ***

*** BLURB HERE *** Tomer Samara (4): staging: android: Replace BUG_ON with WARN_ON staging: android: Add error handling to ion_page_pool_shrink staging: android: Convert BUG to WARN staging: android: Add error handling to order_to_index callers drivers/staging/android/ion

[PATCH v2 4/4] staging: android: Add error handling to order_to_index callers

Add error check to: - free_buffer_page - alloc_buffer_page after calling order_to_index, due to converting BUG to WARN at order_to_index. Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_system_heap.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff

[PATCH v2 3/4] staging: android: Convert BUG to WARN

replace BUG() with WARN() at ion_sytem_heap.c, this fix the following checkpatch issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_system_heap.c | 3 ++- 1 file changed, 2 insert

[PATCH v2 2/4] staging: android: Add error handling to ion_page_pool_shrink

Add error check to ion_page_pool_shrink after calling ion_page_pool_remove, due to converting BUG_ON to WARN_ON. Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_page_pool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/ion/ion_page_pool.c b

[PATCH v2 1/4] staging: android: Replace BUG_ON with WARN_ON

BUG_ON() is replaced with WARN_ON at ion_page_pool.c Fixes the following issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_page_pool.c | 12 1 file change

[PATCH v2 0/4] Replace BUG/BUG_ON to WARN/WARN_ON

This series convert BUGs/BUG_ONs to WARNs/WARN_ONs Tomer Samara (4): staging: android: Replace BUG_ON with WARN_ON staging: android: Add error handling to ion_page_pool_shrink staging: android: Convert BUG to WARN staging: android: Add error handling to order_to_index callers drivers

Re: [PATCH 3/3] staging: androind: Convert BUG() to WARN()

On Sun, Aug 16, 2020 at 10:34:50AM -0700, Randy Dunlap wrote: > On 8/16/20 10:22 AM, Tomer Samara wrote: > > replace BUG() with WARN() at ion_sytem_heap.c, this > > fix the following checkpatch issue: > > Avoid crashing the kernel - try using WARN_ON & > > recovery

[PATCH 3/3] staging: androind: Convert BUG() to WARN()

replace BUG() with WARN() at ion_sytem_heap.c, this fix the following checkpatch issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_system_heap.c | 3 ++- 1 file changed, 2 insert

[PATCH 1/3] staging: androind: Replace BUG_ONs with WARN_ONs

BUG_ON() is replaced with WARN_ON at ion_page_pool.c Fixes the following issue: Avoid crashing the kernel - try using WARN_ON & recovery code ratherthan BUG() or BUG_ON(). Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_page_pool.c | 12 1 file change

[PATCH 2/3] staging: androind: Add error handling to ion_page_pool_shrink

Add error check to ion_page_pool_shrink after calling ion_page_pool_remove, due to converting BUG_ON to WARN_ON. Signed-off-by: Tomer Samara --- drivers/staging/android/ion/ion_page_pool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/ion/ion_page_pool.c b

[PATCH 0/3] Replac BAG/BAG_ON with WARN/WARN_ON

This series convert BUGs/BUG_ONs to WARNs/WARN_ONs Tomer Samara (3): staging: androind: Replace BUG_ONs with WARN_ONs staging: androind: Add error handling to ion_page_pool_shrink staging: androind: Convert BUG() to WARN() drivers/staging/android/ion/ion_page_pool.c | 14

[PATCH v2] staging: wfx: refactor to avoid duplication at hif_tx.c

struct hif_msg. Signed-off-by: Tomer Samara --- Changes in v2: - Changed these functions to static drivers/staging/wfx/hif_tx.c | 180 --- 1 file changed, 80 insertions(+), 100 deletions(-) diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c

Re: [PATCH] staging: wfx: refactor to avoid duplication at hif_tx.c

On Wed, Aug 05, 2020 at 11:04:25AM +0200, Greg KH wrote: > On Wed, Aug 05, 2020 at 11:56:08AM +0300, Tomer Samara wrote: > > Add functions wfx_full_send(), wfx_full_send_no_reply_async(), > > wfx_full_send_no_reply() and wfx_full_send_no_reply_free() > > which works as foll

[PATCH] staging: wfx: refactor to avoid duplication at hif_tx.c

struct hif_msg. Signed-off-by: Tomer Samara --- drivers/staging/wfx/hif_tx.c | 179 --- 1 file changed, 79 insertions(+), 100 deletions(-) diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c index 5110f9b93762..1ee84e5d47ef 100644 --- a

[PATCH] staging: wfx: clear alignment style issues

Clear checkpatch alignment style issues in debug.c. CHECK: Alignment should match open parenthesis Signed-off-by: Tomer Samara --- drivers/staging/wfx/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/debug.c b/drivers/staging/wfx/debug.c index

[PATCH] staging: rts5208: clear alignment style issues

Clear checkpatch alignment style issues in rtsx_transport.c. CHECK: Alignment should match open parenthesis Signed-off-by: Tomer Samara --- drivers/staging/rts5208/rtsx_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/rtsx_transport.c

[PATCH] staging: netlogic: clear alignment style issues

Clear checkpatch alignment style issues in xlr_net.c. CHECK: Alignment should match open parenthesis Signed-off-by: Tomer Samara --- drivers/staging/netlogic/xlr_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging