[PATCH v2] staging: wilc1000: Use common structs to parse ip packets

2018-06-19 Thread Thibaut Robert
Use structs ethhdr, iphdr and tcphdr instead of manual parsing in tcp_process. This commit fix handling of ip packets containing options. It also fixes the following sparse warning: drivers/staging/wilc1000//wilc_wlan.c:201:19: warning: cast to restricted __be16 Signed-off-by: Thibaut Robert

Re: [PATCH 1/2] staging: wilc1000: fix some endianness sparse warnings

2018-06-05 Thread Thibaut Robert
Le mardi 05 juin 2018 à 10:36:31 (+0300), Dan Carpenter a écrit : > On Mon, Jun 04, 2018 at 09:32:50PM +0200, Thibaut Robert wrote: > > Le mercredi 30 mai 2018 à 14:17:25 (+0300), Dan Carpenter a écrit : > > > On Tue, May 29, 2018 at 09:11:43PM +0200, Thibaut Robert wrote: &g

Re: [PATCH 1/2] staging: wilc1000: fix some endianness sparse warnings

2018-06-04 Thread Thibaut Robert
Le mercredi 30 mai 2018 à 14:17:25 (+0300), Dan Carpenter a écrit : > On Tue, May 29, 2018 at 09:11:43PM +0200, Thibaut Robert wrote: > > diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > > b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c > > index e2487

Re: [PATCH 1/1] staging: wilc1000: Use common structs to parse ip packets

2018-06-04 Thread Thibaut Robert
Le lundi 04 juin 2018 à 10:55:49 (+0530), Ajay Singh a écrit : > > Thank you for submitting the patches. > > The modification in this patch looks okay to me. > Please resend this by including changes as suggested by Dan. > I can do the modification and resubmit this patch by including review > co

[PATCH 1/2] staging: wilc1000: fix some endianness sparse warnings

2018-05-29 Thread Thibaut Robert
This commit fix a few sparse warnings. It mostly consists of fixing the type declarations and avoiding the use of variables with mixed endianness values. Signed-off-by: Thibaut Robert --- drivers/staging/wilc1000/wilc_spi.c | 15 ++- .../staging/wilc1000

[PATCH 1/1] staging: wilc1000: Use common structs to parse ip packets

2018-05-29 Thread Thibaut Robert
Use structs ethhdr, iphdr and tcphdr instead of manual parsing in tcp_process. This commit fix handling of ip packets containing options. It also fixes the following sparse warning: drivers/staging/wilc1000//wilc_wlan.c:201:19: warning: cast to restricted __be16 Signed-off-by: Thibaut Robert

[PATCH] staging: gdm72xx: fix typo and coding style

2014-09-30 Thread Thibaut Robert
Fix a typo in error message. Add missing curling braces to conform to coding style. Improve readibility. Signed-off-by: Thibaut Robert --- drivers/staging/gdm72xx/netlink_k.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/gdm72xx/netlink_k.c

Re: [PATCH] Staging: gdm72xx: fix coding style

2014-09-30 Thread Thibaut Robert
Le Tuesday 30 Sep 2014 à 12:23:12 (+0200), Thibaut Robert a écrit : > Remove unnecessary else after return. > Follow coding style for curly braces around single statements. > Fix a typo in error message. > > Signed-off-by: Thibaut Robert > --- > drivers/staging/gdm

[PATCH] Staging: gdm72xx: fix coding style

2014-09-30 Thread Thibaut Robert
Remove unnecessary else after return. Follow coding style for curly braces around single statements. Fix a typo in error message. Signed-off-by: Thibaut Robert --- drivers/staging/gdm72xx/netlink_k.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a

Re: [PATCH] Staging: gdm72xx: fix coding style

2014-09-30 Thread Thibaut Robert
Le Monday 29 Sep 2014 à 11:31:24 (-0700), Joe Perches a écrit : > On Mon, 2014-09-29 at 20:15 +0200, Thibaut Robert wrote: > > This patch remove a checkstyle warning in netlink_k.c. > > Note: This is my homework of the day. > > The "Note: " line isn't useful fo

[PATCH] Staging: gdm72xx: fix coding style

2014-09-29 Thread Thibaut Robert
This patch remove a checkstyle warning in netlink_k.c. Note: This is my homework of the day. Signed-off-by: Thibaut Robert --- drivers/staging/gdm72xx/netlink_k.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/gdm72xx/netlink_k.c b/drivers