Re: [PATCH V2] scsi: storvsc: Allow only one remove lun work item to be issued per lun

2017-10-21 Thread Tejun Heo
Hello, On Thu, Oct 19, 2017 at 08:35:10AM -0700, Christoph Hellwig wrote: > On Tue, Oct 17, 2017 at 01:35:21PM -0400, Cathy Avery wrote: > > + /* > > +* Set the error handler work queue. > > +*/ > > + snprintf(host_dev->work_q_name, sizeof(host_dev->work_q_name), > > +"stor

Re: [PATCH] android: binder: Remove deprecated create_singlethread_workqueue

2016-08-15 Thread Tejun Heo
t; guarantee unless the target CPU is explicitly specified and thus the > increase of local concurrency shouldn't make any difference. > > Signed-off-by: Bhaktipriya Shridhar Acked-by: Tejun Heo Thanks. -- tejun ___ devel mailing list

Re: [PATCH] Drivers: hv: connection: Remove create_workqueue

2016-06-20 Thread Tejun Heo
Hello, On Sat, Jun 18, 2016 at 02:14:23PM +0530, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > A dedicated workqueue has been used since the workitem (viz &ctx->work, > which maps to vmbus_onmessage_work), is engaged in normal device > operation which invo

Re: [PATCH v3] staging: octeon: Convert create_singlethread_workqueue()

2016-02-28 Thread Tejun Heo
ght by the time exit path runs. > > Signed-off-by: Bhaktipriya Shridhar For the workqueue part, Acked-by: Tejun Heo Thanks. -- tejun ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 1/4] dma-mapping: Add devm_ interface for dma_map_single()

2014-06-04 Thread Tejun Heo
Hello, On Wed, Jun 04, 2014 at 04:12:11PM +0200, Joerg Roedel wrote: > Yes, but those drivers usually get DMA buffers at init time with the > dma_alloc_* interfaces. The dma_map_* interfaces discussed here belong > to the streaming DMA-API, so they are usually used for only one DMA > transaction b

Re: [PATCH v2 1/4] dma-mapping: Add devm_ interface for dma_map_single()

2014-06-04 Thread Tejun Heo
Hello, On Wed, Jun 04, 2014 at 01:39:07AM +0200, Joerg Roedel wrote: > I fully agree with the points Shuah brought up here. I don't think it is > a good idea to add this kind of resource management to runtime-allocated > (and de-allocated) resources of device drivers. > > Also DMA handles are not

Re: [PATCH 2/5] dma-mapping: Add devm_ interface for dma_map_single()

2014-05-20 Thread Tejun Heo
Hello, On Tue, May 20, 2014 at 08:54:09AM +0300, Eli Billauer wrote: > That seems OK to me, but the problem I'm concerned with is this: In > devm_get_free_pages() it says > > devres = devres_alloc(devm_pages_release, > sizeof(struct pages_devres), GFP_KERNEL); > if (unli

Re: [PATCH 2/5] dma-mapping: Add devm_ interface for dma_map_single()

2014-05-19 Thread Tejun Heo
Hello, Eli. On Sat, May 17, 2014 at 03:19:21PM +0300, Eli Billauer wrote: > >>+ if (dma_mapping_error(dev, dma_handle)) { > >>+ devres_free(dr); > >>+ return 0; > >Can't we just keep returning dma_handle? Even if that means invoking > >->mapping_error() twice? It's yucky to

Re: [PATCH 3/5] dma-mapping: pci: Add devm_ interface for pci_map_single

2014-05-16 Thread Tejun Heo
On Fri, May 16, 2014 at 11:26:37AM +0300, Eli Billauer wrote: > > Signed-off-by: Eli Billauer > --- > Documentation/driver-model/devres.txt |2 ++ > include/asm-generic/pci-dma-compat.h | 17 + > 2 files changed, 19 insertions(+), 0 deletions(-) The patch looks fine to me

Re: [PATCH 2/5] dma-mapping: Add devm_ interface for dma_map_single()

2014-05-16 Thread Tejun Heo
Hello, On Fri, May 16, 2014 at 11:26:36AM +0300, Eli Billauer wrote: > +dma_addr_t dmam_map_single(struct device *dev, void *ptr, size_t size, > +enum dma_data_direction direction) > + > +{ > + struct dma_devres *dr; > + dma_addr_t dma_handle; > + > + dr = devre

Re: [PATCH 1/5] devres: Add devm_get_free_pages API

2014-05-16 Thread Tejun Heo
On Fri, May 16, 2014 at 11:26:35AM +0300, Eli Billauer wrote: > devm_get_free_pages() and devm_free_pages() are the managed counterparts > for __get_free_pages() and free_pages(). > > Signed-off-by: Eli Billauer Acked-by: Tejun Heo Thanks

Re: [PATCH 39/51] DMA-API: others: use dma_set_coherent_mask()

2013-09-20 Thread Tejun Heo
Hey, On Fri, Sep 20, 2013 at 03:00:18PM +0100, Russell King - ARM Linux wrote: > Another would be if subsystem maintainers are happy that I carry them, > I can add the acks, and then later on towards the end of the cycle, > provide a branch subsystem maintainers could pull. > > Or... if you can t

Re: [PATCH 39/51] DMA-API: others: use dma_set_coherent_mask()

2013-09-20 Thread Tejun Heo
On Fri, Sep 20, 2013 at 07:16:52AM -0500, Tejun Heo wrote: > On Fri, Sep 20, 2013 at 12:11:38AM +0100, Russell King wrote: > > The correct way for a driver to specify the coherent DMA mask is > > not to directly access the field in the struct device, but to use > > dma_set_c

Re: [PATCH 39/51] DMA-API: others: use dma_set_coherent_mask()

2013-09-20 Thread Tejun Heo
> > Convert all direct write accesses to using the correct API. > > Signed-off-by: Russell King Acked-by: Tejun Heo The patch is pretty widely spread. I don't mind how it gets routed but what's the plan? Thanks. -- tejun ___