Checkpatch reports WARNING:SUSPECT_CODE_INDENT in several places. Fix
this by aligning code properly with tabs.
Signed-off-by: Stephen Brennan
---
Changes in v2: rebase on next-20190827, fixing conflict with spacing fixes.
.../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 2 +-
.../staging
Several blocks of code are guarded by #ifdef TO_DO_LIST. If this is
defined, compilation fails. No machinery exists to define this, and no
documenation on the in-progress feature exists. Since this code is dead,
let's delete it.
Signed-off-by: Stephen Brennan
---
Sorry, I know you'r
Checkpatch reports WARNING:SUSPECT_CODE_INDENT in several places. Fix
this by aligning code properly with tabs.
Signed-off-by: Stephen Brennan
---
.../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 2 +-
.../staging/rtl8192u/ieee80211/ieee80211_rx.c | 112 +-
.../staging/rtl8192u
Several macros display unaligned, due to mixes of tabs and spaces. These
can be fixed by making spacing consistent, do this.
Signed-off-by: Stephen Brennan
---
.../staging/rtl8192u/ieee80211/ieee80211.h| 35 ++-
.../staging/rtl8192u/ieee80211/rtl819x_HT.h | 8 ++---
2
Addressed some spacing, brace placement, and macro alignment in this
driver. I do not have the relevant hardware, but I verified that the
drivers/staging/rtl8192u module built between each patch. This time I've
included proper patch descriptions, my apologies for the previous series.
St
Checkpatch emits several errors, warnings, and checks about spacing.
Apply checkpatch's suggested spacing rules.
Signed-off-by: Stephen Brennan
---
drivers/staging/rtl8192u/ieee80211/dot11d.c | 10 ++--
.../staging/rtl8192u/ieee80211/ieee80211.h| 4 +-
.../rtl8192u/ieee
Checkpatch emits several errors regarding braces being on the incorrect
line. These can be fixed by moving the brace, do this. In a few cases,
some comments were moved to facilitate this.
Signed-off-by: Stephen Brennan
---
.../staging/rtl8192u/ieee80211/ieee80211.h| 3 +-
.../staging
Signed-off-by: Stephen Brennan
---
.../staging/rtl8192u/ieee80211/ieee80211.h| 35 ++-
.../staging/rtl8192u/ieee80211/rtl819x_HT.h | 8 ++---
2 files changed, 22 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
b/drivers/staging
Signed-off-by: Stephen Brennan
---
.../staging/rtl8192u/ieee80211/ieee80211.h| 3 +-
.../staging/rtl8192u/ieee80211/ieee80211_rx.c | 116 ++
.../staging/rtl8192u/ieee80211/ieee80211_tx.c | 81 +---
.../staging/rtl8192u/ieee80211/ieee80211_wx.c | 3 +-
.../staging
Addressed some spacing, brace placement, and macro alignment in this driver. I
do not have the relevent hardware, but I verified that the
drivers/staging/rtl8192u module built between each patch.
Stephen Brennan (3):
staging: rtl8192u: fix OPEN_BRACE errors in ieee80211
staging: rtl8192u: fix
Signed-off-by: Stephen Brennan
---
drivers/staging/rtl8192u/ieee80211/dot11d.c | 10 ++--
.../staging/rtl8192u/ieee80211/ieee80211.h| 4 +-
.../rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
.../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 22
.../rtl8192u/ieee80211
Used checkpatch's --fix-inplace option for types SPACING, OPEN_BRACE,
ELSE_AFTER_BRACE. Manually edited the resulting changes to correct for
mistaken fixes and complete fixes that were only partially applied.
Signed-off-by: Stephen Brennan
---
To prevent this patch from getting even longe
In particular, fixes some over-indented if statement bodies as well as a
couple lines indented with spaces. checkpatch.pl now reports no warnings
on this file other than 80 character warnings.
Signed-off-by: Stephen Brennan
---
V2 also fixes an overlooked indentation error that checkpatch didn&#
On Fri, Oct 27, 2017 at 07:23:58AM -0700, Joe Perches wrote:
> On Fri, 2017-10-27 at 11:32 +0300, Dan Carpenter wrote:
> > But then ssi_buffer_mgr_copy_scatterlist_portion() is still not indented
> > correctly.
Yeah, I don't know how I missed it. I'll send a new version of the patch
out momentaril
In particular, fixes some over-indented if statement bodies as well as a
couple lines indented with spaces. checkpatch.pl now reports no warnings
on this file other than 80 character warnings.
Signed-off-by: Stephen Brennan
---
Hello again, hoping these indentation issues are a bit more
Apologies for the noise, this was the wrong patch. Please ignore this.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Simply break down some long lines and tab-indent them.
Signed-off-by: Stephen Brennan
---
I'm learning the patch submission process, and this is my first patch. I know
it's trivial but I'm just trying to get my feet wet. Thanks in advance for
taking the time to review this!
Hi Gilad & Tobin,
> > Perhaps, if Stephen is willing, re-write the code to be more readable
> > by, for example, using a temp
> > variable for the register address, and in doing so both making the
> > code more readable as well as
> > treating the symptom?
I'm definitely willing; however, I don't
Simply break down some long lines and tab-indent them.
Signed-off-by: Stephen Brennan
---
I'm learning the patch submission process, and this is my first patch. I know
it's trivial but I'm just trying to get my feet wet. Thanks in advance for
taking the time to review this!
19 matches
Mail list logo
