Hi Oscar,
On Sat, 18 Apr 2020 15:45:53 +0200
Oscar Carter wrote:
> Replace the for loop by a ternary operator whose condition is an AND
> bitmask against the priv->basic_rates variable.
>
> The purpose of the for loop was to check if any of bits from RATE_54M to
> RATE_6M was set, but it's not
On Wed, 1 Apr 2020 19:17:06 -0700
"John B. Wyatt IV" wrote:
> Remove unused code surrounded by an #if 0 block.
>
> Code has not been altered since 2014 as reported by git blame.
>
> Reported by checkpatch.
>
> Signed-off-by: John B. Wyatt IV
> ---
> drivers/staging/emxx_udc/emxx_udc.h | 6 -
On Wed, 1 Apr 2020 18:25:15 -0700
"John B. Wyatt IV" wrote:
> Fix 2 parenthesis alignment issues.
>
> Reported by checkpatch.
>
> Signed-off-by: John B. Wyatt IV
Reviewed-by: Stefano Brivio
--
Stefano
> Suggested-by: Quentin Deslandes
> Suggested-by: Stefano Brivio
> Reviewed-by: Quentin Deslandes
^ This should be dropped unless Quentin agrees to this version as well
> Signed-off-by: John B. Wyatt IV
Reviewed-by: Stefano Brivio
--
Stefano
__
> Suggested-by: Quentin Deslandes
> Suggested-by: Stefano Brivio
> Reviewed-by: Quentin Deslandes
> Signed-off-by: John B. Wyatt IV
> ---
> v7: Move an if check.
> Suggested by Stefano Brivio
>
> v6: Forgot to add all the v5 code to commit.
>
> v5: Remove
On Mon, 30 Mar 2020 15:26:04 -0700
"John B. Wyatt IV" wrote:
> On Tue, 2020-03-31 at 00:01 +0200, Stefano Brivio wrote:
> > On Mon, 30 Mar 2020 14:46:13 -0700
> > "John B. Wyatt IV" wrote:
> >
> > > Add error code handling to unused 'r
On Mon, 30 Mar 2020 15:03:55 -0700
"John B. Wyatt IV" wrote:
> On Mon, 2020-03-30 at 19:40 +0200, Stefano Brivio wrote:
> > On Sun, 29 Mar 2020 12:37:18 +0200 (CEST)
> > Julia Lawall wrote:
> >
> > > On Sun, 29 Mar 2020, Soumyajit Deb wrote:
> &g
> Suggested-by: Quentin Deslandes
> Suggested-by: Stefano Brivio
> Reviewed-by: Quentin Deslandes
> Signed-off-by: John B. Wyatt IV
> ---
> v6: Forgot to add all the v5 code to commit.
>
> v5: Remove Suggested-by: Julia Lawall above seperator line.
> Remove break
> Suggested-by: Quentin Deslandes
> Suggested-by: Stefano Brivio
> Reviewed-by: Quentin Deslandes
> Signed-off-by: John B. Wyatt IV
> ---
> v5: Remove Suggested-by: Julia Lawall above seperator line.
> Remove break; statement in switch block.
> break; removal checked b
On Sun, 29 Mar 2020 12:37:18 +0200 (CEST)
Julia Lawall wrote:
> On Sun, 29 Mar 2020, Soumyajit Deb wrote:
>
> > I had the same doubt the other day about the replacement of udelay() with
> > usleep_range(). The corresponding range for the single argument value of
> > udelay() is quite confusing a
> Suggested-by: Quentin Deslandes
> Suggested-by: Stefano Brivio
> Suggested-by: Julia Lawall
> Reviewed-by: Quentin Deslandes
> Signed-off-by: John B. Wyatt IV
> ---
> v4: Move Suggested-by: Julia Lawall above seperator line.
Actually, as Julia didn't suggest thi
On Thu, 26 Mar 2020 02:52:53 +0530
Simran Singhal wrote:
> Compress two lines into a single line if immediate return statement is found.
> It also removes variable cmd_obj as it is no longer needed.
>
> It is done using script Coccinelle.
This should be consistent. What does "it" refer to, now?
On Thu, 26 Mar 2020 02:24:18 +0530
Simran Singhal wrote:
> Compress two lines into a single line if immediate return statement is found.
Same as your patches for issues reported by checkpatch, I think you
should post these ones as a patchset.
--
Stefano
___
ed-off-by: Shreeya Patel
Reviewed-by: Stefano Brivio
--
Stefano
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Simran,
On Wed, 25 Mar 2020 22:14:52 +0530
Simran Singhal wrote:
> Add whiteline after variable declarations to remove the checkpatch.pl
> warning:
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Simran Singhal
Sorry for the late review. This patch introduces similar
On Wed, 25 Mar 2020 19:32:45 +0530
Simran Singhal wrote:
> Clean up unnecessary braces around single statement blocks.
> Issues reported by checkpatch.pl as:
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Simran Singhal
> ---
> drivers/staging/rtl8723bs/c
On Wed, 25 Mar 2020 19:52:26 +0530
Simran Singhal wrote:
> Remove multiple assignments by factorizing them.
> Problem found using checkpatch.pl:-
> CHECK: multiple assignments should be avoided
>
> Signed-off-by: Simran Singhal
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 7 +--
> 1
Hi Shreeya,
On Mon, 23 Mar 2020 04:48:08 +0530
Shreeya Patel wrote:
> On Sun, 2020-03-22 at 08:09 -0700, Joe Perches wrote:
> > On Sun, 2020-03-22 at 12:27 +0100, Greg KH wrote:
>
> Hi Greg and Joe,
>
> > > On Sun, Mar 22, 2020 at 03:51:13AM +0530, Shreeya Patel wrote:
> > > > Add space ar
On Sat, 21 Mar 2020 19:34:31 +0530
Simran Singhal wrote:
> This patch fixes the checkpatch warning by removing multiple blank
> lines.
Actually, you're removing just one. Can you please re-post fixing the
description? Mind that it's going to be a "v2", that is, the second
version of this patch.
@
>
> - to = \(kmalloc\|kzalloc\)(size,flag);
> + to = kmemdup(from,size,flag);
>if (to==NULL || ...) S
> - memcpy(to, from, size);
>
> Signed-off-by: Shreeya Patel
Reviewed-by: Stefano Brivio
--
Stefano
___
devel m
I suspect this is actually a bug, that is:
os_dep/os_intfs.c:74:static int rtw_ampdu_enable = 1;/* for enable tx_ampdu ,0:
disable, 0x1:enable (but wifi_spec should be 0), 0x2: force enable (don't care
wifi_spec) */
and that seems to actually map to the ampdu_enable field in
pregistrypriv
Hi Lakshmi,
On Wed, 11 Mar 2020 19:42:06 -0700
Lakshmi Ramasubramanian wrote:
> On 3/11/2020 6:58 AM, Shreeya Patel wrote:
>
> > Remove unnecessary if and else conditions since both are leading to the
> > initialization of "phtpriv->ampdu_enable" with the same value.
> >
> > Signed-off-by: Shr
On Wed, 11 Mar 2020 19:08:11 +0530
Shreeya Patel wrote:
> Remove if and else conditions since both are leading to the
> initialization of "valueDMATimeout" and "valueDMAPageCount" with
> the same value.
>
> Found using coccinelle script.
>
> Signed-off
ed-off-by: Shreeya Patel
This looks good to me. Further clean-ups here could probably make this
look less messy (there are long lines, unnecessary parentheses that are
rather confusing, especially on that 4/5 factor, "magic" constants that
might make sense to figure out the meaning of, e
On Tue, 29 Aug 2017 12:59:00 +0200
Geert Uytterhoeven wrote:
> Hi Greg,
>
> On Sun, Aug 27, 2017 at 5:03 PM, Greg Kroah-Hartman
> wrote:
> > The IRDA code has long been obsolete and broken. So, to keep people
> > from trying to use it, and to prevent people from having to maintain it,
> > let'
25 matches
Mail list logo
