[PATCH v2] spi: mt7621: Move SPI driver out of staging

ND on CS1 without any issues (so far). This patch also documents the devicetree bindings for the MT7621 SPI device driver. Signed-off-by: Stefan Roese Cc: Rob Herring Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin Cc: Armando Mir

Re: [PATCH] spi: mt7621: Move SPI driver out of staging

On 21.03.19 15:25, Mark Brown wrote: On Thu, Mar 14, 2019 at 12:52:12PM +0100, Stefan Roese wrote: This looks pretty good, a few trivial issues below but nothing major I think. +config SPI_MT7621 + tristate "MediaTek MT7621 SPI Controller" + depends on RALINK +

Re: [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c

On 14.03.19 14:14, Matthias Brugger wrote: On 14/03/2019 12:37, Armando Miraglia wrote: Absolutely! Please don't top post :) Cheers, A. On Thu, Mar 14, 2019 at 12:36 PM Stefan Roese wrote: [...] Would it be possible for you to wait a bit with this minor cleanup? As I'm p

[PATCH] spi: mt7621: Move SPI driver out of staging

ND on CS1 without any issues (so far). This patch also documents the devicetree bindings for the MT7621 SPI device driver. Signed-off-by: Stefan Roese Cc: Rob Herring Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin Cc: Armando Mir

Re: [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c

Hi Armando, On 14.03.19 12:13, Armando Miraglia wrote: My answers are in-line below. BTW bare with me as this is my attempt to get my feet wet in how to contribute to the linux kernel for my own pleasure and interest :) On Wed, Mar 13, 2019 at 03:34:54PM +0300, Dan Carpenter wrote: On Wed, Mar

Re: [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c

On 13.03.19 17:46, Matthias Brugger wrote: On 13/03/2019 17:34, Chuanhong Guo wrote: Hi! On Wed, Mar 13, 2019 at 8:28 PM Matthias Brugger wrote: On 13/03/2019 13:24, Armando Miraglia wrote: [...] Apart from fixing styling issues it would be usefull to see if we can add support for mt7621

Re: [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier

On 04.02.19 09:53, Mark Brown wrote: On Mon, Feb 04, 2019 at 09:34:56AM +1100, NeilBrown wrote: It is extremely common in the kernel for a file to start // SPDX-License-Identifier. and to have that immediately followed by a comment lile: /* * . * Yes, there

[PATCH 8/9 v3] staging: spi: mt7621: Use macros instead of hardcoded values

This patch uses macros instead of hardcoded values for the SPI_MASTER register access in mt7621_spi_reset() and mt7621_spi_prepare(). Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - New patch

[PATCH 9/9 v3] staging: spi: mt7621: Remove superfluous pre-declaration of struct mt7621_spi

This patch removes the superfluous pre-declaration of struct mt7621_spi. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - New patch, changes spilt into separate patches drivers/staging/mt7621-spi

[PATCH 6/9 v3] staging: spi: mt7621: Use recommended comment style

This patch changes some comments to use the recommended multi-line comment style. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - New patch, changes spilt into separate patches drivers/staging

[PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier

Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - No change v2: - Changes are done to the driver in staging before

[PATCH 4/9 v3] staging: spi: mt7621: Remove superfluous SPI_BPW_MASK definition

This patch removes the SPI_BPW_MASK definition as this is already available in include/linux/spi/spi.h. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - New patch, changes spilt into separate

[PATCH 7/9 v3] staging: spi: mt7621: Sort register definitions

This patch sorts the SPI register definitions by increasing addresses. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - New patch, changes spilt into separate patches drivers/staging/mt7621-spi

[PATCH 2/9 v3] staging: spi: mt7621: Clean up excessive header usage

This patch removes unnecessary header includes and sorts the remaining ones alphabetically. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - New patch, changes spilt into separate patches drivers

[PATCH 3/9 v3] staging: spi: mt7621: Add return code check on device_reset()

This patch adds a return code check on device_reset() and removes the compile warning. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - New patch, changes spilt into separate patches drivers

[PATCH 5/9 v3] staging: spi: mt7621: Minor cosmetic changes

Align macro definitions and add some empty lines to make the code better readable. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v3: - New patch, changes spilt into separate patches drivers/staging

Re: [PATCH 2/2 v2] staging: spi: mt7621: Minor code cleanup

On 01.02.19 10:03, Greg Kroah-Hartman wrote: On Fri, Feb 01, 2019 at 09:57:12AM +0100, Stefan Roese wrote: This patch cleans up some minor issues with this driver: - Remove unnecessary header includes - Sort header alphabetically - Use correct comment style - Add return code check on

[PATCH 2/2 v2] staging: spi: mt7621: Minor code cleanup

hardcoded values for SPI_MASTER register access as suggested by Neil Brown (in mt7621_spi_reset and mt7621_spi_prepare) Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v2: - Changes are done to the

[PATCH 1/2 v2] staging: spi: mt7621: Switch to SPDX identifier

Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Greg Kroah-Hartman Cc: NeilBrown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin --- v2: - Changes are done to the driver in staging before moving it out of