Re: [PATCH v3 09/26] compat_ioctl: move drivers to compat_ptr_ioctl

2019-04-18 Thread Stefan Hajnoczi
| 12 +- > drivers/vhost/test.c | 12 +- > drivers/vhost/vsock.c | 12 +- > fs/fat/file.c | 13 +-- > 16 files changed, 20 insertions(+), 237 deletions(-) The vhost parts loo

Re: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

2017-08-31 Thread Stefan Hajnoczi
On Tue, Aug 29, 2017 at 03:37:07PM +, Jorgen S. Hansen wrote: > > On Aug 29, 2017, at 4:36 AM, Dexuan Cui wrote: > If we allow multiple host side transports, virtio host side support and > vmci should be able to coexist regardless of the order of initialization. That sounds good to me. This

Re: [PATCH net-next 3/3] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

2017-08-24 Thread Stefan Hajnoczi
On Tue, Aug 22, 2017 at 09:40:01PM +, Dexuan Cui wrote: > > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > > On Fri, Aug 18, 2017 at 10:23:54PM +, Dexuan Cui wrote: > > > > > +static bool hvs_stream_allow(u32 cid, u32 port) > > > > > +{ &

Re: [PATCH net-next 3/3] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

2017-08-22 Thread Stefan Hajnoczi
On Fri, Aug 18, 2017 at 10:23:54PM +, Dexuan Cui wrote: > > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > > Sent: Thursday, August 17, 2017 07:56 > > To: Dexuan Cui > > On Tue, Aug 15, 2017 at 10:18:41PM +, Dexuan Cui wrote: > > > +

Re: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

2017-08-22 Thread Stefan Hajnoczi
On Fri, Aug 18, 2017 at 11:07:37PM +, Dexuan Cui wrote: > > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > > > CID is not really used by us, because we only support guest<->host > > communication, > > > and don't support guest<->guest

Re: [PATCH net-next 3/3] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

2017-08-18 Thread Stefan Hajnoczi
On Tue, Aug 15, 2017 at 10:18:41PM +, Dexuan Cui wrote: > +static u32 hvs_get_local_cid(void) > +{ > + return VMADDR_CID_ANY; > +} Interesting concept: the guest never knows its CID. This is nice from a live migration perspective. Currently VMCI and virtio adjust listen socket local CIDs

Re: [PATCH net-next 2/3] vsock: fix vsock_dequeue/enqueue_accept race

2017-08-18 Thread Stefan Hajnoczi
On Tue, Aug 15, 2017 at 10:15:39PM +, Dexuan Cui wrote: > With the current code, when vsock_dequeue_accept() is removing a sock > from the list, nothing prevents vsock_enqueue_accept() from adding a new > sock into the list concurrently. We should add a lock to protect the list. The listener s

Re: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

2017-08-18 Thread Stefan Hajnoczi
On Fri, Aug 18, 2017 at 03:07:30AM +, Dexuan Cui wrote: > > From: Jorgen S. Hansen [mailto:jhan...@vmware.com] > > Sent: Thursday, August 17, 2017 08:17 > > > > > > Putting aside nested virtualization, I want to load the transport (vmci, > > > Hyper-V, vsock) for which there is paravirtualized

Re: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

2017-08-17 Thread Stefan Hajnoczi
On Thu, Aug 17, 2017 at 08:00:29AM +, Dexuan Cui wrote: > > Without the patch, vmw_vsock_vmci_transport.ko can automatically load > when an application creates an AF_VSOCK socket. > > This is the expected good behavior on VMware hypervisor, but as we > are going to add hv_sock.ko (i.e. Hyper-

Re: [PATCH 0/7] introduce Hyper-V VM Sockets(hvsock)

2015-07-16 Thread Stefan Hajnoczi
On Mon, Jul 06, 2015 at 07:39:35AM -0700, Dexuan Cui wrote: > Hyper-V VM Sockets (hvsock) is a byte-stream based communication mechanism > between Windowsd 10 (or later) host and a guest. It's kind of TCP over > VMBus, but the transportation layer (VMBus) is much simpler than IP. > With Hyper-V VM

Re: [PATCH 00/25] line6usb cleanup

2015-01-11 Thread Stefan Hajnoczi
On Sun, Jan 11, 2015 at 10:34 AM, Takashi Iwai wrote: > At Fri, 9 Jan 2015 23:35:46 -0600, > Chris Rorvick wrote: >> >> The line6usb driver references the device's idProduct and, in some >> cases, the interface number in a number of places to determine device- >> specific configuration values and

Re: [PATCH 00/25] line6usb cleanup

2015-01-10 Thread Stefan Hajnoczi
ng that some of > this is really only compile-tested. I no longer own a Pod HD300 so I cannot test these patches. The code looks fine. Reviewed-by: Stefan Hajnoczi ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: line6: toneport.c: Fix for possible null pointer dereference

2014-12-21 Thread Stefan Hajnoczi
: Rickard Strandqvist > --- > drivers/staging/line6/toneport.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) Reviewed-by: Stefan Hajnoczi ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriv

Re: Anybody working on line6?

2014-06-26 Thread Stefan Hajnoczi
On Fri, Jun 27, 2014 at 1:39 AM, Greg KH wrote: > On Tue, Jun 24, 2014 at 10:12:03PM +0800, Stefan Hajnoczi wrote: >> On Tue, Jun 24, 2014 at 9:52 PM, Greg KH wrote: >> > On Tue, Jun 24, 2014 at 11:54:10AM +0800, Stefan Hajnoczi wrote: >> >> On Tue, Jun 24, 2014

Re: Anybody working on line6?

2014-06-24 Thread Stefan Hajnoczi
On Tue, Jun 24, 2014 at 9:52 PM, Greg KH wrote: > On Tue, Jun 24, 2014 at 11:54:10AM +0800, Stefan Hajnoczi wrote: >> On Tue, Jun 24, 2014 at 4:23 AM, Kristina Martšenko >> wrote: >> > I'm helping Greg do a bit of cleanup in the staging tree. I noticed that >

Re: Anybody working on line6?

2014-06-23 Thread Stefan Hajnoczi
On Tue, Jun 24, 2014 at 4:23 AM, Kristina Martšenko wrote: > I'm helping Greg do a bit of cleanup in the staging tree. I noticed that > nobody seems to have worked towards moving line6 out of staging in over > a year. Are there any plans to clean it up and move it out soon? Because > otherwise we'

Re: [PATCH] staging: line6: toneport.c: Fix for possible null pointer dereference

2014-05-20 Thread Stefan Hajnoczi
idProduct); > > @@ -444,13 +448,11 @@ void line6_toneport_disconnect(struct usb_interface > *interface) > device_remove_file(&interface->dev, &dev_attr_led_green); > } > > - if (toneport != NULL) { > - struct snd_line6_pcm *line6pcm = toneport->

Re: [PATCH v2] staging: line6: Add blank lines after declarations

2014-03-25 Thread Stefan Hajnoczi
rs/staging/line6/playback.c | 5 + > drivers/staging/line6/toneport.c | 1 + > 3 files changed, 7 insertions(+) Reviewed-by: Stefan Hajnoczi ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [patch] staging: line6: add bounds check in snd_toneport_source_put()

2013-09-13 Thread Stefan Hajnoczi
On Fri, Sep 13, 2013 at 10:07 AM, Dan Carpenter wrote: > "source" comes from the user in snd_ctl_elem_write() so it needs to be > checked. > > Signed-off-by: Dan Carpenter Reviewed-by: Stefan Hajnoczi ___