Re: [PATCH 2/2] comedi/ni_pcidio: make all defines uppercase

2018-12-11 Thread Spencer Olson
On Tue, Dec 11, 2018 at 3:50 AM Alexander Schroth wrote: > > According to the Linux coding guidelines, defines should be written > in uppercase. This patch converts all define-statements in the > ni_pcidio.c file to uppercase, thus matching the coding style of the > kernel. > > Signed-off-by: Alex

Re: [PATCH 1/2] comedi/ni_pcidio: remove unused defines

2018-12-11 Thread Spencer Olson
On Tue, Dec 11, 2018 at 3:50 AM Alexander Schroth wrote: > > Define-statements, which are not used within the file, are being removed > as they add clutter to the code. > Because the file is not being included from anywhere else, this has no > negative side-effects. This is somewhat coincidental,

Re: [PATCH v2] staging: comedi: change do_insn*_ioctl to allow more samples

2018-12-04 Thread Spencer Olson
On Tue, Dec 4, 2018 at 12:08 PM Spencer E. Olson wrote: > > Changes do_insn*_ioctl functions to allow for data lengths for each > comedi_insn of up to 2^16. This patch also changes these functions to only > allocate as much memory as is necessary for each comedi_insn, rather than > allocating a f

Re: [PATCH] staging: comedi: change do_insn*_ioctl to allow more samples

2018-12-04 Thread Spencer Olson
On Wed, Oct 31, 2018 at 4:49 AM Ian Abbott wrote: > > On 25/10/18 02:36, Spencer E. Olson wrote: > > Changes do_insn*_ioctl functions to allow for data lengths for each > > comedi_insn of up to 2^16. This patch also changes these functions to only > > allocate as much memory as is necessary for e

Re: [PATCH] staging: comedi: change do_insn*_ioctl to allow more samples

2018-10-30 Thread Spencer Olson
On Tue, Oct 30, 2018 at 6:21 AM Ian Abbott wrote: > > On 25/10/18 02:36, Spencer E. Olson wrote: > > Changes do_insn*_ioctl functions to allow for data lengths for each > > comedi_insn of up to 2^16. This patch also changes these functions to only > > allocate as much memory as is necessary for e

Re: [PATCH] staging: comedi: clarify/unify macros for NI macro-defined terminals

2018-10-24 Thread Spencer Olson
On Wed, Oct 24, 2018 at 10:39 AM Ian Abbott wrote: > > On 24/10/18 15:33, Spencer E. Olson wrote: > > Uses a single macro to define multiple macros that represent a series of > > terminals for NI devices. This patch also redefines NI_MAX_COUNTERS as the > > maximum number of counters possible on

Re: [PATCH] staging: comedi: ni_mio_common: scale ao INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS

2018-10-24 Thread Spencer Olson
On Wed, Oct 24, 2018 at 8:18 AM Dan Carpenter wrote: > > On Wed, Oct 24, 2018 at 07:59:45AM -0600, Spencer E. Olson wrote: > > Changes implementation of INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS for > > ni_mio devices to scale the result by the number of channels being used. > > I really can't unders

Re: [PATCH] staging: comedi: ni_mio_common: protect register write overflow

2018-10-02 Thread Spencer Olson
On Tue, Oct 2, 2018 at 6:16 PM Spencer Olson wrote: > > On Tue, Oct 2, 2018 at 11:32 AM Greg Kroah-Hartman > wrote: > > > > On Wed, Sep 19, 2018 at 10:17:19AM -0600, Spencer E. Olson wrote: > > > Fixes two problems introduced as early as > > > comm

Re: [PATCH] staging: comedi: ni_mio_common: protect register write overflow

2018-10-02 Thread Spencer Olson
On Tue, Oct 2, 2018 at 11:32 AM Greg Kroah-Hartman wrote: > > On Wed, Sep 19, 2018 at 10:17:19AM -0600, Spencer E. Olson wrote: > > Fixes two problems introduced as early as > > commit 03aef4b6dc12 ("Staging: comedi: add ni_mio_common code"): > > (1) Ensures that the last four bits of NISTC_RTSI_

Re: [PATCH v3 04/13] staging: comedi: ni_routing: Add NI signal routing info

2018-10-02 Thread Spencer Olson
On Tue, Oct 2, 2018 at 4:17 AM Ian Abbott wrote: > > On 02/10/18 03:24, Spencer E. Olson wrote: > > See README for a thorough discussion of this content. > > > > Adds tables of all register values for routing various signals to various > > terminals on National Instruments hardware. This informat

Re: [PATCH v2 05/13] staging: comedi: add interface to ni routing table information

2018-10-01 Thread Spencer Olson
On Mon, Oct 1, 2018 at 5:17 AM Ian Abbott wrote: > > On 27/09/18 20:27, Spencer E. Olson wrote: > > Adds interface and associated unittests for accessing/looking-up/validating > > the new ni routing table information. > > > > Signed-off-by: Spencer E. Olson > > --- > > > > Changes since last subm

Re: [PATCH v2 04/13] staging: comedi: ni_routing: Add NI signal routing info

2018-10-01 Thread Spencer Olson
On Mon, Oct 1, 2018 at 5:17 AM Ian Abbott wrote: > > On 27/09/18 20:27, Spencer E. Olson wrote: > > See README for a thorough discussion of this content. > > > > Adds tables of all register values for routing various signals to various > > terminals on National Instruments hardware. This informat

Re: [PATCH 05/13] staging: comedi: add interface to ni routing table information

2018-09-25 Thread Spencer Olson
How about making it selected based on COMEDI_NI_TIO? This will impact all the *mio* (except ATMIO16D) and 660x drivers. This seems to be everything that fits into the e-series, m-series, and 660x series devices for which we know the register values. It also doesn't look like anything else depend

Re: [PATCH 04/13] staging: comedi: ni_routing: Add NI signal routing info

2018-09-25 Thread Spencer Olson
On Tue, Sep 25, 2018 at 6:26 AM Ian Abbott wrote: > > On 25/09/18 05:47, Spencer E. Olson wrote: > > [N.B. top-posting is frowned upon on the kernel mailing lists.] Sorry :-) > > > These static arrays are > >(1) not expressed with as much "const"ness as suggested > >(2) included into one

Re: [PATCH 07/13] staging: comedi: ni_mio_common: implement global pfi,rtsi routing

2018-09-25 Thread Spencer Olson
On Tue, Sep 25, 2018 at 4:27 AM Ian Abbott wrote: > > On 19/09/18 17:38, Spencer E. Olson wrote: > > Implement device-global config interface for ni_mio devices. In > > particular, this patch implements: > > INSN_DEVICE_CONFIG_TEST_ROUTE, > > INSN_DEVICE_CONFIG_CONNECT_ROUTE, > > INSN_DEVICE_CONF