On Wednesday 01 July 2015 02:45 PM, Sudip Mukherjee wrote:
> On Wed, Jul 01, 2015 at 02:04:48PM +0530, Sohny Thomas wrote:
>> On Wednesday 01 July 2015 01:32 PM, Sudip Mukherjee wrote:
>>> On Wed, Jul 01, 2015 at 01:06:48PM +0530, Sohny Thomas wrote:
>>
>
>> Thi
i = virtpci_device_del(NULL /*no parent bus */, VIRTHBA_TYPE,
&scsi.wwnn, NULL);
- if (i) {
+ if (i)
return 1;
- }
- return 0;
+ else
+ return 0;
>>> No, now this will introduce a new checkpatch warni
On Wednesday 01 July 2015 01:32 PM, Sudip Mukherjee wrote:
> On Wed, Jul 01, 2015 at 01:06:48PM +0530, Sohny Thomas wrote:
>
>>> No, now this will introduce a new checkpatch warning that "else is not
>>> required after return". why did you introduce this &quo
Thanks for review, my answers inline
On 01-07-2015 12:27, Sudip Mukherjee wrote:
On Wed, Jul 01, 2015 at 03:05:45AM +0530, Sohny Thomas wrote:
FIX 2 unnecessary braces found by checkpatch.pl
Signed-off-by: Sohny Thomas
---
drivers/staging/unisys/virtpci/virtpci.c | 11 ++-
1 file
FIX 2 unnecessary braces found by checkpatch.pl
Signed-off-by: Sohny Thomas
---
drivers/staging/unisys/virtpci/virtpci.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/virtpci/virtpci.c
b/drivers/staging/unisys/virtpci/virtpci.c
index
