Re: [PATCH] Staging: irda: Prefer 'unsigned int' to bare use of 'unsigned'

Hi, Did you read this? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/irda/TODO Thanks, Shyam > This patch fixes the following checkpatch.pl issue at multiple lines: > > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > > Signed-off-by: Sumit P

[PATCH] rtl8188eu: core: Remove NULL test before vfree

vfree frees the virtually continuous block of memory beginning at addr. If addr is NULL, no operation is performed. So, NULL test is not needed before vfree(). Signed-off-by: Shyam Saini --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH] staging: rtl8192e: rtl8192e: Remove NULL test before vfree

vfree frees the virtually continuous block of memory beginning at addr. If addr is NULL, no operation is performed. So, NULL test is not needed before vfree. Signed-off-by: Shyam Saini --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions

Re: [PATCH] Staging: media: bcm2048: Use octal permissions '0444'

On Tue, 2016-10-18 at 14:36 +0200, Greg KH wrote: > On Tue, Oct 18, 2016 at 05:52:21PM +0530, Shyam Saini wrote: > > > > On Mon, 2016-10-17 at 21:37 +0200, Greg KH wrote: > > > > > > On Mon, Oct 17, 2016 at 10:10:08PM +0530, Shyam Saini wrote: > > > &g

Re: [PATCH] Staging: media: bcm2048: Use octal permissions '0444'

On Mon, 2016-10-17 at 21:37 +0200, Greg KH wrote: > On Mon, Oct 17, 2016 at 10:10:08PM +0530, Shyam Saini wrote: > > > > On Mon, 2016-10-17 at 18:07 +0200, Greg KH wrote: > > > > > > On Mon, Oct 17, 2016 at 09:24:19PM +0530, Shyam Saini wrote: > > > >

Re: [PATCH] Staging: media: bcm2048: Use octal permissions '0444'

On Mon, 2016-10-17 at 18:07 +0200, Greg KH wrote: > On Mon, Oct 17, 2016 at 09:24:19PM +0530, Shyam Saini wrote: > > > > Fixed following checkpatch warning > > Symbolic permissions 'S_IRUGO' are not preferred. Consider using > > octal > > permissions

[PATCH] Staging: media: bcm2048: Use octal permissions '0444'

Fixed following checkpatch warning Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444' Signed-off-by: Shyam Saini --- drivers/staging/media/bcm2048/radio-bcm2048.c | 18 +- 1 file changed, 9 insertions(+), 9 deleti

[PATCH] Staging: media: bcm2048: Use octal permissions '0644'

Fixed following checkpatch.pl warning WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. Signed-off-by: Shyam Saini --- drivers/staging/media/bcm2048/radio-bcm2048.c | 40 +-- 1 file changed,

[PATCH 1/1] Staging: gs_fpgaboot: Use octal permissions '0444'

Fixed following checkpatch warning WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. Signed-off-by: Shyam Saini --- drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle

On Sun, 2016-10-02 at 17:37 +0200, Greg KH wrote: > On Sun, Oct 02, 2016 at 08:51:29PM +0530, Shyam Saini wrote: > > > > On Sun, 2016-10-02 at 16:58 +0200, Greg KH wrote: > > > > > > On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote: > > > &g

Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle

On Sun, 2016-10-02 at 16:58 +0200, Greg KH wrote: > On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote: > > > > Remove the explicit NULL comparison and rewrite in a compact form. > > > > Signed-off-by: shyam saini > > --- > >  drivers/staging/

[PATCH 1/1] Staging: vt6655: Remove explicit NULL comparison using Coccinelle

Remove the explicit NULL comparison and rewrite in a compact form. Signed-off-by: shyam saini --- drivers/staging/vt6655/rxtx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 890d108..7e69bc9 100644

[PATCH 1/1] Staging: android: ion: Fixed coding style issues

Fixed switch case indentation issue and void function return statement issue Signed-off-by: shyam saini --- drivers/staging/android/ion/ion_of.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging

[PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle

Remove the explicit NULL comparison and rewrite in a compact form. Signed-off-by: shyam saini --- drivers/staging/android/ion/ion_of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index 01f3067

[PATCH 1/1] Staging: android: ion: Fixed coding style issues

Fixed checkpatch coding style issues Signed-off-by: shyam saini --- drivers/staging/android/ion/ion_of.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index de0899a..01f3067

[PATCH 1/1] Staging: android: ion : Remove explicit NULL comparison and Fixed coding style

Remove the explicit NULL comparison and rewrite in a compact form and fixed switch case indentation issue. Signed-off-by: shyam saini --- drivers/staging/android/ion/ion_of.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/android/ion

[PATCH 1/1] staging: i4l: pcbit: Remove explicit NULL comparison

Remove the explicit NULL comparison and rewrite in a compact form using Coccinelle Signed-off-by: shyam saini --- drivers/staging/i4l/pcbit/callbacks.c | 4 ++-- drivers/staging/i4l/pcbit/capi.c | 18 +- drivers/staging/i4l/pcbit/drv.c | 14 +++--- drivers

[PATCH 1651/1651] staging: i4l: pcbit: Remove explicit NULL comparison

Remove the explicit NULL comparison and rewrite in a compact form using Coccinelle Signed-off-by: shyam saini --- drivers/staging/i4l/pcbit/callbacks.c | 4 ++-- drivers/staging/i4l/pcbit/capi.c | 18 +- drivers/staging/i4l/pcbit/drv.c | 14 +++--- drivers

[PATCH 1/1] Staging: rdma: hfi1: rc.c: Fixed coding style issues

Fixed following checkpatch.pl warnings: Prefer 'unsigned int' to bare use of 'unsigned' Prefer READ_ONCE() over ACCESS_ONCE() Signed-off-by: Shyam Saini --- drivers/staging/rdma/hfi1/rc.c | 12 ++-- drivers/staging/rdma/hfi1/ruc.c | 6 +++--- 2 files changed

[PATCH 1/1] Staging: rdma: hfi1: sdma.c: Fixed coding style issues

Fixed following checkpatch.pl warnings: Prefer 'unsigned int' to bare use of 'unsigned' Prefer READ_ONCE() over ACCESS_ONCE() Signed-off-by: Shyam Saini --- drivers/staging/rdma/hfi1/sdma.c | 30 +++--- 1 file changed, 15 insertions(+), 1

[PATCH 1/1] Staging: comedi: comedi_fops.c: Fixed coding style issue

Fixed following checkpatch.pl warnings WARNING: Prefer WRITE_ONCE(, ) over ACCESS_ONCE() = WARNING: Prefer READ_ONCE() over ACCESS_ONCE() Signed-off-by: Shyam Saini --- drivers/staging/comedi/comedi_fops.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a

[PATCH 1/1] Staging: emxx_udc: emxx_udc: fixed coding style issue

fixed checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Shyam Saini --- drivers/staging/emxx_udc/emxx_udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b

[PATCH] Staging: android: timed_gpio: fixed bare use of 'unsigned'

'unsigned int gpio' is added in place of 'unsigned gpio' Signed-off-by: Shyam Saini --- drivers/staging/android/timed_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/timed_gpio.c b/drivers/staging/android/timed_gpio.c in