-by: Shraddha Barke
---
drivers/staging/Kconfig | 2 -
drivers/staging/Makefile| 1 -
drivers/staging/gdm72xx/Kconfig | 63 ---
drivers/staging/gdm72xx/Makefile| 6 -
drivers/staging/gdm72xx/TODO| 2 -
drivers/staging/gdm72xx/gdm_qos.c | 438
Hello all,
I'm helping Greg do a bit of cleanup in the staging tree. The checkpatch
warnings in gdm72xx have been taken care of and the TODO only mentions
"fix kernel style warnings". Could you please suggest what needs to be
done before gdm72xx can be moved out of staging?.
Regards,
Shrad
put_event_entry is used only once. Replace it's usage with direct call
to list_add_tail().
Signed-off-by: Shraddha Barke
---
Changes in v4-
Deleted the function
Changes in v3-
Removed BUG_ON
Changes in v2-
No change
drivers/staging/gdm72xx/gdm_wimax.c | 9 +
1 file chang
No need for the parentheses around any function pointer.
Detected using checkpatch.
Signed-off-by: Shraddha Barke
---
Changes -
Nothing
drivers/staging/gdm72xx/gdm_wimax.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers
Add missing spaces around "+", "&" and "/" to follow kernel coding
style. Warning detected by checkpatch.
Signed-off-by: Shraddha Barke
---
Changes in v4-
No change
Changes in v3-
Fix 80 line
Changes in v2-
Subject
drivers/staging/gdm72xx/gdm_qos.c
Add missing spaces around "+", "&" and "|" to follow kernel coding
style. Warning detected by checkpatch.
Signed-off-by: Shraddha Barke
---
Changes -
Nothing
drivers/staging/gdm72xx/hci.h | 2 +-
drivers/staging/gdm72xx/netlink_k.c | 6 +++---
driver
This patch series fixes last of checkpatch warnings in gdm72xx
Shraddha Barke (4):
Staging: gdm72xx: Add space around that "+", "&" and "|"
Staging: gdm72xx: Add space around that "+", "&" and "/"
Staging: gdm72xx:
Delete the BUG_ON check.
Signed-off-by: Shraddha Barke
---
Changes in v3-
Deleted BUG_ON
Changes in v2-
Nothing
drivers/staging/gdm72xx/gdm_wimax.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72xx/gdm_wimax.c
index 859880c
Add missing spaces around "+", "&" and "/" to follow kernel coding
style. Warning detected by checkpatch.
Signed-off-by: Shraddha Barke
---
Changes in v2-
Subject
Changes in v3-
Fix 80 line.
drivers/staging/gdm72xx/gdm_qos.c | 12 ++--
driver
No need for the parentheses around any function pointer.
Detected using checkpatch.
Signed-off-by: Shraddha Barke
---
Changes in v2 and v3-
Nothing.
drivers/staging/gdm72xx/gdm_wimax.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/gdm72xx
Add missing spaces around "+", "&" and "|" to follow kernel coding
style. Warning detected by checkpatch.
Signed-off-by: Shraddha Barke
---
Changes in v2 and v3-
No change.
drivers/staging/gdm72xx/hci.h | 2 +-
drivers/staging/gdm72xx/netlink_k.c |
This patch series fixes last of checkpatch warnings in gdm72xx.
Shraddha Barke (4):
Staging: gdm72xx: Add space around that "+", "&" and "|"
Staging: gdm72xx: Add space around that "+", "&" and "/"
Staging: gdm72xx:
Replace the usage of BUG_ON with WARN_ON.
Signed-off-by: Shraddha Barke
---
Changes in v2-
No change
drivers/staging/gdm72xx/gdm_wimax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72xx/gdm_wimax.c
index 2fa86ad
No need for the parentheses around any function pointer.
Detected using checkpatch.
Signed-off-by: Shraddha Barke
---
Changes in v2-
Nothing
drivers/staging/gdm72xx/gdm_wimax.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b
Add missing spaces around "+", "&" and "|" to follow kernel coding
style. Warning detected by checkpatch.
Signed-off-by: Shraddha Barke
---
Changes in v2-
Subject changed
drivers/staging/gdm72xx/gdm_qos.c | 12 ++--
drivers/staging/gdm72xx/gdm_
Add missing spaces around "+", "&" and "|" to follow kernel coding
style. Warning detected by checkpatch.
Signed-off-by: Shraddha Barke
---
Changes in v2-
Nothing
drivers/staging/gdm72xx/hci.h | 2 +-
drivers/staging/gdm72xx/netlink_k.c | 6 +++---
d
Add missing spaces around "+", "&" and "|" to follow kernel coding
style. Warning detected by checkpatch.
Signed-off-by: Shraddha Barke
---
drivers/staging/gdm72xx/gdm_qos.c | 12 ++--
drivers/staging/gdm72xx/gdm_sdio.c | 4 ++--
drivers/staging/gd
This patch fixes the checkpatch.pl warning of line over 80 characters.
Signed-off-by: Shraddha Barke
---
drivers/staging/gdm72xx/gdm_wimax.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72xx/gdm_wimax.c
index
Replace the usage of BUG_ON with WARN_ON.
Signed-off-by: Shraddha Barke
---
drivers/staging/gdm72xx/gdm_wimax.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72xx/gdm_wimax.c
index 2fa86ad..8861750 100644
--- a
No need for the parentheses around any function pointer.
Detected using checkpatch.
Signed-off-by: Shraddha Barke
---
drivers/staging/gdm72xx/gdm_wimax.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72xx
Add missing spaces around "+", "&" and "|" to follow kernel coding
style. Warning detected by checkpatch.
Signed-off-by: Shraddha Barke
---
drivers/staging/gdm72xx/gdm_qos.c | 12 ++--
drivers/staging/gdm72xx/gdm_sdio.c | 4 ++--
drivers/staging/gd
Add missing spaces around "+", "&" and "|" to follow kernel coding
style. Warning detected by checkpatch.
Signed-off-by: Shraddha Barke
---
drivers/staging/gdm72xx/hci.h | 2 +-
drivers/staging/gdm72xx/netlink_k.c | 6 +++---
drivers/staging/gdm72xx/sd
This patch series fixes last of checkpatch warnings in gdm72xx.
Shraddha Barke (5):
Staging: gdm72xx: Add space around that "+", "&" and "|"
Staging: gdm72xx: Add space around that "+", "&" and "|"
Staging: gdm72xx:
.
Coherent mapping guarantees that the device and CPU are in sync.
Signed-off-by: Shraddha Barke
---
Changes in v2-
Updated commit message, used dmam_alloc_coherent,added cast to dma_handle
drivers/staging/goldfish/goldfish_nand.c | 20 +++-
1 file changed, 11 insertions(+), 9
On Tue, 19 Jan 2016, Alan Cox wrote:
Yes I will free it using dma_free_coherent. Why should devm_kzalloc
be
replaced with dma_alloc_coherent ? I was trying to replace _pa()
Why keep allocating and freeing a buffer rather than having a single
buffer allocated once (as it is in the old driver)
On Tue, 19 Jan 2016, Alan Cox wrote:
Yes I will free it using dma_free_coherent. Why should devm_kzalloc
be
replaced with dma_alloc_coherent ? I was trying to replace _pa()
Why keep allocating and freeing a buffer rather than having a single
buffer allocated once (as it is in the old driver)
On Mon, 18 Jan 2016, Alan Cox wrote:
unnecessarily used when DMA can do the job. Coherent mapping is
allocated
by means of dma_alloc_coherent so that the device and CPU are in
sync.
It's also not freed 8)
As far as I can see you can replace the devm_kzalloc of cmd->params
with a dma_alloc_c
Add support for accessing the device through DMA because CPU is
unnecessarily used when DMA can do the job. Coherent mapping is allocated
by means of dma_alloc_coherent so that the device and CPU are in sync.
Signed-off-by: Shraddha Barke
---
drivers/staging/goldfish/goldfish_nand.c | 15
Fix checkpatch warning of adding space around + in accordance with
kernel coding style.
Signed-off-by: Shraddha Barke
---
Changes in v2-
No change. Added lkml and other maintainers.
drivers/staging/goldfish/goldfish_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
These patches remove the last few checkpatch warnings in staging/goldfish
directory
Shraddha Barke (2):
Staging: goldfish: Add space around +
Staging: goldfish: Remove explicit NULL comparison
drivers/staging/goldfish/goldfish_audio.c | 8
1 file changed, 4 insertions(+), 4
Declare the function fwtty_port_get as static since it is used
only in this particular file. Also remove the corresponding
declaration from header file.
Signed-off-by: Shraddha Barke
---
drivers/staging/fwserial/fwserial.c | 3 +--
drivers/staging/fwserial/fwserial.h | 1 -
2 files changed, 1
Declare the function fwtty_port_put as static since it is used
only in this particular file. Also remove the corresponding
declaration from header file.
Signed-off-by: Shraddha Barke
---
drivers/staging/fwserial/fwserial.c | 3 +--
drivers/staging/fwserial/fwserial.h | 2 --
2 files changed, 1
The functions mdc_pack_req and mdc_getxattr_pack have been
declared in header file but not used. Thus remove the
declarations.
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/mdc/mdc_internal.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre
These functions have been declared in header but not used anywhere.
Thus drop the declarations.
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/lov/lov_internal.h | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_internal.h
b
Declare functions lov_set_add_req, lov_set_finished, lov_update_set,
lov_check_and_wait_active and lov_update_statfs as static since
they are used only in this particular file. Also remove corresponding
declarations from header file.
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre
Declare functions lmv_intent_open and lmv_intent_lookup as static
since they are used only in this particular file. Also remove
corresponding declarations from header file.
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/lmv/lmv_intent.c | 21 +++--
drivers
The function lmv_blocking_ast is declared in header file but not used.
Hence remove the declaration.
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/lmv/lmv_internal.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lmv/lmv_internal.h
b
The functions cl_isize_lock and cl_isize_unlock can be replaced with
direct calls to ll_inode_size_lock and ll_inode_size_unlock. Thus
drop the wrapper functions.
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 4 ++--
drivers/staging/lustre/lustre
These patches remove wrapper functions, unused declarations
and declare local functions as static in lustre.
Shraddha Barke (6):
Staging: lustre: lclient: Remove wrapper functions
Staging: lustre: lmv: Remove unused function declaration
Staging: lustre: lmv: Declare local functions as
The Linux kernel coding style guidelines suggest not using typedefs
for structure types. This patch gets rid of the typedef for
srpc_server_rpc_t.
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lnet/selftest/brw_test.c | 4 ++--
drivers/staging/lustre/lnet/selftest/console.c | 2
Remove declaration of function lprocfs_wr_timeouts from header file
since it is not used
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/include/lprocfs_status.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lprocfs_status.h
b
On Thu, 22 Oct 2015, Arnd Bergmann wrote:
On Thursday 22 October 2015 16:59:01 Shraddha Barke wrote:
On Thu, 22 Oct 2015, Arnd Bergmann wrote:
On Thursday 22 October 2015 15:16:39 Shraddha Barke wrote:
On Thu, 22 Oct 2015, Arnd Bergmann wrote:
On Thursday 22 October 2015 14:50:18
On Thu, 22 Oct 2015, Arnd Bergmann wrote:
On Thursday 22 October 2015 15:16:39 Shraddha Barke wrote:
On Thu, 22 Oct 2015, Arnd Bergmann wrote:
On Thursday 22 October 2015 14:50:18 Shraddha Barke wrote:
These patches remove the definitions of functions which are not used.
Shraddha Barke
On Thu, 22 Oct 2015, Arnd Bergmann wrote:
On Thursday 22 October 2015 14:50:18 Shraddha Barke wrote:
These patches remove the definitions of functions which are not used.
Shraddha Barke (2):
Staging: lustre: ptlrpc: Remove unused functions
Staging: lustre: obdclass: Remove unused
Remove the functions which are not used anywhere throughout the
kernel
Signed-off-by: Shraddha Barke
---
.../staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c| 63 --
1 file changed, 63 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c
b/drivers
Remove the functions since they are not used anywhere throughout the
kernel
Signed-off-by: Shraddha Barke
---
.../lustre/lustre/obdclass/lprocfs_status.c| 139 -
1 file changed, 139 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
b
These patches remove the definitions of functions which are not used.
Shraddha Barke (2):
Staging: lustre: ptlrpc: Remove unused functions
Staging: lustre: obdclass: Remove unused functions
.../lustre/lustre/obdclass/lprocfs_status.c| 139 -
.../staging/lustre
Remove the functions which are defined but not used anywhere
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/include/lustre_log.h | 90 --
1 file changed, 90 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre_log.h
b/drivers/staging
Remove macro OBD_SLAB_FREE_RTN0 since it is defined but not used
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/include/obd_support.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/obd_support.h
b/drivers/staging/lustre/lustre
On Sun, 27 Sep 2015, Jonathan Cameron wrote:
On 26/09/15 18:14, Lars-Peter Clausen wrote:
On 09/25/2015 07:23 PM, Shraddha Barke wrote:
Replace bit shifting on 1 with the BIT(x) macro
Signed-off-by: Shraddha Barke
Acked-by: Lars-Peter Clausen
This is a good little patch, so applied
Make struct static and remove definition from header file since the
struct is accessed only in this particular file
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 2 +-
drivers/staging/lustre/lustre/ptlrpc/service.c | 2 +-
2 files changed, 2
Remove dev_info as the information can be obtained by other means
Signed-off-by: Shraddha Barke
---
drivers/staging/iio/cdc/ad7746.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
index 55cc8bb..ca7d33f 100644
--- a
Replace bit shifting on 1 with the BIT(x) macro
Signed-off-by: Shraddha Barke
---
drivers/staging/iio/cdc/ad7746.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
index 10fa372..55cc8bb 100644
These patches use the BIT macro and remove dev_info
Shraddha Barke (2):
Staging: iio: cdc: Prefer using the BIT macro
Staging: iio: cdc: Remove unnecessary dev_info
drivers/staging/iio/cdc/ad7746.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
--
2.1.4
Stop using DBG_88E which is a custom macro for printing debugging
messages. Instead start using pr_debug and in the process define
pr_fmt.
Signed-off-by: Shraddha Barke
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 31 +++--
1 file changed, 16 insertions(+), 15
On Sun, 20 Sep 2015, Greg Kroah-Hartman wrote:
On Sat, Sep 19, 2015 at 10:19:17PM +0530, Shraddha Barke wrote:
Remove debug messages related to fbtft_par_dbg(DEBUG_INIT_DISPLAY.. )
as this info can be obtained using kernel function tracer
Signed-off-by: Shraddha Barke
Something is messed
Remove debug messages related to fbtft_par_dbg(DEBUG_INIT_DISPLAY.. )
as this info can be obtained using kernel function tracer
Signed-off-by: Shraddha Barke
---
Change in v2-
No change. Resending due to malformed patch error
drivers/staging/fbtft/fb_agm1264k-fl.c | 2 --
drivers/staging
Remove debug messages related to fbtft_par_dbg(DEBUG_INIT_DISPLAY.. )
as this info can be obtained using kernel function tracer
Signed-off-by: Shraddha Barke
---
drivers/staging/fbtft/fb_agm1264k-fl.c | 2 --
drivers/staging/fbtft/fb_bd663474.c| 4
drivers/staging/fbtft/fb_hx8347d.c
Use msecs_to_jiffies instead of driver specific macro
MSECS.
Signed-off-by: Shraddha Barke
---
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
b/drivers/staging/rtl8192u
Use msecs_to_jiffies instead of driver specific macro
MSECS.
Signed-off-by: Shraddha Barke
---
drivers/staging/rtl8192u/r8192U_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index
Use netdev_* family of macros when there is reference to a network
device. dev->name is removed as netdev_info will print the device
name
Signed-off-by: Shraddha Barke
---
drivers/staging/most/aim-network/networking.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --
On Tue, 15 Sep 2015, Shraddha Barke wrote:
Replace pr_info with dev_info when appropriate device structure
is present
Signed-off-by: Shraddha Barke
---
drivers/staging/fbtft/fbtft_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft
Replace pr_info with dev_info when appropriate device structure
is present
Signed-off-by: Shraddha Barke
---
drivers/staging/fbtft/fbtft_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft/fbtft_device.c
On Mon, 14 Sep 2015, Greg Kroah-Hartman wrote:
On Mon, Sep 14, 2015 at 07:14:12PM +0530, Shraddha Barke wrote:
Replace all occurrences of printk(KERN_* by pr_info and pr_warn macros.
Build tested it.
Why put this here in the changelog area? You always have to at least
build test your
Replace all occurrences of printk(KERN_* by pr_info and pr_alert macros.
Build tested it.
Signed-off-by: Shraddha Barke
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211
Replace all occurrences of printk(KERN_* by pr_info and pr_warn macros.
Build tested it.
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/libcfs/tracefile.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/lustre/lustre
This patch introduces the use of the function usb_endpoint_type.
The Coccinelle semantic patch that makes these changes is as follows:
@@ struct usb_endpoint_descriptor *epd; @@
- (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\))
+ usb_endpoint_type(epd)
Signed-off-by: Shraddh
The Coccinelle semantic patch that makes these changes is as follows:
@@ struct usb_endpoint_descriptor *epd; @@
- (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\))
+ usb_endpoint_type(epd)
Signed-off-by: Shraddha Barke
---
Changes in v2:
-Fix subject line
drivers/staging/med
This patch introduces the use of the function usb_endpoint_type.
The Coccinelle semantic patch that makes these changes is as follows:
@@ struct usb_endpoint_descriptor *epd; @@
- (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\))
+ usb_endpoint_type(epd)
Signed-off-by: Shraddh
This patch introduces the use of the function usb_endpoint_type.
The Coccinelle semantic patch that makes these changes is as follows:
@@ struct usb_endpoint_descriptor *epd; @@
- (epd->bmAttributes & \(USB_ENDPOINT_XFERTYPE_MASK\|3\))
+ usb_endpoint_type(epd)
Signed-off-by: Shraddh
(a == NULL || ...) S
...>
- sprintf(a,args);
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/obdclass/obd_mount.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/obd_mount.c
b/drivers/staging/lustre/
;
@@
type tn.td;
identifier tn.i;
@@
-td
+ struct i
Signed-off-by: Shraddha Barke
---
drivers/staging/wilc1000/wilc_wlan.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wlan.c
b/drivers/staging/wilc1000/wilc_wlan.c
index def72fd
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
Signed-off-by: Shraddha Barke
---
Changes in v4:
-Added Signed-off-by line
drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
1 file changed, 1
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
Signed-off-by: Shraddha Barke
---
Changes in v4:
-Added Signed-off-by line
drivers/staging/netlogic/platform_net.c | 2 +-
1 file changed, 1 insertion
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
Signed-off-by: Shraddha Barke
---
Changes in v4:
-Added Signed-off-by line
drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 2 +-
1 file changed, 1
This patch does away with the cast on void * as it is unnecessary.
Semantic patch used is as follows:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/
This patch does away with the cast on void * as it is unnecessary.
Semantic patch used is as follows:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/
This patch does away with the cast on void * as it is unnecessary.
Semantic patch used is as follows:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/lib
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
---
Changes in v3:
-No changes made.
drivers/staging/netlogic/platform_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/sta
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
---
Changes in v3:
-No changes made.
drivers/staging/netlogic/platform_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/sta
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
---
Changes in v3:
-Make subject clearer.
drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
---
Changes in v3:
-Make subject clearer.
drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
---
Changes in v2:
-No changes made.
drivers/staging/netlogic/platform_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/sta
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
---
Changes in v2:
-Make subject more clearer.
drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
---
Changes in v2:
-No changes made.
drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
---
drivers/staging/netlogic/platform_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/netlogic/platform_net.c
b/driv
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
---
drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/libc
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/mgc/mgc_r
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Correct indentation issues according to checkpatch.pl :
WARNING: suspect code indent for conditional statements
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/llite/rw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
Signed-off-by: Shraddha Barke
---
drivers/staging/netlogic/platform_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Replace comma between expression statements by a semicolon.
The semantic patch used is as follows:
@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Correct indentation issues according to checkpatch.pl :
WARNING: suspect code indent for conditional statements
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/llite/rw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite
This patch does away with the cast on void * as it is unnecessary.
Semantic patch used is as follows:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/obdcl
:
@tn@
identifier i;
type td;
@@
-typedef
struct i { ... }
-td
;
@@
type tn.td;
identifier tn.i;
@@
-td
+ struct i
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/libcfs/workitem.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging
>From b67c6c20455b04b77447ab4561e44f1a75dd978d Mon Sep 17 00:00:00 2001
From: Shraddha Barke
Date: Mon, 3 Aug 2015 11:34:19 +0530
Subject: [PATCH] Staging : lustre : Use -EINVAL instead of -ENOSYS
ENOSYS means that a nonexistent system call was called. This should
not be used for inva
Declare the file_operations structure ll_file_operations as const, as done
elsewhere in the kernel, as there are no modifications to its fields.
Problem found using checkpatch:
WARNING: struct file_operations should normally be const
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre
Declare the file_operations structure ll_file_operations as const, as done
elsewhere in the kernel, as there are no modifications to its fields.
Problem found using checkpatch.
Signed-off-by: Shraddha Barke
---
Changes in v2:
- Make the commit message more clearer.
drivers/staging/lustre
This patch fixes the following checkpatch.pl warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Shraddha Barke
---
drivers/staging/lustre/lustre/llite/llite_internal.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/lustre/lustre/llite/llite_internal.h
1 - 100 of 119 matches
Mail list logo
