[PATCH] staging: cxt1e1: change declaration of TWV_table

Changes the declaration of TWV_table to 'static void' to eliminate a sparse "should it be static" warning. Signed-off-by: Shaun Laing --- drivers/staging/cxt1e1/comet.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/cxt1e1/comet.c b/dr

[PATCH] staging: cxt1e1: removed version string declaration

Removed the unneeded pmcc4_OSSI_release version string, as well as the now unused 'release' element of the sbe_card_info struct. This also resolves a sparse "should it be static" warning. Signed-off-by: Shaun Laing --- V2: changed to remove the version string entirely. C

[PATCH] staging: cxt1e1: moved version string declaration

To resolve a sparse "should it be static" warning, the declaration for the pmcc4_OSSI_release version string was moved from its own file to linux.c, and the resulting empty file was deleted. Signed-off-by: Shaun Laing --- drivers/staging/cxt1e1/Makefile |1 - drivers/stag

[PATCH] staging: cxt1e1: Add extern keyword for sparse 'static' warning

Resolve sparse "warning: symbol '...' was not declared. Should it be static?" messages. Includes "comet_tables.h", which contains extern declarations for the variables defined in comet_tables.c. Signed-off-by: Shaun Laing --- drivers/staging/cxt1e1/comet_tables

[PATCH] staging: crystalhd: Resolve sparse 'different base types' warnings.

The result from crystalhd_get_sgle_paddr and crystalhd_get_sgle_len are later used in calculations, so the result should be in CPU byte ordering. Signed-off-by: Shaun Laing --- Assumes sg_dma_address and sg_dma_len return values in CPU byte ordering. drivers/staging/crystalhd/crystalhd_misc.h

[patch] staging: cxt1e1: Remove #define SBE_INCLUDE_SYMBOLS

rototype (musycc_init_port) as adding the 'static' declaration produced a new gcc warning. (musycc_init_port is only declared if SBE_WAN256T3_ENABLE is set) Signed-off-by: Shaun Laing --- diff --git a/drivers/staging/cxt1e1/Makefile b/drivers/staging/cxt1e1/Makefile index b9ccb76..2f2

Re: staging: comedi: dt9812: Resolves sparse endian warnings.

Thank you. On Tue, Jul 30, 2013 at 11:13 AM, H Hartley Sweeten wrote: > On Tuesday, July 30, 2013 10:06 AM, Shaun Laing wrote: >> Ok, >> >> 1) I'm unclear as to the process at this point: should I re-send this patch >> with the suggested change? > > Yes. P

[PATCH v2] staging: comedi: dt9812: Resolve different base types warnings.

Resolves warnings from the "sparse" checker of the form "warning: incorrect type in assignment (different base types)". Signed-off-by: Shaun Laing Reviewed-by: Ian Abbott Reviewed-by: H Hartley Sweeten --- diff --git a/drivers/staging/comedi/drivers/dt9812.c b/drivers/st

staging: comedi: dt9812: Resolves sparse endian warnings.

Resolves warnings from the "sparse" checker of the form "warning: incorrect type in assignment (different base types)". Signed-off-by: Shaun Laing --- diff --git a/drivers/staging/comedi/drivers/dt9812.c b/drivers/staging/comedi/drivers/dt9812.c index 6c60949..0bb2bd4

Re: [patch] staging: comedi: dt9812: Resolves sparse endian warnings.

Ok, I'll send in this additional patch. On Mon, Jul 29, 2013 at 9:03 AM, Ian Abbott wrote: > On 2013-07-26 19:19, H Hartley Sweeten wrote: >> >> On Friday, July 26, 2013 10:59 AM, Shaun Laing wrote: >> >> Please make sure to copy the mailing list... ;-) >&

[patch] staging: comedi: dt9812: Resolves sparse endian warnings.

Resolves warnings from the "sparse" checker of the form "warning: cast to restricted __le??". Signed-off-by: Shaun Laing --- diff --git a/drivers/staging/comedi/drivers/dt9812.c b/drivers/staging/comedi/drivers/dt9812.c index 6c60949..fdd008c 100644 --- a/drivers/staging/c