27; was not declared. Should it be static?
Signed-off-by: Serguey Parkhomovsky
---
v3: Wrap commit message at 72 cols, and remove filename from subject line.
v2: Don't break the build, and fix the warnings by defining the functions in
libcfs.h.
drivers/staging/lustre/include/linux/libcfs/
On Wed, Dec 31, 2014 at 11:40:29AM +0100, Konrad Zapalowicz wrote:
> This lines are way too long. You should break the commit message line
> around 72nd column so that it looks nice when emailed.
>
> You can also omit the filename from the topic line as this is already in
> the diff.
Thanks for t
27; was not declared. Should it be static?
Signed-off-by: Serguey Parkhomovsky
---
v2: Don't break the build, and fix the warnings by defining the functions in
libcfs.h.
drivers/staging/lustre/include/linux/libcfs/libcfs.h | 3 +++
drivers/staging/lustre/lustre/libcfs/module.c|
On Tue, Dec 30, 2014 at 02:35:18PM -0800, Jeremiah Mahler wrote:
>
> If you look at the source code just below these functions you will find:
>
> EXPORT_SYMBOL(libcfs_arch_init);
> EXPORT_SYMBOL(libcfs_arch_cleanup);
>
> So making these static is incorrect because they are being used outside
> o
27; was not declared. Should it be static?
Signed-off-by: Serguey Parkhomovsky
---
drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c
b/drivers/staging/lustre/lustr
Fixes the following sparse warning for rtw_mlme.c:
drivers/staging/rtl8188eu/core/rtw_mlme.c:810:9: warning: context imbalance in
'rtw_free_assoc_resources' - different lock contexts for basic block
Signed-off-by: Serguey Parkhomovsky
---
drivers/staging/rtl8188eu/core/rtw_m
>
> This sort of test is generally better where the
> individual tests are written on separate lines like:
>
> if ((data[idx] != pktdata[i]) ||
> (data[idx+1] != pktdata[i+1])) {
>
Thanks for all the suggestions, Joe. I'll upload a revised patch s
This patch fixes two unnecessary else conditions that were found by
checkpatch.pl.
Signed-off-by: Serguey Parkhomovsky
---
v2: use negation instead of comparing to false in if statement (suggested by
Joe Perches)
drivers/staging/rtl8712/rtl8712_efuse.c | 40
This patch fixes two unnecessary else conditions that were found by
checkpatch.pl.
Signed-off-by: Serguey Parkhomovsky
---
drivers/staging/rtl8712/rtl8712_efuse.c | 41 +
1 file changed, 21 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rtl8712
