Re: [PATCH v1 3/9] staging: android: binder: Add cmd == CMD_NAME handling

2013-12-05 Thread Serban Constantinescu
On 05/12/13 08:40, Dan Carpenter wrote: On Wed, Dec 04, 2013 at 06:09:35PM +, Serban Constantinescu wrote: This patch modifies the functions that need to be passed the explicit command to use a boolean flag. This way we can reuse the code for 64bit compat commands. I don't under

Re: [PATCH v1 2/9] staging: android: binder: Add binder_copy_to_user()

2013-12-05 Thread Serban Constantinescu
On 04/12/13 23:17, Greg KH wrote: On Wed, Dec 04, 2013 at 06:09:34PM +, Serban Constantinescu wrote: This patch adds binder_copy_to_user() to be used for copying binder commands to user address space. This way we can abstract away the copy_to_user() calls and add separate handling for the

Re: [PATCH v1 1/9] staging: android: binder: Move some of the logic into subfunction

2013-12-05 Thread Serban Constantinescu
On 05/12/13 08:18, Dan Carpenter wrote: On Wed, Dec 04, 2013 at 06:09:33PM +, Serban Constantinescu wrote: +static void bc_increfs_done(struct binder_proc *proc, + struct binder_thread *thread, uint32_t cmd, + void __user *node_ptr, void __user *cookie

Re: [PATCH v1 1/9] staging: android: binder: Move some of the logic into subfunction

2013-12-05 Thread Serban Constantinescu
On 05/12/13 08:00, Dan Carpenter wrote: On Wed, Dec 04, 2013 at 06:09:33PM +, Serban Constantinescu wrote: +static void bc_dead_binder_done(struct binder_proc *proc, + struct binder_thread *thread, void __user *cookie) +{ + struct binder_work *w; + struct

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-05 Thread Serban Constantinescu
_t != void *). Author: Serban Constantinescu Date: Thu Jul 4 10:54:48 2013 +0100 staging: android: binder: fix binder interface for 64bit compat layer *64bit kernel/ 64bit coexisting with 32bit userspace Please note that *none of the above solutions fix this yet*. To understand why this is a sp

[PATCH v1 1/9] staging: android: binder: Move some of the logic into subfunction

2013-12-04 Thread Serban Constantinescu
This patch moves some of the logic for binder_thread_write() into subfunctions. This way we can share more code with the binder compat layer. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 403 +- 1 file changed, 220 insertions

[PATCH v1 8/9] staging: android: binder: Add binder compat handling to binder.h

2013-12-04 Thread Serban Constantinescu
This patch adds all the needed compat structures to binder.h. All the structures defined in this patch mirror the structure and size of 32bit ones. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.h | 109 ++ 1 file changed, 109

[PATCH v1 0/9] Android: Add Support for Binder Compat

2013-12-04 Thread Serban Constantinescu
helper macros are extended with compat handling by the last patch of the series. The patches have been successfully tested on 32 and 64bit platforms. Thanks for your help, Best regards, Serban Constantinescu Serban Constantinescu (9): staging: android: binder: Move some of the logic into

[PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Serban Constantinescu
This patch adds support for 32bit userspace running on 64bit kernels. All the changes done in this patch have been tested on 32bit and 64bit systems. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 355 +- 1 file changed, 353

[PATCH v1 3/9] staging: android: binder: Add cmd == CMD_NAME handling

2013-12-04 Thread Serban Constantinescu
This patch modifies the functions that need to be passed the explicit command to use a boolean flag. This way we can reuse the code for 64bit compat commands. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 35 ++- 1 file changed, 18

[PATCH v1 5/9] staging: android: binder: Add deref_helper() macro

2013-12-04 Thread Serban Constantinescu
-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index 6719a53..95c2581 100644 --- a/drivers/staging/android

[PATCH v1 2/9] staging: android: binder: Add binder_copy_to_user()

2013-12-04 Thread Serban Constantinescu
This patch adds binder_copy_to_user() to be used for copying binder commands to user address space. This way we can abstract away the copy_to_user() calls and add separate handling for the compat layer. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 39

[PATCH v1 7/9] staging: android: binder: Add copy_flat_binder_object()

2013-12-04 Thread Serban Constantinescu
This patch adds copy_flat_binder_object macro() that will help dereference struct flat_binder_object on 64bit systems where the structure differs between 32bit and 64bit userspace. This patch is a temporary patch that will be extended with 32bit compat handling. Signed-off-by: Serban

[PATCH v1 4/9] staging: android: binder: Add align_helper() macro

2013-12-04 Thread Serban Constantinescu
This patch adds align_helper() macro that will be used for enforcing the desired alignment on 64bit systems where the alignment will differ depending on the userspace used (32bit /64bit). This patch is a temporary patch that will be extended with 32bit compat handling. Signed-off-by: Serban

[PATCH v1 6/9] staging: android: binder: Add size_helper() macro

2013-12-04 Thread Serban Constantinescu
-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index 95c2581..6d22717 100644 --- a/drivers/staging/android/binder.c +++ b