[PATCH] staging:rtl8192e: Usage count off by one

2015-11-15 Thread Sean MacLennan
The rtllib driver is not calling try_module_get() when loading the encryption modules. Because of this, you can never remove the module once you have used it one (i.e. bring up the wireless interface). Signed-off-by: Sean MacLennan --- drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- drivers

[PATCH] r8192e_pci driver broken 3.14+

2014-05-28 Thread Sean MacLennan
A sparse error fixup removed a htons() which is required for the driver to function. This patch puts the htons() back and fixes the sparse warning correctly by changing the left side cast. Signed-off-by: Sean MacLennan --- diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging

Re: r8192e_pci driver broken 3.14+

2014-05-21 Thread Sean MacLennan
On Sat, 19 Apr 2014 16:57:45 -0400 Sean MacLennan wrote: > A sparse error fixup removed a htons() which is required for the > driver to function. This patch puts the htons() back and fixes the > sparse warning correctly by changing the left side cast. > > Signed-off-by:

[PATCH] r8192e_pci driver broken 3.14+

2014-04-19 Thread Sean MacLennan
A sparse error fixup removed a htons() which is required for the driver to function. This patch puts the htons() back and fixes the sparse warning correctly by changing the left side cast. Signed-off-by: Sean MacLennan --- diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging

Re: r8192e_pci driver broken 3.14+

2014-04-19 Thread Sean MacLennan
On Sat, 19 Apr 2014 11:17:23 -0700 Greg KH wrote: > On Sat, Apr 19, 2014 at 02:12:34PM -0400, Sean MacLennan wrote: > > Fix a sparse error in the htons() call. htons() returns a __be16 > > not a u16. > > > > Signed-off-by: Sean MacLennan > > --- > > Y

Re: r8192e_pci driver broken 3.14+

2014-04-19 Thread Sean MacLennan
Fix a sparse error in the htons() call. htons() returns a __be16 not a u16. Signed-off-by: Sean MacLennan --- diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c index 3e79bff..b7dd153 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging

Re: r8192e_pci driver broken 3.14+

2014-04-19 Thread Sean MacLennan
A sparse error fixup removed a htons() which is required for the driver to function. Put the htons() back. Signed-off-by: Sean MacLennan --- diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c index 11d0a9d..3e79bff 100644 --- a/drivers/staging/rtl8192e

r8192e_pci driver broken 3.14+

2014-04-18 Thread Sean MacLennan
Commit 198e0d17c on November 2 by Rashika Kheria breaks the r8192e_pci driver on my laptop. The bulk of the commit is fine. It is just the following change that causes grief: diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c index 3183627..7796488 100644 ---