Re: [PATCH 5/5] staging: fsl-mc: Management Complex restool driver

2015-10-26 Thread Scott Wood
On Sun, 2015-10-25 at 17:41 -0500, Lijun Pan wrote: > The kernel support for the restool (a user space resource management > tool) is a driver for the /dev/dprc.N device file. > Its purpose is to provide an ioctl interface, > which the restool uses to interact with the MC bus driver > and with the

Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support

2015-05-05 Thread Scott Wood
On Tue, 2015-05-05 at 15:22 -0500, Rivera Jose-B46482 wrote: > > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Tuesday, May 05, 2015 2:57 PM > > To: Dan Carpenter > > Cc: Rivera Jose-B46482; de...@driverdev.osuosl.org; Yoder Stuart-B08248; > > Hamciuc Bogdan-BHAMCIU1; a...@

Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support

2015-05-05 Thread Scott Wood
On Tue, 2015-05-05 at 19:40 +0300, Dan Carpenter wrote: > On Tue, May 05, 2015 at 04:08:49PM +, Jose Rivera wrote: > > > Subject: Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support > > > > > > On Mon, May 04, 2015 at 10:09:08PM +, Jose Rivera wrote: > > > > > > + WARN_ON((int16_

Re: [PATCH 1/7] staging: fsl-mc: MC bus IRQ support

2015-05-05 Thread Scott Wood
On Tue, 2015-05-05 at 11:08 -0500, Rivera Jose-B46482 wrote: > > > > to read what "goto error;" does. The error handling here calls > > > > devm_kfree() which is not needed... devm_ functions automatically > > > > clean up after themselves. This seems a pattern throughout. Do a > > > > search f