Re: [PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement

On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote: > On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote: > > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct > > mbox_params *mbcp) > > mbcp->out_count = 6; > >

Re: [PATCH v2 20/23] staging: qlge: Fix CHECK: usleep_range is preferred over udelay

On Thu, Dec 12, 2019 at 01:45:57PM +0300, Sergei Shtylyov wrote: > Hello! > > On 11.12.2019 21:12, Scott Schafer wrote: > > > chage udelay() to usleep_range() > >Change? > > > Signed-off-by: Scott Schafer > > --- > > drivers/staging/ql

[PATCH v2 19/23] staging: qlge: Fix WARNING: msleep < 20ms can sleep for up to 20ms

Fix WARNING: msleep < 20ms can sleep for up to 20ms by changing msleep to usleep_range() in qlge_dbg.c, qlge_ethtool.c, and qlge_main.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_dbg.c | 2 +- drivers/staging/qlge/qlge_ethtool.c | 2 +- drivers/staging/qlge/qlge_mai

[PATCH v2 23/23] staging: qlge: Fix WARNING: Avoid multiple line dereference

Fix WARNING: Avoid multiple line dereference in qlge_main.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_main.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index 102da1fe9899

[PATCH v2 18/23] staging: qlge: Fix CHECK: Prefer using the BIT macro

Fix CHECK: Prefer using the BIT macro changed (1<<4) to BIT(4) in 2 places in qlge.h Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h index 010d39

[PATCH v2 15/23] staging: qlge: Fix WARNING: please, no spaces at the start of a line

Fix WARNING: please, no spaces at the start of a line in qlge_main.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index

[PATCH v2 16/23] staging: qlge: Fix WARNING: Block comments use a trailing */ on a separate line

Fix WARNING: Block comments use a trailing */ on a separate line in qlge_main.c and qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_main.c | 3 ++- drivers/staging/qlge/qlge_mpi.c | 10 ++ 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement

Fix CHECK: braces {} should be used on all arms of this statement in qlge_ethtool.c and qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_ethtool.c | 18 -- drivers/staging/qlge/qlge_mpi.c | 9 ++--- 2 files changed, 18 insertions(+), 9 deletions

[PATCH v2 17/23] staging: qlge: Fix WARNING: else is not generally useful after a break or return

Fix WARNING: else is not generally useful after a break or return in, qlge_dbg.c, qlge_main.c, and qlge_mpi.c Moved everything out of the else block wothout changing any logic Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_dbg.c | 23 ++- drivers/staging/qlge

[PATCH v2 20/23] staging: qlge: Fix CHECK: usleep_range is preferred over udelay

chage udelay() to usleep_range() Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index e18aa335c899..9427386e4a1e 100644 --- a/drivers

[PATCH v2 21/23] staging: qlge: Fix WARNING: suspect code indent for conditional statements

Fix indentation for conditionals in qlge_ethtool.c and qlge_main.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_ethtool.c | 4 ++-- drivers/staging/qlge/qlge_main.c| 18 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/qlge

[PATCH v2 22/23] staging: qlge: Fix CHECK: Unbalanced braces around else statement

Fix CHECK: Unbalanced braces around else statement in file qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_mpi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c index ba8ce3506a59

[PATCH v2 04/23] staging: qlge: Fix WARNING: Missing a blank line after declarations

Fix WARNING: Missing a blank line after declarations in the following files: qlge.h qlge_dbg.c qlge_main.c qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 2 +- drivers/staging/qlge/qlge_dbg.c | 10 +- drivers/staging/qlge/qlge_main.c | 26

[PATCH v2 09/23] staging: qlge: Fix CHECK: No space is necessary after a cast

Fix CHECK: No space is necessary after a cast in qlge_dbg.c and qlge_main.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_dbg.c | 28 +++ drivers/staging/qlge/qlge_main.c | 38 2 files changed, 33 insertions(+), 33 deletions

[PATCH v2 12/23] staging: qlge: Fix WARNING: please, no space before tabs in qlge.h

Fix WARNING: please, no space before tabs in qlge.h Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h index ede767a70b10

[PATCH v2 14/23] staging: qlge: Fix WARNING: Unnecessary space before function pointer arguments

WARNING: Unnecessary space before function pointer arguments in qlge.h Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h index 9ab4c7ce7714..010d39b4b30d

[PATCH v2 13/23] staging: qlge: Fix CHECK: spaces preferred around that (ctx:VxV)

Fix CHECK: spaces preferred around that (ctx:VxV) in qlge.h and qlge_main.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 6 +++--- drivers/staging/qlge/qlge_main.c | 18 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging

[PATCH v2 06/23] staging: qlge: Fix CHECK: Blank lines aren't necessary after an open brace '{'

Fix CHECK: Blank lines aren't necessary after an open brace '{' in the following files: qlge.h qlge_dbg.c qlge_main.c qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 3 --- drivers/staging/qlge/qlge_dbg.c | 1 - drivers/staging/qlge/

[PATCH v2 10/23] staging: qlge: Fix CHECK: blank line after function/struct/union/enum declarations

Fix CHECK: Please use a blank line after function/struct/union/enum declarations in qlge_ethtool.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/qlge/qlge_ethtool.c b/drivers/staging/qlge/qlge_ethtool.c

[PATCH v2 08/23] staging: qlge: Fix CHECK: Unnecessary parentheses around mpi_coredump->mpi_global_header

Fix CHECK: Unnecessary parentheses around mpi_coredump->mpi_global_header in file qlge_dbg.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_dbg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_db

[PATCH v2 00/23] V2: Break up from one patch to multiple

I broke up the changes from one patch to many so each patch has more defined changes. I also added a few other patches for formatting issues I missed in the original patch. Scott Schafer (23): staging: qlge: Fix CHECK extra blank lines in many files staging: qlge: Fix CHECK: Alignment should

[PATCH v2 07/23] staging: qlge: Fix WARNING: quoted string split across lines

Fix WARNING: quoted string split across lines in the following files: qlge_dbg.c qlge_main.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_dbg.c | 19 +-- drivers/staging/qlge/qlge_main.c | 13 ++--- 2 files changed, 15 insertions(+), 17 deletions(-) diff

[PATCH v2 05/23] staging: qlge: Fix CHECK: Blank lines aren't necessary before a close brace '}'

Fix CHECK: Blank lines aren't necessary before a close brace '}' in the following files: qlge_dbg.c qlge_main.c qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_dbg.c | 3 --- drivers/staging/qlge/qlge_main.c | 3 --- drivers/staging/qlge/qlge_mpi.c

[PATCH v2 01/23] staging: qlge: Fix CHECK extra blank lines in many files

Fix CHECK: Please don't use multiple blank lines in qlge.h, qlge_dbg.c, qlge_ethtool.c, qlge_main.c, and qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 1 - drivers/staging/qlge/qlge_dbg.c | 4 drivers/staging/qlge/qlge_ethtool.c | 1 - dr

[PATCH v2 03/23] staging:qlge: Fix WARNING: Missing a blank line after declarations

Fix WARNING: Missing a blank line after declarations for the follig files: qlge.h qlge_dbg.c qlge_main.c qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 1 + drivers/staging/qlge/qlge_dbg.c | 5 + drivers/staging/qlge/qlge_main.c | 13 + drivers

[PATCH v2 02/23] staging: qlge: Fix CHECK: Alignment should match open parenthesis

02 I made these changes due to touching these lines in the original fix Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_dbg.c | 8 +- drivers/staging/qlge/qlge_ethtool.c | 34 +++-- drivers/staging/qlge/qlge_main.c| 184 +--- drivers/staging/qlge/

Re: [PATCH] staging: qlge: Fix multiple WARNING and CHECK relating to formatting

On Wed, Dec 11, 2019 at 08:31:36AM +0100, Greg Kroah-Hartman wrote: > On Tue, Dec 10, 2019 at 07:47:59PM -0600, Scott Schafer wrote: > > CHECK: Please don't use multiple blank lines > > CHECK: Blank lines aren't necessary before a close brace '}' > > CHE

[PATCH] staging: qlge: Fix multiple WARNING and CHECK relating to formatting

separate line ERROR: trailing whitespace In files qlge.h, qlge_dbg.c, qlge_ethtool.c, qlge_main.c, and qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 45 ++--- drivers/staging/qlge/qlge_dbg.c | 41 ++- driver

[PATCH] staging: qlge: Fix CamelCase in qlge.h and qlge_dbg.c

This patch addresses CamelCase warnings in qlge.h under struct mpi_coredump_global_header and mpi_coredump_segment_header. As well ass addresses CamelCase warnings in qlge_dbg.c when the structs are used. Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge.h | 14