Re: [PATCH] staging: clocking-wizard: Fix incorrect type of speed grade

igned-off-by: Xavier Roumegue Acked-by: Sören Brinkmann Sören ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: clocking-wizard: add blank line after struct declaration.

On Tue, 2015-12-01 at 01:56PM +0100, Christian Colic wrote: > Add blank line after struct declaration to fix checkpatch check. > > Signed-off-by: Christian Colic Reviewed-by: Sören Brinkmann Thanks, Sören ___ devel mailin

[PATCH 1/2] staging: lustre: libcfs/nidstrings: Declare internal symbols static

Some functions had static forward declarations followed by non-static implementations. Those forward declarations are removed and the implementations are declared static and moved into a location that doesn't require forward declarations. Signed-off-by: Sören Brinkmann --- drivers/sta

[PATCH 2/2] staging: lustre: libcfs/nidstrings: Avoid forward declarations

Avoid forward declaratoins by moving functions to a location before they are referenced. Signed-off-by: Sören Brinkmann --- drivers/staging/lustre/lustre/libcfs/nidstrings.c | 77 +++ 1 file changed, 37 insertions(+), 40 deletions(-) diff --git a/drivers/staging/lustre

Re: [PATCH] Staging: clocking-wizard: Added a blank line after declaration

Hi Mohammad, On Sun, 2014-12-21 at 08:03AM +0530, Mohammad Jamal wrote: > Fix the coding style issue by adding blank line after declaration > > Signed-off-by: Mohammad Jamal > --- > .../clocking-wizard/clk-xlnx-clock-wizard.c|1 + > 1 file changed, 1 insertion(+) > > diff --git a/d

Re: [PATCH] Clocking-wizard: Fixed missing blank line warning

On Sun, 2014-12-07 at 02:35PM +0530, Athira Lekshmi wrote: > Added a new line after declaration to remove the warning > 'Missing a blank line after declarations' > > Signed-off-by: Athira Lekshmi Acked-by: Soren Brinkmann Soren ___ devel maili

[PATCH] staging: vt6655: Declare vnt_init() static

Fix sparse warning: drivers/staging/vt6655/device_main.c:1672:5: warning: symbol 'vnt_init' was not declared. Should it be static? Signed-off-by: Sören Brinkmann --- drivers/staging/vt6655/device_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

Re: [PATCH v3] Drivers:staging:clocking-wizard: Added a newline

On Sun, 2014-11-30 at 02:16PM +0530, Athira Sharikkal wrote: > Fixed checkpatch warning: > Missing a newline after declarations There are two such warnings. If we gonna fix them, please fix them all. > > Signed-off-by: Athira Sharikkal Acked-by: Soren Brinkmann Thanks, Sören _

Re: [PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration

On Sat, 2014-11-29 at 06:25PM +0530, Anjana Sasindran wrote: > This patch fix the checkpatch.pl warning > > WARNING:Missing a blank line after declaration There are two such warnings. If we gonna fix them, please fix them all. > > Signed-off-by: Anjana Sasindran Acked-by: Soren Brinkmann

Re: [PATCH] staging: clocking-wizard: check for a valid clk_name pointer

On Sat, 2014-11-29 at 05:48PM -0500, Devendra Naga wrote: > The clk_name gets the return value from kasprintf (part of which does the > allocation of the returned buffer). So check the return pointer > before using it for clk_register_fixed_factor. > > Cc: Soren Brinkmann > Signed-off-by: Devendr

Re: [PATCH v2] staging: Add Xilinx Clocking Wizard driver

On Thu, 2014-10-02 at 02:19AM +0300, Laurent Pinchart wrote: > Hi Sören, > > Thank you for the patch. > > On Wednesday 01 October 2014 14:02:32 Soren Brinkmann wrote: > > Add a driver for the Xilinx Clocking Wizard soft IP. The clocking wizard > > provides an AXI interface to dynamically reconfig

Re: [PATCH] staging: Add Xilinx Clocking Wizard driver

On Wed, 2014-10-01 at 09:58PM +0300, Dan Carpenter wrote: > On Wed, Oct 01, 2014 at 10:21:48AM -0700, Soren Brinkmann wrote: > > +enum clk_wzrd_inp_clks { > > + wzrd_clk_in1, > > + wzrd_s_axi_aclk, > > + wzrd_clk_inp_max > > +}; > > + > > +enum clk_wzrd_int_clks { > > + wzrd_clk_mul, > > +

Re: [PATCH] staging: Add Xilinx Clocking Wizard driver

On Wed, 2014-10-01 at 10:57AM -0700, Greg Kroah-Hartman wrote: > On Wed, Oct 01, 2014 at 10:46:16AM -0700, Sören Brinkmann wrote: > > On Wed, 2014-10-01 at 10:39AM -0700, Greg Kroah-Hartman wrote: > > > On Wed, Oct 01, 2014 at 10:21:48AM -0700, Soren Brinkmann wrote: > >

Re: [PATCH] staging: Add Xilinx Clocking Wizard driver

On Wed, 2014-10-01 at 10:39AM -0700, Greg Kroah-Hartman wrote: > On Wed, Oct 01, 2014 at 10:21:48AM -0700, Soren Brinkmann wrote: > > Add a driver for the Xilinx Clocking Wizard soft IP. The clocking wizard > > provides an AXI interface to dynamically reconfigure the clocking > > resources of Xilin

Re: [PATCH] checkpatch: Remove unnecessary + after {8,8}

Hi Joe, On Fri, 2014-07-11 at 07:09PM -0700, Joe Perches wrote: > There's a useless "+" use that needs to be removed as perl 5.20 > emits a "Useless use of greediness modifier '+'" message each > time it's hit. I saw this Perl warning today as well and wondered whether this patch is coming or not

[PATCH] staging: ad7606_core: Fix checkpatch warning

Fix the checkpatch complaint regarding unnecessary line continuation. WARNING: Avoid unnecessary line continuations #143: FILE: ad7606_core.c:143: Signed-off-by: Sören Brinkmann --- drivers/staging/iio/adc/ad7606_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a