Re: [PATCH 14/78] staging: media: imx7-mipi-csis: use pm_runtime_resume_and_get()

rement on errors. > > Use the new API, in order to cleanup the error check logic. > > Signed-off-by: Mauro Carvalho Chehab Thanks, looks good. Acked-by: Rui Miguel Silva -- Cheers, Rui > --- > drivers/staging/media/imx/imx7-mipi-csis.c | 7 +++ > 1 file cha

Re: [PATCH 06/10] staging: greybus: spilib: use 'spi_delay_to_ns' for getting xfer delay

>speed_hz); > > gb_xfer->len = cpu_to_le32(xfer_len); > > - gb_xfer->delay_usecs = cpu_to_le16(xfer->delay_usecs); > > + xfer_delay = spi_delay_to_ns(&xfer->delay, xfer) / 1000; > > + xfer_delay = clamp_t(u16, xfer_delay,

Re: [PATCH v2 -next] staging: greybus: light: Use kzalloc for allocating only one thing

> - kcalloc(1, > + kzalloc( > ...) > // > > Signed-off-by: Zheng Yongjun Like Alex said, LGTM also. Reviewed-by: Rui Miguel Silva -- Cheers, Rui > --- > drivers/staging/greybus/light.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > di

Re: [PATCH] staging: media: imx: no need to check return value of debugfs_create functions

. > > Cc: Rui Miguel Silva > Cc: Steve Longerbeam > Cc: Philipp Zabel > Cc: Mauro Carvalho Chehab > Cc: Greg Kroah-Hartman > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: linux-me...@vge

Re: [PATCH -next] staging: greybus: fix a missing-check bug in gb_lights_light_config()

Hi, On Thu, Apr 02, 2020 at 05:22:37PM +0300, Dan Carpenter wrote: > On Thu, Apr 02, 2020 at 02:16:18PM +0100, Rui Miguel Silva wrote: > > > > --- a/drivers/staging/greybus/light.c > > > > +++ b/drivers/staging/greybus/light.c > > > > @@ -1026,7 +1026,8 @@ s

Re: [PATCH -next] staging: greybus: fix a missing-check bug in gb_lights_light_config()

Hi Dan, On Thu, Apr 02, 2020 at 03:22:28PM +0300, Dan Carpenter wrote: > On Wed, Apr 01, 2020 at 11:00:17AM +0800, Chen Zhou wrote: > > In gb_lights_light_config(), 'light->name' is allocated by kstrndup(). > > It returns NULL when fails, add check for it. > > > > Signed-off-by: Chen Zhou > > --

Re: [PATCH -next] staging: greybus: fix a missing-check bug in gb_lights_light_config()

Hi Chen Zhou, Thanks for the patch. On Wed, Apr 01, 2020 at 11:00:17AM +0800, Chen Zhou wrote: > In gb_lights_light_config(), 'light->name' is allocated by kstrndup(). > It returns NULL when fails, add check for it. > > Signed-off-by: Chen Zhou Acked-by: Rui Mig

Re: [PATCH] media: imx7-mipi-csis: remove subdev_notifier

Hi Hans, On Fri, Dec 13, 2019 at 08:59:22AM +0100, Hans Verkuil wrote: > On 12/12/19 8:17 PM, Rui Miguel Silva wrote: > > It was defined a notifier in the csi_state structure that is never > > allocated. And besides that it's unregister in the remove, even > > though

[PATCH] media: imx7-mipi-csis: remove subdev_notifier

l Suggested-by: Dan Carpenter Suggested-by: Philipp Zabel Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/imx7-mipi-csis.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c ind

Re: [PATCH] media: imx7-mipi-csis: Add the missed v4l2_async_notifier_cleanup in remove

Hi Dan, Thanks for the inputs. On Thu, Dec 12, 2019 at 02:51:34PM +0300, Dan Carpenter wrote: > On Mon, Dec 09, 2019 at 04:58:28PM +0800, Chuhong Yuan wrote: > > All drivers in imx call v4l2_async_notifier_cleanup() after > > unregistering the notifier except this driver. This should be a > > miss

Re: [PATCH] media: imx7-mipi-csis: Add the missed v4l2_async_notifier_cleanup in remove

off-by: Chuhong Yuan Reviewed-by: Rui Miguel Silva -- Cheers, Rui > --- > drivers/staging/media/imx/imx7-mipi-csis.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c > b/drivers/staging/media/imx/imx7-mipi-csis.c &

Re: [PATCH v8 5/5] media: imx: Try colorimetry at both sink and source pads

e case for imx7 > it > should also support converting ALTERNATE to INTERLACED at its output. > Yeah, that makes sense to me, I already saw yours csi_try_field that does something in this lines. I will try to handle that in imx7 also. Thanks for your inputs here. Cheers, Rui > >

Re: [PATCH v8 5/5] media: imx: Try colorimetry at both sink and source pads

Hi Laurent, On Tue 22 Oct 2019 at 02:44, Laurent Pinchart wrote: > Hi Steve, > > On Tue, May 21, 2019 at 06:03:17PM -0700, Steve Longerbeam wrote: >> Retask imx_media_fill_default_mbus_fields() to try colorimetry parameters, >> renaming it to to imx_media_try_colorimetry(), and call it at both sink

Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

dds a check for devm_regulator_get to avoid potential risk. > > Signed-off-by: Chuhong Yuan Reviewed-by: Rui Miguel Silva --- Cheers, Rui > --- > Changes in v2: > - Add a check in mipi_csis_probe for the modified mipi_csis_phy_init. > > drivers/staging/media/imx/imx

Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

Hi Marco, On Thu 17 Oct 2019 at 09:10, Marco Felsch wrote: > Hi Rui, > > On 19-10-16 14:43, Rui Miguel Silva wrote: >> Hi Marco, >> On Wed 16 Oct 2019 at 10:06, Marco Felsch wrote: >> > Hi Chuhong, >> > >> > On 19-10-15 21:59, Chuhong Yuan wrote:

Re: [PATCH v2] media: imx7-mipi-csis: Add a check for devm_regulator_get

Hi Marco, On Wed 16 Oct 2019 at 10:06, Marco Felsch wrote: > Hi Chuhong, > > On 19-10-15 21:59, Chuhong Yuan wrote: >> devm_regulator_get may return an error but mipi_csis_phy_init misses >> a check for it. >> This may lead to problems when regulator_set_voltage uses the unchecked >> pointer. >> Th

Re: [PATCH] media: imx7-mipi-csis: Add a check for devm_regulator_get

Hi Chuhong, Thanks for the patch. On Mon 14 Oct 2019 at 03:08, Chuhong Yuan wrote: > devm_regulator_get may return an error but mipi_csis_phy_init misses > a check for it. > This may lead to problems when regulator_set_voltage uses the unchecked > pointer. > This patch adds a check for devm_regula

Re: [PATCH] staging: media: imx: make use devm_platform_ioremap_resource

Hi Hariprasad, Thanks for the patch On Tue 08 Oct 2019 at 07:17, nobody wrote: > From: Hariprasad Kelam > Something went wrong formating the patch email, no To: nor From: > > fix below issue reported by coccicheck > drivers/staging//media/imx/imx7-mipi-csis.c:973:1-12: WARNING: Use > devm_platfo

Re: [PATCH] staging: media: imx: Use devm_platform_ioremap_resource().

helper which wraps platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Jeeeun Evans > Thanks for the patch. LGTM. Reviewed-by: Rui Miguel Silva --- Cheers, Rui > drivers/staging/media/imx/imx7-mipi-csis.c | 4 +--- > 1 file changed, 1 insertion(+), 3 d

Re: [PATCH] media: imx7-mipi-csis: make array 'registers' static const, makes object smaller

mipi-csis.o > > (gcc version 9.2.1, amd64) > > Signed-off-by: Colin Ian King Looks very good to me. Reviewed-by: Rui Miguel Silva Cheers, Rui > --- > drivers/staging/media/imx/imx7-mipi-csis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

Re: [PATCH 15/22] media: imx7-media-csi: Create media links in bound notifier

Hi Steve, On Tue 06 Aug 2019 at 00:34, Steve Longerbeam wrote: > Implement a notifier bound op to register media links from the remote > sub-device's source pad(s) to the CSI sink pad. > > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media/imx/imx7-media-csi.c | 24

Re: [PATCH 14/22] media: imx7-mipi-csis: Create media links in bound notifier

Hi Steve, Just to let you know that this series no longer apply clean after your other series: media: imx: Fix subdev unregister/register issues And since you will need to send a new one, some notes... On Tue 06 Aug 2019 at 00:34, Steve Longerbeam wrote: > Implement a notifier bound op to registe

Re: [PATCH] staging: greybus: light: fix a couple double frees

ot;) > Signed-off-by: Dan Carpenter > Thanks so much for this, I was looking for some time at this and was half way to a much less elegant fix then yours. Acked-by: Rui Miguel Silva Cheers, Rui > --- > drivers/staging/greybus/light.c | 12 ++-- > 1 file changed, 6

Re: [PATCH v2] staging: greybus: add missing includes

Hi Randy, On Wed 28 Aug 2019 at 16:09, Randy Dunlap wrote: > On 8/28/19 1:35 AM, Greg Kroah-Hartman wrote: >> On Tue, Aug 27, 2019 at 09:59:17PM +0100, Rui Miguel Silva wrote: >>> Before moving greybus core out of staging and moving header files to >>> include/linux som

Re: [PATCH] staging: greybus: fix more header includes

Hi, On Wed 28 Aug 2019 at 12:42, Greg Kroah-Hartman wrote: > On Wed, Aug 28, 2019 at 12:47:26PM +0200, Johan Hovold wrote: >> On Wed, Aug 28, 2019 at 11:28:59AM +0100, Rui Miguel Silva wrote: >> > More headers needed to be fixed when moving greybus out of staging and >> >

[PATCH v2] staging: greybus: fix more header declarations

More headers needed to be fixed when moving greybus out of staging and enabling the COMPILE_TEST option. Add forward declarations for the needed structures. Reported-by: kbuild test robot Signed-off-by: Rui Miguel Silva --- v1->v2: Johan Hovold: - use forward declarations instead includ

[PATCH] staging: greybus: fix more header includes

More headers needed to be fixed when moving greybus out of staging and enabling the COMPILE_TEST option. Reported-by: kbuild test robot Signed-off-by: Rui Miguel Silva --- include/linux/greybus/operation.h | 1 + include/linux/greybus/svc.h | 2 ++ 2 files changed, 3 insertions(+) diff

[PATCH v2] staging: greybus: add missing includes

:32: error: unknown type name 'gfp_t' struct gb_message *message, gfp_t gfp_mask); ^ ./include/linux/greybus/hd.h:35:55: error: unknown type name 'u16' int (*latency_tag_enable)(struct gb_host_device *hd, u16 cport_id); Reported-by: kbuild test robot Reported-by: Gao Xiang Signe

Re: [PATCH] staging: greybus: add missing includes

Hi Alex, On Tue 27 Aug 2019 at 18:22, Alex Elder wrote: > On 8/27/19 10:53 AM, Rui Miguel Silva wrote: >> Before moving greybus core out of staging and moving header files to >> include/linux some greybus header files were missing the necessary >> includes. This would trigger

Re: [PATCH 0/9] staging: move greybus core out of staging

Hi Greg, On Tue 27 Aug 2019 at 16:43, Greg KH wrote: > On Tue, Aug 27, 2019 at 03:30:21PM +0100, Rui Miguel Silva wrote: >> Hi, >> On Tue 27 Aug 2019 at 14:45, Greg Kroah-Hartman wrote: >> > On Tue, Aug 27, 2019 at 04:36:11PM +0300, Dan Carpenter wrote: >> >>

[PATCH] staging: greybus: add missing includes

:32: error: unknown type name 'gfp_t' struct gb_message *message, gfp_t gfp_mask); ^ ./include/linux/greybus/hd.h:35:55: error: unknown type name 'u16' int (*latency_tag_enable)(struct gb_host_device *hd, u16 cport_id); Signed-off-by: Rui Miguel Silva Signed-off-by: Rui Miguel S

Re: [PATCH 0/9] staging: move greybus core out of staging

Hi, On Tue 27 Aug 2019 at 14:45, Greg Kroah-Hartman wrote: > On Tue, Aug 27, 2019 at 04:36:11PM +0300, Dan Carpenter wrote: >> I can't compile greybus so it's hard to run Smatch on it... I have a >> Smatch thing which ignores missing includes and just tries its best. >> It mostly generates garbage

Re: [PATCH v3 2/3] media: imx7-media-csi: add i.MX6UL support

is imx6ul/l soc. Reviewed-by: Rui Miguel Silva --- Cheers, Rui > --- > > Changes for v3: > - rebase on Linux v5.3-rc2 > - remove csi_soc_id var as it's not needed anymore thanks to commit > e0c76a7d3428 ("media: imx7-media-csi: get csi upstream endpoint&

Re: [PATCH] media: imx7-media-csi: Remove unneeded break after return

Hi Chinmaya, Thanks for your patch. On Sun 30 Jun 2019 at 04:49, Chinmaya Krishnan Mahesh wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: break is not useful after a goto or return but this is already fixed in the media subsystem tree, by a patch from Fabio: 964fcacddf media: i

[PATCH v2] media: imx7-media-csi: get csi upstream endpoint

When the upstream endpoint is neither a mux nor a CSI2 module, just get the source pad directly upstream from the CSI. Fixes: 05f634040c0d ("media: staging/imx7: add imx7 CSI subdev driver") Reported-by: Sebastien Szymanski Signed-off-by: Rui Miguel Silva --- v1->v2: Dan Carpenter

Re: [PATCH] media: imx7-media-csi: get csi upstream endpoint

Hi Dan, On Wed 12 Jun 2019 at 08:43, Dan Carpenter wrote: > On Tue, Jun 11, 2019 at 04:09:55PM +0100, Rui Miguel Silva wrote: >> When the upstream endpoint is neither a mux nor a CSI2 module, just get >> the source pad directly upstream from the CSI. >> >> Fixes: 05f6340

[PATCH] media: imx7-media-csi: get csi upstream endpoint

When the upstream endpoint is neither a mux nor a CSI2 module, just get the source pad directly upstream from the CSI. Fixes: 05f634040c0d ("media: staging/imx7: add imx7 CSI subdev driver") Reported-by: Sebastien Szymanski Signed-off-by: Rui Miguel Silva --- drivers/staging/medi

Re: [PATCH v2 2/3] media: imx7-media-csi: add i.MX6UL support

Hi Sebastien, On Tue 11 Jun 2019 at 11:03, Sébastien Szymanski wrote: > On 6/11/19 11:40 AM, Rui Miguel Silva wrote: >> Hi Sebastien, >> On Tue 11 Jun 2019 at 09:16, Sébastien Szymanski wrote: >>> Hi Rui, >>> >>> thanks for the review! >>> >&

Re: [PATCH v2 2/3] media: imx7-media-csi: add i.MX6UL support

Hi Sebastien, On Tue 11 Jun 2019 at 09:16, Sébastien Szymanski wrote: > Hi Rui, > > thanks for the review! > > On 6/10/19 12:28 PM, Rui Miguel Silva wrote: >> Hi Sebastien, >> Thanks for the patch. >> >> On Thu 06 Jun 2019 at 16:38, Sébastien Szymanski wrote

Re: [PATCH v2 2/3] media: imx7-media-csi: add i.MX6UL support

Hi Randy, On Fri 07 Jun 2019 at 00:10, Randy Dunlap wrote: > On 6/6/19 8:38 AM, Sébastien Szymanski wrote: >> i.MX7 and i.MX6UL/L have the same CSI controller. So add i.MX6UL/L support >> to imx7-media-csi driver. >> >> Signed-off-by: Sébastien Szymanski >> --- >> >> Changes for v2: >> - rebase o

Re: [PATCH v2 2/3] media: imx7-media-csi: add i.MX6UL support

Hi Sebastien, Thanks for the patch. On Thu 06 Jun 2019 at 16:38, Sébastien Szymanski wrote: > i.MX7 and i.MX6UL/L have the same CSI controller. So add i.MX6UL/L support > to imx7-media-csi driver. > > Signed-off-by: Sébastien Szymanski > --- > > Changes for v2: > - rebase on top of linuxtv/maste

Re: [PATCH 2/2] media: imx7-media-csi: add i.MX6UL support

igned-off-by: Sébastien Szymanski Can you also add i.MX6UL/L to the header of this file and maybe in the help string in the Kconfig. That would make it clear that this is supported also by this driver. > --- > This patch needs the following patch from Rui Miguel Silva: > https://patchw

Re: [PATCH v3 5/8] media: staging/imx: Remove capture_device_set_format

Hi Steve, Thanks for v3 with bisect fixed. On Tue 30 Apr 2019 at 23:50, Steve Longerbeam wrote: > Don't propagate the source pad format to the connected capture device. > It's now the responsibility of userspace to call VIDIOC_S_FMT on the > capture device to ensure the capture format and compose

[PATCH] media: imx7_mipi_csis: fix racy entity pads init

-off-by: Rui Miguel Silva --- drivers/staging/media/imx/imx7-mipi-csis.c | 24 ++ 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c index 19455f425416..042837b8ea28 100644 --- a

Re: [PATCH v2 4/8] Revert "media: imx: Set capture compose rectangle in capture_device_set_format"

Hi Steve, On Sun 28 Apr 2019 at 20:09, Steve Longerbeam wrote: > Rvert this commit, as imx_media_capture_device_set_format() will be > removed. > > This reverts commit 5964cbd8692252615370b77eb96764dd70c2f837. > > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media/imx/imx-ic-prpencvf.c

Re: [PATCH v2 1/8] media: staging/imx: Switch to sync registration for IPU subdevs

Hi Steve, On Sun 28 Apr 2019 at 20:09, Steve Longerbeam wrote: > Because the IPU sub-devices VDIC and IC are not present in the > device-tree, platform devices were created for them instead. This > allowed these sub-devices to be added to the media device's async > notifier and registered asynchron

Re: [PATCH] media: staging/imx: add media device to capture register

--- Cheers, Rui > > Steve > > > On 4/12/19 9:44 AM, Rui Miguel Silva wrote: >> When register the capture media device it is assumed that the device >> data is the media device. In the imx6 case is but in the imx7 is not >> case. The device data is the csi struct

Re: [PATCH v2] staging: greybus: power_supply: use struct_size() helper

, replace code of the following form: sizeof(*resp) + props_count * sizeof(struct gb_power_supply_props_desc) with: struct_size(resp, props, props_count) This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva Reviewed-by: Rui Miguel Silva --- Cheers

[PATCH] media: staging/imx: add media device to capture register

: Laurent Pinchart Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/imx-ic-prpencvf.c | 2 +- drivers/staging/media/imx/imx-media-capture.c | 6 +++--- drivers/staging/media/imx/imx-media-csi.c | 2 +- drivers/staging/media/imx/imx-media.h | 3 ++- drivers/staging/media/imx

Re: [PATCH] staging: greybus: power_supply: fix prop-descriptor request size

operation. Fortunately, the pointer size is always larger than this one-byte request, but this could still cause trouble on the remote end due to the unexpected message size. Fixes: 9d15134d067e ("greybus: power_supply: rework get descriptors") Cc: stable # 4.9 Cc: Rui Miguel Silva

Re: [PATCH] staging: greybus: power_supply: Use struct_size() helper

Hi Gustavo, Thanks a lot for the patch. On Wed 03 Apr 2019 at 21:58, Gustavo A. R. Silva wrote: Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes, in particular in the context in which this code is being used. So, replace code

Re: [PATCH 1/1] staging: media: imx: imx7-mipi-csis: simplify getting .driver_data

Hi Wolfram, Thanks for the patch. On Tue 19 Mar 2019 at 16:36, Wolfram Sang wrote: We should get 'driver_data' from 'struct device' directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang Reviewed-by: Rui Miguel Silva ---

Re: [PATCH] staging: media: imx7-mipi-csis: fix debugfs compilation

: Arnd Bergmann Reviewed-by: Rui Miguel Silva --- Cheers, Rui --- drivers/staging/media/imx/imx7-mipi-csis.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c

Re: [PATCH v4 06/12] media: dt-bindings: add bindings for i.MX7 media driver

Hi Laurent, On Tue 12 Mar 2019 at 15:10, Laurent Pinchart wrote: Hi Rui, On Tue, Mar 12, 2019 at 02:07:02PM +, Rui Miguel Silva wrote: On Sun 10 Mar 2019 at 21:48, Laurent Pinchart wrote: > On Fri, May 18, 2018 at 09:27:58AM +0100, Rui Miguel Silva > wrote: >> On Fri 18 Ma

Re: [PATCH v14 08/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

Hi Laurent, On Tue 12 Mar 2019 at 14:10, Laurent Pinchart wrote: Hi Rui, On Tue, Mar 12, 2019 at 02:05:24PM +, Rui Miguel Silva wrote: On Sun 10 Mar 2019 at 21:41, Laurent Pinchart wrote: > Hi Rui, > > Thank you for the patch. Where have you been for the latest 14

Re: [PATCH v4 06/12] media: dt-bindings: add bindings for i.MX7 media driver

Hi Laurent, On Sun 10 Mar 2019 at 21:48, Laurent Pinchart wrote: Hi Rui, On Fri, May 18, 2018 at 09:27:58AM +0100, Rui Miguel Silva wrote: Hi Sakari, Thanks for the review. On Fri 18 May 2018 at 06:58, Sakari Ailus wrote: > On Thu, May 17, 2018 at 01:50:27PM +0100, Rui Miguel Silva >

Re: [PATCH v14 08/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

Hi Laurent, On Sun 10 Mar 2019 at 21:41, Laurent Pinchart wrote: Hi Rui, Thank you for the patch. Where have you been for the latest 14 versions? :) This is already merged, but... follow up patches can address your issues bellow. On Wed, Feb 06, 2019 at 03:13:23PM +, Rui Miguel Silva

Re: [PATCH] media: a few more typos at staging, pci, platform, radio and usb

Hi Mauro, On Fri 01 Mar 2019 at 15:03, Mauro Carvalho Chehab wrote: Those typos were left over from codespell check, on my first pass or belong to code added after the time I ran it. Signed-off-by: Mauro Carvalho Chehab For the imx7 part: Acked-by: Rui Miguel Silva Thanks. --- Cheers

[PATCH] media: imx7_mipi_csis: remove internal ops

Remove code that is not called anywhere, just remove the internal ops. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/imx7-mipi-csis.c | 27 -- 1 file changed, 27 deletions(-) diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media

Re: [PATCH v14 05/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

Hi Hans, On Wed 20 Feb 2019 at 08:56, Hans Verkuil wrote: On 2/6/19 4:13 PM, Rui Miguel Silva wrote: Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile |1 + drivers/staging

Re: [PATCH 2/2] media: imx7-media-csi: get rid of unused var

le] const struct imx_media_pixfmt *in_cc; ^ Signed-off-by: Mauro Carvalho Chehab Acked-by: Rui Miguel Silva --- Cheers, Rui --- drivers/staging/media/imx/imx7-media-csi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/d

Re: [PATCH 1/2] media: imx7-media-csi: don't store a floating pointer

-by: Rui Miguel Silva --- Cheers, Rui --- drivers/staging/media/imx/imx7-media-csi.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c index d775e259fece..0b17

[PATCH v14.1] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva --- kbuild-bot: - remove __exit from debugfs_exit to solve tree: git://linuxtv.org/hverkuil/media_tree.git imx7 head: a95edaa9069c275170a9ecf5aedc68be974678a2 commit

[PATCH v14.1] media: staging/imx: refactor imx media device probe

Refactor and move media device initialization code to a new common module, so it can be used by other devices, this will allow for example a near to introduce imx7 CSI driver, to use this media device. Signed-off-by: Rui Miguel Silva --- v14->v14.1: - Fix SPDX in dev-common drivers/stag

[PATCH v14 12/13] media: video-mux: add bayer formats

Add non vendor bayer formats to the allowed format array. Signed-off-by: Rui Miguel Silva Reviewed-by: Philipp Zabel Acked-by: Sakari Ailus --- drivers/media/platform/video-mux.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/media/platform/video-mux.c b

[PATCH v14 11/13] media: staging/imx: add i.MX7 entries to TODO file

Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5ca5324

[PATCH v14 10/13] media: imx7.rst: add documentation for i.MX7 media driver

Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus --- Documentation/media/v4l-drivers/imx7.rst | 159 ++ Documentation/media/v4l-drivers

[PATCH v14 13/13] media: MAINTAINERS: add entry for Freescale i.MX7 media driver

Add maintainer entry for the imx7 media csi, mipi csis driver, dt-bindings and documentation. Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3e211916d2bc..d8e0c9040736

[PATCH v14 09/13] ARM: dts: imx7s-warp: add ov2680 sensor node

Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete the camera data path for this system. Add the needed regulator to the analog voltage supply, the port and endpoints in mipi_csi node and the pinctrl for the reset gpio. Signed-off-by: Rui Miguel Silva --- arch/arm

[PATCH v14 05/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1186 2 files changed, 1187 insertions(+) create mode

[PATCH v14 08/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s-warp.dts | 51

[PATCH v14 02/13] media: staging/imx: rearrange group id to take in account IPU

IPU have internal subdevices. Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus --- drivers/staging/media/imx/imx-ic-common.c | 6 ++--- drivers/staging/media/imx/imx-ic-prp.c| 16 ++--- drivers/staging/media/imx/imx-media-csi.c | 6 ++--- drivers/staging/media/imx

[PATCH v14 06/13] ARM: dts: imx7s: add mipi phy power domain

Add power domain index 0 related with mipi-phy to imx7s. While at it rename pcie power-domain node to remove pgc prefix. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7s.dtsi b

[PATCH v14 00/13] media: staging/imx7: add i.MX7 media driver

User Controls' failed test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: FAIL test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 10 Private Controls: 0 Format ioctls: test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK (Not Supported) test VIDIOC_G/S_PA

[PATCH v14 03/13] media: dt-bindings: add bindings for i.MX7 media driver

Add bindings documentation for i.MX7 media drivers. The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva Reviewed-by: Rob Herring Acked-by: Sakari Ailus --- .../devicetree/bindings/media/imx7-csi.txt| 45 ++ .../bindings/media/imx7-mipi-csi2.txt

[PATCH v14 07/13] ARM: dts: imx7s: add multiplexer controls

The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register and mask. Signed-off-by: Rui Miguel Silva Reviewed-by: Philipp Zabel --- arch/arm/boot/dts/imx7s.dtsi | 9 - 1 file

[PATCH v14 04/13] media: staging/imx7: add imx7 CSI subdev driver

This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus --- drivers/staging/media/imx/Kconfig |9 +- drivers/staging/media/imx/Makefile |2 + drivers/staging/media/imx/imx7-media

[PATCH v14 01/13] media: staging/imx: refactor imx media device probe

Refactor and move media device initialization code to a new common module, so it can be used by other devices, this will allow for example a near to introduce imx7 CSI driver, to use this media device. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile| 1

Re: [PATCH v13 10/13] media: imx7.rst: add documentation for i.MX7 media driver

Hi Hans, On Wed 06 Feb 2019 at 10:54, Hans Verkuil wrote: On 2/6/19 11:25 AM, Rui Miguel Silva wrote: Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus

[PATCH v13 06/13] ARM: dts: imx7s: add mipi phy power domain

Add power domain index 0 related with mipi-phy to imx7s. While at it rename pcie power-domain node to remove pgc prefix. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7s.dtsi b

[PATCH v13 07/13] ARM: dts: imx7s: add multiplexer controls

The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register and mask. Signed-off-by: Rui Miguel Silva Reviewed-by: Philipp Zabel --- arch/arm/boot/dts/imx7s.dtsi | 9 - 1 file

[PATCH v13 08/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s-warp.dts | 51

[PATCH v13 12/13] media: video-mux: add bayer formats

Add non vendor bayer formats to the allowed format array. Signed-off-by: Rui Miguel Silva Reviewed-by: Philipp Zabel Acked-by: Sakari Ailus --- drivers/media/platform/video-mux.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/media/platform/video-mux.c b

[PATCH v13 09/13] ARM: dts: imx7s-warp: add ov2680 sensor node

Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete the camera data path for this system. Add the needed regulator to the analog voltage supply, the port and endpoints in mipi_csi node and the pinctrl for the reset gpio. Signed-off-by: Rui Miguel Silva --- arch/arm

[PATCH v13 11/13] media: staging/imx: add i.MX7 entries to TODO file

Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5ca5324

[PATCH v13 13/13] media: MAINTAINERS: add entry for Freescale i.MX7 media driver

Add maintainer entry for the imx7 media csi, mipi csis driver, dt-bindings and documentation. Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3e211916d2bc..d8e0c9040736

[PATCH v13 10/13] media: imx7.rst: add documentation for i.MX7 media driver

Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus --- Documentation/media/v4l-drivers/imx7.rst | 157 ++ Documentation/media/v4l-drivers

[PATCH v13 05/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1186 2 files changed, 1187 insertions(+) create mode

[PATCH v13 01/13] media: staging/imx: refactor imx media device probe

Refactor and move media device initialization code to a new common module, so it can be used by other devices, this will allow for example a near to introduce imx7 CSI driver, to use this media device. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile| 1 + drivers

[PATCH v13 02/13] media: staging/imx: rearrange group id to take in account IPU

IPU have internal subdevices. Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus --- drivers/staging/media/imx/imx-ic-common.c | 6 ++--- drivers/staging/media/imx/imx-ic-prp.c| 16 ++--- drivers/staging/media/imx/imx-media-csi.c | 6 ++--- drivers/staging/media/imx

[PATCH v13 04/13] media: staging/imx7: add imx7 CSI subdev driver

This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus --- drivers/staging/media/imx/Kconfig |9 +- drivers/staging/media/imx/Makefile |2 + drivers/staging/media/imx/imx7-media

[PATCH v13 03/13] media: dt-bindings: add bindings for i.MX7 media driver

Add bindings documentation for i.MX7 media drivers. The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva Reviewed-by: Rob Herring Acked-by: Sakari Ailus --- .../devicetree/bindings/media/imx7-csi.txt| 45 ++ .../bindings/media/imx7-mipi-csi2.txt

[PATCH v13 00/13] media: staging/imx7: add i.MX7 media driver

ate Controls: 0 Format ioctls: test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK (Not Supported) test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK (Not Supported) test VIDIOC_TRY_FMT: OK (Not Supported)

Re: [PATCH v12 00/13] media: staging/imx7: add i.MX7 media driver

Hi Sakari, On Tue 05 Feb 2019 at 11:14, Sakari Ailus wrote: Hi Rui, On Mon, Feb 04, 2019 at 12:00:26PM +, Rui Miguel Silva wrote: Hi, This series introduces the Media driver to work with the i.MX7 SoC. it uses the already existing imx media core drivers but since the i.MX7, contrary to

[PATCH v12 06/13] ARM: dts: imx7s: add mipi phy power domain

Add power domain index 0 related with mipi-phy to imx7s. While at it rename pcie power-domain node to remove pgc prefix. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7s.dtsi b

[PATCH v12 05/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1186 2 files changed, 1187 insertions(+) create mode

[PATCH v12 10/13] media: imx7.rst: add documentation for i.MX7 media driver

Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus --- Documentation/media/v4l-drivers/imx7.rst | 157 ++ Documentation/media/v4l-drivers

[PATCH v12 09/13] ARM: dts: imx7s-warp: add ov2680 sensor node

Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete the camera data path for this system. Add the needed regulator to the analog voltage supply, the port and endpoints in mipi_csi node and the pinctrl for the reset gpio. Signed-off-by: Rui Miguel Silva --- arch/arm

[PATCH v12 08/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s-warp.dts | 51

[PATCH v12 12/13] media: video-mux: add bayer formats

Add non vendor bayer formats to the allowed format array. Signed-off-by: Rui Miguel Silva Reviewed-by: Philipp Zabel Acked-by: Sakari Ailus --- drivers/media/platform/video-mux.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/media/platform/video-mux.c b

  1   2   3   4   >