Re: [PATCH v11 4/4] drm/bridge: anx7625: add HDMI audio function

Hey Xin, This series does not apply on drm-misc-next. Please fix this and resend. Make sure that checkpatch --strict passes as well. On Wed, 3 Nov 2021 at 15:20, Dan Carpenter wrote: > > This is a super awkward way to resend a patch series. Next time, just > start a new thread and put [PATCH RE

Re: [PATCH v2] drm/bridge: anx7625: enable DSI EOTP

On Thu, 19 Aug 2021 at 08:01, Xin Ji wrote: > > Enable DSI EOTP feature for fixing some panel screen constant shift issue. > Removing MIPI flag MIPI_DSI_MODE_NO_EOT_PACKET to enable DSI EOTP. > > Reviewed-by: Robert Foss > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/b

Re: [PATCH v2] drm/bridge: anx7625: Tune K value for IVO panel

Applied to drm-misc-next ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 1/1] drm/bridge: anx7625: Tune K value for IVO panel

Hey Xin, Thanks for implementing the suggestion so quickly. Can you send this version of the patch out as v2? Versioning is important and both tools and processes break if different versions aren't submitted in different emails. On Fri, 6 Aug 2021 at 11:35, Xin Ji wrote: > > IVO panel require l

Re: [PATCH v1 1/1] drm/bridge: anx7625: Tune K value for IVO panel

u/drm/bridge/analogix/anx7625.h > @@ -210,7 +210,9 @@ > #define MIPI_VIDEO_STABLE_CNT 0x0A > > #define MIPI_LANE_CTRL_10 0x0F > -#define MIPI_DIGITAL_ADJ_1 0x1B > +#define MIPI_DIGITAL_ADJ_1 0x1B > +#define IVO_MID0 0x26 > +#d

Re: [PATCH 1/1] drm/bridge: anx7625: send DPCD command to downstream

te_and(ctx, ctx->i2c.tx_p2_client, 0x08, 0x7f); > > ret |= anx7625_video_mute_control(ctx, 1); > + > + DRM_DEV_DEBUG_DRIVER(dev, "notify downstream enter into standby\n"); > + > + /* Downstream monitor enter into standby mode */ > + data = 2; > + ret |= anx7625_aux_dpcd_write(ctx, 0x00, 0x06, 0x00, 1, &data); > if (ret < 0) > DRM_DEV_ERROR(dev, "IO error : mute video fail\n"); > + > + return; > } Reviewed-by: Robert Foss ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v6 5/5] drm/bridge: anx7625: add HDMI audio function

Hey Xin, This patch looks good to me. Reviewed-by: Robert Foss On Fri, 19 Mar 2021 at 07:35, Xin Ji wrote: > > Add audio HDMI codec function support, enable it through device true flag > "analogix,audio-enable". > > Reported-by: kernel test robot > Signed-off-by:

Re: [PATCH v6 3/5] drm/bridge: anx7625: add MIPI DPI input feature support

Hey Xin, This patch looks good to me, feel free to add my r-b. Reviewed-by: Robert Foss On Fri, 19 Mar 2021 at 07:34, Xin Ji wrote: > > Add MIPI rx DPI input support. > > Reported-by: kernel test robot > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/ana

Re: [PATCH v6 2/5] drm/bridge: anx7625: fix not correct return value

Hey Xin, This patch looks good to me. Reviewed-by: Robert Foss On Fri, 19 Mar 2021 at 07:33, Xin Ji wrote: > > At some time, the original code may return non zero value, force return 0 > if operation finished. > > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/a

Re: [PATCH v4 3/3] drm/bridge: anx7625: add MIPI DPI input feature support

Hey Xin, On Thu, 28 Jan 2021 at 04:12, Xin Ji wrote: > > Add MIPI rx DPI input support > > Reported-by: kernel test robot > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 326 > -- > drivers/gpu/drm/bridge/analogix/anx7625.h | 20 +- > 2

Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP

On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat wrote: > > On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda wrote: > > > > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote: > > >> Hi Xin, > &g

Re: [PATCH v4 2/3] drm/bridge: anx7625: fix not correct return value

Hi Xin, On Thu, 28 Jan 2021 at 04:12, Xin Ji wrote: > > At some time, the original code may return non zero value, force return 0 > if operation finished Missing "." at end of line. Other than that, this patch looks fine. Feel free to add my r-b. Reviewed-by: Robert Foss

Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP

Hi Xin, Thanks for the patch. On Thu, 28 Jan 2021 at 12:17, Xin Ji wrote: > > Enable DSI EOTP feature for fixing some panel screen constance > shift issue. > Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. I don't think I quite understand how removing the MIPI_DSI_MODE_EOT_PACKE

Re: [PATCH] media: atomisp: remove redundant NULL check

Thanks for the patch. Feel free to add my r-b: Reviewed-by: Robert Foss On Thu, 21 Jan 2021 at 09:31, Yang Li wrote: > > Fix below warnings reported by coccicheck: > ./drivers/staging/media/atomisp/pci/sh_css_params.c:1575:2-8: WARNING: > NULL check before some freeing functions i

[PATCH] Staging: crystalhd: fixed whitespace and string style issues

Fixed 3 instances of user-visible string being broken into two string. Fixed 2 instances of illegal whitespace. --- drivers/staging/crystalhd/crystalhd_cmds.c |3 +-- drivers/staging/crystalhd/crystalhd_hw.c |7 +++ drivers/staging/crystalhd/crystalhd_lnx.c |3 +-- 3 files chang