Re: [PATCH] arch: um: convert tasklets to use new tasklet_setup() API

2020-10-18 Thread Richard Weinberger
On Mon, Aug 17, 2020 at 11:17 AM Allen Pais wrote: > > From: Allen Pais > > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > > Signed-of

Re: [PATCH] erofs: move erofs out of staging

2019-08-19 Thread Richard Weinberger
- Ursprüngliche Mail - > On Sun, Aug 18, 2019 at 10:29:38AM -0700, Eric Biggers wrote: >> Not sure what you're even disagreeing with, as I *do* expect new filesystems >> to >> be held to a high standard, and to be written with the assumption that the >> on-disk data may be corrupted or mal

Re: [PATCH] erofs: move erofs out of staging

2019-08-19 Thread Richard Weinberger
- Ursprüngliche Mail - > I have made a simple fuzzer to inject messy in inode metadata, > dir data, compressed indexes and super block, > https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/commit/?h=experimental-fuzzer > > I am testing with some given dirs and the follow

Re: [PATCH] erofs: move erofs out of staging

2019-08-18 Thread Richard Weinberger
, "Fang Wei" , > "Pavel Machek" , "linux-fsdevel" > , "Andrew Morton" > , "torvalds" > Gesendet: Sonntag, 18. August 2019 19:46:21 > Betreff: Re: [PATCH] erofs: move erofs out of staging > On Sun, Aug 18, 2019 at 07:06:40PM +0200,

Re: [PATCH] erofs: move erofs out of staging

2019-08-18 Thread Richard Weinberger
- Ursprüngliche Mail - > So holding a file system like EROFS to a higher standard than say, > ext4, xfs, or btrfs hardly seems fair. Nobody claimed that. Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linu

Re: [PATCH] erofs: move erofs out of staging

2019-08-18 Thread Richard Weinberger
- Ursprüngliche Mail - > You have looked at reiserfs lately, right? :) Don't remind me of that. ;-) > Not to say that erofs shouldn't be worked on to fix these kinds of > issues, just that it's not an unheard of thing to trust the disk image. > Especially for the normal usage model of e

Re: [PATCH] erofs: move erofs out of staging

2019-08-18 Thread Richard Weinberger
- Ursprüngliche Mail - > I agree with you, but what can we do now is trying our best to fuzz > all the fields. > > So, what is your opinion about EROFS? All I'm saying is that you should not blindly trust the disk. Another thing that raises my attention is in superblock_read(): m

Re: [PATCH v3 RESEND] staging: erofs: fix an error handling in erofs_readdir()

2019-08-18 Thread Richard Weinberger
- Ursprüngliche Mail - > changelog from v2: > - transform EIO to EFSCORRUPTED as suggested by Matthew; erofs does not define EFSCORRUPTED, so the build fails. At least on Linus' tree as of today. Thanks, //richard ___ devel mailing list de...@li

Re: [PATCH] erofs: move erofs out of staging

2019-08-18 Thread Richard Weinberger
- Ursprüngliche Mail - >> While digging a little into the code I noticed that you have very few >> checks of the on-disk data. >> For example ->u.i_blkaddr. I gave it a try and created a >> malformed filesystem where u.i_blkaddr is 0xdeadbeef, it causes the kernel >> to loop forever around

Re: [PATCH] erofs: move erofs out of staging

2019-08-17 Thread Richard Weinberger
- Ursprüngliche Mail - >> How does erofs compare to squashfs? >> IIUC it is designed to be faster. Do you have numbers? >> Feel free to point me older mails if you already showed numbers, >> I have to admit I didn't follow the development very closely. > > You can see the following related

Re: [PATCH] erofs: move erofs out of staging

2019-08-17 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Gao Xiang" > An: "Greg Kroah-Hartman" , "Al Viro" > , "linux-fsdevel" > , de...@driverdev.osuosl.org, > linux-er...@lists.ozlabs.org, "linux-kernel" > > CC: "Andrew Morton" , "Stephen Rothwell" > , "tytso" , > "Pavel Machek" , "David Sterba" , "Amir > Go

Re: [PATCH 5/5] mtd: Stop updating erase_info->state and calling mtd_erase_callback()

2018-02-12 Thread Richard Weinberger
ck() calls and all > erase_info->state assignments. While at it, get rid of the > erase_info->state field, all MTD_ERASE_XXX definitions and the > mtd_erase_callback() function. > > Signed-off-by: Boris Brezillon Reviewed-by: Richard Weinberger Thanks, //richard __

Re: [PATCH 4/5] mtd: Unconditionally update ->fail_addr and ->addr in part_erase()

2018-02-12 Thread Richard Weinberger
erase_info->mtd field which was only > needed to let mtd_erase_callback() get the partition device back. > > Signed-off-by: Boris Brezillon Reviewed-by: Richard Weinberger Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/5] mtd: Stop assuming mtd_erase() is asynchronous

2018-02-12 Thread Richard Weinberger
0 means > failure. > > Signed-off-by: Boris Brezillon Reviewed-by: Richard Weinberger Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/5] mtd: Initialize ->fail_addr early in mtd_erase()

2018-02-12 Thread Richard Weinberger
int mtd_erase(struct mtd_info *mtd, struct erase_info > *instr) if (!(mtd->flags & MTD_WRITEABLE)) > return -EROFS; > > - instr->fail_addr = MTD_FAIL_ADDR_UNKNOWN; > if (!instr->len) { > instr->stat

Re: [PATCH 2/5] mtd: Get rid of unused fields in struct erase_info

2018-02-12 Thread Richard Weinberger
t erase_info *next; > }; > > struct mtd_erase_region_info { Reviewed-by: Richard Weinberger Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: dgnc: Let line have less 80 char

2016-09-01 Thread Richard Weinberger
Sean, On Thu, Sep 1, 2016 at 5:58 PM, Sean wrote: > This patch fix a minor checkpath warming: > > "WARNING: line over 80 characters" Please don't do patches just because of the sake of checkpatch.pl. Especially since "line over 80 characters" is only a warning, not an error. Your changelog fails

[PATCH 04/22] staging: iio: Fix dependencies for !HAS_IOMEM archs

2016-01-25 Thread Richard Weinberger
Not every arch has io memory. So, unbreak the build by fixing the dependencies. Signed-off-by: Richard Weinberger --- drivers/staging/iio/adc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig index 58d4517..b9519be

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2015-10-30 Thread Richard Weinberger
Am 30.10.2015 um 23:03 schrieb Haiyang Zhang: > > >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Friday, October 30, 2015 6:56 AM >> To: Haiyang Zhang >> Cc: Richard Weinberger ; David Miller >> ; o...

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2015-10-27 Thread Richard Weinberger
On Mon, Jun 23, 2014 at 10:10 PM, David Miller wrote: > From: Haiyang Zhang > Date: Mon, 23 Jun 2014 16:09:59 + > >> So, what's the equivalent or similar command to "network restart" on SLES12? >> Could >> you update the command line for the usermodehelper when porting this patch >> to SLES

Re: [PATCH 6/6] MAINTAINERS: maintain parport

2015-05-20 Thread Richard Weinberger
Am 20.05.2015 um 18:33 schrieb One Thousand Gnomes: > On Wed, 20 May 2015 17:46:44 +0200 > Richard Weinberger wrote: > >> On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee >> wrote: >>> Lets give the parport subsystem a proper name and start >>> main

Re: [PATCH 6/6] MAINTAINERS: maintain parport

2015-05-20 Thread Richard Weinberger
On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee wrote: > Lets give the parport subsystem a proper name and start > maintaining the files. Excuse me, but usually someone takes over the maintainer role after proving that he cares for a sub system for a certain period of time. Or did I miss somethi

Re: [PATCH] staging: unisys: Disable driver for UML

2015-05-10 Thread Richard Weinberger
Am 10.05.2015 um 15:02 schrieb Greg KH: > On Mon, May 04, 2015 at 09:02:10PM +0200, Richard Weinberger wrote: >> UML has no io memory nor cpuid. >> Let's disable this driver for UML. > > Doesn't apply to my tree :( I'm sorry Greg, looks like my -next t

[PATCH] staging: unisys: Disable driver for UML

2015-05-04 Thread Richard Weinberger
ap’ [-Werror=implicit-function-declaration] iounmap(addr); Signed-off-by: Richard Weinberger --- drivers/staging/unisys/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/Kconfig b/drivers/staging/unisys/Kconfig index 19fcb34..a6d6c2a 100644

Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

2015-03-29 Thread Richard Weinberger
Am 29.03.2015 um 01:26 schrieb Shirish Gajera: > Are you sure you want me to do this changes. Because it will conflict > the things written on http://kernelnewbies.org/ Conflict with what? Thanks, //richard ___ devel mailing list de...@linuxdriverprojec

Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

2015-03-28 Thread Richard Weinberger
Am 29.03.2015 um 00:44 schrieb Shirish Gajera: > On Sat, Mar 28, 2015 at 02:35:19PM -0700, Joe Perches wrote: >> On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote: >>> Am 28.03.2015 um 22:18 schrieb Joe Perches: >>>> On Sat, 2015-03-28 at 21:40 +0100, Rich

Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

2015-03-28 Thread Richard Weinberger
Am 28.03.2015 um 22:18 schrieb Joe Perches: > On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote: >> On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera >> wrote: >>> This patch fixes the checkpatch.pl warning: > > [] > >>> diff --git a/driver

Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

2015-03-28 Thread Richard Weinberger
On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera wrote: > This patch fixes the checkpatch.pl warning: > WARNING: line over 80 characters > > All line over 80 characters in driver/staging/speakup/* are fixed. > > Signed-off-by: Shirish Gajera > --- > drivers/staging/speakup/main.c | 9 ++

Re: checkpatch induced patches...

2015-02-11 Thread Richard Weinberger
Am 11.02.2015 um 23:43 schrieb Dan Carpenter: > On Wed, Feb 11, 2015 at 12:43:03PM -0800, Joe Perches wrote: >> Maybe some help/warning text like: >> >> --forceWithout --force, checkpatch will not scan files >> using -f or --file outside of >> dri

Re: checkpatch induced patches...

2015-02-11 Thread Richard Weinberger
On Wed, Feb 11, 2015 at 7:36 PM, Dan Carpenter wrote: > On Wed, Feb 11, 2015 at 10:00:29AM -0800, Joe Perches wrote: >> I'm half tempted to submit some patch like this to >> make it difficult to use checkpatch on files outside >> of drivers/staging. >> >> o Only allow checkpatch to be used with th

Re: [GIT PULL] Staging driver patches for 3.19-rc1

2014-12-16 Thread Richard Weinberger
Am 15.12.2014 um 19:56 schrieb Greg KH: > On Mon, Dec 15, 2014 at 10:41:03AM -0800, Greg KH wrote: >> On Mon, Dec 15, 2014 at 10:39:15AM -0800, Christoph Hellwig wrote: >>> On Mon, Dec 15, 2014 at 07:23:35PM +0100, Richard Weinberger wrote: >>>> I don't un

Re: [GIT PULL] Staging driver patches for 3.19-rc1

2014-12-15 Thread Richard Weinberger
Am 15.12.2014 um 19:44 schrieb Greg KH: > On Mon, Dec 15, 2014 at 07:36:00PM +0100, Richard Weinberger wrote: >> >> Am 15.12.2014 um 19:30 schrieb Greg KH: >>> On Mon, Dec 15, 2014 at 07:23:35PM +0100, Richard Weinberger wrote: >>>> On Mon, Dec 15, 2014 at 6:55

Re: [GIT PULL] Staging driver patches for 3.19-rc1

2014-12-15 Thread Richard Weinberger
Am 15.12.2014 um 19:30 schrieb Greg KH: > On Mon, Dec 15, 2014 at 07:23:35PM +0100, Richard Weinberger wrote: >> On Mon, Dec 15, 2014 at 6:55 PM, Greg KH wrote: >>> The following changes since commit 009d0431c3914de64666bec0d350e54fdd59df6a: >>> >>> Linux

Re: [GIT PULL] Staging driver patches for 3.19-rc1

2014-12-15 Thread Richard Weinberger
On Mon, Dec 15, 2014 at 6:55 PM, Greg KH wrote: > The following changes since commit 009d0431c3914de64666bec0d350e54fdd59df6a: > > Linux 3.18-rc7 (2014-11-30 16:42:27 -0800) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ > tag

Re: [PATCH] Drivers:staging:speakup: Fixed checkpatch warning

2014-11-26 Thread Richard Weinberger
On Wed, Nov 26, 2014 at 12:14 PM, Athira Lekshmi C V wrote: > Fixed the checkpatch warning: > WARNING: simple_strtoul is obsolete, use kstrtoul instead > > Signed-off-by: Athira Lekshmi C V > --- > drivers/staging/speakup/varhandlers.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH 08/44] kernel: Move pm_power_off to common code

2014-10-07 Thread Richard Weinberger
Am 07.10.2014 07:28, schrieb Guenter Roeck: > arch/um/kernel/reboot.c| 2 -- Acked-by: Richard Weinberger Thanks, //richard ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listi

Re: [hyperv] BUG at drivers/hv/channel.c:462 while changing MTU

2014-08-25 Thread Richard Weinberger
Am 25.08.2014 16:53, schrieb KY Srinivasan: > > >> -Original Message----- >> From: Richard Weinberger [mailto:richard.weinber...@gmail.com] >> Sent: Monday, August 25, 2014 3:48 AM >> To: Sitsofe Wheeler >> Cc: Haiyang Zhang; KY Srinivasan; Greg Kroah-Hart

Re: [hyperv] BUG at drivers/hv/channel.c:462 while changing MTU

2014-08-25 Thread Richard Weinberger
via On Wed, Aug 20, 2014 at 5:41 AM, Sitsofe Wheeler wrote: > Aug 20 04:04:41 ubuntuhv kernel: [9.230399] random: nonblocking pool is > initialized > Aug 20 04:04:41 ubuntuhv kernel: [ 10.338487] EXT4-fs (sda1): re-mounted. > Opts: errors=remount-ro > Aug 20 04:04:41 ubuntuhv kernel: [

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-08-07 Thread Richard Weinberger
On Mon, Jul 21, 2014 at 11:32 PM, David Miller wrote: > From: Olaf Hering > Date: Mon, 21 Jul 2014 11:18:51 +0200 > >> On Mon, Jul 21, Richard Weinberger wrote: >> >>> My concern is that 10 seconds is maybe not a the right choice. >>> (As we cannot know a

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Richard Weinberger
Am 24.07.2014 21:05, schrieb Nick Krause: > On Thu, Jul 24, 2014 at 2:55 PM, Nick Krause wrote: >> On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger >> wrote: >>> On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote: >>>> Steve, >>>> I have prog

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-24 Thread Richard Weinberger
On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote: > Steve, > I have programming a lot in other areas just not the kernel. > You are right through I need to test my code better through. Nick, let's make a deal. Take the challenge at http://eudyptula-challenge.org. After you've solved all tasks

Re: [PATCH] staging: Change kzalloc to kcalloc

2014-07-23 Thread Richard Weinberger
On Thu, Jul 24, 2014 at 1:03 AM, Nicholas Krause wrote: > This changes the call to kzalloc to kcalloc in ion_dummy_driver > for allocating the heap. > > Signed-off-by: Nicholas Krause > --- > drivers/staging/android/ion/ion_dummy_driver.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-21 Thread Richard Weinberger
Yue, Am 21.07.2014 10:44, schrieb Yue Zhang (OSTC DEV): > Hi, Richard > > IMHO, all networking implementations should handle the cable offline event. > Consider > this situation. I unplugged the network cable and connect it to a new network > switch > after 10 seconds. If the DHCP renew is not

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-21 Thread Richard Weinberger
Yue, Am 21.07.2014 10:05, schrieb Yue Zhang (OSTC DEV): > The problem of systemd implementation is that in different distros, the ways > to > restart service are different. Propagating the event to userspace also > doesn't help > for this issue. This way each distro can provide their own rest

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-20 Thread Richard Weinberger
Yie, Am 21.07.2014 04:44, schrieb Yue Zhang (OSTC DEV): >> From: Richard Weinberger [mailto:richard.weinber...@gmail.com] >> Why 10? Is this a random number which works by accident for ifplugd? >> What about other networking implementations, is 10 also ok for them? >> --

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-20 Thread Richard Weinberger
Am 20.07.2014 10:38, schrieb Chen Gang: > On 07/19/2014 02:02 AM, Chen Gang wrote: >>> 2014-07-18 18:51 GMT+08:00 Richard Weinberger : >>>> Am 18.07.2014 12:44, schrieb Chen Gang: >>>>> On 07/18/2014 03:35 PM, Richard Weinberger wrote: >&g

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-18 Thread Richard Weinberger
On Fri, Jul 18, 2014 at 12:55 PM, Yue Zhang wrote: > From: Yue Zhang > > This patch addresses the comment from Olaf Hering and Greg KH > for a previous commit 3a494e710367 ("hyperv: Add handler for > RNDIS_STATUS_NETWORK_CHANGE event") > > In previous solution, the driver calls "network restart"

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-18 Thread Richard Weinberger
Am 18.07.2014 12:44, schrieb Chen Gang: > On 07/18/2014 03:35 PM, Richard Weinberger wrote: >> Am 18.07.2014 02:36, schrieb Chen Gang: >>> >>> On 07/18/2014 02:09 AM, Richard Weinberger wrote: >>>> Am 17.07.2014 12:48, schrieb Arnd Bergmann: >>>&g

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-18 Thread Richard Weinberger
Am 18.07.2014 02:36, schrieb Chen Gang: > > On 07/18/2014 02:09 AM, Richard Weinberger wrote: >> Am 17.07.2014 12:48, schrieb Arnd Bergmann: >>> AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take >>> a shortcut here and make COMPILE_TEST depend

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Richard Weinberger
Am 17.07.2014 12:48, schrieb Arnd Bergmann: > AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take > a shortcut here and make COMPILE_TEST depend on !UML? Getting random stuff > to build on UML seems pointless to me and we special-case it in a number of > places already. If UM

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Richard Weinberger
Am 17.07.2014 12:28, schrieb Arnd Bergmann: > On Thursday 17 July 2014 11:26:57 Richard Weinberger wrote: >> Am 17.07.2014 11:20, schrieb Arnd Bergmann: >>> On Thursday 17 July 2014 09:27:58 Chen Gang wrote: >>>> gfp_t gfp_

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-17 Thread Richard Weinberger
Am 17.07.2014 11:20, schrieb Arnd Bergmann: > On Thursday 17 July 2014 09:27:58 Chen Gang wrote: >> gfp_t gfp_mask, unsigned int order); >> extern void devm_free_pages(struct device *dev, unsigned long addr); >> >> +#ifdef CONFIG_HAS_IOMEM >> void __iome

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-14 Thread Richard Weinberger
Am 14.07.2014 10:48, schrieb Lars-Peter Clausen: > On 07/14/2014 10:31 AM, Richard Weinberger wrote: >> Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman: >>> On Sun, Jul 13, 2014 at 09:33:38PM +0200, Richard Weinberger wrote: >>>> Maybe we could add COMPILE_TEST to the

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-14 Thread Richard Weinberger
Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman: > On Sun, Jul 13, 2014 at 09:33:38PM +0200, Richard Weinberger wrote: >> Maybe we could add COMPILE_TEST to the version string too? >> Just to detect such kernels fast in user bug reports... > > What kind of bug report are yo

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Richard Weinberger
Am 13.07.2014 21:22, schrieb Greg Kroah-Hartman: > On Sun, Jul 13, 2014 at 04:25:06PM +0200, Lars-Peter Clausen wrote: >> On 07/13/2014 04:03 PM, Richard Weinberger wrote: >>> Am 13.07.2014 15:56, schrieb Lars-Peter Clausen: >>>> On 07/13/2014 03:40 PM, Rich

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Richard Weinberger
Am 13.07.2014 15:56, schrieb Lars-Peter Clausen: > On 07/13/2014 03:40 PM, Richard Weinberger wrote: >> Am 13.07.2014 15:26, schrieb Lars-Peter Clausen: >>> On 07/13/2014 11:45 AM, Richard Weinberger wrote: >>>> Am 13.07.2014 11:27, schrieb Lennox Wu: >>>&

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Richard Weinberger
Am 13.07.2014 15:26, schrieb Lars-Peter Clausen: > On 07/13/2014 11:45 AM, Richard Weinberger wrote: >> Am 13.07.2014 11:27, schrieb Lennox Wu: >>> As I said before, some configurations don't make sense. >> >> If such a configuration can be achieved using allm

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-13 Thread Richard Weinberger
Am 13.07.2014 11:27, schrieb Lennox Wu: > As I said before, some configurations don't make sense. If such a configuration can be achieved using allmod/yesconfig it has to be fixed. Chen's fixes seem reasonable as not all architectures support iomem. Thanks, //richard

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-12 Thread Richard Weinberger
On Thu, Jul 10, 2014 at 12:33 PM, Richard Weinberger wrote: > On Wed, Jul 9, 2014 at 8:51 PM, KY Srinivasan wrote: >> >> >>> -Original Message- >>> From: Christoph Hellwig [mailto:h...@infradead.org] >>> Sent: Wednesday, July 9, 2014 1:44

Re: [PATCH 6/8] Drivers: scsi: storvsc: Implement an abort handler

2014-07-10 Thread Richard Weinberger
On Wed, Jul 9, 2014 at 8:51 PM, KY Srinivasan wrote: > > >> -Original Message- >> From: Christoph Hellwig [mailto:h...@infradead.org] >> Sent: Wednesday, July 9, 2014 1:44 AM >> To: KY Srinivasan >> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; >> oher...@suse.com; jbotto

[PATCH v3] hyperv: Add netpoll support

2014-07-09 Thread Richard Weinberger
In order to have at least a netconsole to debug kernel issues on Windows Azure this patch implements netpoll support. Sending packets is easy, netvsc_start_xmit() does already everything needed. Signed-off-by: Richard Weinberger --- drivers/net/hyperv/netvsc_drv.c | 11 +++ 1 file

Re: [PATCH v2] hyperv: Add netpoll support

2014-07-09 Thread Richard Weinberger
Am 09.07.2014 16:13, schrieb Sergei Shtylyov: > Hello. > > On 07/09/2014 11:58 AM, Richard Weinberger wrote: > >> In order to have at least a netconsole to debug kernel issues on >> Windows Azure this patch implements netpoll support. >> Sending packets is easy, ne

Re: [PATCH] hyperv: Add netpoll support

2014-07-09 Thread Richard Weinberger
Am 09.07.2014 01:43, schrieb Francois Romieu: > Richard Weinberger : >> Am 09.07.2014 00:47, schrieb Francois Romieu: > [...] >>> What are you taking about ? netconsole does not need to receive. >> >> Isn't netconsole is only one user of netpoll ? >

[PATCH v2] hyperv: Add netpoll support

2014-07-09 Thread Richard Weinberger
In order to have at least a netconsole to debug kernel issues on Windows Azure this patch implements netpoll support. Sending packets is easy, netvsc_start_xmit() does already everything needed. Signed-off-by: Richard Weinberger --- drivers/net/hyperv/netvsc_drv.c | 11 +++ 1 file

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
Am 09.07.2014 00:47, schrieb Francois Romieu: > Richard Weinberger : > [...] >> This won't work as netpoll runs with IRQs disabled. >> ->ndo_poll_controller() has to make sure that SKBs can be received and >> transmitted >> while IRQs are off. I thought call

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
Am 09.07.2014 00:47, schrieb Francois Romieu: > Richard Weinberger : > [...] >> This won't work as netpoll runs with IRQs disabled. >> ->ndo_poll_controller() has to make sure that SKBs can be received and >> transmitted >> while IRQs are off. I thought call

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
Am 08.07.2014 22:03, schrieb KY Srinivasan: > The VCPU the channel is bound to is available in the channel state. You could > use the following code > Fragment to ensure that the call is made on the "right" cpu: > > smp_call_function_single(dev->channel->target_cpu, >

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
Am 08.07.2014 19:55, schrieb Haiyang Zhang: > > >> -Original Message----- >> From: Richard Weinberger [mailto:rich...@nod.at] >> Sent: Tuesday, July 8, 2014 5:32 AM >> To: KY Srinivasan; Haiyang Zhang >> Cc: de...@linuxdriverproject.org; n

Re: [PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
Am 08.07.2014 20:01, schrieb KY Srinivasan: > > >> -Original Message----- >> From: Richard Weinberger [mailto:rich...@nod.at] >> Sent: Tuesday, July 8, 2014 2:32 AM >> To: KY Srinivasan; Haiyang Zhang >> Cc: de...@linuxdriverproject.org; n

[PATCH] hyperv: Add netpoll support

2014-07-08 Thread Richard Weinberger
(). Signed-off-by: Richard Weinberger --- drivers/net/hyperv/netvsc_drv.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 4fd71b7..367b71e 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv

[PATCH] staging/rtl8821ae: Fix OOM handling in _rtl_init_deferred_work()

2014-03-20 Thread Richard Weinberger
alloc_workqueue() can fail, handle this case. Signed-off-by: Richard Weinberger --- drivers/staging/rtl8821ae/base.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8821ae/base.c b/drivers/staging/rtl8821ae/base.c index fce9c3f..8dbe13c 100644

[PATCH] staging/xillybus: Handle OOM in xillybus_init()

2014-03-18 Thread Richard Weinberger
alloc_workqueue() can fail and returns NULL in case of OOM. Handle this case and undo class_create(). Signed-off-by: Richard Weinberger --- drivers/staging/xillybus/xillybus_core.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/xillybus/xillybus_core.c

Re: [PATCH 20/28] Remove OMAP_PM_SRF

2014-02-09 Thread Richard Weinberger
Am 09.02.2014 20:55, schrieb Paul Bolle: > On Sun, 2014-02-09 at 19:47 +0100, Richard Weinberger wrote: >> The symbol is an orphan, get rid of it. >> >> Signed-off-by: Richard Weinberger >> --- >> drivers/staging/tidspbridge/Kconfig | 2 +- >> 1 f

[PATCH 20/28] Remove OMAP_PM_SRF

2014-02-09 Thread Richard Weinberger
The symbol is an orphan, get rid of it. Signed-off-by: Richard Weinberger --- drivers/staging/tidspbridge/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/tidspbridge/Kconfig b/drivers/staging/tidspbridge/Kconfig index 1b6d581..b5e74e9 100644 --- a

[PATCH 7/7] staging,lpc32xx_adc: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/built-in.o: In function `lpc32xx_adc_probe': drivers/staging/iio/adc/lpc32xx_adc.c:149: undefined reference to `devm_ioremap' Signed-off-by: Richard Weinberger --

[PATCH 6/7] power,goldfish: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/built-in.o: In function `goldfish_battery_probe': drivers/power/goldfish_battery.c:181: undefined reference to `devm_ioremap' Signed-off-by: Richard Weinberger --

[PATCH 5/7] net,marvell: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/built-in.o: In function `orion_mdio_probe': drivers/net/ethernet/marvell/mvmdio.c:228: undefined reference to `devm_ioremap' Signed-off-by: Richard Weinberger --

[PATCH 2/7] staging,dgap: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
-function-declaration] drivers/staging/dgap/dgap_driver.c: In function ‘dgap_do_remap’: drivers/staging/dgap/dgap_driver.c:694:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] Signed-off-by: Richard Weinberger --- drivers/staging/dgap/Kconfig | 2 +- 1

[PATCH 1/7] ptp_pch: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
/ptp_pch.c: In function ‘pch_probe’: drivers/ptp/ptp_pch.c:621:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] Signed-off-by: Richard Weinberger --- drivers/ptp/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ptp/Kconfig b/drivers/ptp

[PATCH 3/7] staging,spear_adc: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
-function-declaration Signed-off-by: Richard Weinberger --- drivers/staging/iio/adc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig index e3d6430..7d5d675 100644 --- a/drivers/staging/iio/adc/Kconfig +++ b/drivers/staging

[PATCH 4/7] phy,exynos: Add dependency on HAS_IOMEM

2014-01-14 Thread Richard Weinberger
On archs like S390 or um this driver cannot build nor work. Make it depend on HAS_IOMEM to bypass build failures. drivers/built-in.o: In function `exynos_mipi_video_phy_probe': drivers/phy/phy-exynos-mipi-video.c:130: undefined reference to `devm_ioremap_resource' Signed-off-b

Re: [PATCH 1/2] staging: octeon-ethernet: don't assume that CPU 0 is special

2013-09-28 Thread Richard Weinberger
Am 28.09.2013 21:50, schrieb Aaro Koskinen: > Currently the driver assumes that CPU 0 is handling all the hard IRQs. > This is wrong in Linux SMP systems where user is allowed to assign to > hardware IRQs to any CPU. The driver will stop working if user sets > smp_affinity so that interrupts end up

Re: [PATCH 1/2] staging: octeon-ethernet: don't assume that CPU 0 is special

2013-09-28 Thread Richard Weinberger
Am 28.09.2013 21:50, schrieb Aaro Koskinen: > Currently the driver assumes that CPU 0 is handling all the hard IRQs. > This is wrong in Linux SMP systems where user is allowed to assign to > hardware IRQs to any CPU. The driver will stop working if user sets > smp_affinity so that interrupts end up