On Fri, Sep 28, 2018 at 10:20:55AM +, Ioana Ciocoi Radulescu wrote:
> Generally speaking, I think it's better to remove unused code from the current
> driver and re-add it along with the feature actually using it.
+1
Thanks,
Richard
___
devel mailin
On Wed, Apr 25, 2018 at 05:17:49PM +0800, Yangbo Lu wrote:
> +/* PTP nominal frequency 1GHz */
> +#define DPAA2_PTP_NOMINAL_FREQ_PERIOD_NS 1
Nit: Frequency is the inverse of the period. It can be one or the
other, not both.
Why not call it simply DPAA2_PTP_CLK_PERIOD_NS?
You haven't implemente
On Mon, Apr 23, 2018 at 02:28:09AM +, Y.b. Lu wrote:
> Actually I will send the timestamping support patch for
> drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c.
> Since the 1588 timer module had been initialized in MC firmware, the
> timestamping support and the clock driver will not depend o
On Sat, Apr 21, 2018 at 07:41:35AM +0300, Dan Carpenter wrote:
> On Fri, Apr 20, 2018 at 02:01:25PM -0700, Richard Cochran wrote:
> > On Thu, Apr 19, 2018 at 01:40:08PM +0300, Dan Carpenter wrote:
> > > This driver seems nice and so far as I can see it doesn't need to be i
On Thu, Apr 19, 2018 at 01:40:08PM +0300, Dan Carpenter wrote:
> This driver seems nice and so far as I can see it doesn't need to be in
> staging once we get the other parts merged.
Please explain how this unit ties in with the MAC units.
Thanks,
Richard
___
On Fri, Jan 13, 2017 at 02:05:43PM +0100, Vitaly Kuznetsov wrote:
> Instead of doing in-kernel time adjustments offload the work to an
> NTP client by exposing TimeSync messages as a PTP device. Users my now
> decide what they want to use as a source.
>
> I tested the solution with chrony, the con
On Mon, Oct 20, 2014 at 11:02:13PM -0500, Jeff Epler wrote:
> It's interesting to imagine that a virtualization host could present a
> time service to the guest *userspace*, even when the guest is not
> otherwise exposed to the internet at large. This could take the form of
> an NTP server on a pr
On Tue, Oct 21, 2014 at 03:18:58AM +, Thomas Shao wrote:
>
> In some situation, the user is not able to enable guest VM to sync with
> external
> time source, like NTP. But the host is still synced with a trusted time
> source.
But the guest *is* networked, right?
(Otherwise syncing the
On Wed, Oct 15, 2014 at 09:21:33AM +, Thomas Shao wrote:
>
> In V2, I address all the Dan's comments.
It is customary to detail the changes in each patch series revision,
in order to make things easier for the reviewers.
Thanks,
Richard
___
devel m
On Wed, Oct 15, 2014 at 01:40:04AM -0700, Thomas Shao wrote:
> In current hyper-v time sync service,it only gets the initial clock time
> from the host. It didn't process the following time samples. This change
> introduced a module parameter called host_time_sync. If it is set to true,
> the guest
You really need to put John Stultz onto CC.
Thanks,
Richard
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Oct 14, 2014 at 04:33:46PM +0200, Richard Cochran wrote:
>
> IMHO, you should let the guest steer its own clock. That gives the end
> user the most flexibility. Just provide the offset information, and
> let a dedicated service (like ntpd or linuxptp's phc2sys) do th
On Tue, Oct 14, 2014 at 03:14:21PM +0100, Mike Surcouf wrote:
> Even with networking I think there are other senarios where this would
> be useful such as no access to an NTP server due to firewall rules or
> no internal NTP or simply an admin without much knowledge of NTP.
Perhaps, but ...
> Hy
Maybe John Stultz should also go onto CC.
Thanks,
Richard
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Oct 14, 2014 at 02:16:34PM +0100, Mike Surcouf wrote:
> What is your expected value for TICK_USEC? I cant make the arithmetic work.
> You double the check time if you are close but you never reduce the
> check time if you are not.
> Adjusting the tick count is a coarse adjustment of the cl
On Tue, Oct 14, 2014 at 01:04:35PM +, Thomas Shao wrote:
> > I really don't see the need for this. We have NTP. If the guests want to,
> > they
> > may use it. Otherwise, they have a free running clock, just like real
> > machines.
> >
> Sometimes the user can't setup NTP. For example the gu
On Tue, Oct 14, 2014 at 01:04:35PM +, Thomas Shao wrote:
> > > + /*
> > > + * Use the Hyper-V time sample to adjust the guest time. The
> > > + * algorithm is: If the sample offsets exceeds 1 second, we
> > > + * directly set the clock to the server time. If the
On Tue, Oct 14, 2014 at 04:11:18AM -0700, Thomas Shao wrote:
> In current hyper-v time sync service,it only gets the initial clock time
> from the host. It didn't process the following time samples. This change
> introduced a module parameter called host_time_sync. If it is set to true,
> the guest
18 matches
Mail list logo
