[PATCH] staging/goldfish/goldfish_audio: Fix annotations

2015-03-16 Thread Ricardo Ribalda Delgado
spaces) drivers/staging/goldfish/goldfish_audio.c:296:27:expected char [noderef] *buffer_virt drivers/staging/goldfish/goldfish_audio.c:296:27:got void * Signed-off-by: Ricardo Ribalda Delgado --- drivers/staging/goldfish/goldfish_audio.c | 10 +- 1 file changed, 5 insertions

Re: [PATCH] staging/sm75fb: Declare static functions as such

2015-03-16 Thread Ricardo Ribalda Delgado
; convention is always to use colons in subject lines. About the typo, you are right of course :) Regarding the colon, there is no convention about that, every subsystem has its own preference. I prefer / than : I agree that is your patch that should be pulled, not this one. But I think you s

[PATCH] staging/sm75fb: Declare static functions as such

2015-03-16 Thread Ricardo Ribalda Delgado
ivers/staging/sm750fb/ddk750_swi2c.c:361:6: warning: symbol 'swI2CInit_SM750LE' was not declared. Should it be static? Signed-off-by: Ricardo Ribalda Delgado --- drivers/staging/sm750fb/ddk750_swi2c.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a

[PATCH v2 2/2] staging/unisys/visorutil/procobjecttree: Replace typedef

2015-02-02 Thread Ricardo Ribalda Delgado
Instead of declaring a new type, define a new struct. Signed-off-by: Ricardo Ribalda Delgado --- v2: Suggested by Joe Perches Replace unnecessary casting. drivers/staging/unisys/visorutil/procobjecttree.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a

[PATCH 0/2] Code Styte

2015-02-02 Thread Ricardo Ribalda Delgado
Fix minor code stype problems found by checkpatch.pl Ricardo Ribalda Delgado (2): staging/unisys/visorutil/procobjecttree: Code Style staging/unisys/visorutil/procobjecttree: Replace typedef drivers/staging/unisys/visorutil/procobjecttree.c | 23 +-- 1 file changed, 13

[PATCH 2/2] staging/unisys/visorutil/procobjecttree: Replace typedef

2015-02-02 Thread Ricardo Ribalda Delgado
Instead of declaring a new type, define a new struct. Signed-off-by: Ricardo Ribalda Delgado --- drivers/staging/unisys/visorutil/procobjecttree.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/staging/unisys/visorutil/procobjecttree.c b/drivers

[PATCH 1/2] staging/unisys/visorutil/procobjecttree: Code Style

2015-02-02 Thread Ricardo Ribalda Delgado
Lines should not be over 80 characters Signed-off-by: Ricardo Ribalda Delgado --- drivers/staging/unisys/visorutil/procobjecttree.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/unisys/visorutil/procobjecttree.c b/drivers/staging/unisys