Re: [staging:staging-testing 54/54] drivers/staging/r8188eu/core/rtw_pwrctrl.c:400:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false

On Sat, Jul 30, 2022 at 01:08:23PM +0200, Greg Kroah-Hartman wrote: > On Sat, Jul 30, 2022 at 04:14:57PM +0800, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > staging-testing > > head: f3a76018dd55d8ddcd28cb47049f46ae5c0ce557 > > commi

Re: [PATCH 0/6] staging: rtl8723bs: remove DBG_COUNTER

On Tue, Feb 16, 2021 at 12:24:38PM +0300, Dan Carpenter wrote: > Looks good. > > Reviewed-by: Dan Carpenter > > regards, > dan carpenter > Thank you Dan. Regards, Phil ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverp

[PATCH 4/6] staging: rtl8723bs: remove DBG_COUNTER calls from core/rtw_recv.c

Remove all DBG_COUNTER macro calls from core/rtw_recv.c, as the corresponding variables are only ever written to and not used. This makes the code cleaner, and is necessary prior to removing the DBG_COUNTER definition itself. Signed-off-by: Phillip Potter --- drivers/staging/rtl8723bs/core

[PATCH 5/6] staging: rtl8723bs: remove DBG_COUNTER definition from rtw_debug.h

Remove DBG_COUNTER macro definition from include/rtw_debug.h, as all uses of it have now been removed and it is no longer required. The DBG_COUNTER incremented values were never actually used anywhere else in the driver. Signed-off-by: Phillip Potter --- drivers/staging/rtl8723bs/include

[PATCH 6/6] staging: rtl8723bs: remove rx_logs/tx_logs/int_logs from drv_types.h

DBG_COUNTER macro, which has also been removed. Signed-off-by: Phillip Potter --- drivers/staging/rtl8723bs/include/drv_types.h | 131 -- 1 file changed, 131 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h

[PATCH 2/6] staging: rtl8723bs: remove DBG_COUNTER calls from os_dep/xmit_linux.c

Remove all DBG_COUNTER macro calls from os_dep/xmit_linux.c, as the corresponding variables are only ever written to and not used. This makes the code cleaner, and is necessary prior to removing the DBG_COUNTER definition itself. Signed-off-by: Phillip Potter --- drivers/staging/rtl8723bs

[PATCH 3/6] staging: rtl8723bs: remove DBG_COUNTER calls from core/rtw_xmit.c

Remove all DBG_COUNTER macro calls from core/rtw_xmit.c, as the corresponding variables are only ever written to and not used. This makes the code cleaner, and is necessary prior to removing the DBG_COUNTER definition itself. Signed-off-by: Phillip Potter --- drivers/staging/rtl8723bs/core

[PATCH 0/6] staging: rtl8723bs: remove DBG_COUNTER

the codebase as well. These are inside a CONFIG_DBG_COUNTER preprocessor ifdef, and the only thing that was using them was the aforementioned DBG_COUNTER calls. Removing this code goes some way towards cleaning up this driver, and is therefore worth doing. Phillip Potter (6): staging: rtl8723bs

[PATCH 1/6] staging: rtl8723bs: remove DBG_COUNTER calls from os_dep/recv_linux.c

Remove all DBG_COUNTER macro calls from os_dep/recv_linux.c, as the corresponding variables are only ever written to and not used. This makes the code cleaner, and is necessary prior to removing the DBG_COUNTER definition itself. Signed-off-by: Phillip Potter --- drivers/staging/rtl8723bs

Re: [PATCH] staging: rtl8723bs: cleanup macros within include/rtw_debug.h

> > So I'm in the process of stripping out _dbgdump entirely as per Greg > > K-H's suggestion - am I to understand raw printk is frowned upon though, > > even with the correct KERN_x level specified? > > Yes. Ideally in drivers everything would use dev_dbg() and dev_err() or > whatever. But it's

Re: [PATCH] staging: rtl8723bs: cleanup macros within include/rtw_debug.h

On Wed, Feb 10, 2021 at 09:40:27PM +0300, Dan Carpenter wrote: > On Wed, Feb 10, 2021 at 05:00:03PM +0000, Phillip Potter wrote: > > Remove do/while loops from DBG_871X, MSG_8192C and DBG_8192C. > > I'm pretty hip to checkpatch.pl warnings, but I had forgotten what the &g

Re: [PATCH] staging: rtl8723bs: cleanup macros within include/rtw_debug.h

On Wed, Feb 10, 2021 at 06:12:54PM +0100, Greg KH wrote: > On Wed, Feb 10, 2021 at 05:00:03PM +0000, Phillip Potter wrote: > > Remove do/while loops from DBG_871X, MSG_8192C and DBG_8192C. Also > > fix opening brace placements and trailing single statement layout within > > R

[PATCH] staging: rtl8723bs: remove blank line from include/autoconf.h

Remove additional blank line from include/autoconf.h, fixes one checkpatch check notice. Signed-off-by: Phillip Potter --- drivers/staging/rtl8723bs/include/autoconf.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/include/autoconf.h b/drivers/staging/rtl8723bs

[PATCH] staging: rtl8723bs: cleanup macros within include/rtw_debug.h

definition. This fixes 3 checkpatch warnings, 5 checkpatch errors and 3 checkpatch checks. Signed-off-by: Phillip Potter --- drivers/staging/rtl8723bs/include/rtw_debug.h | 40 +-- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/drivers/staging/rtl8723bs/include

[PATCH] staging: rtl8723bs: remove typedefs from rtl8723b_recv.h

Remove typedefs from include/rtl8723b_recv.h and convert one usage in hal/rtl8723bs_recv.c to use the actual structure name in its pointer declaration. Fixes two checkpatch warnings. Signed-off-by: Phillip Potter --- drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c| 2 +- drivers/staging

[PATCH] staging: rtl8723bs: fix blank lines and comments in rtl8723b_hal.h

Remove unnecessary blank line, and move close of multiple-line comments to their own trailing lines. This fixes four checkpatch warnings and one checkpatch check notice for the include/rtl8723b_hal.h file. Signed-off-by: Phillip Potter --- drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 13

[PATCH] staging: rtl8723bs: fix braces for os_dep/mlme_linux.c

Add braces to both branches of an if block for consistency, and also remove braces from a single line for loop. Fixes a checkpatch check and warning, thus clearing this file of any brace check/warning notices. Signed-off-by: Phillip Potter --- drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 6

[PATCH] staging: rtl8723bs: remove braces from two single line if blocks

-off-by: Phillip Potter --- drivers/staging/rtl8723bs/include/rtw_mlme.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme.h b/drivers/staging/rtl8723bs/include/rtw_mlme.h index ea0dd156051e..d8655cb619a1 100644 --- a/drivers/staging

Re: [PATCH] staging: octeon: remove braces from single-line block

On Mon, Feb 08, 2021 at 08:14:02AM +0100, Alexander Sverdlin wrote: > Hi! > > On 06/02/2021 21:17, Phillip Potter wrote: > > This removes the braces from the if statement that checks the > > physical node return value in cvm_oct_phy_setup_device, as this > > block

[PATCH] staging: rtl8192e: remove braces from single-line block

This removes the braces from the if statement that checks the wps_ie_len and ieee->wps_ie values in rtllib_association_req of rtllib_softmac.c as this block contains only one statement. Fixes a checkpatch warning. Signed-off-by: Phillip Potter --- drivers/staging/rtl8192e/rtllib_softmac.c

[PATCH] staging: rtl8192e: replace spaces with tab for a closing if brace

Remove spaces preceding closing brace of one of the nested if statement blocks inside the rtl92e_leisure_ps_leave function, and replace with a tab, to align it properly with the start of the block. Fixes a checkpatch warning. Signed-off-by: Phillip Potter --- drivers/staging/rtl8192e/rtl8192e

Re: [PATCH v2] staging: octeon: convert all uses of strlcpy to strscpy in ethernet-mdio.c

On Sun, Feb 07, 2021 at 04:35:06PM +0100, Greg KH wrote: > On Sun, Feb 07, 2021 at 03:13:20PM +0000, Phillip Potter wrote: > > Convert three calls to strlcpy inside the cvm_oct_get_drvinfo function > > to strscpy calls. As return values were not checked for these three > >

[PATCH v2] staging: octeon: convert all uses of strlcpy to strscpy in ethernet-mdio.c

Convert three calls to strlcpy inside the cvm_oct_get_drvinfo function to strscpy calls. As return values were not checked for these three calls before, change should be safe as functionality is equivalent. Signed-off-by: Phillip Potter --- v2: Modified changelog to take account of feedback

[PATCH v2] staging: octeon: convert all uses of strlcpy to strscpy in ethernet-mdio.c

Convert three calls to strlcpy inside the cvm_oct_get_drvinfo function to strscpy calls. As return values were not checked for these three calls before, change should be safe as functionality is equivalent. Signed-off-by: Phillip Potter --- drivers/staging/octeon/ethernet-mdio.c | 6 +++--- 1

[PATCH] staging: octeon: convert all uses of strlcpy to strscpy in ethernet-mdio.c

Convert three calls to strlcpy inside the cvm_oct_get_drvinfo function to strscpy calls. Fixes a style warning. Signed-off-by: Phillip Potter --- drivers/staging/octeon/ethernet-mdio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/octeon/ethernet

[PATCH] staging: octeon: remove braces from single-line block

This removes the braces from the if statement that checks the physical node return value in cvm_oct_phy_setup_device, as this block contains only one statement. Fixes a style warning. Signed-off-by: Phillip Potter --- drivers/staging/octeon/ethernet-mdio.c | 3 +-- 1 file changed, 1 insertion

Re: [PATCH] staging: android: ion: Update wording in drivers/staging/android/ion/Kconfig

Yes, sorry, I took that bit out as I wasn’t aware it was important. I will make sure it is included in future patches. Thank you for your response. Regards, Phil Potter >> On 16 Mar 2018, at 17:48, Laura Abbott wrote: >> >> On 03/15/2018 11:13 AM, Phillip Potter wrote: >&

[PATCH] staging: android: ion: Update wording in drivers/staging/android/ion/Kconfig

Changes the usage of the word 'Chose' to 'Choose' in the ION Memory Manager Kconfig. Signed-off-by: Phillip Potter --- --- a/drivers/staging/android/ion/Kconfig +++ b/drivers/staging/android/ion/Kconfig @@ -4,7 +4,7 @@ menuconfig ION select GENERIC_ALLO