[PATCH v2 1/2] Staging: fbtft: Fix probing of gpio descriptor

2019-07-15 Thread Phil Reid
t;Staging: fbtft: Switch to the gpio descriptor interface") Reviewed-by: Nicolas Saenz Julienne Tested-by: Nicolas Saenz Julienne Tested-by: Jan Sebastian Götte Signed-off-by: Phil Reid --- drivers/staging/fbtft/fbtft-core.c | 39 ++ 1 file changed,

[PATCH v2 2/2] Staging: fbtft: Fix reset assertion when using gpio descriptor

2019-07-15 Thread Phil Reid
ötte Signed-off-by: Phil Reid --- drivers/staging/fbtft/fbtft-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index 44b8074..bc75025 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b/drive

[PATCH 0/2] Staging: fbtft: Fix probing of gpio descriptor

2019-07-15 Thread Phil Reid
GPIO probing and reset polarity are broken. Fix them. Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface") Changes from v2: - Add fixes tag to "Fix reset assertion when using gpio descriptor" - Add tested-by / reviewed-by tags Phil Reid (2):

[PATCH 1/2] Staging: fbtft: Fix probing of gpio descriptor

2019-07-11 Thread Phil Reid
t;Staging: fbtft: Switch to the gpio descriptor interface") Signed-off-by: Phil Reid --- drivers/staging/fbtft/fbtft-core.c | 39 ++ 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbt

[PATCH 2/2] Staging: fbtft: Fix reset assertion when using gpio descriptor

2019-07-11 Thread Phil Reid
calls the polarity in the DT was ignored and assumed to be active low. Fix it so that DT polarity is respected. Signed-off-by: Phil Reid --- drivers/staging/fbtft/fbtft-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/s

[PATCH 0/2] Staging: fbtft: Fix probing of gpio descriptor

2019-07-11 Thread Phil Reid
GPIO probing and reset polarity are broken. Fix them. Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor interface") Phil Reid (2): Staging: fbtft: Fix probing of gpio descriptor Staging: fbtft: Fix reset assertion when using gpio descriptor drivers/staging/f

Re: BUG: Staging: fbtft: Switch to the gpio descriptor interface

2019-07-10 Thread Phil Reid
On 10/07/2019 17:05, Nicolas Saenz Julienne wrote: On Wed, 2019-07-10 at 16:31 +0800, Phil Reid wrote: G'day Nishad, I'm just wondering if the commit c440eee1a7a1d0f "Staging: fbtft: Switch to the gpio descriptor interface" was tested on anything. I've had to apply t

BUG: Staging: fbtft: Switch to the gpio descriptor interface

2019-07-10 Thread Phil Reid
G'day Nishad, I'm just wondering if the commit c440eee1a7a1d0f "Staging: fbtft: Switch to the gpio descriptor interface" was tested on anything. I've had to apply the following patch to get my display functioning again. in particular the devm_gpiod_get_index using dev->driver->name for the gpio

Re: [PATCH] staging: iio: adt7316: Fix build errors when GPIOLIB is not set

2019-06-05 Thread Phil Reid
7,6 +7,8 @@ #include #include This should be removed as well. See comment at top of linux/gpio.h +#include +#include #include #include #include -- Regards Phil Reid ___ devel mailing list de...@li

Re: [PATCH 1/3] staging: iio: ad7192: Fix style issue

2019-03-17 Thread Phil Reid
On 18/03/2019 4:53 am, Vladimir Petrigo wrote: Signed-off-by: Vladimir Petrigo --- drivers/staging/iio/adc/ad7192.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c index acdbc07..7c632cf 100644 --- a/drive

Re: [PATCH v2] staging: iio: ad7816: Switch to the gpio descriptor interface

2018-10-18 Thread Phil Reid
ret); return ret; } - gpio_direction_input(chip->busy_pin); The busy pin doesn't exist on the ad7818. Which the driver claims to support in the id table: > static const struct spi_device_id ad7816_id[] = { >{ "ad7816", 0 }, >{ "