[PATCH] staging: gasket: apex: Make structure apex_desc constant

modification. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/gasket/apex_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c index 464648ee2036..2973bb920a26 100644

[PATCH RESEND 1/4] staging: rtl8712: xmitframe_addmic(): Change return values and type

Change return values of xmitframe_addmic from _SUCCESS and _FAIL to 0 and -ENOMEM respectively. Modify call sites to check for non-zero values instead of _FAIL. Also change return type from sint to int. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_xmit.c | 12

[PATCH RESEND 2/4] staging: rtl8712: r8712_append_mpdu_unit(): Change return type

_SUCCESS. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_xmit.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c index 04e70048f0dd..6f1dbcf25859 100644 --- a

[PATCH RESEND 4/4] staging: rtl8712: r8712_dump_aggr_xframe(): Change type to void

Change return type of r8712_dump_aggr_xframe from u8 to void as it always returns _SUCCESS and its return value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_xmit.c | 6 ++ drivers/staging/rtl8712/rtl8712_xmit.h | 4 ++-- 2 files changed, 4 insertions

[PATCH RESEND 3/4] staging: rtl8712: r8712_xmitframe_aggr_1st(): Change return type to void

Change return type of r8712_xmitframe_aggr_1st from u8 to void as it always returns _SUCCESS and its return value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_xmit.c | 6 ++ drivers/staging/rtl8712/rtl8712_xmit.h | 4 ++-- 2 files changed, 4 insertions

Re: [PATCH 01/11] staging: rtl8712: _r8712_init_xmit_priv(): Change return values and type

On 12/08/19 8:07 PM, Greg KH wrote: On Fri, Aug 09, 2019 at 10:53:43AM +0530, Nishka Dasgupta wrote: Change the return values in _r8712_init_xmit_priv from _SUCCESS/_FAIL to 0/-ENOMEM respectively. Change return type from sint to int. Signed-off-by: Nishka Dasgupta I only received 9 patches

[PATCH 07/11] staging: rtl8712: r8712_construct_txaggr_cmd_desc(): Change return type

Change return type of r8712_construct_txaggr_cmd_desc from u8 to void (and remove its return statement) as it always returns _SUCCESS and its return value is never stored, checked or otherwise used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_xmit.c | 4 +--- 1 file

[PATCH 10/11] staging: rtl8712: r8712_xmitframe_aggr_1st(): Change return type to void

Change return type of r8712_xmitframe_aggr_1st from u8 to void as it always returns _SUCCESS and its return value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_xmit.c | 6 ++ drivers/staging/rtl8712/rtl8712_xmit.h | 4 ++-- 2 files changed, 4 insertions

[PATCH 01/11] staging: rtl8712: _r8712_init_xmit_priv(): Change return values and type

Change the return values in _r8712_init_xmit_priv from _SUCCESS/_FAIL to 0/-ENOMEM respectively. Change return type from sint to int. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_xmit.c | 14 +++--- drivers/staging/rtl8712/rtl871x_xmit.h | 4 ++-- 2 files changed

[PATCH 04/11] staging: rtl8712: make_wlanhdr(): Change return values and type

Change return values of make_wlanhdr from _SUCCESS/_FAIL to 0/-EINVAL. Modify call site to check for non-zero return values instead of _FAIL. Change return type from sint to int. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_xmit.c | 10 +- 1 file changed, 5

[PATCH 11/11] staging: rtl8712: r8712_dump_aggr_xframe(): Change type to void

Change return type of r8712_dump_aggr_xframe from u8 to void as it always returns _SUCCESS and its return value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_xmit.c | 6 ++ drivers/staging/rtl8712/rtl8712_xmit.h | 4 ++-- 2 files changed, 4 insertions

[PATCH 08/11] staging: rtl8712: r8712_construct_txaggr_cmd_hdr(): Change return type

Change return type of r8712_construct_txaggr_cmd_hdr from u8 to void as it always returns _SUCCESS and its return value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_xmit.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH 02/11] staging: rtl8712: r8712_update_attrib(): Change return values and type

Change return values of r8712_update_attrib from _SUCCESS and _FAIL to 0 and -ENOMEM or -EINVAL respectively. Modify call site to check for the new failure conditions. Also modify the return type from sint to int. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_xmit.c | 16

[PATCH 05/11] staging: rtl8712: r8712_free_xmitbuf(): Change return type

Change return type of r8712_free_xmitbuf from int to void (and remove its return values) as its return value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_xmit.c | 5 ++--- drivers/staging/rtl8712/rtl871x_xmit.h | 4 ++-- 2 files changed, 4 insertions(+), 5

[PATCH 06/11] staging: rtl8712: r8712_xmit_direct(): Change return type

Change return type of r8712_xmit_direct from int to void as its return value is never used. Remove return statement accordingly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_xmit.c | 3 +-- drivers/staging/rtl8712/rtl871x_xmit.h | 2 +- 2 files changed, 2 insertions(+), 3

[PATCH 10/10] staging: rtl8712: r8712_xmit_classifier(): Change return values and type

Change return values of r8712_xmit_classifier from _SUCCESS and _FAIL to 0 and -EINVAL respectively. Modify call site to check for non-zero return values instead of _FAIL. Change return type from sint to int. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_xmit.c | 2

[PATCH 06/10] staging: rtl8712: init_default_value(): Change return type

Change return type of init_default_value from u8 to void as it always returns _SUCCESS. Remove now-unnecessary return statement. Modify call site to simply call the function. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/os_intfs.c | 6 ++ 1 file changed, 2 insertions(+), 4

[PATCH 01/10] staging: rtl8712: amsdu_to_msdu(): Change return type

the now-removed if-branch Modify call site to call the function amsdu_to_msdu without expecting a return value. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_recv.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8712

[PATCH 02/10] staging: rtl8712: recv_indicatepkt_reorder(): Change return values

Change return values of recv_indicatepkt_reorder from _SUCCESS/_FAIL to 0/-ENOMEM and -EINVAL. Within recv_indicatepkt_reorder, modify comparison to true and use the respective value directly. Modify call site of recv_indicatepkt_reorder to check for the new return values. Signed-off-by: Nishka

[PATCH 09/10] staging: rtl8712: Remove while loop and check_cmd_fifo()

Remove while loop as it only runs while the function check_cmd_fifo returns _FAIL, whereas check_cmd_fifo always returns _SUCCESS (and hence this loop will never run). Remove now unused function check_cmd_fifo. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_cmd.c | 12

[PATCH 08/10] staging: rtl8712: r8712_free_drv_sw(): Change return type

Change return type of r8712_free_drv_sw from u8 to void and remove its return statement as it always returns the same value (_SUCCESS) and even this value is never stored, checked or otherwise used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/os_intfs.c | 3 +-- drivers/staging

[PATCH 03/10] staging: rtl8712: r8712_wlanhdr_to_ethhdr(): Change return values

match its prototype in corresponding .h file. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_recv.c | 4 ++-- drivers/staging/rtl8712/rtl871x_recv.c | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers

[PATCH 05/10] staging: rtl8712: recvbuf2recvframe(): Change return type

Change return type of recvbuf2recvframe from int to void as its return value is never used. Modify or remove return statements accordingly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_recv.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a

[PATCH 04/10] staging: rtl8712: r8712_recv_entry(): Change return type

Change return type of r8712_recv_entry from s32 to void as its return value is never used. Modify or remove return statements accordingly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/recv_osdep.h | 2 +- drivers/staging/rtl8712/rtl871x_recv.c | 5 ++--- 2 files changed, 3

[PATCH 07/10] staging: rtl8712: init_drv_sw(): Change return values

Change return values of init_drv_sw from _SUCCESS and _FAIL to 0 and -ENOMEM. Change return type from u8 to int to allow this. Add a return variable to streamline return of error codes of called functions. Modify call site to check for non-zero return value instead of _FAIL. Signed-off-by: Nishka

[PATCH 4/9] staging: rtl8712: r8712_os_recvbuf_resource_alloc(): Change return values

: Nishka Dasgupta --- drivers/staging/rtl8712/recv_linux.c | 4 ++-- drivers/staging/rtl8712/rtl8712_recv.c | 6 ++ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8712/recv_linux.c b/drivers/staging/rtl8712/recv_linux.c index aaa77823115a..682f5b2802ee

[PATCH 6/9] staging: rtl8712: r8712_tkip_decrypt(): Change return type

Change return type of r8712_tkip_decrypt from u8 to void as the return value is never used. Modify or remove return statements accordingly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_security.c | 12 ++-- drivers/staging/rtl8712/rtl871x_security.h | 2 +- 2

[PATCH 5/9] staging: rtl8712: r8712_os_recvbuf_resource_free(): Change return type

Change return type of r8712_os_recvbuf_resource_free from int to void as it always returns _SUCCESS and this return value is never stored, checked or otherwise used. Remove return statement accordingly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/recv_linux.c | 5 ++--- drivers

[PATCH 2/9] staging: rtl8712: _r8712_init_recv_priv(): Change return type

Change return type of _r8712_init_recv_priv as its return value is never checked or used. Modify return statements accordingly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/recv_osdep.h | 2 +- drivers/staging/rtl8712/rtl871x_recv.c | 6 +++--- 2 files changed, 4 insertions

[PATCH 1/9] staging: rtl8712: r8712_os_recv_resource_alloc(): Change return type

Change return type of function r8712_os_recv_resource_alloc from int to void as its return value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/recv_linux.c | 5 ++--- drivers/staging/rtl8712/recv_osdep.h | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions

[PATCH 8/9] staging: rtl8712: aes_decipher(): Change return type

Change return type of aes_decipher from sint to void as it always returns _SUCCESS and this value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_security.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8712

[PATCH 7/9] staging: rtl8712: aes_cipher(): Change return type

Change return type of aes_cipher from sint to void as it always returns _SUCCESS and its return value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_security.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8712

[PATCH 3/9] staging: rtl8712: r8712_init_recv_priv(): Change return type

Change return type of r8712_init_recv_priv from int to void as its return value is never used. Remove return statements accordingly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/recv_osdep.h | 4 ++-- drivers/staging/rtl8712/rtl8712_recv.c | 3 +-- 2 files changed, 3 insertions

[PATCH 9/9] staging: rtl8712: r8712_aes_decrypt(): Change return type

Change return type of r8712_aes_decrypt from u8 to void as its return value is never checked. Modify return statements accordingly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_security.c | 7 ++- drivers/staging/rtl8712/rtl871x_security.h | 2 +- 2 files changed, 3

[PATCH 2/4] staging: rtl8723bs: Change return type of hal_btcoex_IsBtControlLps()

Change return type of hal_btcoex_IsBtControlLps from u8 to bool as it only returns boolean values. Change comparison to false within this function; check the boolean variable directly instead. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ++-- drivers

[PATCH 3/4] staging: rtl8723bs: Change return type of hal_btcoex_IsLpsOn()

Change return type of hal_btcoex_IsLpsOn from u8 to bool as the function only returns boolean values. Modify a comparison of a boolean value to false to instead check that boolean value directly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ++-- drivers

[PATCH 1/4] staging: rtl8723bs: Change return type of hal_btcoex_IsBtExist()

Change return type of hal_btcoex_IsBtExist from u8 to bool as its only possible return values are true and false. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +- drivers/staging/rtl8723bs/include/hal_btcoex.h | 2 +- 2 files changed, 2 insertions(+), 2

[PATCH 4/4] staging: rtl8723bs: Replace hal_btcoex_Initialize()

function parameter of new hal_btcoex_Initialize. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h | 1 - drivers/staging/rtl8723bs/hal/hal_btcoex.c | 16 ++-- drivers/staging/rtl8723bs/include/hal_btcoex.h | 2 +- drivers/staging/rtl8723bs/os_dep

[PATCH] staging: wlan-ng: Remove function prism2mib_excludeunencrypted()

Remove function prism2mib_excludeunencrypted as all it does is call prism2mib_flag. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/wlan-ng/prism2mib.c | 44 + 1 file changed, 1 insertion(+), 43 deletions

[PATCH 9/9] staging: rtl8723bs: Remove unused function prototype ODM_SetAntenna()

Remove unused function prototype ODM_SetAntenna. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/odm.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h index 6ba77bb70889..fba3b9e1491b 100644 --- a

[PATCH 8/9] staging: rtl8723bs: Replace function ODM_TXPowerTrackingCheck()

Remove function ODM_TXPowerTrackingCheck as all it does is call odm_TXPowerTrackingCheckCE. Rename odm_TXPowerTrackingCheckCE to ODM_TXPowerTrackingCheck to maintain compatibility with call site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/odm.c

[PATCH 3/9] staging: rtl8723bs: hal: Replace function PHY_GetTxPowerIndex()

Remove function PHY_GetTxPowerIndex as it does nothing except call PHY_GetTxPowerIndex_8723B. Rename PHY_GetTxPowerIndex_8723B to PHY_GetTxPowerIndex to maintain compatibility with call site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal

[PATCH 7/9] staging: rtl8723bs: Replace function odm_TXPowerTrackingInit()

Remove function odm_TXPowerTrackingInit as all it does is call odm_TXPowerTrackingThermalMeterInit. Rename odm_TXPowerTrackingThermalMeterInit to odm_TXPowerTrackingInit to maintain compatibility with call sites. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging

[PATCH 6/9] staging: rtl8723bs: Replace function beacon_timing_control()

Remove function beacon_timing_control as it does nothing except call rtw_hal_bcn_related_reg_setting. Rename rtw_hal_bcn_related_reg_setting to beacon_timing_control to maintain compatibility with call site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging

[PATCH 5/9] staging: rtl8723bs: hal: Replace function rtl8723b_set_ap_wowlan_cmd()

Remove function rtl8723b_set_ap_wowlan_cmd as all it does is call rtl8723b_set_AP_FwWoWlanRelated_cmd. Rename rtl8723b_set_AP_FwWoWlanRelated_cmd to rtl8723b_set_ap_wowlan_cmd to maintain compatibility with call site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers

[PATCH 2/9] staging: rtl8723bs: hal: Replace function PHY_SetTxPowerIndex()

Remove function PHY_SetTxPowerIndex as it does nothing except call PHY_SetTxPowerIndex_8723B. Rename PHY_SetTxPowerIndex_8723B to PHY_SetTxPowerIndex to maintain compatibility with call site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal

[PATCH 1/9] staging: rtl8723bs: rtw_pwrctrl: Change true/false checks

Change comparisons to true to the variable itself. Change comparisons to false to the negation of the variable. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 117 +-- 1 file changed, 54 insertions(+), 63 deletions(-) diff --git a/drivers

[PATCH 4/9] staging: rtl8723bs: hal: Replace function rtl8723b_set_wowlan_cmd()

Remove function rtl8723b_set_wowlan_cmd as all it does is call rtl8723b_set_FwWoWlanRelated_cmd. Rename rtl8723b_set_FwWoWlanRelated_cmd to rtl8723b_set_wowlan_cmd to maintain compatibility with call site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs

[PATCH] staging: comedi: daqboard2000: Remove function db2k_initialize_dac()

Remove function db2k_initialize_dac as all it does is call db2k_dac_disarm. Modify call site accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/comedi/drivers/daqboard2000.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a

Re: [PATCH v2] staging: media: sunxi: Add bool cast to value

On 22/07/19 5:54 PM, Paul Kocialkowski wrote: Hi, On Mon 22 Jul 19, 12:12, Jeremy Sowden wrote: On 2019-07-22, at 11:36:51 +0530, Nishka Dasgupta wrote: Typecast as bool the return value of cedrus_find_format in cedrus_check_format as the return value of cedrus_check_format is always treated

[PATCH 5/8] staging: rtl8712: init_mp_priv(): Change return values

Change return values of init_mp_priv from _SUCCESS/_FAIL to 0/-ENOMEM respectively. Remove label that returns the required value and return the values directly as they are set. Consequently remove now-unnecessary return variable. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712

[PATCH 1/8] staging: rtl8712: r8712_init_mlme_priv(): Change return values

Change return values of r8712_init_mlme_priv from _SUCCESS/_FAIL to 0/-ENOMEM respectively. Modify call site accordingly. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/os_intfs.c | 2 +- drivers/staging/rtl8712/rtl871x_mlme.c | 4 ++-- 2 files changed, 3 insertions(+), 3

[PATCH 2/8] staging: rtl8712: r8712_set_auth(): Change return values

Change return values of r8712_set_auth from _SUCCESS/_FAIL to 0/-ENOMEM respectively. Modify call site accordingly. Also change return type of the function from sint to int. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_ioctl_set.c | 6 +++--- drivers/staging/rtl8712

[PATCH 8/8] staging: rtl8712: r8712_free_recvframe(): Change return type

Change return type of r8712_free_recvframe from int to void as it always returns _SUCCESS and its return value is never used. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_recv.c | 3 +-- drivers/staging/rtl8712/rtl871x_recv.h | 2 +- 2 files changed, 2 insertions(+), 3

[PATCH 4/8] staging: rtl8712: r8712_register_cmd_alive(): Change return values

Change return values of r8712_register_cmd_alive from _SUCCESS and _FAIL to 0 and -EINVAL. Change the return type of this function from sint to int. Modify its call site to check for 0 instead of _SUCCESS. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_cmd.c | 2

[PATCH 7/8] staging: rtl8712: r8712_init_recvbuf(): Change return type

Change return type of r8712_init_recvbuf from int to void as it always returned _SUCCESS and this return value was never used at any call site. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl8712_recv.c | 3 +-- drivers/staging/rtl8712/rtl8712_recv.h | 2 +- 2 files changed, 2

[PATCH 6/8] staging: rtl8712: r8712_set_802_11_add_wep(): Change return values

to int to accommodate these new return values. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 5 ++--- drivers/staging/rtl8712/rtl871x_ioctl_set.c | 10 -- drivers/staging/rtl8712/rtl871x_ioctl_set.h | 4 ++-- 3 files changed, 8 insertions(+), 11

[PATCH 3/8] staging: rtl8712: r8712_set_key(): Change return values

according to the change in the return values. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8712/rtl871x_ioctl_set.c | 2 +- drivers/staging/rtl8712/rtl871x_mlme.c | 20 ++-- drivers/staging/rtl8712/rtl871x_mlme.h | 4 ++-- 3 files changed, 13 insertions(+), 13

[PATCH RESEND] staging: media: davinci_vpfe: Replace function vpfe_isif_cleanup()

. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- Sorry, I think this may have gotten lost the last time I sent it? .../staging/media/davinci_vpfe/dm365_isif.c | 21 +++ 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/staging/media

[PATCH v2] staging: media: sunxi: Add bool cast to value

Typecast as bool the return value of cedrus_find_format in cedrus_check_format as the return value of cedrus_check_format is always treated like a boolean value. Signed-off-by: Nishka Dasgupta --- Changes in v2: - Add !! to the returned pointer to ensure that the return value is always either

[PATCH] staging: media: sunxi: Add bool cast to value

Typecast as bool the return value of cedrus_find_format in cedrus_check_format as the return value of cedrus_check_format is always treated like a boolean value. Signed-off-by: Nishka Dasgupta --- drivers/staging/media/sunxi/cedrus/cedrus_video.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] staging: mt7621-pci: Add of_node_put() before return

Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return in two places. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta

[PATCH] staging: mt7621-pinctrl: Add of_node_put() before return

Each iteration of for_each_compatible_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Add an of_node_put before the return. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/mt7621

[PATCH] staging: wilc1000: Replace function wilc_wlan_cfg_get_val()

compatibility with call sites (including in wilc_netdev.c). Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/wilc1000/wilc_netdev.c | 1 + drivers/staging/wilc1000/wilc_wlan.c | 5 - drivers/staging/wilc1000/wilc_wlan.h | 2 -- drivers/staging/wilc1000

[PATCH 8/8] staging: rtl8188eu: Replace function rtl88eu_phy_rf_config()

Remove function rtl88eu_phy_rf_config as all it does is call rtl88e_phy_rf6052_config. Rename rtl88e_phy_rf6052_config to rtl88eu_phy_rf_config and change its type from static to non-static to maintain compatibility with call sites. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta

[PATCH 7/8] staging: rtl8188eu: Replace function rtl88e_phy_rf6052_config()

Remove function rtl88e_phy_rf6052_config as all it does is call rf6052_conf_para. Rename rf6052_conf_para to rtl88e_phy_rf6052_config to maintain compatibility with call site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8188eu/hal/rf_cfg.c | 7 +-- 1

[PATCH 5/8] staging: rtl8188eu: Remove function rtw_modular64()

Remove function rtw_modular64 as all it does is call do_div. Replace call to rtw_modular64 with call to do_div. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +- drivers/staging/rtl8188eu/include/osdep_service.h | 2

[PATCH 3/8] staging: rtl8188eu: Replace function beacon_timing_control()

Remove function beacon_timing_control as all it does is call rtw_hal_bcn_related_reg_setting. Rename rtw_hal_bcn_related_reg_setting to beacon_timing_control for compatibility with call sites. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8188eu/core

[PATCH 6/8] staging: rtl8188eu: Replace function rtw_alloc_network()

rtw_alloc_network was static) as this functionality is used in other files as well. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +- drivers/staging/rtl8188eu/core/rtw_mlme.c| 9 ++--- drivers/staging/rtl8188eu/include/rtw_mlme.h | 2

[PATCH 4/8] staging: rtl8188eu: Remove function rtw_os_indicate_scan_done()

-off-by: Nishka Dasgupta --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +- drivers/staging/rtl8188eu/include/mlme_osdep.h | 1 - drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 5 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c

[PATCH 1/8] staging: rtl8188eu: core: Replace function Set_MSR()

Change reference to Set_NETYPE0_MSR to Set_MSR. Replace the contents of Set_MSR with the contents of Set_NETYPE0_MSR as Set_MSR does nothing but call Set_NETYPE0_MSR. Delete Set_NETYPE0_MSR. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8188eu/core

[PATCH 2/8] staging: rtl8188eu: core: Remove function enable_rate_adaptive()

Remove function enable_rate_adaptive as it does nothing except call Update_RA_Entry. Modify call site of enable_rate_adaptive to call Update_RA_Entry instead. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 7 +-- 1 file

[PATCH] staging: erofs: Remove function erofs_kill_sb()

Remove function erofs_kill_sb as all it does is call kill_block_super. Modify references to the former to point to the latter. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/erofs/super.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a

[PATCH 10/10] staging: wlan-ng: Replace function hfa384x_dowmem()

). Remove function hfa384x_dowmem_wait as it does nothing except call hfa384x_dowmem with these extra arguments. Modify call sites of hfa384x_dowmem_wait to call hfa384x_dowmem instead. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/wlan-ng/hfa384x_usb.c | 51

[PATCH 06/10] staging: wlan-ng: Remove function hfa384x_dowmem_async()

Remove unused function hfa384x_dowmem_async. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/wlan-ng/hfa384x_usb.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c

[PATCH 03/10] staging: wlan-ng: Remove function hfa384x_dowrid_async()

Remove function hfa384x_dowrid_async as it does nothing except call hfa384x_dowrid, and itself is called only once. Move the contents of hfa384x_dowrid_async (i.e the call to hfa384x_dowrid) to its call site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/wlan

[PATCH 05/10] staging: wlan-ng: Remove unused function hfa384x_dormem_async()

Remove unused function hfa384x_dormem_async. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/wlan-ng/hfa384x_usb.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index

[PATCH 02/10] staging: wlan-ng: Remove function hfa384x_dowrid_wait()

: Nishka Dasgupta --- drivers/staging/wlan-ng/hfa384x_usb.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 4befc615d8e2..dc6abc654165 100644 --- a/drivers/staging/wlan-ng

[PATCH 01/10] staging: wlan-ng: Remove function hfa384x_dorrid_wait()

Remove function hfa384x_dorrid_wait as it is only called once and it does nothing except call hfa384x_dorrid. Move contents of hfa384x_dorrid_wait to its only call site to maintain functionality. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/wlan-ng

[PATCH 07/10] staging: wlan-ng: Remove unused function hfa384x_docmd_async()

Remove unused function hfa384x_docmd_async. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/wlan-ng/hfa384x_usb.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index

[PATCH 04/10] staging: wlan-ng: Remove unused function hfa384x_dorrid_async()

Remove unused function hfa384x_dorrid_async. Signed-off-by: Nishka Dasgupta --- drivers/staging/wlan-ng/hfa384x_usb.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index 732ffb6aab0b..c1a315bf5a81

[PATCH 09/10] staging: wlan-ng: Replace function hfa384x_dormem()

). Remove function hfa384x_dormem_wait as it does nothing except call hfa384x_dormem with these extra arguments. Modify call sites of hfa384x_dormem_wait to call hfa384x_dormem instead. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/wlan-ng/hfa384x_usb.c | 37

[PATCH 08/10] staging: wlan-ng: Remove function hfa384x_docmd_wait()

Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/wlan-ng/hfa384x_usb.c | 43 +-- 1 file changed, 14 insertions(+), 29 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index ce1a9ee995a0..c469b89948e6

[PATCH 2/3] staging: most: dim2: Remove function dimcb_io_read()

Remove function dimcb_io_read as it does nothing except call inbuilt function readl. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/most/dim2/dim2.c | 9 - drivers/staging/most/dim2/hal.c | 15 --- drivers

[PATCH 1/3] staging: most: dim2: Replace function dim_norm_ctrl_async_buffer_size()

inline to non-static to match the old version. Modify only remaining call site of norm_ctrl_async_buffer_size to call dim_norm_ctrl_async_buffer_size instead. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/most/dim2/hal.c | 9 ++--- 1 file changed, 2

[PATCH 3/3] staging: most: dim2: Remove function dimcb_io_write()

Remove function dimcb_io_write as all it does is call writel. Modify calls to dimcb_io_write to writel, flipping the order of the arguments as required. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/most/dim2/dim2.c | 10 drivers/staging/most/dim2/hal.c

[PATCH] staging: greybus: Replace function gb_i2c_device_setup()

Remove function gb_i2c_device_setup as all it does is call gb_i2c_functionality_operation. Rename gb_i2c_functionality_operation to gb_i2c_device_setup to maintain compatibility with call sites. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/greybus/i2c.c | 22

Re: [PATCH 2/2] staging: media: sunxi: Replace function cedrus_check_format()

On 05/07/19 3:56 PM, Paul Kocialkowski wrote: Hi, On Wed 03 Jul 19, 13:43, Nishka Dasgupta wrote: Remove function cedrus_check_format as all it does is call cedrus_find_format. Rename cedrus_find_format to cedrus_check_format to maintain compatibility with call sites. Issue found with

Re: [PATCH 1/2] staging: media: sunxi: Change return type of cedrus_find_format()

On 05/07/19 3:56 PM, Paul Kocialkowski wrote: Hi, On Wed 03 Jul 19, 13:43, Nishka Dasgupta wrote: Change return type of cedrus_find_format to bool as it is only called once, by a function whose return value is bool, and the return value of cedrus_find_format is returned as-is at the call-site

[PATCH] staging: media: davinci_vpfe: Replace function vpfe_isif_cleanup()

. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- .../staging/media/davinci_vpfe/dm365_isif.c | 21 +++ 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_isif.c b/drivers/staging/media/davinci_vpfe/dm365_isif.c

Re: [PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c

On 03/07/19 2:07 PM, Greg KH wrote: On Wed, Jul 03, 2019 at 01:48:41PM +0530, Nishka Dasgupta wrote: Remove file ion_carveout_heap.c as its functions and definitions are not used anywhere. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/android/ion/Kconfig

[PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c

Remove file ion_carveout_heap.c as its functions and definitions are not used anywhere. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/android/ion/Kconfig | 9 -- drivers/staging/android/ion/Makefile | 1 - .../staging/android/ion

[PATCH 2/2] staging: android: ion: Remove file ion_chunk_heap.c

Remove file ion_chunk_heap.c as its functions and definitions are not used anywhere else. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/android/ion/Kconfig | 9 -- drivers/staging/android/ion/Makefile | 1 - drivers/staging/android/ion

[PATCH 2/2] staging: media: sunxi: Replace function cedrus_check_format()

Remove function cedrus_check_format as all it does is call cedrus_find_format. Rename cedrus_find_format to cedrus_check_format to maintain compatibility with call sites. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/media/sunxi/cedrus/cedrus_video.c | 10

[PATCH 1/2] staging: media: sunxi: Change return type of cedrus_find_format()

Change return type of cedrus_find_format to bool as it is only called once, by a function whose return value is bool, and the return value of cedrus_find_format is returned as-is at the call-site. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/media/sunxi/cedrus

[PATCH 8/9] staging: rtl8723bs: Remove rtw_btcoex_DisplayBtCoexInfo()

Remove function rtw_btcoex_DisplayBtCoexInfo as all it does is call hal_btcoex_DisplayBtCoexInfo. Modify call site accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 5 - drivers/staging/rtl8723bs/core/rtw_debug.c

[PATCH 6/9] staging: rtl8723bs: Remove function rtw_btcoex_SetDBG()

Remove function rtw_btcoex_SetDBG as all it does is call hal_btcoex_setDBG. Modify call sites accordingly. Include the header file for hal_btcoex in the file that now calls hal_btcoex_SetDBG instead of rtw_btcoex_SetDBG. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers

[PATCH 4/9] staging: rtl8723bs: Remove rtw_btcoex_BtInfoNotify()

Remove function rtw_btcoex_BtInfoNotify as it does nothing except call hal_btcoex_BtInfoNotify. Modify call sites accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c | 5 - drivers/staging/rtl8723bs/core/rtw_cmd.c

[PATCH 9/9] staging: rtl8723bs: Change return type of hal_btcoex_IsBtDisabled()

Change return type of hal_btcoex_IsBtDisabled from u8 to bool as the only possible return values are true and false. Where needed, modify accordingly the type of the variables used to store this return value. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2

[PATCH 5/9] staging: rtl8723bs: Remove rtw_btcoex_IsBTCoexCtrlAMPDUSize()

Remove function rtw_btcoex_IsBTCoexCtrlAMPDUSize as it does nothing except call hal_btcoex_IsBTCoexCtrlAMPDUSize. Modify call site accordingly. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_btcoex.c| 9 - drivers/staging/rtl8723bs

  1   2   3   >