Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread Nick Desaulniers
hink we should just add `break`s for those. -- Thanks, ~Nick Desaulniers ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8192u: Remove an unnecessary NULL check

2019-05-21 Thread Nick Desaulniers
rg/onlinedocs/gcc/Zero-Length.html). I wonder if -Wtautological-pointer-compare applies to Flexible Array Members or not (Richard, do you know)? In general, you'd be setting param->u.wpa_ie to the return value of a dynamic memory allocation, no

Re: [PATCH] staging: kpc2000: Use memset to initialize resources

2019-04-24 Thread Nick Desaulniers
gt; cell.platform_data = NULL; > @@ -321,6 +323,8 @@ static int create_dma_engine_core(struct kp2000_device > *pcard, size_t engine_re > cell.name = KP_DRIVER_NAME_DMA_CONTROLLER; > cell.num_resources = 2; > > +memset(&resources, 0, sizeof(resources)); > + Bo

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as used

2019-01-10 Thread Nick Desaulniers
On Wed, Jan 9, 2019 at 11:01 PM Greg KH wrote: > > On Wed, Jan 09, 2019 at 04:19:30PM -0800, Nick Desaulniers wrote: > > Digging up an old thread to point out I was wrong: > > > > On Thu, Sep 27, 2018 at 1:08 PM Nick Desaulniers > > wrote: > > > > Th

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as maybe unused

2018-09-26 Thread Nick Desaulniers
On Wed, Sep 26, 2018 at 11:39 AM Greg KH wrote: > > On Wed, Sep 26, 2018 at 11:28:46AM -0700, Nick Desaulniers wrote: > > On Wed, Sep 26, 2018 at 10:55 AM Nick Desaulniers > > wrote: > > > > > > On Wed, Sep 26, 2018 at 12:41 AM Nathan Chancellor > > >

Re: [PATCH] staging: rtl8723bs: Mark ACPI table declaration as maybe unused

2018-09-26 Thread Nick Desaulniers
On Wed, Sep 26, 2018 at 10:55 AM Nick Desaulniers wrote: > > On Wed, Sep 26, 2018 at 12:41 AM Nathan Chancellor > wrote: > > > > On Wed, Sep 26, 2018 at 09:13:59AM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Sep 26, 2018 at 12:02:09AM -0700, Nathan Chancellor