Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

2016-06-14 Thread Neil Horman
> include/linux/visorbus}/channel_guid.h (100%) > rename {drivers/staging/unisys/include => > include/linux/visorbus}/diagchannel.h (100%) > rename {drivers/staging/unisys/include => > include/linux/visorbus}/guestlinuxdebug.h (100%) > rename {drivers/staging/unisys/in

Re: [PATCH RESEND 00/28] staging: unisys: fix visorbus & visorinput issues raised by tglx

2016-06-14 Thread Neil Horman
us/visorchipset.c | 434 --- > drivers/staging/unisys/visorinput/visorinput.c | 141 +++-- > drivers/staging/unisys/visornic/visornic_main.c| 2 +- > 14 files changed, 879 insertions(+), 1141 deletions(-) > delete mode 100644 drivers/staging/un

Re: [PATCH v3 04/30] staging: unisys: visorbus: remove unused module parameters

2016-06-08 Thread Neil Horman
On Wed, Jun 08, 2016 at 02:42:08PM +, Binder, David Anthony wrote: > > -Original Message- > > From: Neil Horman [mailto:nhor...@redhat.com] > > Sent: Wednesday, June 08, 2016 9:08 AM > > To: Binder, David Anthony > > Cc: Kershner, David A ; cor...@lwn.n

Re: [PATCH v3 04/30] staging: unisys: visorbus: remove unused module parameters

2016-06-08 Thread Neil Horman
On Wed, Jun 08, 2016 at 02:13:47AM +, Binder, David Anthony wrote: > > -Original Message- > > From: Neil Horman [mailto:nhor...@redhat.com] > > Sent: Tuesday, June 07, 2016 9:23 AM > > To: Kershner, David A > > Cc: cor...@lwn.net; t...@linutron

Re: [PATCH v3 11/30] staging: unisys: visorbus: use kernel timer instead of workqueue

2016-06-07 Thread Neil Horman
On Tue, Jun 07, 2016 at 01:47:13PM +, Sell, Timothy C wrote: > > -Original Message- > > From: Neil Horman [mailto:nhor...@redhat.com] > > Sent: Tuesday, June 07, 2016 9:40 AM > > To: Kershner, David A > > Cc: cor...@lwn.net; t...@linutronix.de; mi...@redha

Re: [PATCH v3 11/30] staging: unisys: visorbus: use kernel timer instead of workqueue

2016-06-07 Thread Neil Horman
On Sat, Jun 04, 2016 at 01:27:11PM -0400, David Kershner wrote: > From: Tim Sell > > A kernel timer is now used as the vehicle to periodically call the > channel_interrupt function of registered visor drivers, instead of a > workqueue. > > This simplifies a lot of things by making periodic_work.

Re: [PATCH v3 04/30] staging: unisys: visorbus: remove unused module parameters

2016-06-07 Thread Neil Horman
On Sat, Jun 04, 2016 at 01:27:04PM -0400, David Kershner wrote: > From: David Binder > > Removes unused module parameters from visorbus_main.c, in response to > findings by SonarQube. > > Signed-off-by: David Binder > Signed-off-by: David Kershner > Reviewed-by: Tim Sell > --- > drivers/stag

Re: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-06-02 Thread Neil Horman
On Thu, Jun 02, 2016 at 05:02:11AM +, Sell, Timothy C wrote: > > -Original Message- > > From: Neil Horman [mailto:nhor...@redhat.com] > > Sent: Wednesday, June 01, 2016 2:43 PM > > To: Sell, Timothy C > > Cc: Kershner, David A; cor...@lwn.net; t...@linut

Re: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-06-01 Thread Neil Horman
On Wed, Jun 01, 2016 at 03:09:13PM +, Sell, Timothy C wrote: > > -Original Message- > > From: Neil Horman [mailto:nhor...@redhat.com] > > Sent: Wednesday, June 01, 2016 10:18 AM > > To: Kershner, David A > > Cc: cor...@lwn.net; t...@linutronix.de; mi...@

Re: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-06-01 Thread Neil Horman
On Tue, May 31, 2016 at 10:26:36PM -0400, David Kershner wrote: > From: Tim Sell > > Locking in the _interrupt() function is NOT necessary so long as we ensure > that interrupts have been stopped whenever we need to pause or resume the > device, which we now do. > > While a device is paused, we

Re: [PATCH v2 03/27] staging: unisys: iovmcall_gnuc.h change -1 return values

2016-06-01 Thread Neil Horman
On Tue, May 31, 2016 at 10:26:29PM -0400, David Kershner wrote: > From: Erik Arfvidson > > This patch changes the vague -1 return values to -EPERM. > This operation is not supported is a good alternative > to -1 because the return is basically telling the caller > that the processor doesn't suppo

Re: [PATCH v2 01/27] staging: unisys: visorbus change -1 return values

2016-06-01 Thread Neil Horman
On Tue, May 31, 2016 at 10:26:27PM -0400, David Kershner wrote: > From: Erik Arfvidson > > This patch changes the vague -1 return values to -EFAULT since > it would be the most appropriate, given that this error > would only occur in an unexpected bad offset field. > Resulting in a bad address. >

Re: [PATCH v2 02/27] staging: unisys: visorchipset change -1 return value

2016-06-01 Thread Neil Horman
On Tue, May 31, 2016 at 10:26:28PM -0400, David Kershner wrote: > From: Erik Arfvidson > > This patch changes the vague -1 return value to -EINVAL > > Signed-off-by: Erik Arfvidson > Signed-off-by: David Kershner > Reviewed-by: Tim Sell > --- > drivers/staging/unisys/visorbus/visorchipset.c

Re: Staging: unisys/verisonic: Correct double unlock

2016-04-05 Thread Neil Horman
On Tue, Apr 05, 2016 at 03:49:57PM +, Sell, Timothy C wrote: > > -Original Message- > > From: Neil Horman [mailto:nhor...@redhat.com] > > Sent: Tuesday, April 05, 2016 10:58 AM > > To: Sell, Timothy C > > Cc: Iban Rodriguez; Kershner, David A; Greg Kroah-H

Re: Staging: unisys/verisonic: Correct double unlock

2016-04-05 Thread Neil Horman
On Mon, Apr 04, 2016 at 09:40:13PM +, Sell, Timothy C wrote: > > -Original Message- > > From: Neil Horman [mailto:nhor...@redhat.com] > > Sent: Monday, April 04, 2016 10:35 AM > > To: Sell, Timothy C > > Cc: Iban Rodriguez; Kershner, David A; Greg Kroah-H

Re: Staging: unisys/verisonic: Correct double unlock

2016-04-04 Thread Neil Horman
On Sat, Apr 02, 2016 at 11:20:14PM +, Sell, Timothy C wrote: > > -Original Message- > > From: Iban Rodriguez [mailto:iban.rodrig...@ono.com] > > Sent: Saturday, April 02, 2016 1:47 PM > > To: Kershner, David A; Greg Kroah-Hartman; Benjamin Romer; Sell, Timothy &

Re: [PATCH 3/6] staging: unisys: visorbus: git rid of gotos in devmajorminor_create_file

2016-03-09 Thread Neil Horman
On Wed, Mar 09, 2016 at 05:10:28PM +, Sell, Timothy C wrote: > > -Original Message- > > From: Neil Horman [mailto:nhor...@redhat.com] > > Sent: Wednesday, March 09, 2016 11:09 AM > > To: external-ges-uni...@redhat.com > > Cc: gre...@linuxf

Re: [PATCH 3/6] staging: unisys: visorbus: git rid of gotos in devmajorminor_create_file

2016-03-09 Thread Neil Horman
On Tue, Mar 08, 2016 at 08:22:45PM -0500, David Kershner wrote: > The gotos in devmajorminor_create_file aren't needed, get rid of them. > > Signed-off-by: David Kershner > Signed-off-by: Timothy Sell > --- > drivers/staging/unisys/visorbus/visorbus_main.c | 25 > - > 1

Re: [PATCH 2/2] staging: unisys: visornic: Convert to using napi

2015-08-01 Thread Neil Horman
On Sat, Aug 01, 2015 at 08:55:09AM -0700, Greg KH wrote: > On Sat, Aug 01, 2015 at 09:36:19AM -0400, Neil Horman wrote: > > On Fri, Jul 31, 2015 at 09:41:10PM -0400, Neil Horman wrote: > > > On Fri, Jul 31, 2015 at 06:56:33PM -0400, Benjamin Romer wrote: > &g

Re: [PATCH 2/2] staging: unisys: visornic: Convert to using napi

2015-08-01 Thread Neil Horman
On Fri, Jul 31, 2015 at 09:41:10PM -0400, Neil Horman wrote: > On Fri, Jul 31, 2015 at 06:56:33PM -0400, Benjamin Romer wrote: > > From: Neil Horman > > > > Switch the visornic over to use napi. Currently there is a kernel > > thread > > that sits and waits o

Re: [PATCH 2/2] staging: unisys: visornic: Convert to using napi

2015-07-31 Thread Neil Horman
On Fri, Jul 31, 2015 at 06:56:33PM -0400, Benjamin Romer wrote: > From: Neil Horman > > Switch the visornic over to use napi. Currently there is a kernel > thread > that sits and waits on a wait queue to get notified of incoming virtual > interrupts. It would be nice if we

Re: [PATCH 1/7] staging: unisys: visornic: fix serialization mechanism around usage atomic

2015-07-24 Thread Neil Horman
On Fri, Jul 24, 2015 at 01:35:51PM -0700, Greg KH wrote: > On Fri, Jul 24, 2015 at 12:00:19PM -0400, Benjamin Romer wrote: > > From: Neil Horman > > > > Missed this in my initial review. The usage counter that guards against > > kthread task is horribly racy. The ato

Re: [PATCH 00/15] staging: unisys: visornic technical fix series

2015-07-21 Thread Neil Horman
On Tue, Jul 21, 2015 at 09:55:34AM -0400, Benjamin Romer wrote: > This patch series consists of several technical fixes for the visornic > driver. > > Neil Horman (15): > staging: unisys: Remove num_visornic_open array > staging: unisys: Check retur

Re: [PATCH 01/15] staging: unisys: Remove num_visornic_open array

2015-07-21 Thread Neil Horman
On Tue, Jul 21, 2015 at 05:23:54PM +0300, Dan Carpenter wrote: > On Tue, Jul 21, 2015 at 02:08:10PM +, Kershner, David A wrote: > > We don't have any scripts that access this debugfs file. > > > > Then it's fine to delete the file (in a follow on patch). The kernel > ABI is anything that pro

Re: [PATCH 01/15] staging: unisys: Remove num_visornic_open array

2015-07-21 Thread Neil Horman
On Tue, Jul 21, 2015 at 05:05:22PM +0300, Dan Carpenter wrote: > On Tue, Jul 21, 2015 at 09:55:35AM -0400, Benjamin Romer wrote: > > static ssize_t enable_ints_write(struct file *file, > > const char __user *buffer, > > size_t count, loff_t