Re: [PATCH] Staging: wlan-ng: fix a wrong type of a assignment

On Thu, Sep 17, 2015 at 06:14:04AM -0700, Greg Kroah-Hartman wrote: > On Thu, Sep 17, 2015 at 01:48:14PM +0800, Navy Cheng wrote: > > On Wed, Sep 16, 2015 at 09:52:06PM -0700, Greg Kroah-Hartman wrote: > > > On Wed, Sep 16, 2015 at 09:06:13PM +0800, Navy Cheng wrote: > >

Re: [PATCH] Staging: wlan-ng: fix a wrong type of a assignment

On Wed, Sep 16, 2015 at 09:52:06PM -0700, Greg Kroah-Hartman wrote: > On Wed, Sep 16, 2015 at 09:06:13PM +0800, Navy Cheng wrote: > > The type of value is u16 however the return type of cpu_to_le16() is > > __le16. The incorrect type of assignment is complained by sparse. > &g

[PATCH] Staging: wlan-ng: fix a wrong type of a assignment

The type of value is u16 however the return type of cpu_to_le16() is __le16. The incorrect type of assignment is complained by sparse. Signed-off-by: Navy Cheng --- drivers/staging/wlan-ng/hfa384x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng

[PATCHv2] Staging: vme: remove an unnecessary and wrong warning message

The wrong warning message in vme_user_probe() will mislead developers and users. As the error message which prompt cdev_add() error already exists, just remove the unnecessary and wrong message. Signed-off-by: Navy Cheng --- drivers/staging/vme/devices/vme_user.c | 4 +--- 1 file changed, 1

[PATCH] Staging: vme: fix a wrong waring in vme_user_probe()

The waring message will mislead developers and users. This will cause a potential damage. Fix the waring message to give developers and users the correct guidance. Signed-off-by: Navy Cheng --- drivers/staging/vme/devices/vme_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCHv2,2/2] Staging: dgnc: dgnc_driver.c: Add end tag to dgnc_init_module()

On Mon, Jul 27, 2015 at 03:26:57PM +0530, Sudip Mukherjee wrote: > On Mon, Jul 27, 2015 at 04:10:29PM +0800, Navy Cheng wrote: > > The work flow of dgnc_init_module() is base on if statment. Here is a > > nest "if" in the function. > > > > To avoid the nest

[PATCHv2,2/2] Staging: dgnc: dgnc_driver.c: Add end tag to dgnc_init_module()

ontrol the work flow. Signed-off-by: Navy Cheng --- drivers/staging/dgnc/dgnc_driver.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c index 805dc61..2ef5e12 100644 --- a/

[PATCHv2,1/2] Staging: dgnc: dgnc_driver.h: remove unnecessary comments

The public headers is well known by others and the redundant commits make the code mess. Remove the comments of the public headers to make the code tidy. Signed-off-by: Navy Cheng --- drivers/staging/dgnc/dgnc_driver.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a