On 4/24/2019 8:20 AM, YueHaibing wrote:
Remove duplicated include.
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/kpc2000/kpc2000/kp2000_module.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/kpc2000/kpc2000/kp2000_module.c
On 4/18/2019 5:50 PM, Colin King wrote:
From: Colin Ian King
There are multiple spelling mistakes in variable names, fix these.
Signed-off-by: Colin Ian King
Well, this one a bit sensitive to touch.
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/rtl8723bs/hal
On 4/17/2019 5:30 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in an RT_TRACE message, fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 2 +-
1 file changed, 1 insertion
On 4/17/2019 5:38 PM, Colin King wrote:
From: Colin Ian King
There are two spelling mistake in RT_TRACE messages. Fix them.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c | 4 ++--
1 file changed, 2
On 4/15/2019 11:19 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a dev_error message. Fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/comedi/drivers/adv_pci1710.c | 2 +-
1 file changed, 1 insertion
On 4/15/2019 10:03 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a netdev_err error message, fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion
On 4/6/2019 1:53 PM, Hariprasad Kelam wrote:
changes interupts --> interrupts to fix warning reported by checkpatch
tool
Signed-off-by: Hariprasad Kelam
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
Changes in v2:
- Make the Subject more clear by including changed file p
et but not used [-Wunused-but-set-variable]
drivers/staging/rtlwifi/base.c:2470:5: warning:
variable 'ht_cap_len' set but not used [-Wunused-but-set-variable]
They are never used and can be removed.
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
driv
sed [-Wunused-but-set-variable]
u16 VenderID;
^
It's never used and can be removed.
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/rtl8192e/rtl8192e/rtl_pci.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl
quot;Staging:
comedi: add dyna_pci10xx driver")
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/comedi/drivers/dyna_pci10xx.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dyna_pci10xx.c
b/drivers/stagin
but not used [-Wunused-but-set-variable]
It's never used and can be removed.
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/rtlwifi/rtl8822be/hw.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtlwif
gned-off-by: Colin Ian King
fix the commit text minor err
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
On 4/4/2019 6:54 AM, Hariprasad Kelam wrote:
changes interupts --> interrupts to fix warning reported by checkpatch
tool
Signed-off-by: Hariprasad Kelam
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/comedi/drivers/dt2811.c | 2 +-
1 file changed, 1 insertion(+)
: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/android/Makefile | 1 +
drivers/staging/axis-fifo/Makefile | 1 +
drivers/staging/board/Makefile | 1 +
drivers/staging/clocking-wizard/Makefile | 1
On 4/1/2019 10:43 PM, Greg KH wrote:
On Mon, Apr 01, 2019 at 08:36:50PM +0530, Mukesh Ojha wrote:
On 4/1/2019 8:07 PM, Marcelo Schmitt wrote:
Add SPDX identifier of GPL-2.0 for the ad9832 driver.
Signed-off-by: Marcelo Schmitt
---
drivers/staging/iio/frequency/ad9832.c | 3 +--
1 file
On 4/1/2019 4:23 AM, Will Cunningham wrote:
Removed unnecessary parentheses.`
Remove the extra character at the end.
Fix the above thing then you can take.
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
Signed-off-by: Will Cunningham
---
drivers/staging/comedi/drivers/pcl818.c | 8
On 3/31/2019 5:49 PM, Mukesh Ojha wrote:
On 3/31/2019 2:44 PM, Ojaswin Mujoo wrote:
Fix checkpatch.pl styling error related to SPDX-License-Identifier
comment in vt6656/*.h
* v2: fix patch styling
Above line should be after ---.
Signed-off-by: Ojaswin Mujoo
Although, it looks ok to me
a result of a copy paste.
Reviewed-by: Mukesh Ojha
But, i would want other to comment on this, whether we really want this
kind of effort coming forward.
or can it be not done by some scripting?
Cheers,
-Mukesh
---
drivers/staging/vt6656/baseband.h | 2 +-
drivers/staging/vt6656
cmd(padapter, psta, true, false);
}
Get rid of this {}.fix this .
Now patch looks good after Dan comment.
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
}
___
devel mailing list
de...@linuxdriverproj
On 3/29/2019 8:59 PM, Mauro Carvalho Chehab wrote:
There are a few left overs at staging with were still using the
deprecated strlcpy() function.
Signed-off-by: Mauro Carvalho Chehab
s/with/which
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/media/imx/imx-media-dev
On 3/25/2019 4:13 AM, Kangjie Lu wrote:
When kzalloc fails, "platform_state->inited = 1" is a NULL pointer
dereference. The fix returns VCHIQ_ERROR in case it failed to
avoid NULL pointer dereference.
Signed-off-by: Kangjie Lu
Reviewed-by: Mukesh Ojha
-Mukesh
---
*)skb_put(skb, totalpacketlen), &reserved_page_packet,
totalpacketlen);
Reviewed-by: Mukesh Ojha
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 3/20/2019 10:51 PM, Aditya Pakki wrote:
hwxmits is allocated via kcalloc and not checked for failure before its
No need to mention kcalloc as the other place allocates the memory
through kmalloc.
Otherwise looks good.
Acked-by: Mukesh Ojha
dereference. The patch fixes this problem
riv->phydm.internal)
+ return 0;
_rtl_phydm_init_com_info(rtlpriv, ic, params);
Reviewed-by: Mukesh Ojha
Thanks,
Mukesh
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/dri
wed-by: Mukesh Ojha
Can you fix that cleanly ? or i will do?
Cheers,
Mukesh
_rtl_phydm_init_com_info(rtlpriv, ic, params);
odm_init_all_timers(dm);
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproje
viewed-by: Mukesh Ojha
Can you fix that cleanly ? Otherwise i will do.
Cheers,
Mukesh
_rtl_phydm_init_com_info(rtlpriv, ic, params);
odm_init_all_timers(dm);
___
devel mailing list
de...@linuxdriverproject.or
26 matches
Mail list logo
