Re: [PATCH] staging: clocking-wizard: Fix incorrect type of speed grade

2016-10-18 Thread Moritz Fischer
e >> drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c:162:56:got int >> * >> >> Signed-off-by: Xavier Roumegue > Acked-by: Sören Brinkmann Acked-by: Moritz Fischer Thanks, Moritz ___ devel mailing list de...@linuxdriver

Re: [RFC 0/2] staging: ion: of_ion_device_get

2016-03-22 Thread Moritz Fischer
On Tue, Mar 22, 2016 at 4:20 PM, Laura Abbott wrote: > If allocation is coming from userspace and drivers are only importing > you should be using the dma_buf APIs instead of Ion APIs directly. > Ion is a dma_buf exporter and dma_buf APIs are the preferred API. Ok, thanks. Sounds reasonable. Th

Re: [RFC 0/2] staging: ion: of_ion_device_get

2016-03-22 Thread Moritz Fischer
On Tue, Mar 22, 2016 at 4:20 PM, Laura Abbott wrote: > On 03/22/2016 04:08 PM, Moritz Fischer wrote: >> >> Hi Laura, >> >> On Tue, Mar 22, 2016 at 3:51 PM, Laura Abbott wrote: >> >>> In the past what drivers have done is a foo_ion_client_create

Re: [RFC 0/2] staging: ion: of_ion_device_get

2016-03-22 Thread Moritz Fischer
Hi Laura, On Tue, Mar 22, 2016 at 3:51 PM, Laura Abbott wrote: > In the past what drivers have done is a foo_ion_client_create which has the > reference > to the ion_device created from ion_device_create. Drivers then call the > foo_ion_client_create function. Oh, so you mean you add a function

Re: [RFC 1/2] misc: Add of_get_misc get a reference from devicetree

2016-03-22 Thread Moritz Fischer
Meh, On Tue, Mar 22, 2016 at 3:33 PM, Moritz Fischer wrote: > > + > +err_dev: > + put_device(dev); > + return ERR_PTR(ret); > +} > +#else > +struct misc_device *of_misc_get(struct device_node *) Ok, that one is bro

Re: [RFC 2/2] staging: android: ion: Add of_ion_device_get function

2016-03-22 Thread Moritz Fischer
Derp, On Tue, Mar 22, 2016 at 3:33 PM, Moritz Fischer wrote: > Allows to obtain a reference to the global /dev/ion backing > struct ion_device via devicetree. > > Signed-off-by: Moritz Fischer > --- > drivers/staging/android/ion/ion.c | 10 ++ > 1 file c

[RFC 2/2] staging: android: ion: Add of_ion_device_get function

2016-03-22 Thread Moritz Fischer
Allows to obtain a reference to the global /dev/ion backing struct ion_device via devicetree. Signed-off-by: Moritz Fischer --- drivers/staging/android/ion/ion.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion

[RFC 1/2] misc: Add of_get_misc get a reference from devicetree

2016-03-22 Thread Moritz Fischer
This commit enables access to a miscdevice via a reference obtained from devicetree. This allows to implement a of_ion_device_get() in the next step. Signed-off-by: Moritz Fischer --- drivers/char/misc.c| 38 ++ include/linux/miscdevice.h | 3 +++ 2

[RFC 0/2] staging: ion: of_ion_device_get

2016-03-22 Thread Moritz Fischer
dn't find a way to get to that via devicetree, though. I'll admit that hacking up miscdevice is quite hacky, maybe I should add a foo_get_ion_device() to my heap implementing platform device? If someone can explain me how to correctly do that with what we currently have, even better. C

Re: [PATCH 3/3] STAGING: COMEDI: Using kernel types in plx9080.h

2015-12-16 Thread Moritz Fischer
t; + u8 dma_status; >> const int timeout = 1; >> unsigned int i; >> >> > > Thanks! > > Reviewed-by: Ian Abbott Acked-by: Moritz Fischer ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v11 0/4] FPGA Manager Framework

2015-10-07 Thread Moritz Fischer
Hi Greg, Alan On Wed, Oct 7, 2015 at 6:09 PM, Greg KH wrote: > On Wed, Oct 07, 2015 at 04:36:25PM +0100, at...@opensource.altera.com wrote: >> From: Alan Tull >> >> Hi Greg, >> >> I'm resending v11 >> >> The changes requested for v12 are minor. We can fix them upstream in >> some small patches.

Re: [PATCH v11 2/4] fpga manager: add sysfs interface document

2015-09-22 Thread Moritz Fischer
On Tue, Sep 22, 2015 at 8:21 AM, wrote: > From: Alan Tull > > Add documentation under drivers/staging for new fpga manager's > sysfs interface. > Reviewed-by: Moritz Fischer > Signed-off-by: Alan Tull > --- > v5 : (actually second version, but keeping version

Re: [PATCH v11 1/4] usage documentation for FPGA manager core

2015-09-22 Thread Moritz Fischer
Hi Alan, On Tue, Sep 22, 2015 at 8:21 AM, wrote: > From: Alan Tull > > Add a document on the new FPGA manager core. > Reviewed-by: Moritz Fischer > Signed-off-by: Alan Tull > --- > v9: initial version where this patch was added > > v10: requested cleanups

Re: [PATCH v10 5/8] staging: usage documentation for simple fpga bus

2015-08-19 Thread Moritz Fischer
Acked-by: Moritz Fischer On Wed, Aug 19, 2015 at 11:28 AM, atull wrote: > On Mon, 17 Aug 2015, Pavel Machek wrote: > >> On Thu 2015-08-13 12:37:29, at...@opensource.altera.com wrote: >> > From: Alan Tull >> > >> > Add a document spelling out usage of th

Re: [PATCH v10 3/8] add fpga manager core

2015-08-14 Thread Moritz Fischer
Hi Alan, On Fri, Aug 14, 2015 at 8:46 AM, atull wrote: > On Fri, 14 Aug 2015, atull wrote: > >> On Fri, 14 Aug 2015, Moritz Fischer wrote: >> >> > Hi Alan, >> > >> > I've updated my Zynq driver (it can be found in an older version >> &g

Re: [PATCH v10 3/8] add fpga manager core

2015-08-13 Thread Moritz Fischer
Hi Alan, I've updated my Zynq driver (it can be found in an older version against your v8 in the Xilinx tree, too) https://github.com/mfischer/linux/tree/alan-fpga-mgr-v10 to use your v10 version of the patch. Either I'm using the API wrong , or it never gets to the 'operating state'. Comments i

Re: [PATCH v10 1/8] usage documentation for FPGA manager core

2015-08-13 Thread Moritz Fischer
Hi Alan, thanks for continuing to work on this :) A couple of minor nits ... On Thu, Aug 13, 2015 at 10:37 AM, wrote: > From: Alan Tull > > Add a document on the new FPGA manager core. > > Signed-off-by: Alan Tull > --- > v9: initial version where this patch was added > > v10: requested clea

Re: [PATCH v10 4/8] fpga manager: add driver for socfpga fpga manager

2015-08-13 Thread Moritz Fischer
Acked-by: Moritz Fischer On Thu, Aug 13, 2015 at 10:37 AM, wrote: > From: Alan Tull > > Add driver to fpga manager framework to allow configuration > of FPGA in Altera SoCFPGA parts. > > Signed-off-by: Alan Tull > Acked-by: Michal Simek > --- > v2: fpga_manager

Re: [PATCH v9 6/7] staging: add simple-fpga-bus

2015-07-23 Thread Moritz Fischer
Hi Alan, I saw that your socfpga driver doesn't support the partial reconfig use case (not a big deal). What I currently do for Zynq is if I'm doing a non-partial reconfig is that I disable input level shifters and assert *all* resets while reprogramming in my FPGA manager .write_init() and .write

Re: [PATCH v9 5/7] staging: fpga manager core

2015-07-22 Thread Moritz Fischer
Hi Alan, a couple of small things I found while reworking the Zynq version to match the v9 patchset: On Fri, Jul 17, 2015 at 8:51 AM, wrote: > From: Alan Tull > > API to support programming FPGA. > > The following functions are exported as GPL: > * fpga_mgr_buf_load >Load fpga from image i

Re: [PATCH v9 7/7] staging: fpga manager: add driver for socfpga fpga manager

2015-07-17 Thread Moritz Fischer
Alan, it looks pretty good so far. I have worked with Michal and developed a Zynq equivalent against your last patchset which can be found in the Xilinx tree now. I just briefly glanced the changes below just two nits that caught my eye. I'll take a closer look while trying to update the zynq-fpg