Re: How to replace control code in gdm72xx?

On 07/17/2014 01:59 AM, Ben Chan wrote: > > From what I read from the user-space code, the custom ioctl is to read > the following information from the driver: > > enum { > SIOC_DATA_FSM, // Device/Connection State > SIOC_DATA_NETLIST, // Network list > SIOC_DATA_CONNN

[PATCH] staging: gdm72xx: remove debug code

Removed dump_eth_packet() and helper functions called upon packet tx/rx. Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_wimax.c | 106 1 file changed, 106 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging

[PATCH] staging: gdm72xx: replace print_hex_dump_debug() with dev_dbg()

Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_sdio.c | 15 +++ drivers/staging/gdm72xx/gdm_usb.c | 10 ++ 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_sdio.c b/drivers/staging/gdm72xx/gdm_sdio.c index 6a23bef

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

On 07/16/2014 09:50 PM, Greg KH wrote: > On Wed, Jul 16, 2014 at 09:40:18PM +0100, Michalis Pappas wrote: >> On 07/09/2014 07:51 PM, Greg KH wrote: >>>> diff --git a/drivers/staging/gdm72xx/gdm_sdio.c >>>> b/drivers/staging/gdm72xx/gdm_sdio.c >>>> ind

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

On 07/09/2014 07:51 PM, Greg KH wrote: >> diff --git a/drivers/staging/gdm72xx/gdm_sdio.c >> b/drivers/staging/gdm72xx/gdm_sdio.c >> index 9d2de6f..914fd75 100644 >> --- a/drivers/staging/gdm72xx/gdm_sdio.c >> +++ b/drivers/staging/gdm72xx/gdm_sdio.c >> @@ -280,9 +280,11 @@ static void send_sdu(st

How to replace control code in gdm72xx?

Hi, I'm currently working on bringing the gdm72xx WiMAX driver out of staging. The driver currently uses two control channels: 1. The SIOCDEVPRIVATE ioctl to send and receive state messages 2. A customly defined netlink protocol for passing messages verbatim to the device controller AFAIK both

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

On 07/09/2014 07:51 PM, Greg KH wrote: > On Tue, Jul 01, 2014 at 02:00:15PM +0100, Michalis Pappas wrote: >> Signed-off-by: Michalis Pappas >> --- >> drivers/staging/gdm72xx/gdm_qos.c | 2 ++ >> drivers/staging/gdm72xx/gdm_sdio.c | 7 +++ >> driver

[PATCH v2] staging: gdm72xx: reorder functions and remove forward declarations

Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_sdio.c | 77 drivers/staging/gdm72xx/gdm_usb.c | 87 +- drivers/staging/gdm72xx/gdm_wimax.c | 179 +--- 3 files changed, 164 insertions(+), 179 deletions(-) diff

[PATCH v4] staging: gdm72xx: move T_CAPABILITY definitions to hci.h

Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_wimax.c | 11 +++ drivers/staging/gdm72xx/hci.h | 6 ++ 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index 0f71d41

[PATCH v3] staging: gdm72xx: move T_CAPABILITY definitions to hci.h

Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_wimax.c | 11 +++ drivers/staging/gdm72xx/hci.h | 6 ++ 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index 4148013

Re: [PATCH V2] staging: gdm72xx: move T_CAPABILITY definitions to hci.h

On 07/09/2014 11:26 AM, Dan Carpenter wrote: >> /* GetInformation mac address */ >> len = 0; >> @@ -621,12 +618,12 @@ static void gdm_wimax_prepare_device(struct net_device >> *dev) >> hci->length = H2B(len); >> gdm_wimax_send(nic, hci, HCI_HEADER_SIZE+len); >> >> -val =

Re: Anybody working on gdm72xx?

On 07/01/2014 09:17 PM, Michalis Pappas wrote: > The wimax.h interface specifies communication through "message pipes", a > means of free-form communication between user-space and the driver. So > my understanding is that the library only needs to replace the lowest > layer (

[PATCH] staging: gdm72xx: reorder functions and remove function declarations

Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_sdio.c | 77 drivers/staging/gdm72xx/gdm_usb.c | 87 +- drivers/staging/gdm72xx/gdm_wimax.c | 179 +--- 3 files changed, 164 insertions(+), 179 deletions(-) diff

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

On 07/01/2014 07:08 PM, Ben Chan wrote: > > > > On Tue, Jul 1, 2014 at 9:40 AM, Michalis Pappas <mailto:mpap...@fastmail.fm>> wrote: > > On 07/01/2014 04:30 PM, Ben Chan wrote: > > > > > > > > On Tue, Jul 1, 2014 at 6:00 A

[PATCH V2] staging: gdm72xx: move T_CAPABILITY definitions to hci.h

Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_wimax.c | 11 --- drivers/staging/gdm72xx/hci.h | 6 ++ 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index 4148013

Re: Anybody working on gdm72xx?

On 07/01/2014 07:38 PM, Olof Johansson wrote: > I'm not Greg, but in general the requirements of not breaking the > userspace ABI does not apply to staging drivers. > > However, that doesn't mean that it makes sense to gratuitously break it > "just because". Certainly not. My only concern was ab

Re: Anybody working on gdm72xx?

On 07/01/2014 07:29 PM, Ben Chan wrote: > > [Ben] AFAIK, there is another Intel i2400m WiMAX driver in kernel. The > wimax-tools probably works with that particular driver. I haven't > looked at either the i2400m driver or wimax-tools, and need to spend > some time to figure out the differences be

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

On 07/01/2014 04:30 PM, Ben Chan wrote: > > > > On Tue, Jul 1, 2014 at 6:00 AM, Michalis Pappas <mailto:mpap...@fastmail.fm>> wrote: > > Signed-off-by: Michalis Pappas <mailto:mpap...@fastmail.fm>> > --- > drivers/staging/gdm72xx

Re: [PATCH] staging: gdm72xx: move T_CAPABILITY bit definitions to hci.h

On 07/01/2014 04:37 PM, Ben Chan wrote: > On Tue, Jul 1, 2014 at 6:00 AM, Michalis Pappas wrote: >> Signed-off-by: Michalis Pappas >> --- >> drivers/staging/gdm72xx/gdm_wimax.c | 10 +++--- >> drivers/staging/gdm72xx/hci.h | 6 ++ >> 2 files chan

Re: Anybody working on gdm72xx?

On 07/01/2014 04:27 PM, Ben Chan wrote: > Except from the above, there is the issue I mentioned earlier about > netlink. In particular, the driver defines a custom control interface > based on ioctl and netlink. However their implementation has the > following issues: > > - Use

[PATCH] staging: gdm72xx: move T_CAPABILITY bit definitions to hci.h

Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_wimax.c | 10 +++--- drivers/staging/gdm72xx/hci.h | 6 ++ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index 63a760b

[PATCH] staging: gdm72xx: conditionally compile debug code

Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_qos.c | 2 ++ drivers/staging/gdm72xx/gdm_sdio.c | 7 +++ drivers/staging/gdm72xx/gdm_usb.c | 7 +++ drivers/staging/gdm72xx/gdm_wimax.c | 6 ++ drivers/staging/gdm72xx/gdm_wimax.h | 2 ++ 5 files changed, 24

[PATCH] staging: gdm72xx: remove unused code

Remove code surrounded by otherwise unused #define LOOPBACK_TEST Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_wimax.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index 4148013

Re: Anybody working on gdm72xx?

On 06/30/2014 05:51 AM, Ben Chan wrote:> > Hi Michalis, > > Thanks for your help. I'm happy to collaborate if you're interested > too. I'm not the author of the driver, so my knowledge is limited to > what I've read from the code and how we use it on Chrome OS. So how do you use it on the Chrome O

Re: Anybody working on gdm72xx?

On 06/28/2014 07:39 AM, Ben Chan wrote: > On Wed, Jun 25, 2014 at 5:11 AM, Michalis Pappas wrote: >> >> >> Hi everyone, >> >> I've been working on a driver review for gdm72xx and I think there are some >> more issues to be fixed except from stuff rep

Re: Anybody working on gdm72xx?

On 06/24/2014 08:12 AM, Ben Chan wrote: > Thanks Kristina. checkpatch reports 1 errors and 17 warnings on the > current driver. > > I guess I need to first submit patches to staging-next to address > these issues, and then submit another patch to move it out of staging, > right? > Hi everyone,

[PATCH v5 02/10] staging: gdm72xx: Replace comparisons on jiffies values with wrap-safe functions

Fixes the following checkpatch.pl issue: WARNING: Comparing jiffies is almost always wrong; prefer time_after, time_before and friends Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_usb.c | 2 +- drivers/staging/gdm72xx/sdio_boot.c | 4 ++-- 2 files changed, 3 insertions

[PATCH v5 07/10] staging: gdm72xx: Removed commented-out code

Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_qos.h | 17 - drivers/staging/gdm72xx/gdm_wimax.c | 4 drivers/staging/gdm72xx/gdm_wimax.h | 6 -- drivers/staging/gdm72xx/usb_boot.c | 17 + 4 files changed, 1 insertion(+), 43 deletions

[PATCH v5 10/10] staging: gdm72xx: Remove task from TODO list

Removed line related to replacement of kernel_thread with kthread, as issue was fixed on ff5e4a1d2702 ('Staging: gdm72xx: gdm_usb: fix deprecated function kernel_thread') Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/TODO | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v5 06/10] staging: gdm72xx: Fix braces to conform with coding style

Fixes the following checkpatch.pl issue: CHECK: braces {} should be used on all arms of this statement Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_wimax.c | 16 drivers/staging/gdm72xx/netlink_k.c | 7 --- 2 files changed, 12 insertions(+), 11 deletions

[PATCH v5 08/10] staging: gdm72xx: Whitespace fixes to conform to coding standards

Fixes the following checkpatch.pl issues: WARNING: unnecessary whitespace before a quoted newline CHECK: Alignment should match open parenthesis CHECK: No space is necessary after a cast Also some additional, whitespace related, readability issues. Signed-off-by: Michalis Pappas --- drivers

[PATCH v5 03/10] staging: gdm72xx: Modify a struct allocation to match coding standards

Fixes the following checkpatch.pl issue: CHECK: Prefer kmalloc(sizeof(*entry)...) over kmalloc(sizeof(struct qos_entry_s)...) Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_qos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm72xx

[PATCH v5 05/10] staging: gdm72xx: Fix some camel-case variables

Fixes the following checkpatch.pl issue: CHECK: Avoid CamelCase: Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_qos.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging

[PATCH v5 04/10] staging: gdm72xx: Move logical continuation to previous line to conform to coding style

Fixes the following checkpatch.pl issue: CHECK: Logical continuations should be on the previous line Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_usb.c b/drivers/staging

[PATCH v5 09/10] staging: gdm72xx: Indentation and other whitespace fixes

Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_qos.c | 2 +- drivers/staging/gdm72xx/gdm_sdio.c | 14 +++--- drivers/staging/gdm72xx/gdm_sdio.h | 29 + drivers/staging/gdm72xx/gdm_usb.c | 17 drivers/staging/gdm72xx/gdm_usb.h | 11 + drivers

[PATCH v5 01/10] staging: gdm72xx: Remove unnecessary extern declarations from header files

Fixes the following checkpatch.pl issue: CHECK: extern prototypes should be avoided in .h files Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_wimax.h | 6 +++--- drivers/staging/gdm72xx/sdio_boot.h | 2 +- drivers/staging/gdm72xx/usb_boot.h | 4 ++-- 3 files changed, 6

[PATCH v5 0/10] staging: gdm72xx: Code cleanup

On 04/29/2014 10:03 AM, Michalis Pappas wrote: > Ok, I generated a new patchset based on running checkpatch.pl with the > --strict option, as well as any recommendations made earlier on this thread. > > From the following patches, both 8/10 and 9/10 involve whitespace fixes: > t

[PATCH v4 10/10] staging: gdm72xx: Removed task from TODO list

Removed line related to replacement of kernel_thread with kthread, as issue was fixed on ff5e4a1d2702 ('Staging: gdm72xx: gdm_usb: fix deprecated function kernel_thread') Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/TODO | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v4 9/10] staging: gdm72xx: Indentation and other whitespace fixes.

Indentation and other whitespace fixes. Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_qos.c | 2 +- drivers/staging/gdm72xx/gdm_sdio.c | 14 +++--- drivers/staging/gdm72xx/gdm_sdio.h | 29 + drivers/staging/gdm72xx/gdm_usb.c | 17 drivers/staging

[PATCH v4 8/10] staging: gdm72xx: Whitespace fixes to conform to coding standards

Whitespace fixes to conform to coding standards Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_qos.c | 72 ++--- drivers/staging/gdm72xx/gdm_sdio.c | 15 drivers/staging/gdm72xx/gdm_usb.c | 43 -- drivers/staging

[PATCH v4 7/10] staging: gdm72xx: Removed commented-out code

Removed commented-out code Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_qos.h | 17 - drivers/staging/gdm72xx/gdm_wimax.c | 4 drivers/staging/gdm72xx/gdm_wimax.h | 6 -- drivers/staging/gdm72xx/usb_boot.c | 17 + 4 files changed

[PATCH v4 6/10] staging: gdm72xx: Fixed some braces to conform with coding style

Fixed some braces to conform with coding style Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_wimax.c | 16 drivers/staging/gdm72xx/netlink_k.c | 7 --- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b

[PATCH v4 5/10] staging: gdm72xx: Fixed some camelCase variables

Fixed some camelCase variables Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_qos.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c index 519db48

[PATCH v4 4/10] staging: gdm72xx: Moved logical continuation to previous line to conform to coding style

Moved logical continuation to previous line to conform to coding style --- drivers/staging/gdm72xx/gdm_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_usb.c b/drivers/staging/gdm72xx/gdm_usb.c index 9ddf8f5..b9d7643 100644 --- a/drivers/

[PATCH v4 3/10] staging: gdm72xx: Modified struct allocation to match coding standards

Modified struct allocation to match coding standards --- drivers/staging/gdm72xx/gdm_qos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c index 50d43ad..519db48 100644 --- a/drivers/staging/gdm72xx/gdm_qo

[PATCH v4 2/10] staging: gdm72xx: Replaced comparisons on jiffies values with wrap-safe functions

Replaced comparisons on jiffies values with wrap-safe functions. Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_usb.c | 2 +- drivers/staging/gdm72xx/sdio_boot.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_usb.c b

[PATCH v4 1/10] staging: gdm72xx: Removed unnecessary extern declarations from header files

Removed unnecessary extern declarations from header files Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_wimax.h | 6 +++--- drivers/staging/gdm72xx/sdio_boot.h | 2 +- drivers/staging/gdm72xx/usb_boot.h | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a

[PATCH v4 0/3] staging: gdm72xx: Code cleanup

Ok, I generated a new patchset based on running checkpatch.pl with the --strict option, as well as any recommendations made earlier on this thread. >From the following patches, both 8/10 and 9/10 involve whitespace fixes: the former fixes issues reported by checkpatch.pl while the latter is mostly

Re: [PATCH v3 0/3] staging: gdm72xx: Minor cleanup

On 04/23/2014 04:04 PM, Dan Carpenter wrote: > On Wed, Apr 23, 2014 at 08:39:06AM +0800, Michalis Pappas wrote: >> After all patches have been applied, the only remaining issue on the >> TODO list is to conform to the coding standards. The remaining issues >> reported

[PATCH v3 3/3] staging: gdm72xx: Removed direct comparisons on jiffies

Replaced comparisons on jiffies values with wrap-safe functions. Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_usb.c | 2 +- drivers/staging/gdm72xx/sdio_boot.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_usb.c b

[PATCH v3 2/3] staging: gdm72xx: Removed completed task from TODO list

Removed line related to replacement of kernel_thread with kthread, as issue was fixed on ff5e4a1d2702 ('Staging: gdm72xx: gdm_usb: fix deprecated function kernel_thread') Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/TODO | 1 - 1 file changed, 1 deletion(-) di

Re: [PATCH v3 1/3] staging: gdm72xx: Coding style fixes

Minor white-space fixes as suggested by checkpatch.pl. Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_qos.c | 2 +- drivers/staging/gdm72xx/gdm_wimax.c | 2 ++ drivers/staging/gdm72xx/usb_boot.c | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v3 0/3] staging: gdm72xx: Minor cleanup

The following patches perform various cleanups on the gdm72xx driver. PATCH 1/3 fixes some small coding style issues PATCH 2/3 removes an already completed item from the TODO list PATCH 3/3 replaces some jiffies comparisons with wrap-safe functions After all patches have been applied, the only re

[PATCH v2 3/3] staging: gdm72xx: Minor cleanup

Replaced comparisons on jiffies values with wrap-safe functions. Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_usb.c | 2 +- drivers/staging/gdm72xx/sdio_boot.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_usb.c b

[PATCH v2 2/3] staging: gdm72xx: Minor cleanup

Removed line related to replacement of kernel_thread with kthread, as issue was fixed on ff5e4a1d2702582614996f6f6d005e9b5caadeb8. Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gdm72xx/TODO b/drivers/staging

[PATCH v2 1/3] staging: gdm72xx: Minor cleanup

Minor white-space fixes as suggested by checkpatch.pl. Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_qos.c | 2 +- drivers/staging/gdm72xx/gdm_wimax.c | 2 ++ drivers/staging/gdm72xx/usb_boot.c | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 0/3] staging: gdm72xx: Minor cleanup

The following patches perform various cleanups on the gdm72xx driver. PATCH 1/3 fixes some small coding style issues PATCH 2/3 removes an already completed item from the TODO list PATCH 3/3 replaces some jiffies comparisons with wrap-safe functions After all patches have been applied, the only re

[PATCH] staging: dt3155v4l: Fixed global symbol

Made q_ops static, as suggested by sparse. Signed-off-by: Michalis Pappas --- drivers/staging/media/dt3155v4l/dt3155v4l.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/dt3155v4l/dt3155v4l.c b/drivers/staging/media/dt3155v4l/dt3155v4l.c index e729e52

[PATCH 2/3] staging: gdm72xx: Removed task from TODO list

Removed task related to replacement of kernel_thread with kthread, as issue was fixed on ff5e4a1d2702582614996f6f6d005e9b5caadeb8. Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gdm72xx/TODO b/drivers/staging

[PATCH 3/3] staging: gdm72xx: Removed direct comparisons on jiffies

Replaced comparisons on jiffies values with wrap-safe functions. Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_usb.c | 2 +- drivers/staging/gdm72xx/sdio_boot.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_usb.c b

[PATCH 0/3] staging: gdm72xx: Minor cleanup

The following patches perform various cleanups on the gdm72xx driver. PATCH 1/3 fixes some small coding style issues PATCH 2/3 removes an already completed item from the TODO list PATCH 3/3 replaces some jiffies comparisons with wrap-safe functions After all patches have been applied, the only re

[PATCH 1/3] staging: gdm72xx: Coding style fixes

Minor white-space fixes as suggested by checkpatch.pl. Signed-off-by: Michalis Pappas --- drivers/staging/gdm72xx/gdm_qos.c | 2 +- drivers/staging/gdm72xx/gdm_wimax.c | 2 ++ drivers/staging/gdm72xx/usb_boot.c | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers