Re: [PATCH v2 4/5] staging: emxx_udc: add missing usb_ep_set_maxpacket_limit()

2015-07-08 Thread Michal Nazarewicz
is needed by epautoconf. > > Signed-off-by: Robert Baldyga Acked-by: Michal Nazarewicz > --- > drivers/staging/emxx_udc/emxx_udc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/emxx_udc/emxx_udc.c > b/drivers/staging/emxx_udc

Re: [PATCH v2 5/5] usb: gadget: atmel_usba_udc: add missing ret value check

2015-07-08 Thread Michal Nazarewicz
On Wed, Jul 08 2015, Robert Baldyga wrote: > Add missing return value check. In case of error print debug message > and return error code. > > Signed-off-by: Robert Baldyga > Acked-by: Nicolas Ferre Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/udc/atmel_usb

Re: [PATCH v2 3/5] usb: isp1760: udc: add missing usb_ep_set_maxpacket_limit()

2015-07-08 Thread Michal Nazarewicz
is needed by epautoconf. > > Signed-off-by: Robert Baldyga Acked-by: Michal Nazarewicz > --- > drivers/usb/isp1760/isp1760-udc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/isp1760/isp1760-udc.c > b/drivers/usb/isp1760/isp

Re: [PATCH v2 2/5] usb: gadget: midi: avoid redundant f_midi_set_alt() call

2015-07-08 Thread Michal Nazarewicz
o avoid this problem we do such things only once, > for interface number 1 (MIDI Streaming interface). > > Signed-off-by: Robert Baldyga Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/function/f_midi.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/

Re: [PATCH v2 1/5] usb: gadget: ffs: call functionfs_unbind() if _ffs_func_bind() fails

2015-07-08 Thread Michal Nazarewicz
-off-by: Robert Baldyga Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/function/f_fs.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/function/f_fs.c > b/drivers/usb/gadget/function/f_fs.c > index 6e7be91..65161

[PATCHv2] staging: comedi: fix potentially uninitialised variable

2013-11-11 Thread Michal Nazarewicz
If none of the if conditions take a true path, the ret variable will never be assigned a value. Signed-off-by: Michal Nazarewicz --- drivers/staging/comedi/drivers/vmk80xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) On Sun, Nov 10 2013, Dan Carpenter wrote: > Don't us

[PATCHv2] staging: go7007: fix use of uninitialised pointer

2013-11-11 Thread Michal Nazarewicz
go variable is initialised only after the switch case so it cannot be dereferenced prior to that happening. Signed-off-by: Michal Nazarewicz --- drivers/staging/media/go7007/go7007-usb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) On Sun, Nov 10 2013, Dan Carpenter wrote

[PATCH 1/7] staging: go7007: fix use of uninitialised pointer

2013-11-10 Thread Michal Nazarewicz
Signed-off-by: Michal Nazarewicz --- drivers/staging/media/go7007/go7007-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) On Sun, Nov 10 2013, Greg Kroah-Hartman wrote: > Please either delete this entirely, or use the struct device in the > usb_interface pointer. > > A d