Re: [bug report] staging: vc04_services: add vchiq_pagelist_info structure

2018-10-25 Thread Michael Zoran
> On Oct 25, 2018, at 8:44 AM, Dan Carpenter wrote: > > Hello Michael Zoran, > > The patch 4807f2c0e684: "staging: vc04_services: add > vchiq_pagelist_info structure" from Nov 7, 2016, leads to the > following static checker warning: > > dr

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-21 Thread Michael Zoran
On Tue, 2017-03-21 at 23:30 +0300, Dan Carpenter wrote: > I've read Stefan's review comments and intervened where I didn't > understand them.  The recent ones are very specific and reasonable... > > Just send a v2.  I don't get what the deal is... Partly because Eric and Stefan have publically an

Re: Eric Anholt offically announces support of VC4 without access to expander on the RPI 3

2017-03-21 Thread Michael Zoran
On Tue, 2017-03-21 at 12:09 -0700, Michael Zoran wrote: > On Tue, 2017-03-21 at 10:34 -0700, Eric Anholt wrote: > > Michael Zoran writes: > > > > > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: > > > > Michael Zoran writes: > > > > >

Re: Eric Anholt offically announces support of VC4 without access to expander on the RPI 3

2017-03-21 Thread Michael Zoran
On Tue, 2017-03-21 at 10:34 -0700, Eric Anholt wrote: > Michael Zoran writes: > > > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: > > > Michael Zoran writes: > > > > > > > > > Since the API is completely documented, I see

Re: [PATCH 2/5] staging: bcm2835-camera: Fix integer underrun in port_parameter_get

2017-03-21 Thread Michael Zoran
On Tue, 2017-03-21 at 14:45 +0300, Dan Carpenter wrote: > On Tue, Mar 21, 2017 at 04:36:16AM -0700, Michael Zoran wrote: > > On Tue, 2017-03-21 at 13:41 +0300, Dan Carpenter wrote: > > > You're fixing a bug you introduced in [PATCH 1/5].  Don't do > > > that.  

Re: [PATCH 2/5] staging: bcm2835-camera: Fix integer underrun in port_parameter_get

2017-03-21 Thread Michael Zoran
On Tue, 2017-03-21 at 13:41 +0300, Dan Carpenter wrote: > You're fixing a bug you introduced in [PATCH 1/5].  Don't do > that.  Just > fix Dave's patch and add a note in the commit log. > > regards, > dan carpenter > OK, thanks I'm still learning about the whole process. It looks like Dave's ve

Re: [PATCH 1/5] bcm2835-camera: Correct port_parameter_get return value

2017-03-21 Thread Michael Zoran
On Tue, 2017-03-21 at 08:27 +0100, Greg KH wrote: > On Fri, Mar 17, 2017 at 02:56:42PM -0700, Michael Zoran wrote: > > From: Dave Stevenson > > > > The API for port_parameter_get() requires that the > > filled length is returned, or if insufficient space > > th

Eric Anholt offically announces support of VC4 without access to expander on the RPI 3

2017-03-20 Thread Michael Zoran
On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: > Michael Zoran writes: > > > > > Since the API is completely documented, I see no reason we or > > > > anybody > > > > couldn't essentially rewrite the driver while it's in > > >

Re: [PATCH 0/5] staging: vc04_services: camera driver maintance

2017-03-20 Thread Michael Zoran
On Mon, 2017-03-20 at 23:40 +0300, Dan Carpenter wrote: > On Mon, Mar 20, 2017 at 07:53:18AM -0700, Michael Zoran wrote: > > On Mon, 2017-03-20 at 16:57 +0300, Dan Carpenter wrote: > > > On Mon, Mar 20, 2017 at 04:06:00AM -0700, Michael Zoran wrote: > > > > On Mon,

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-20 Thread Michael Zoran
On Mon, 2017-03-20 at 11:54 -0700, Michael Zoran wrote: > On Mon, 2017-03-20 at 10:28 -0700, Michael Zoran wrote: > > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: > > > Michael Zoran writes: > > > > > > > > > Since the API is completely

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-20 Thread Michael Zoran
On Mon, 2017-03-20 at 10:28 -0700, Michael Zoran wrote: > On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: > > Michael Zoran writes: > > > > > > > Since the API is completely documented, I see no reason we or > > > > > anybody > > > >

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-20 Thread Michael Zoran
On Mon, 2017-03-20 at 10:22 -0700, Eric Anholt wrote: > Michael Zoran writes: > > > > > Since the API is completely documented, I see no reason we or > > > > anybody > > > > couldn't essentially rewrite the driver while it's in > > >

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-20 Thread Michael Zoran
On Mon, 2017-03-20 at 12:33 -0300, Mauro Carvalho Chehab wrote: > Em Mon, 20 Mar 2017 08:11:41 -0700 > Michael Zoran escreveu: > > > On Mon, 2017-03-20 at 11:58 -0300, Mauro Carvalho Chehab wrote: > > > Em Mon, 20 Mar 2017 04:08:21 -0700 > > > Michael Zoran

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-20 Thread Michael Zoran
On Mon, 2017-03-20 at 11:58 -0300, Mauro Carvalho Chehab wrote: > Em Mon, 20 Mar 2017 04:08:21 -0700 > Michael Zoran escreveu: > > > On Mon, 2017-03-20 at 07:58 -0300, Mauro Carvalho Chehab wrote: > > > Em Sun, 19 Mar 2017 22:11:07 -0300 > > > Mauro Carvalho Cheh

Re: [PATCH 0/5] staging: vc04_services: camera driver maintance

2017-03-20 Thread Michael Zoran
On Mon, 2017-03-20 at 16:57 +0300, Dan Carpenter wrote: > On Mon, Mar 20, 2017 at 04:06:00AM -0700, Michael Zoran wrote: > > On Mon, 2017-03-20 at 13:55 +0300, Dan Carpenter wrote: > > > I'm not going to review this because it has kbuild errors. > > > &g

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-20 Thread Michael Zoran
On Mon, 2017-03-20 at 07:58 -0300, Mauro Carvalho Chehab wrote: > Em Sun, 19 Mar 2017 22:11:07 -0300 > Mauro Carvalho Chehab escreveu: > > > Em Sun, 19 Mar 2017 10:04:28 -0700 > > Michael Zoran escreveu: > > > > > A working DT that I tried this mornin

Re: [PATCH 0/5] staging: vc04_services: camera driver maintance

2017-03-20 Thread Michael Zoran
On Mon, 2017-03-20 at 13:55 +0300, Dan Carpenter wrote: > I'm not going to review this because it has kbuild errors. > > regards, > dan carpenter > Hi, can you e-mail out the errors or send them to me. It worked when I submitted it. ___ devel mailin

Re: [PATCH 5/6] staging: bcm2835-firmware-gpio: Add a build system for the driver

2017-03-20 Thread Michael Zoran
On Mon, 2017-03-20 at 13:43 +0300, Dan Carpenter wrote: > On Sat, Mar 18, 2017 at 10:40:06PM -0700, Michael Zoran wrote: > > On Sun, 2017-03-19 at 13:27 +0800, kbuild test robot wrote: > > > Hi Michael, > > > > > > [auto build test WARNING on staging/sta

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-19 Thread Michael Zoran
On Sun, 2017-03-19 at 13:58 -0300, Mauro Carvalho Chehab wrote: > Em Fri, 17 Mar 2017 17:34:36 -0700 > Eric Anholt escreveu: > > > Mauro Carvalho Chehab writes: > > > > > Em Wed, 15 Mar 2017 18:46:24 -0700 > > > Michael Zoran escreveu: > > >

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-19 Thread Michael Zoran
> > Since the API is completely documented, I see no reason we or > > anybody > > couldn't essentially rewrite the driver while it's in staging.  I > > just > > think it would be best for everyone if the new version was a drop > > in > > replacement for the original version.  Essential an enhancem

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-19 Thread Michael Zoran
On Sun, 2017-03-19 at 11:39 +0100, Stefan Wahren wrote: > Hi Michael, > > > Michael Zoran hat am 19. März 2017 um 05:42 > > geschrieben: > > > > > > On Sat, 2017-03-18 at 14:23 +0100, Stefan Wahren wrote: > > > > Michael Zoran hat am 17

Re: outreachy/moving a driver out of staging

2017-03-19 Thread Michael Zoran
On Sun, 2017-03-19 at 09:15 +, Russell King - ARM Linux wrote: > On Sun, Mar 19, 2017 at 12:37:47AM -0700, Michael Zoran wrote: > > I just noticed this e-mail.  What exactly is the requirement to get > > a > > driver or subsystem out of staging? > > This is wh

Re: outreachy/moving a driver out of staging

2017-03-19 Thread Michael Zoran
On Thu, 2017-03-09 at 22:20 +0100, Greg KH wrote: > On Thu, Mar 09, 2017 at 01:56:49PM -0700, Stephen Warren wrote: > > On 03/09/2017 01:51 PM, Scott Branden wrote: > > > Hi Julia, > > > > > > On 17-03-09 12:36 PM, Julia Lawall wrote: > > > > Hello, > > > > > > > > I discussed the issue of outrea

Re: [PATCH 3/6] staging: bcm2835-firmware-gpio: Expand DT options for driver

2017-03-19 Thread Michael Zoran
On Sat, 2017-03-18 at 14:24 +0100, Stefan Wahren wrote: > > Michael Zoran hat am 17. März 2017 um 16:22 > > geschrieben: > > > > > > This change adds the following optional DT properties: > > > > number-gpios: Number of GPIOs the device should expose &

Re: [PATCH 5/6] staging: bcm2835-firmware-gpio: Add a build system for the driver

2017-03-18 Thread Michael Zoran
, please drop us a > note to help improve the system] > > url:    https://github.com/0day-ci/linux/commits/Michael-Zoran/stagin > g-bcm2835-firmware-gpio-Initial-staging-commit/20170319-14 > > > coccinelle warnings: (new ones prefixed by >>) > > > > dri

Re: [PATCH 5/6] staging: bcm2835-firmware-gpio: Add a build system for the driver

2017-03-18 Thread Michael Zoran
On Sat, 2017-03-18 at 14:25 +0100, Stefan Wahren wrote: > > Michael Zoran hat am 17. März 2017 um 16:22 > > geschrieben: > > > > > > This change adds the driver to the standard kernel build system. > > > > Signed-off-by: Michael Zoran > >

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-18 Thread Michael Zoran
On Sat, 2017-03-18 at 14:23 +0100, Stefan Wahren wrote: > > Michael Zoran hat am 17. März 2017 um 16:22 > > geschrieben: > > > > > > From: Dave Stevenson > > > > Pi3 and Compute Module 3 have a GPIO expander that the > > VPU communicates with

[PATCH 5/5] staging: bcm2835-camera: Remove 2 completed issues from TODO list

2017-03-17 Thread Michael Zoran
code hook into that mechanism. That completes another TODO item. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/TODO | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/TODO b/

[PATCH 1/5] bcm2835-camera: Correct port_parameter_get return value

2017-03-17 Thread Michael Zoran
/bcm2835-camera/mmal-vchiq.c Signed-off-by: Michael Zoran --- .../vc04_services/bcm2835-camera/mmal-vchiq.c| 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services

[PATCH 4/5] staging: bcm2835-camera: Fix TODO issue #4 where camera doesn't start if vchiq isn't connected.

2017-03-17 Thread Michael Zoran
The camera currently doesn't start if vchiq hasn't connected yet. Vchiq does have a mechanism to receive a callback when vchiq is connected. So instead of connecting to the camera immedialy, wait for the callback. This fixed TODO issue #4 Signed-off-by: Michael Zoran --- .../vc0

[PATCH 2/5] staging: bcm2835-camera: Fix integer underrun in port_parameter_get

2017-03-17 Thread Michael Zoran
: Michael Zoran --- .../vc04_services/bcm2835-camera/mmal-vchiq.c | 27 +++--- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c index

[PATCH 3/5] staging: vchiq_arm: Add vchiq_remove_connected_callback

2017-03-17 Thread Michael Zoran
The connected callback mechanism of vchiq is missing the ability to remove a connected callback, such as when a module unloads. So add the vchiq_remove_connected_callback to support unloading modules that hook into vchiq. Signed-off-by: Michael Zoran --- .../interface/vchiq_arm

[PATCH 0/5] staging: vc04_services: camera driver maintance

2017-03-17 Thread Michael Zoran
rt of the camera is complete and the start race condition is fixed. Dave Stevenson (1): bcm2835-camera: Correct port_parameter_get return value Michael Zoran (4): staging: bcm2835-camera: Fix integer underrun in port_parameter_get staging: vchiq_arm: Add vchiq_remove_connected_callback st

Re: [PATCH 0/6] staging: bcm2835-firmware-gpio: Initial staging commit

2017-03-17 Thread Michael Zoran
On Fri, 2017-03-17 at 18:24 +0100, Stefan Wahren wrote: > Hi Michael, > > > Michael Zoran hat am 17. März 2017 um 17:48 > > geschrieben: > > > > > > On Fri, 2017-03-17 at 17:31 +0100, Stefan Wahren wrote: > > > Hi Michael, > > > >

Re: [PATCH 0/6] staging: bcm2835-firmware-gpio: Initial staging commit

2017-03-17 Thread Michael Zoran
On Fri, 2017-03-17 at 17:31 +0100, Stefan Wahren wrote: > Hi Michael, > > > Am 17.03.2017 um 16:22 schrieb Michael Zoran: > > The firmware now has a mailbox API for performing generalized gpio > > through > > the firmware.  This driver builds upon a driver written

[PATCH 5/6] staging: bcm2835-firmware-gpio: Add a build system for the driver

2017-03-17 Thread Michael Zoran
This change adds the driver to the standard kernel build system. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/Kconfig| 2 ++ drivers/staging/vc04_services/Makefile | 1 + drivers/staging/vc04_services/bcm2835-firmware-gpio/Kconfig

[PATCH 3/6] staging: bcm2835-firmware-gpio: Expand DT options for driver

2017-03-17 Thread Michael Zoran
-off-by: Michael Zoran --- .../bcm2835-firmware-gpio/gpio-bcm-exp.c | 40 -- 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-firmware-gpio/gpio-bcm-exp.c b/drivers/staging/vc04_services/bcm2835-firmware-gpio/gpio

[PATCH 6/6] staging: vc04_services: Update makefile to use CONFIG_BCM_VIDEOCORE

2017-03-17 Thread Michael Zoran
The toplevel config for vc04_services is CONFIG_BCM2835_VCHIQ. Since other drivers are being added that don't use vchiq, change the toplevel Makefile to use CONFIG_BCM_VIDEOCORE. Signed-off-by: Michael Zoran --- drivers/staging/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 4/6] staging: bcm2835-firmware-gpio: Add brcm, bcm2835-firmware-gpio to compatible list

2017-03-17 Thread Michael Zoran
Since this driver is really a generalized mechanism for doing GPIO through the firmware, add a new compatible id for brcm,bcm2835-firmware-gpio. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-firmware-gpio/gpio-bcm-exp.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 2/6] staging: bcm2835-firmware-gpio: Add needed mailbox defines to driver

2017-03-17 Thread Michael Zoran
(commit efad03c3c86642dafccc03fcdd3ab84dd11e2ab7) Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-firmware-gpio/gpio-bcm-exp.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/vc04_services/bcm2835-firmware-gpio/gpio-bcm-exp.c b/drivers/staging

[PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-17 Thread Michael Zoran
Stripped off changes to Makefile and Kconfig Also stripped off changes to raspberrypi-firmware.h Moved to drivers/staging/vc04_services/bcm2835-firmware-gpio Signed-off-by: Michael Zoran --- .../bcm2835-firmware-gpio/gpio-bcm-exp.c | 256 + 1 file changed, 256

[PATCH 0/6] staging: bcm2835-firmware-gpio: Initial staging commit

2017-03-17 Thread Michael Zoran
firmware = <&firmware>; }; hdmi { hpd-gpios = <&firmwaregpio 132 GPIO_ACTIVE_LOW>; }; }; }; &uart1 { status = "okay"; }; Dave Stevenson (1): bcm2835-g

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-15 Thread Michael Zoran
On Wed, 2017-03-15 at 22:08 -0300, Mauro Carvalho Chehab wrote: > No, I didn't. Thanks! Applied it but, unfortunately, didn't work. > Perhaps I'm missing some other patch. I'm compiling it from > the Greg's staging tree (branch staging-next): > https://git.kernel.org/pub/scm/linux/kernel/git

[PATCH V3 0/1] staging: bcm2835-audio: Add support for simultanous HDMI and Headphone audio

2017-03-14 Thread Michael Zoran
as well and perhaps it would make sense for it to be on by default after it gets tested more. Michael Zoran (1): staging: bcm2835-audio: Add support for simultanous HDMI and Headphone audio .../vc04_services/bcm2835-audio/bcm2835-ctl.c | 86 + .../vc04_services

[PATCH V3 1/1] staging: bcm2835-audio: Add support for simultanous HDMI and Headphone audio

2017-03-14 Thread Michael Zoran
same time through the HDMI and Headphones jacks and control the audio independently. Signed-off-by: Michael Zoran --- .../vc04_services/bcm2835-audio/bcm2835-ctl.c | 86 + .../vc04_services/bcm2835-audio/bcm2835-pcm.c | 40 +- .../staging/vc04_services/bcm2835-audio/bcm283

[PATCH] bcm2835-v4l2: Fix buffer overflow problem

2017-03-14 Thread Michael Zoran
a belt-and-braces check to ensure we never copy more than *value_size bytes into value. Signed-off-by: Dave Stevenson Signed-off-by: Michael Zoran Tested-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion

[PATCH V2 1/1] staging: bcm2835-audio: Add support for simultanous HDMI and Headphone audio

2017-03-14 Thread Michael Zoran
same time through the HDMI and Headphones jacks and control the audio independently. Signed-off-by: Michael Zoran --- .../vc04_services/bcm2835-audio/bcm2835-ctl.c | 86 + .../vc04_services/bcm2835-audio/bcm2835-pcm.c | 40 +- .../staging/vc04_services/bcm2835-audio/bcm283

[PATCH V2 0/1] staging: bcm2835-audio: Add support for simultanous HDMI and Headphone audio

2017-03-14 Thread Michael Zoran
snd_bcm2835_new_simple_pcm. 3. Standardize on if (err) instead of if (err < 0). 4. Multiple minor formating fixes. Michael Zoran (1): staging: bcm2835-audio: Add support for simultanous HDMI and Headphone audio .../vc04_services/bcm2835-audio/bcm2835-ctl.c | 86 + .../vc04_servi

Re: [PATCH 2/2] staging: bcm2835-audio: Disable extra virtual cards by default

2017-03-14 Thread Michael Zoran
On Tue, 2017-03-14 at 14:05 +0300, Dan Carpenter wrote: > On Tue, Mar 14, 2017 at 01:55:01AM -0700, Michael Zoran wrote: > > On Tue, 2017-03-14 at 09:17 +0100, Stefan Wahren wrote: > > > Am 14.03.2017 um 07:45 schrieb Michael Zoran: > > > > The extra virtual cards

Re: [PATCH 2/2] staging: bcm2835-audio: Disable extra virtual cards by default

2017-03-14 Thread Michael Zoran
On Tue, 2017-03-14 at 09:17 +0100, Stefan Wahren wrote: > Am 14.03.2017 um 07:45 schrieb Michael Zoran: > > The extra virtual cards created for HDMI and Headphone output > > may not be compatible with operating systems that expose > > very simple audio controls. > > >

[PATCH 1/2] staging: bcm2835-audio: Add support for simultanous HDMI and Headphone audio

2017-03-13 Thread Michael Zoran
same time through the HDMI and Headphones jacks and control the audio independently. Signed-off-by: Michael Zoran --- .../vc04_services/bcm2835-audio/bcm2835-ctl.c | 86 + .../vc04_services/bcm2835-audio/bcm2835-pcm.c | 45 ++- .../staging/vc04_services/bcm2835-audio/bcm283

[PATCH 2/2] staging: bcm2835-audio: Disable extra virtual cards by default

2017-03-13 Thread Michael Zoran
the extra virtual cards. Signed-off-by: Michael Zoran --- .../staging/vc04_services/bcm2835-audio/Kconfig| 26 ++ .../staging/vc04_services/bcm2835-audio/bcm2835.c | 18 +++ 2 files changed, 44 insertions(+) diff --git a/drivers/staging/vc04_services/bcm2835

Re: [PATCH 08/10] staging: bcm2835-camera: Fix buffer overflow calculation on query of camera properties

2017-03-10 Thread Michael Zoran
On Fri, 2017-03-10 at 11:11 +, Dave Stevenson wrote: > On 10 March 2017 at 05:08, Michael Zoran wrote: > > The code that queries properties on the camera has a check > > for buffer overruns if the firmware sends too much data.  This > > check is incorrect, and during

[PATCH] staging: vchi: Remove ARM64 from TODO list

2017-03-09 Thread Michael Zoran
changes should be needed, perhaps it's best to remove it from the TODO list. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/interface/vchi/TODO | 21 +++-- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/drivers/staging/vc04_services/interface

[PATCH 08/10] staging: bcm2835-camera: Fix buffer overflow calculation on query of camera properties

2017-03-09 Thread Michael Zoran
2 bit as often. So perhaps it's best for the check to be fixed. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drive

[PATCH 10/10] staging: bcm2835-camera: remove depends on ARM

2017-03-09 Thread Michael Zoran
Since all the arm64 specific issues have been fixed now and the camera is working fine with a arm64 kernel, the depends on ARM can be removed from Kconfig. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a

[PATCH 07/10] staging: bcm2835-camera: Convert spinlock to mutex in handle mapping code

2017-03-09 Thread Michael Zoran
x27;s better to just use a mutex. Signed-off-by: Michael Zoran --- .../vc04_services/bcm2835-camera/mmal-vchiq.c | 23 +++--- 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_ser

[PATCH 09/10] staging: bcm2835-camera: Fix bogus compiler warnings regarding constants

2017-03-09 Thread Michael Zoran
In debug logging code, the compiler is warning about imposible situations and size of constants not matching the format specifier. This change fixes all three instances of this. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h | 4 ++-- drivers

[PATCH 04/10] staging: bcm2835-camera: Convert client_context field to a 32 bit handle

2017-03-09 Thread Michael Zoran
The client_context field is passed around which is really just a pointer to a msg_context. A lookup table mechanism for msg_context was added previously, so convert this field to a handle as well. The firmware never interperates the client_context, just passed it back. Signed-off-by: Michael

[PATCH 00/10] staging: bcm2835-camera: Finish ARM64 port

2017-03-09 Thread Michael Zoran
camera with the simplefb graphics driver instead of VC4 since the firmware has known issues with the camera when used at the same time as the VC4 driver. This is a known issue and Eric Anholt is working on what is needed from the firmware to make that work. Michael Zoran (10): staging: bcm2835

[PATCH 01/10] staging: bcm2835-camera: Create struct mmal_es_format_local to mirror struct mmal_es_format

2017-03-09 Thread Michael Zoran
The struct struct mmal_es_format is passed between the firmware which has pointers. A local version of mmal_es_format is also used. Luckly, the two versions are always memberwise copied from each other so simply have different structures for the local and msg versions. Signed-off-by: Michael

[PATCH 03/10] staging: bcm2835-camera: Convert delayed_buffer to u32

2017-03-09 Thread Michael Zoran
A delayed buffer field is passed between the firmware and the kernel. This field is never used either so it's safe to change it to a u32. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH 02/10] staging: bcm2835-camera: Convert client_component field to u32

2017-03-09 Thread Michael Zoran
In the messages passed back and forth between the camera and the firmware, a client_component field is passed. This is a pointer to a structure that represents part of the camera. Luckly, it's only used for debug logging, so simply convert it to a u32. Signed-off-by: Michael Zoran --- dr

[PATCH 06/10] staging: bcm2835-camera: Convert struct mmal_buffer_header info fields to u32

2017-03-09 Thread Michael Zoran
The struct mmal_buffer_header has multiple fields used for informational and debugging purposes. These are safe to convert to u32. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h | 10 +- drivers/staging/vc04_services/bcm2835-camera/mmal

[PATCH 05/10] staging: bcm2835-camera: Convert struct mmal_port info fields to u32

2017-03-09 Thread Michael Zoran
The struct mmal_port has a few informational fields. Convert these to u32. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/mmal-msg-port.h | 10 +- drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c| 2 +- 2 files changed, 6 insertions(+), 6

[PATCH 1/2] staging: bcm2835_camera: Convert control_service field of mmal_msg_header to u32

2017-03-08 Thread Michael Zoran
a u32 which has a fixed size. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h b/drivers/staging/vc04_services/bcm2835-camera/mmal

[PATCH 0/2] staging: bcm2835_camera: Fix pointer dependency of mmal_msg_header

2017-03-08 Thread Michael Zoran
a local version of the data and a remote version, and do a memberwise copy when converting between the two. The local version does need to have a pointer, but the pointer itself does not need to be sent access the communication channel. Michael Zoran (2): staging: bcm2835_camera: Convert contro

[PATCH 2/2] staging: bcm2835_camera: Use a mapping table for context field of mmal_msg_header

2017-03-08 Thread Michael Zoran
The btree library is a hidden configuration option. Signed-off-by: Michael Zoran --- .../staging/vc04_services/bcm2835-camera/Kconfig | 1 + .../vc04_services/bcm2835-camera/mmal-msg.h| 2 +- .../vc04_services/bcm2835-camera/mmal-vchiq.c | 176 ++--- 3 files ch

[PATCH] staging: bcm2835-camera: Remove explicit cache flush operations

2017-03-08 Thread Michael Zoran
V2 camera for the RPI was tested on a RPI 3 running in 32 bit mode(armhf). The cheese application and ffmpeg was used to view and stream video from the camera. Nothing new seems to be broken without the cache flushing. Signed-off-by: Michael Zoran --- drivers

[PATCH V5 2/2] staging: vchiq_arm: Disable ability to dump memory by default

2017-03-07 Thread Michael Zoran
value, create a new build configuration and disable the feature by default. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/Kconfig | 12 .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 14 ++ 2 files changed, 26 inser

[PATCH V5 0/2] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-07 Thread Michael Zoran
reenable it for support of existing closed source diagnostic tools. Michael Zoran (2): staging: vchiq_arm: Add compatibility wrappers for ioctls staging: vchiq_arm: Disable ability to dump memory by default drivers/staging/vc04_services/Kconfig | 12

[PATCH V5 1/2] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-07 Thread Michael Zoran
for the RPI and that kernel was built for arm64. That kernel was used to boot Raspbian. Many of the builtin features are now functional such as the "hello_pi" examples, and minecraft_pi. Signed-off-by: Michael Zoran --- .../vc04_services/interface/vchiq_arm/vchiq_ar

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-06 Thread Michael Zoran
On Mon, 2017-03-06 at 17:11 +0100, Stefan Wahren wrote: > Am 06.03.2017 um 16:57 schrieb Michael Zoran: > > On Mon, 2017-03-06 at 14:01 +0100, Greg KH wrote: > > > On Sat, Mar 04, 2017 at 06:57:50AM -0800, Michael Zoran wrote: > > > > On Sat, 2017-03-04 at 14

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-06 Thread Michael Zoran
On Mon, 2017-03-06 at 18:22 +0300, Dan Carpenter wrote: > > + > > +struct vchiq_completion_data32 { > > + VCHIQ_REASON_T reason; > > + compat_uptr_t header; > > + compat_uptr_t service_userdata; > > + compat_uptr_t bulk_userdata; > > +}; > > + > > +struct vchiq_await_completion32 { > > +

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-06 Thread Michael Zoran
On Mon, 2017-03-06 at 14:01 +0100, Greg KH wrote: > On Sat, Mar 04, 2017 at 06:57:50AM -0800, Michael Zoran wrote: > > On Sat, 2017-03-04 at 14:58 +0300, Dan Carpenter wrote: > > > On Wed, Mar 01, 2017 at 07:41:46PM -0800, Michael Zoran wrote: > > > > Changes: > &g

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-04 Thread Michael Zoran
On Sat, 2017-03-04 at 14:58 +0300, Dan Carpenter wrote: > On Wed, Mar 01, 2017 at 07:41:46PM -0800, Michael Zoran wrote: > > Changes: > > V1 - Complete rewrite of the ioctl code. > > V2 - Rewrite of only ioctls that change > >  between 32 bit and 64

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-02 Thread Michael Zoran
On Thu, 2017-03-02 at 21:07 +0100, Stefan Wahren wrote: > > Michael Zoran hat am 2. März 2017 um 04:41 > > geschrieben: > > > +static long > > +vchiq_compat_ioctl_dump_phys_mem(struct file *file, > > +  unsigned int cmd, > > +

Re: [RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-02 Thread Michael Zoran
On Thu, 2017-03-02 at 10:45 -0800, Eric Anholt wrote: > Michael Zoran writes: > > >   > > +#if defined(CONFIG_COMPAT) > > +static long > > +vchiq_compat_ioctl_queue_message(struct file *file, > > +  unsigned int cmd, > > +

[RESEND PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-03-01 Thread Michael Zoran
hat change between 32 bit and 64 bit. V3 - Minor changes. V4(This Version) - Abandon cleaning up the exising code and completely write the wrappers on top of the native ioctls. No existing lines are changed. Signed-off-by: Mic

[PATCH V2 2/3] staging: bcm2835-audio: select BCM2835_VCHIQ rather then depending on it.

2017-03-01 Thread Michael Zoran
ot be what most people would expect. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-audio/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/Kconfig b/drivers/staging/vc04_services/bcm2835-audio/Kco

[PATCH V2 1/3] staging: vc04_services: Create new BCM_VIDEOCORE setting for VideoCore services.

2017-03-01 Thread Michael Zoran
Create a new memuconfig for Broadcom VideoCore services since VideoCore is a general term used by Broadcom for a large family of products that includes more then the BCM2835. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/Kconfig | 15 +++ 1 file changed, 11

[PATCH V2 3/3] staging: bcm2835-camera: select BCM2835_VCHIQ rather then depending on it.

2017-03-01 Thread Michael Zoran
may not be what most people would expect. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/Kconfig b/drivers/staging/vc04_services/bcm2835-came

[PATCH V2 0/3] staging: vc04-services: Create new toplevel config BCM_VIDEOCORE

2017-03-01 Thread Michael Zoran
1. Change toplevel config to BCM_VIDEOCORE Michael Zoran (3): staging: vc04_services: Create new BCM_VIDEOCORE setting for VideoCore services. staging: bcm2835-audio: select BCM2835_VCHIQ rather then depending on it. staging: bcm2835-camera: select BCM2835_VCHIQ rather then depen

Re: [PATCH 1/2] staging/vc04_services: initialize cache line size properly

2017-03-01 Thread Michael Zoran
Hi Arnd, I submitted a change which is in Linux-next now that makes the whole CACHE_LINE_SIZE macro meaningless. It now always reads the size from the DT and errors out with -ENODEV if the property is missing. I was going to submit a change to delete the macro completely, just never got to it.

Re: [PATCH 2/3] staging: bcm2835-audio: select BCM2835_VCHIQ rather then depending on it.

2017-03-01 Thread Michael Zoran
On Wed, 2017-03-01 at 16:51 +0300, Dan Carpenter wrote: > On Tue, Feb 28, 2017 at 09:18:56PM +0100, Stefan Wahren wrote: > > > > > Michael Zoran hat am 28. Februar 2017 um > > > 19:49 geschrieben: > > > > > > > > > Change the audio's d

Re: [PATCH 2/3] staging: bcm2835-audio: select BCM2835_VCHIQ rather then depending on it.

2017-02-28 Thread Michael Zoran
On Tue, 2017-02-28 at 21:18 +0100, Stefan Wahren wrote: > > Michael Zoran hat am 28. Februar 2017 um > > 19:49 geschrieben: > > > > > > Change the audio's dependency on BCM2835_VCHIQ to a select. > > > > Signed-off-by: Michael Zoran > >

Re: [PATCH 1/3] staging: vc04_services: Create new CONFIG_VIDEOCORE setting for VideoCore services.

2017-02-28 Thread Michael Zoran
On Tue, 2017-02-28 at 20:19 +0100, Greg KH wrote: > On Tue, Feb 28, 2017 at 10:49:35AM -0800, Michael Zoran wrote: > > Create a new config for Broadcom VideoCore services. > > > > Signed-off-by: Michael Zoran > > --- > >  drivers/staging/vc04_services/Kconfig

[PATCH 1/3] staging: vc04_services: Create new CONFIG_VIDEOCORE setting for VideoCore services.

2017-02-28 Thread Michael Zoran
Create a new config for Broadcom VideoCore services. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/Kconfig | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig index

[PATCH 2/3] staging: bcm2835-audio: select BCM2835_VCHIQ rather then depending on it.

2017-02-28 Thread Michael Zoran
Change the audio's dependency on BCM2835_VCHIQ to a select. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-audio/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/Kconfig b/drivers/st

[PATCH 3/3] staging: bcm2835-camera: select BCM2835_VCHIQ rather then depending on it.

2017-02-28 Thread Michael Zoran
Change the camera's dependency on BCM2835_VCHIQ to a select. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/Kconfig b/drivers/st

[PATCH 0/3] staging: vc04-services: Create new toplevel config VIDEOCORE

2017-02-28 Thread Michael Zoran
her then depend on BCM2835_VCHIQ. This allows BCM2835_VCHIQ to be changed to say a module independenly, but yet the menu still works just like the original description says that it should. It is forced in if any of the specific VideoCore services(like camera) are enabled. Michael Zoran (3): s

[PATCH 2/4] staging: bcm2835-camera: Move driver under vc04_services

2017-02-27 Thread Michael Zoran
The bcm2835-camera driver is part of v04_services, so it makes sense for it to be located under vc04_services to make configuration clearer. Signed-off-by: Michael Zoran --- drivers/staging/media/Kconfig | 2 -- drivers/staging/media/Makefile

[PATCH 0/4] Move VCHIQ/VC04_SERVICES based camera and audio support under vc04_services directory

2017-02-27 Thread Michael Zoran
. These driver all need to stay in staging for now since all of the drivers need significant cleanup work. Michael Zoran (4): staging: bcm2835-audio: Move driver under vc04_services staging: bcm2835-camera: Move driver under vc04_services staging: bcm2835-audio: Update driver description

[PATCH 4/4] staging: bcm2835-camera: Update driver name

2017-02-27 Thread Michael Zoran
Update the name of the camera driver as displayed by the Kconfig to match the audio driver style. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/bcm2835

[PATCH 1/4] staging: bcm2835-audio: Move driver under vc04_services

2017-02-27 Thread Michael Zoran
The bcm2835-audio driver is part of v04_services, so it makes sense for it to be located under vc04_services to make configuration clearer. Signed-off-by: Michael Zoran --- drivers/staging/Kconfig | 2 -- drivers/staging/Makefile

[PATCH 3/4] staging: bcm2835-audio: Update driver description

2017-02-27 Thread Michael Zoran
The audio driver description contains a reference to a card. Since this is for built in audio, drop the card reference from the description. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-audio/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

driverdev-devel@linuxdriverproject.org

2017-02-27 Thread Michael Zoran
On Mon, 2017-02-27 at 12:35 -0800, Scott Branden wrote: > > > Hi Julia, > > On 17-02-26 10:25 PM, Julia Lawall wrote: > > > > If you consider that you are getting too much outreachy mail at the > > moment, just let me know what subsystem you want me to add an > > exception > > for. > > The emai

[PATCH V4] staging: vchiq_arm: Add compatibility wrappers for ioctls

2017-02-26 Thread Michael Zoran
hat change between 32 bit and 64 bit. V3 - Minor changes. V4(This Version) - Abandon cleaning up the exising code and completely write the wrappers on top of the native ioctls. No existing lines are changed. Signed-off-by: Mic

Re: [PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

2017-02-26 Thread Michael Zoran
On Sun, 2017-02-26 at 20:36 +0100, Noralf Trønnes wrote: > Den 26.02.2017 19.11, skrev Stefan Wahren: > > > Eric Anholt hat am 26. Februar 2017 um 18:16 > > > geschrieben: > > > > > > ... > > > > > > For staging, Greg has been taking patches without platform > > > maintainer > > > ack.  I think

Re: [PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

2017-02-25 Thread Michael Zoran
On Sat, 2017-02-25 at 19:15 +0100, Stefan Wahren wrote: > > > > What's the rule as to who exactly I should be including on > > patches?  > > get_maintainer.pl displays a very long list for stagging, so it > > isn't > > clear to me who should be getting this. > > At least the active maintainers (b

  1   2   3   >