x_hint and y_hint
against ~0 below, rather than -1 (see inline below)? Other than that,
looks good to me. I will send Gianfranco a patch to test against
Ubuntu's version of the driver.
Regards
Michael
> Reported-by: Gianfranco Costamagna
> Cc: sta...@vger.kernel.org
> Cc: Michael
yet, but as
said, it looks completely sensible.
Regards
Michael
Acked-by: Michael Thayer
> Regards,
>
> Hans
>
>
>> ---
>> drivers/staging/vboxvideo/vbox_mode.c | 5 -
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/staging/vboxvi
s de Goede
Looks good to me too. Sorry for the slow response. Still had no time
to actually apply it, but as said, it looks completely sensible.
Regards
Michael
Acked-by: Michael Thayer
>> ---
>> drivers/staging/vboxvideo/vbox_drv.c | 2 +-
>> drivers/staging/vboxvid
/drm/vbox_fb.c (revision 116355)
+++ src/VBox/Additions/linux/drm/vbox_fb.c (working copy)
@@ -364,6 +364,9 @@
if (fbdev->helper.fbdev) {
info = fbdev->helper.fbdev;
+#ifdef CONFIG_FB_DEFERRED_IO
+ fb_deferred_io_cleanup(info);
+#endif
small as possible will make sense for me.
Regards
Michael
[...]
--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt
ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht Münch
d-up
code? Of course, I am open to patches or suggestions as to how to
simplify the code in our repository as long as they do not affect other
platforms (vboxguest builds and runs for five different operating system
kernels).
Regards
Michael
> Regards,
>
> Hans
--
Michael Thayer | Virt
nversion to Atomic would probably have to happen at some time or
another anyway. I have put that off (out-of-tree) so far because I was
tracking the AST driver as closely as possible as the simplest way of
picking up fixes, and because Dave, who wrote that, knows much more
about drm drivers
as the subject
is relevant to it.
Regards, and sorry for the annoyance
Michael
--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt
ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgerich
13.06.2017 15:59, Greg Kroah-Hartman wrote:
> On Tue, Jun 13, 2017 at 03:45:14PM +0200, Michael Thayer wrote:
>> 13.06.2017 14:48, Greg Kroah-Hartman wrote:
>> [Discussion of vboxvideo coding style.]
>>> Once your code is accepted into the main kernel tree, why would you
&g
ports to its stable kernels.
Regards
Michael
[...]
--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt
ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95
style throws a bit of a
spanner in that).
Please be clear, I am not trying to dictate to anyone. The code is GPL,
it is fine to include it with whatever modifications you deem
appropriate. Since individual distributions are already doing that, it
will still simplify our life somewhat if it is
ould be explained by waiting for a moderator,
though I don't get a warning that the message is waiting for approval.
For now we have disabled that on vbox-dev too (I assume that was the
list you meant).
Regards
Michael
--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG
not trying to argue here, just to get an idea for my
own planning.
Regards
Michael
Dave.
--
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt
ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
kes sense in a virtual machine, where you often explicitly want to be
running older software). And on the other hand, someone who doesn't
need that might also appreciate knowing that it doesn't apply to them.
Regards and thanks
Michael
Regards,
Hans--
Michael Thayer | VirtualBox e
14 matches
Mail list logo
