Re: [PATCH RESEND 1/2] staging: binder: add __user annotation in binder.c

2014-04-15 Thread Mathieu Maret
Dan Carpenter wrote: > This is the first time you have sent it to the list, it's not a RESEND. > The first one was only on the linux-kernel mailing list. May be, that's why you did not get it. As it was just before the 3.14 release, I was asked to resend latter. Is it the expected meaning of the

[PATCH RESEND 2/2] staging: binder: Code simplification

2014-04-15 Thread Mathieu Maret
Remove duplicate code Signed-off-by: Mathieu Maret --- drivers/staging/android/binder.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index 3dca577..c29c3c7 100644 --- a/drivers/staging/android

[PATCH RESEND 1/2] staging: binder: add __user annotation in binder.c

2014-04-15 Thread Mathieu Maret
Add __user to binder_version to correct sparse warning. Reduce line size to fit to coding style. Signed-off-by: Mathieu Maret --- drivers/staging/android/binder.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging

[PATCHv2 4/5] staging: wlags49_h2: Correct macro style in wl_netdev.c

2014-03-19 Thread Mathieu Maret
Multi statement macro should use do{}while(0) patch v2 does not break compilation --- drivers/staging/wlags49_h2/wl_netdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlags49_h2/wl_netdev.c b/drivers/staging/wlags49_h2/wl_netdev.c index 255d291..

[PATCH 4/5] staging: wlags49_h2: Correct macro style in wl_netdev.c

2014-03-19 Thread Mathieu Maret
Multi statement macro should use do{}while(0) Signed-off-by: Mathieu Maret --- drivers/staging/wlags49_h2/wl_netdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wlags49_h2/wl_netdev.c b/drivers/staging/wlags49_h2/wl_netdev.c index 255d291

[PATCH 5/5] staging: wlags49_h2: Correct coding style in wl_netdev.c

2014-03-19 Thread Mathieu Maret
Remove space between parenthesis. Test with simple statement does not need brackets. Simplify test condition Signed-off-by: Mathieu Maret --- drivers/staging/wlags49_h2/wl_netdev.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/drivers

[PATCH 3/5] staging: wlags49_h2: Correct comment style in wl_netdev.c

2014-03-19 Thread Mathieu Maret
Code is using C99 code style, so change them to kernel style Signed-off-by: Mathieu Maret --- drivers/staging/wlags49_h2/wl_netdev.c | 158 +++-- 1 file changed, 89 insertions(+), 69 deletions(-) diff --git a/drivers/staging/wlags49_h2/wl_netdev.c b/drivers/staging

[PATCH 2/5] staging: wlags49_h2: remove commented code in wl_netdev.c

2014-03-19 Thread Mathieu Maret
Remove unused code under C99 comment style Signed-off-by: Mathieu Maret --- drivers/staging/wlags49_h2/wl_netdev.c | 38 -- 1 file changed, 38 deletions(-) diff --git a/drivers/staging/wlags49_h2/wl_netdev.c b/drivers/staging/wlags49_h2/wl_netdev.c index