eak/goto/return/fallthrough statements instead of just
> letting the code fall through to the next case.
>
> [...]
Applied to 5.11/scsi-queue, thanks!
[054/141] target: Fix fall-through warnings for Clang
https://git.kernel.org/mkp/scsi/c/492096ecfa39
--
Martin K. Petersen
Gustavo,
> This series aims to fix almost all remaining fall-through warnings in
> order to enable -Wimplicit-fallthrough for Clang.
Applied 20-22,54,120-124 to 5.11/scsi-staging, thanks.
--
Martin K. Petersen Oracle Linux Engin
b: zstd: Avoid comma separated statements
(no commit info)
[27/29] ipv6: fib6: Avoid comma separated statements
(no commit info)
[28/29] sunrpc: Avoid comma separated statements
(no commit info)
[29/29] tools: Avoid comma separated statements
(no commit info)
--
, now
> they each get their own copy, which leads to a huge increase in stack
> usage as seen from the compiler warning:
Applied to 5.3/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriv
ue and 5.3/scsi-sg.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Bart,
> Do you perhaps plan to push out these patches at a later time? It
> seems like that branch has not been updated recently:
I had a test failure on this end, that's why I didn't push. Appears to
be hardware-related, though. Still looking into it.
--
Martin K. Petersen
e
change.
Oh, and I held back the rtsx patch due to lack of reviews. But since
that driver is in staging I'm not too worried about it. Hope we can get
the fix for that reviewed and merged soon.
--
Martin K. Petersen Oracle Linux Engineering
__
4.21 so this patch isn't needed.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
gt; because at the beginning of vmbus_open() we checked newchannel->state so
> only one path could succeed, and the other would return with -EINVAL.
Applied to 4.20/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
_
ntr has been moved out of pvscsi_release_resources.
Applied to 4.20/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Michael,
> Current code allocates 240 Kbytes (in typical configs) for each
> synthetic SCSI controller to use as temp cpumask variables. Recode to
> avoid needing the temp cpumask variables and remove the memory
> allocation.
Applied to 4.18/scsi-queue. Thanks!
--
Martin
Long,
> If num_cpus=1, we don't have any sub channels.
>
> The host offers one sub channel for VM with 5 CPUs, after that it offers
> an additional sub channel every 4 CPUs.
>
> The primary channel is always offered.
Applied to 4.17/scsi-fixes. Thanks!
--
Martin K. Pet
ytes) to take advantage of cache locality.
Applied to 4.18/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Long,
> Can you take a look at the following patch?
>> > + max_sub_channels =
>> > + (num_cpus - 1) / storvsc_vcpus_per_sub_channel;
What happens if num_cpus = 1?
--
Martin K. Petersen Oracle Linux Engineering
_
8/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ll need an ack from davem.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Michael,
> Increase cmd_per_lun to allow more I/Os in progress per device,
> particularly for NVMe's. The Hyper-V host side can handle the higher
> count with no issues.
Applied to 4.16/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Lin
ode, skewing
> the interrupt load to that CPU.
Applied to 4.16/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> Increase cmd_per_lun to allow more I/Os in progress per device,
> particularly for NVMe's. The Hyper-V host side can handle the
> higher count with no issues.
Long/KY/Cathy/Stephen: Please ack/review Michael's patches.
--
Martin K. Petersen Oracl
Dan,
> We should set the error code if fc_remote_port_add() fails.
Applied to 4.16/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.
-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
SCSI
> host.
Applied to 4.15/scsi-queue with some fuzz. Please verify, thanks!
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
:
> Replaced create_singlethread_workqueue with
> alloc_ordered_workqueue [Christoph Hellwig]
>
> Added reviewed by's.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> forward progress guarantee and use WQ_MEM_RECLAIM if so.
Cathy?
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Long,
>> Which kernel version is this patch aimed at?
>
> Martin, thanks for pointing this out. This should also go to stable
> trees.
The reason I asked is that it didn't apply to neither fixes, nor
for-next.
I applied it to 4.13/scsi-fixes by hand and added a stabl
uffer busy, the storvsc
> allocated buffer descriptor should also be freed.
Which kernel version is this patch aimed at?
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverpr
Bhumika,
> Make these const as they are only stored in the type field of a device
> structure, which is const.
Applied to 4.14/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing l
tch is simple and
the path of least resistance.
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Stephen,
> These are refactoring changes to the Hyper-V scsi driver.
Applied to 4.13/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.
r rport role in the fc transport.
Applied to 4.12/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
a good time to send submissions for 4.12...
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
n> By setting the correct blacklist flags, the target with the DVD
Stephen> device is scanned with REPORTLUN and that works correctly.
Applied to 4.11/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de..
>>>>> "kys" == kys writes:
kys> From: K. Y. Srinivasan Miscellaneous fixes and
kys> enhancements.
Applied to 4.11/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de
>>>>> "Cathy" == Cathy Avery writes:
Cathy> On a 32 bit kernel sizeof(void *) is not 64 bits as hv_mpb_array
Cathy> requires. Also the buffer needs to be cleared or the upper bytes
Cathy> will contain junk.
Applied to 4.10/scsi-queue.
--
Martin K. Pete
>>>>> "KY" == KY Srinivasan writes:
KY> Done.
Thank you!
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>>>>> "Cathy" == Cathy Avery writes:
Cathy> On a 32 bit kernel sizeof(void *) is not 64 bits as hv_mpb_array
Cathy> requires. Also the buffer needs to be cleared or the upper bytes
Cathy> will contain junk.
K.Y.: Please review!
--
Martin K. Pete
re 32 is the correct size?
Olaf> Its a size that works, while the current state does not work at
Olaf> all.
>> I know 32 it what it had before, but the reason for the commit you
>> quote was to improve performance ...
Olaf> The commit above broke 32bit. Wh
>>>>> "Cathy" == Cathy Avery writes:
Cathy> When a virtual scsi DVD device is present with no image file
Cathy> attached the storvsc driver logs all resulting unnecessary sense
Cathy> errors whenever IO is issued to the device.
Tweaked whitespace and applie
lternative to the FC transport would be a better
solution.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
I now have wwn names published in the guest and I can also
KY> issue manual scan.
Why does it have to look like FC? Will a device identification VPD page
not do the trick?
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailin
B_STATUS_AUTOSENSE_VALID) case a dead code. The logic from
Vitaly> this branch (e.g. storvsc_device_scan() call) is still required,
Vitaly> fix the check.
Applied to 4.5/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
___
>>>>> "kys" == K Y Srinivasan writes:
kys> With this commit, the storvsc driver depends on FC
kys> atttributes. Make this dependency explicit.
Applied to 4.6/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
__
>>>>> "Dan" == Dan Carpenter writes:
Dan> The module_param is "storvsc_vcpus_per_sub_channel" so we need to
Dan> use that for MODULE_PARM_DESC() as well.
Applied to 4.5/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
>>>>> "KYS" == K Y Srinivasan writes:
The template discussion appears to have lost momentum and since the
concerns were minor I have applied your latest series to 4.5/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
>>>>> "Long" == Long Li writes:
Long> Introduce a logging level for storvsc to log certain error/warning
Long> messages. Those messages are helpful in some environments,
Long> e.g. Microsoft Azure, for customer support and troubleshooting
Long> purposes.
App
e latter is controlled
by the logical block provisioning heuristics and is not affected by
no_write_same at all.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
{"Msft", "Virtual Disk", "1.0", BLIST_TRY_VPD_PAGES},
Is that version field meaningful or is it safe for us to inquire about
VPD pages without problems on older versions?
--
Martin K. Petersen Oracle Linux Engineering
try_rc16_first(struct scsi_device *sdp)
{
if (sdp->host->max_cmd_len < 16)
return 0;
if (sdp->try_rc_10_first)
return 0;
if (sdp->scsi_level > SCSI_SPC_2)
return 1;
if (scsi_device_protection(sdp))
t. Whereas I know
several other devices that will benefit from the TRY_VPD_PAGES blacklist
option.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
time around we identified this as a problem with Microsoft's
interpretation of the T10 SBC spec. And they promised that they are
going to fix that.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing
>>>>> "Sitsofe" == Sitsofe Wheeler writes:
Sitsofe> A previous patch attempted to add a quirk to workaround this
Sitsofe> but the quirk was only enabled after the features had been
Sitsofe> scanned for, wouldn't work for "small" disks
What
>>>>> "KY" == KY Srinivasan writes:
KY> We will fix this bug in the next release of Windows; we are also
KY> looking at backporting the fix to prior versions of Windows.
Excellent. Thanks for looking into this!
--
Martin K. Peterse
ovisioned) in the
Logical Block Provisioning VPD page (see 6.6.4).
That's a "shall". The LBP VPD elaborates on the provisioning type,
commands preference, etc. But it's all gated by LBPME=1 in the READ
CAPACITY(16) response.
--
Martin K. Petersen Oracle Linux Engin
TY(16) response. The LBP VPD is correctly
provided with LBPU flag set but because LBPME is reported as disabled we
will not attempt to issue UNMAP commands to the device.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@l
al details.
Great! I'd just like to have a reasonable level of confidence in what's
happening down the stack before I entertain turning something on that's
not being properly advertised.
--
Martin K. Petersen Oracle Linux Engineering
__
ation?
One challenge in that department is that a single UNMAP command may turn
into many, many, many DSM TRIM commands on the underlying SATA device.
That's why we went with WRITE SAME for the internal Linux SATL, capping
the maximum number of blocks to what we can fit in a single DSM TRIM
co
ives that are
known to be working correctly. Your drive is an ADATA and therefore very
likely to be blacklisted by default by a vendor SATL.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
we were
trying to avoid with this patch series. Namely sending down commands
unsupported by the target device.
This kind of thing really needs to be a sysadmin decision and can be
handled with a udev rule.
--
Martin K. Petersen Oracle Linux Engineering
__
r
implementations are buggy. Even with a Linux implementation readily
available it's hard to get them to test since Linux is not a tier 1
platform in the consumer segment. For enterprise drives it's an entirely
different matter, of course.
e LBP VPD.
I'll contemplate the LBPME => mandatory VPD lookup thing for bit.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
express large regions, DSM TRIM on the SATA side is limited to 32
MB per range. So in many cases we end up maxing out the payload capacity
even with a single contiguous range.
We expect LBP SCSI devices to queue commands. Being able to express
multiple ranges in one shot is less cri
the READ CAPACITY(16) response. I'll see if I can locate the details.
Otherwise I'm willing to entertain that idea.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
).
If a WRITE SAME(10/16) command fails and the UNMAP bit is not set we'll
set no_write_same=1 and disable REQ_WRITE_SAME support.
If a WRITE SAME(10/16) command fails and the UNMAP bit is set we'll
disable REQ_DISCARD support.
Not sure where the 10 vs. 16 byte 2TB l
_UNMAP flag or something like
that. But BLIST_TRY_VPD_PAGES seems more generally useful and it does
fix the problem at hand. That's why I went that route.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
#x27;t
see why we'd need to overload no_write_same which was meant for an
entirely different purpose.
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ce a blacklist flag that can be used to
trigger VPD page inquiries on devices that are known to support them.
Reported-by: KY Srinivasan
Signed-off-by: Martin K. Petersen
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 4a6e4ba5a400..a5b1a224628a 100644
--- a/drivers/scsi/scs
(16) with the UNMAP bit set
unless the device sets LBPME=1 in the READ CAPACITY(16) response.
So what does the storsvc report as its thin provisioning capabilities?
--
Martin K. Petersen Oracle Linux Engineering
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
67 matches
Mail list logo
