Hello, my name is Mario Rugiero, and I'm in the process of resurrecting
the attempts to get the via driver in shape, and had a few questions on
the proper etiquette for such a thing.
As some may know, there are talks about removing dri1 support on X.org,
so we (the users interested) should updat
El 18/12/15 a las 19:50, Greg KH escribió:
On Tue, Dec 01, 2015 at 11:49:55PM -0300, Mario J. Rugiero wrote:
struct set_multicast uses (implicitly) sizeof(bool) to determine how many bytes
to copy in
Handle_SetMulticastFilter. Since that is implementation defined, it triggered
sparse to
This silences a sparse warning about incompatible comparisons, while making the
intent of the check a bit clearer.
Signed-off-by: Mario J. Rugiero
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000
Would be v3, or remains v2 because of the lack of further changes
afterwards?
Regards,
Mario.
El 03/12/15 a las 12:17, Dan Carpenter escribió:
On Thu, Dec 03, 2015 at 12:13:59PM -0300, Mario J. Rugiero wrote:
Thank you. Then the patch itself should see no changes as of now, am
I right
Thank you. Then the patch itself should see no changes as of now, am I
right?
Should I submit a new one anyway to fix the subject line?
Regards,
Mario.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/
OK. Since the maintainers are CC'd, I guess I should wait for a
clarification about this?
El 02/12/15 a las 10:29, Dan Carpenter escribió:
Put v2 in the subject. Also the subsystem prefix is:
[PATCH v3] staging: wilc1000: ...
On Mon, Nov 30, 2015 at 09:09:04PM -0300, Mario J. Rugiero
replaced the bool member by
a u32.
Also, time_out and buf_size members of ba_session_info are u16, but while
copying their
bytes into ptr in Handle_AddBASession shift 16 bits for the second byte instead
of 8 bits.
This patch fixes those two issues.
Signed-off-by: Mario J. Rugiero
---
drivers
This patch replaces an "if (ptr > 0)" comparison that seems to be a
confusing way to check for null by a simpler "if (ptr)" check.
Signed-off-by: Mario J. Rugiero
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Signed-off-by: Mario J. Rugiero
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
b/drivers/staging/wilc1000/host_interface.c
index d5b7725..9ce1d22 100644
--- a/drivers/staging/wilc1000
OK, I'll do that, thanks.
Mario.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
I didn't expect that. Maybe I used the wrong linux-next?
Just to make sure, what should I be making the patches against? I made
them against the latest next branch I was able to find on Linus tree, is
that right?
___
devel mailing list
de...@linuxdriv
Replace __attribute__(packed) by __packed as suggested by checkpatch.
Signed-off-by: Mario J. Rugiero
---
.../include/linux/libcfs/libcfs_kernelcomm.h | 2 +-
.../staging/lustre/include/linux/lnet/lib-types.h | 2 +-
.../lustre/lustre/include/lustre/lustre_idl.h | 44
would suffice
Mario J. Rugiero (4):
staging/lustre: checkpatch cleanup: macros should not use a trailing
semicolon
staging/lustre: checkpatch cleanup: __printf(string-index,
first-to-check) is preferred over __attribute__((format(printf,
string-index, first-to-check)))
staging/lustre
Replace uses of __attribute__(format(__printf,...)) by __printf(...), as
suggested by checkpatch.
Signed-off-by: Mario J. Rugiero
---
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 4 ++--
drivers/staging/lustre/lustre/include/lu_object.h | 2 +-
drivers/staging/lustre
Remove trailing semicolons from macros, as suggested by checkpatch.
Signed-off-by: Mario J. Rugiero
---
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 2 +-
drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 4 ++--
drivers/staging/lustre/lustre/include
Replace uses of __attribute__(aligned(size)) by __aligned(size), as suggested
by checkpatch.
Signed-off-by: Mario J. Rugiero
---
drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/include
Replace uses of __attribute__(aligned(size)) by __aligned(size), as
recommended by checkpatch.
Signed-off-by: Mario J. Rugiero
---
drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/include
Substitute uses of __attribute__(format(printf(...)) by __printf(...),
as recommended by checkpatch.
Signed-off-by: Mario J. Rugiero
---
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 4 ++--
drivers/staging/lustre/lustre/include/lu_object.h | 2 +-
drivers/staging
Cleanup trailing semicolons in macros, as recommended by cleanpatch.
Signed-off-by: Mario J. Rugiero
---
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 2 +-
drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 4 ++--
drivers/staging/lustre/lustre/include
Replace __attribute__(packed) by __packed, as recommended by checkpatch.
Signed-off-by: Mario J. Rugiero
---
.../include/linux/libcfs/libcfs_kernelcomm.h | 2 +-
.../staging/lustre/include/linux/lnet/lib-types.h | 2 +-
.../lustre/lustre/include/lustre/lustre_idl.h | 44
This patches cleans the following checkpatch issues:
trailing semicolons in macros
__attribute__(format(printf,...)) instead of __printf(...)
__attribute__(aligned(size)) instead of __aligned(size)
__attribute__(packed) instead of __packed
Mario J. Rugiero (4):
staging/lustre: checkpatch
OK, thanks, I'll fix it.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Do you mean a description, or the diffstats?
I thought it was enough to describe it in the cover letter, I'll fix it
and resend, thank you.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/dri
Signed-off-by: Mario J. Rugiero
---
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 2 +-
drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 4 ++--
drivers/staging/lustre/lustre/include/lprocfs_status.h | 6 +++---
3 files changed, 6 insertions(+), 6 deletions
Signed-off-by: Mario J. Rugiero
---
drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
b/drivers/staging/lustre/include/linux/libcfs
Signed-off-by: Mario J. Rugiero
---
.../include/linux/libcfs/libcfs_kernelcomm.h | 2 +-
.../staging/lustre/include/linux/lnet/lib-types.h | 2 +-
.../lustre/lustre/include/lustre/lustre_idl.h | 44 +++---
.../lustre/lustre/include/lustre/lustre_user.h | 14
Signed-off-by: Mario J. Rugiero
---
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 4 ++--
drivers/staging/lustre/lustre/include/lu_object.h | 2 +-
drivers/staging/lustre/lustre/include/lustre_dlm.h | 2 +-
drivers/staging/lustre/lustre/include/lustre_net.h
rds,
Mario.
Mario J. Rugiero (4):
staging/lustre: checkpatch cleanup: macros should not use a trailing
semicolon
staging/lustre: checkpatch cleanup: __printf(string-index,
first-to-check) is preferred over __attribute__((format(printf,
string-index, first-to-check)))
staging/lustre:
That's weird, I passed the parameter signed-off-by to git-send-email.
The from header must have been my mistake, I thought that parameter was
mandatory.
Thanks for the hint.
Regards,
Mario.
___
devel mailing list
de...@linuxdriverproject.org
http://d
s,
Mario.
>From 01a11dfacba84065a69deed929acaa84d249b7b5 Mon Sep 17 00:00:00 2001
From: "Mario J. Rugiero"
Date: Wed, 18 Feb 2015 17:23:39 -0300
Subject: [PATCH] Lustre: single statement macros should not use a do {} while
(0) loop.
Signed-off-by: Mario J. Rugiero
---
.../lustre/include/linux/li
30 matches
Mail list logo
