On Tue, Feb 19, 2019 at 11:20:10AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Feb 13, 2019 at 08:40:35PM +0100, Marcin Ciupak wrote:
> > This patch adds driver for Nordic Semiconductor nRF24L01+ radio
> > transceiver.
> >
> > Signed-off-by: Marcin Ciupak
> > -
This patch adds driver for Nordic Semiconductor nRF24L01+ radio
transceiver.
Signed-off-by: Marcin Ciupak
---
Changes in v2:
- add terminating newlines to all logging formats
Changes in v3:
- patch subject
- comments cleanup
- goto labels cleanup
- scnprintf bugfix
On Fri, Oct 19, 2018 at 09:58:01AM +0300, Dan Carpenter wrote:
> Hi Marcin,
>
> Thank you for the patch! Perhaps something to improve:
>
> url:
> https://github.com/0day-ci/linux/commits/Marcin-Ciupak/staging-nrf24-add-new-driver-for-2-4GHz-radio-transceiver/20181018-
This patch adds driver for Nordic Semiconductor nRF24L01+ radio
transceiver.
Signed-off-by: Marcin Ciupak
---
Changes in v2:
- add terminating newlines to all logging formats
Changes in v3:
- patch subject
- comments cleanup
- goto labels cleanup
- scnprintf bugfix
On Tue, Oct 16, 2018 at 02:41:50PM +0300, Dan Carpenter wrote:
> When we add drivers, can we use the new subsystem prefix for the driver?
> In other words:
>
> [PATCH] staging: nrf24: Add new driver for 2.4Ghz radio transceiver
>
Sure.
> This driver seems basically OK to me. I don't think you ne
This patch adds driver for Nordic Semiconductor nRF24L01+ radio module.
Signed-off-by: Marcin Ciupak
---
Changes in v2:
- add terminating newlines to all logging formats
drivers/staging/Kconfig | 2 +
drivers/staging/Makefile | 1 +
drivers
This patch adds driver for Nordic Semiconductor nRF24L01+ radio module.
Signed-off-by: Marcin Ciupak
---
drivers/staging/Kconfig | 2 +
drivers/staging/Makefile | 1 +
drivers/staging/nrf24/Kconfig | 16 +
drivers/staging/nrf24
This patch fixes following sparse warning:
Using plain integer as NULL pointer
in drivers/staging/most/dim2/dim2.c
Signed-off-by: Marcin Ciupak
---
drivers/staging/most/dim2/dim2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/dim2/dim2.c b/drivers
Function rf69_reset_flag is unused and should be removed.
Signed-off-by: Marcin Ciupak
---
Changes in v2:
- rebase against staging-testing
drivers/staging/pi433/rf69.c | 12
drivers/staging/pi433/rf69.h | 1 -
2 files changed, 13 deletions(-)
diff --git a/drivers/staging/pi433
Function rf69_set_sync_tolerance is unused and should be removed.
Signed-off-by: Marcin Ciupak
---
Changes in v2:
- rebase against staging-testing
drivers/staging/pi433/rf69.c | 12
drivers/staging/pi433/rf69.h | 1 -
2 files changed, 13 deletions(-)
diff --git a/drivers/staging
Remaining patches of unused functions cleanup patchset rebased against
staging-testing.
Marcin Ciupak (2):
staging: pi433: remove unused rf69_set_sync_tolerance function
staging: pi433: remove unused rf69_reset_flag function
drivers/staging/pi433/rf69.c | 24
The following functions:
* rf69_set_dc_cut_off_frequency,
* rf69_set_dc_cut_off_frequency_intern,
* rf69_set_dc_cut_off_frequency_during_afc
are unused and should be removed along with type enum dcc_percent which
was used only by these functions.
Signed-off-by: Marcin Ciupak
---
drivers/staging
Function rf69_set_ook_threshold_type is unused and should be removed
along with type enum thresholdType which was used only by that function.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 12
drivers/staging/pi433/rf69.h | 1 -
drivers/staging/pi433
Function rf69_set_ook_threshold_step is unused and should be removed
along with type enum thresholdStep which was used only by that function.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 17 -
drivers/staging/pi433/rf69.h | 1 -
drivers/staging
Function rf69_reset_flag is unused and should be removed.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 12
drivers/staging/pi433/rf69.h | 1 -
2 files changed, 13 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index
Function rf69_set_rssi_timeout is unused and should be removed.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 7 ---
drivers/staging/pi433/rf69.h | 1 -
2 files changed, 8 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index
Function rf69_set_rx_start_timeout is unused and should be removed.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 7 ---
drivers/staging/pi433/rf69.h | 1 -
2 files changed, 8 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index
Function rf69_set_sync_tolerance is unused and should be removed.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 12
drivers/staging/pi433/rf69.h | 1 -
2 files changed, 13 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
Function rf69_get_payload_length is unused and should be removed.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 5 -
drivers/staging/pi433/rf69.h | 1 -
2 files changed, 6 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index
Following functions:
* rf69_get_modulation
* rf69_read_reg
* rf69_write_reg
are used locally only and should be declared as static
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 94 ++--
drivers/staging/pi433/rf69.h | 3 --
2 files
These patches make local functions static and remove unused ones. Each
function is removed by separate patch in order to make it easier to
revert patch in future if the function will be needed in later version
of the driver.
Marcin Ciupak (9):
staging: pi433: make local functions static
On Tue, Dec 19, 2017 at 07:59:33PM +0100, Oliver Graute wrote:
> On 12/12/17, Marcin Ciupak wrote:
> >
> > this is due to fact that pi433_write returns 0 on successful copy while
> > it should return 'copied' value. So it is a bug :)
> >
> >
On Mon, Dec 11, 2017 at 10:29:54PM +0200, Marcus Wolf wrote:
>
> Am 11.12.2017 um 20:40 schrieb Oliver Graute:
> > Hello list,
> >
> > I just got my pi433 working somehow on Raspberry Pi Model B Rev 2.
> >
> > Here are my findings:
> >
> > first I need to enabling spi in config.txt on boot part
.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 3b73a3a02879..a66db795d7df 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging
only
and all other values are in else branch what leads to possibility of
setting modulation shaping for undefined modulation.
Marcin Ciupak (2):
staging: pi433: Fix missing 'undefined' value in enum modulation
staging: pi433: Fix validation of rf69_get_modulation value
drivers/sta
It is possible that rf69_get_modulation() function will return
'undefined' value and this value is missing in enum modulation. Fix this
by adding appropriate entry in enum modulation.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 2 +-
drivers/staging/pi433/r
On Sat, Dec 02, 2017 at 08:46:15AM -0800, Joe Perches wrote:
> On Sat, 2017-12-02 at 17:20 +0200, Marcus Wolf wrote:
> > rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only.
> > Therefore removed the function from header and declared it staic in
> > the implemtation.
> > Signed-o
On Sat, Nov 11, 2017 at 01:51:10PM +0200, Marcus Wolf wrote:
Hi Marcus,
since 4.15-rc1 is out I would like to ask if you are going to provide
your changes anytime soon?
I would like to send a few patches as well and do not want to block your
work.
Thanks,
Marcin
> Hi Greg,
>
> ok.
>
> I'll po
These patches fix messages logging and device naming issues when probing
for new radio module.
Those two changes are send as one patchset since both modify the same
part of code (second patch depends on first one)
Marcin Ciupak (2):
staging: pi433: fix (NULL device *) in log message
staging
When using more than one hardware radio module pi433_probe fails as the
same name is used for all modules. Create unique name by adding minor
number to the device name.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/pi433_if.c | 6 --
1 file changed, 4 insertions(+), 2 deletions
(NULL device *) is printed in log message in pi433_probe and
pi433_get_minor functions due to device->dev being used prior to call to
device_create function.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/pi433_if.c | 26 +-
1 file changed, 13 insertions(+),
This patch fixes the following checkpatch.pl error:
ERROR: "(foo*)" should be "(foo *)"
in rf69.c file as requested by TODO file.
Additionally some style warnings remain valid here and could be fixed by
another patch.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi
This patch fixes the following checkpatch.pl error:
ERROR: code indent should use tabs where possible
in rf69.c file as requested by TODO file.
Additionally some style warnings remain valid here and could be fixed by
another patch.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69
tx:VxV)
ERROR: space required before the open parenthesis '('
in rf69.c file as requested by TODO file.
Additionally some style warnings remain valid here and could be fixed by
another patch.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 154 +---
style warnings remain valid here and could be fixed by
another patch.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index
some style warnings remain valid here and could be fixed by
another patch.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 58 +++-
1 file changed, 41 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/
sis ')'
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required before the open parenthesis '('
ERROR: code indent should use tabs where possible
ERROR: "(foo*)" should be "(foo *)"
Marcin Ciupak (5):
staging: pi433: rf69.c style fix - t
nd therefore
this macro is replaced by inline code.
Additionally following 3 minor issues:
ERROR: code indent should use tabs where possible
ERROR: spaces required around that '!=' (ctx:VxV)
ERROR: space prohibited before that close parenthesis ')'
were fiexed inline.
Signed-
There is a typo in patch subject. Please drop this patch. I will send v2
with corrected subject.
Thanks,
Marcin
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
nd therefore
this macro is replaced by inline code.
Additionally following 3 minor issues:
ERROR: code indent should use tabs where possible
ERROR: spaces required around that '!=' (ctx:VxV)
ERROR: space prohibited before that close parenthesis ')'
were fiexed inline.
Signe
This patch fixes the following checkpatch.pl error:
ERROR: space required before the open brace '{'
in rf69.c file as requested by TODO file.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/sta
some style warnings remain valid here and could be fixed by
another patch.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 33 +++--
1 file changed, 11 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf
This patch fixes the following checkpatch.pl error:
ERROR: else should follow close brace '}'
in rf69.c file as requested by TODO file.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/sta
'}'
ERROR: space required before the open brace '{'
Marcin Ciupak (3):
staging: pi433: rf69.c style fix - that open brace
staging: pi433: rf69.c style fix - else close brace
staging: pi433: rf69.c style fix - spaces open brace
drivers/stagi
lid here and could be fixed
by another patch.
Signed-off-by: Marcin Ciupak
---
drivers/staging/pi433/rf69.c | 2 +-
drivers/staging/pi433/rf69.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index f83523e3395d..9f4
I did test it and not everything works as expected. I
need to reconsider that change. Please drop this patch.
Thanks,
Marcin
P.S. Sorry for late (sic!) response.
On Fri, Apr 14, 2017 at 10:16:31AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Mar 21, 2017 at 01:46:09PM +0100, Marcin Ciupak wr
Replace simple_strtoul with kstrtoint.
simple_strtoul is marked for obsoletion as reported by checkpatch.pl
Signed-off-by: Marcin Ciupak
---
v2:
-improving kstrtoint error handling
-updating commit message
drivers/staging/lustre/lustre/obdclass/obd_mount.c | 16
On Sun, Mar 12, 2017 at 02:36:47PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 09, 2017 at 03:53:00PM +0100, Marcin Ciupak wrote:
> > Replace simple_strtoul with kstrtoint.
>
> Why?
Because
> > simple_strtoul is marked for obsoletion.
as reported by checkpatch.pl.
&
Replace simple_strtoul with kstrtoint.
simple_strtoul is marked for obsoletion.
Signed-off-by: Marcin Ciupak
---
drivers/staging/lustre/lustre/obdclass/obd_mount.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass
On Thu, Mar 02, 2017 at 04:17:12PM +0100, Samuel Thibault wrote:
> Marcin Ciupak, on jeu. 02 mars 2017 15:28:23 +0100, wrote:
> > - int val;
> > + int ret;
> >
> > - val = simple_strtoul(skip_spaces(start), &start, 10);
> > + ret = kstrtou8(skip_space
Replace simple_strtoul with kstrtou8.
simple_strtoul is marked for obsoletion.
Signed-off-by: Marcin Ciupak
---
drivers/staging/speakup/varhandlers.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/speakup/varhandlers.c
b/drivers/staging/speakup
51 matches
Mail list logo
