Re: [PATCH] tty: Fix WARNING in tty_set_termios

2019-01-31 Thread Marcel Holtmann
Hi Johan, >>> On Fri, Jan 25, 2019 at 04:29:05PM -0700, Shuah Khan wrote: tty_set_termios() has the following WARMN_ON which can be triggered with a syscall to invoke TIOCGETD __NR_ioctl. > > You meant TIOCSETD here, and in fact its the call which sets the uart > protocol that triggers

Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver

2017-07-21 Thread Marcel Holtmann
Hi Quentin, >>> The Espressif ESP8089 WiFi chips can be often found in cheap tablets. >>> There is one in A23 Polaroid tablets for example. >>> >>> The chip is often embedded as an eMMC SDIO device. >>> >>> The code was taken from an out-of-tree repository and has seen a first >>> pass in the cl

Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver

2017-07-21 Thread Marcel Holtmann
Hi Quentin, > The Espressif ESP8089 WiFi chips can be often found in cheap tablets. > There is one in A23 Polaroid tablets for example. > > The chip is often embedded as an eMMC SDIO device. > > The code was taken from an out-of-tree repository and has seen a first > pass in the cleanup process.

Re: [PATCH 8/8] Makefile: drop -D__CHECK_ENDIAN__ from cflags

2016-12-14 Thread Marcel Holtmann
| 2 -- > net/wireless/Makefile | 2 -- > 38 files changed, 5 insertions(+), 68 deletions(-) for drivers/bluetooth, net/bluetooth, net/ieee802154 and net/mac802154 Acked-by: Marcel Holtmann Regards Marcel

Re: [PATCH] rtlbt: Add RTL8822BE Bluetooth device

2016-09-12 Thread Marcel Holtmann
Hi Larry, > The RTL8822BE is a new Realtek wifi and BT device. Support for the BT > part is hereby added. > > As this device is similar to most of the other Realtek BT devices, the > changes are minimal. The main difference is that the 8822BE needs a > configuration file for enabling and disablin

Re: [RFC] rfkill: Add new ACPI device for Realtek serial BT

2016-07-15 Thread Marcel Holtmann
Hi Larry, > The Realtek RTL8723BS chips, which are connected via SDIO, also contain > a serial Bluetooth device. In order for BT to work, the device must be > added to the acpi_device_id table. > > Signed-off-by: Larry Finger > --- > > I have no idea if this device should be added here, or if t

Re: [PATCH 15/26] Bluetooth: Use skcipher and hash

2016-01-24 Thread Marcel Holtmann
Hi Herbert, > This patch replaces uses of blkcipher with skcipher and the long > obsolete hash interface with shash. > > Signed-off-by: Herbert Xu Acked-by: Marcel Holtmann > --- > > net/bluetooth/smp.c | 135 > -

Re: [PATCH] Staging: btmtk_usb: Add hdev parameter to hdev->send driver callback

2013-11-15 Thread Marcel Holtmann
Hi Greg, > while this is patch is correct, I do not really care about staging > drivers that actually bluntly violate my copyright. > That's very cryptic. What is going on here? I googled it and I wasn't able to find what you are talking about. Care to gi

Re: [PATCH] Staging: btmtk_usb: Add hdev parameter to hdev->send driver callback

2013-11-15 Thread Marcel Holtmann
Hi Greg, while this is patch is correct, I do not really care about staging drivers that actually bluntly violate my copyright. >>> >>> That's very cryptic. >>> >>> What is going on here? I googled it and I wasn't able to find what you >>> are talking about. Care to give us a

Re: [PATCH] Staging: btmtk_usb: Add hdev parameter to hdev->send driver callback

2013-11-15 Thread Marcel Holtmann
Hi Dan, >> while this is patch is correct, I do not really care about staging drivers >> that actually bluntly violate my copyright. >> > > That's very cryptic. > > What is going on here? I googled it and I wasn't able to find what you > are talking about. Care to give us a hint and what you

Re: [PATCH] Staging: btmtk_usb: Add hdev parameter to hdev->send driver callback

2013-11-15 Thread Marcel Holtmann
Hi Geert, > drivers/staging/btmtk_usb/btmtk_usb.c: In function ‘btmtk_usb_probe’: > drivers/staging/btmtk_usb/btmtk_usb.c:1610: warning: assignment from > incompatible pointer type > > Add the new hdev parameter, cfr. commit > 7bd8f09f69f8a190f9b8334a07bb0a9237612314 ("Bluetooth: Add hdev parame