e));
+ strscpy(ser_dev->phys, "nvec", sizeof(ser_dev->phys));
lgtm, so
Acked-by: Marc Dietrich
Thanks!
Marc
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hello Rohit,
On Sat, 25 Jul 2020, Rohit K Bharadwaj wrote:
changed usage of slave (which is deprecated) to secondary without breaking the
driver
Tested-by: Dan Carpenter
Acked-by: Marc Dietrich
Signed-off-by: Rohit K Bharadwaj
please don't add "*-by"'s by yourself
Hi,
On Sat, 25 Jul 2020, Michał Mirosław wrote:
On Sat, Jul 25, 2020 at 06:01:19PM +0530, Rohit K Bharadwaj wrote:
On 25/07/20 5:31 pm, Michał Mirosław wrote:
On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote:
changed usage of slave (which is deprecated) to secondary without
Hi Rohit,
On Fri, 24 Jul 2020, Rohit K Bharadwaj wrote:
On 24/07/20 10:06 pm, Marc Dietrich wrote:
On Fri, 24 Jul 2020, Marc Dietrich wrote:
Hi Rohit,
On Fri, 24 Jul 2020, Rohit Bharadwaj wrote:
On 24/07/20 1:58 pm, Greg KH wrote:
On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit
On Fri, 24 Jul 2020, Marc Dietrich wrote:
Hi Rohit,
On Fri, 24 Jul 2020, Rohit Bharadwaj wrote:
On 24/07/20 1:58 pm, Greg KH wrote:
On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit Bharadwaj wrote:
On 24/07/20 10:06 am, Rohit K Bharadwaj wrote:
changed usage of slave (deprecated) to
Hi Rohit,
On Fri, 24 Jul 2020, Rohit Bharadwaj wrote:
On 24/07/20 1:58 pm, Greg KH wrote:
On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit Bharadwaj wrote:
On 24/07/20 10:06 am, Rohit K Bharadwaj wrote:
changed usage of slave (deprecated) to secondary
Signed-off-by: Rohit K Bharadwaj
---
v3
Hello Xidong,
On Wed, 18 Dec 2019, Xidong Wang wrote:
In nvec_kbd_probe(), the return value of devm_input_allocate_device()
should be checked before it is used.
Signed-off-by: Xidong Wang
looks good to me. Thanks!
Acked-by: Marc Dietrich
---
drivers/staging/nvec/nvec_kbd.c | 2 ++
1
devm_platform_ioremap_resource for base
Signed-off-by: Hariprasad Kelam
Acked-by: Marc Dietrich
Thanks!
Marc
---
drivers/staging/nvec/nvec.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 1cbd7b7..360ec04 100644
--- a
Hi,
On Mon, 17 Dec 2018, Greg KH wrote:
On Sun, Dec 16, 2018 at 08:57:43AM -0800, Amir Mahdi Ghorbanian wrote:
@@ -626,7 +628,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
break;
case 2: /* first byte after command */
if (status ==
This reverts commit 5a3e59ce3acf2f52c8b4a6fc656c3b1e4a329f06, because the
necessary changes were applied in the "staging: nvec: convert to use GPIO
descriptors" patch.
Signed-off-by: Marc Dietrich
---
drivers/staging/nvec/TODO | 5 -
1 file changed, 5 deletions(-)
diff --git
Am Donnerstag, 19. April 2018, 16:06:19 CEST schrieb Wolfram Sang:
> We should get drvdata from struct device directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang
Acked-by: Marc Dietrich
> ---
>
> Build tested on
hanks for the reminder!
Marc
>
> Cc: Marc Dietrich
> Signed-off-by: Linus Walleij
> ---
> drivers/staging/nvec/TODO | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/staging/nvec/TODO b/drivers/staging/nvec/TODO
> index e4d85d9b4681..78b84c243df4
Use GPIO descriptors instead of relying on the old method.
Cc: Linus Walleij
Signed-off-by: Marc Dietrich
---
This obsolets the ToDo reminder sent by Linus a few hours ago.
---
drivers/staging/nvec/nvec.c | 42 +
drivers/staging/nvec/nvec.h | 2 +-
2 files
This cleanups the probe function a bit by using a dev variable instead
of &pdev-dev.
Signed-off-by: Marc Dietrich
---
drivers/staging/nvec/nvec.c | 35 ++-
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/dri
Hello Thomas,
Am Freitag, 2. M?rz 2018, 20:05:25 CET schrieb Thomas Avery:
> This patch adds error checking to the nvec_power_poll function, which
> will allow for easier debugging if the driver has issues.
>
> Signed-off-by: Thomas Avery
> ---
> drivers/staging/nvec/nvec_power.c | 13 +
Hi Simran,
Am Donnerstag, 2. März 2017, 15:48:13 CET schrieb SIMRAN SINGHAL:
> On Thursday, March 2, 2017 at 8:06:40 PM UTC+5:30, Julia Lawall wrote:
> > On Thu, 2 Mar 2017, simran singhal wrote:
> > > Resolve strict checkpatch USLEEP_RANGE checks by converting delays and
> > > sleeps as described
Am Dienstag, 14. Februar 2017, 22:31:20 CET schrieb Arushi Singhal:
> Prefer kzalloc(sizeof(*ser_dev)...) over kzalloc(sizeof(struct
> serio)...) as reported by checkpatch.pl.
>
> Signed-off-by: Arushi Singhal
looks like we are in a (make everyone) happy week.
Acked-by: M
(different signedness) drivers/staging/nvec/nvec.c:781:35:expected
> unsigned int [usertype] *out_value drivers/staging/nvec/nvec.c:781:35:
> got int *
>
> Signed-off-by: Franck Demathieu
looks correct. Thanks!
Acked-by: Marc Dietrich
> ---
> drivers/staging/nvec/nvec.
This basicly reverts commit e534f3e9 (staging:nvec: Introduce the use of
the managed version of kzalloc). Serio struct should never by managed
because it is refcounted. Doing so will lead to a double free oops on module
remove.
Signed-off-by: Marc Dietrich
---
drivers/staging/nvec/nvec_ps2.c
t "staging: nvec: ps2: change serio type to passthrough"
>
> drivers/staging/nvec/nvec_ps2.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
Works fine now. Thanks!
The series is
Acked-by: Marc Dietrich
signature.asc
Description: This is a digitally signed messa
Hi Paul,
thanks for finding the issue!
Am Donnerstag, 27. Oktober 2016, 16:55:14 CEST schrieb Paul Fertser:
> This command was sent behind serio's back and the answer to it was
> confusing atkbd probe function which lead to the elantech touchpad
> getting detected as a keyboard.
>
> To prevent t
PASS-THROUGH OPTION section).
>
> Since paz00's embedded controller is not connected to a PS/2 port
> itself, the PS/2 interface it exposes is not a pass-through one.
>
> Acked-by: Marc Dietrich
> Signed-off-by: Paul Fertser
In fact I was a bit to fast to ack. Turns out I
e know which patches are needed and
> which are not?
you should not send patches which others already did.
Marc
> > On 29-Feb-2016, at 5:00 PM, Marc Dietrich wrote:
> >
> > Hi Parth,
> >
> > please also cc de...@linuxdriverproject.org next time.
> >
>
Hi Parth,
please also cc de...@linuxdriverproject.org next time.
Some comments below.
Am Freitag, 26. Februar 2016, 15:24:21 CET schrieb Parth Sane:
> 1)Null comparison
> 2)Extra Line after curly braces
> 3)Changed udelay to udelay_range
> 4)BUG_ON to WARN_ON to avoid crashing kernel
> 5)Removed
Am Dienstag, 23. Februar 2016, 21:59:04 CET schrieb Laura Garcia Liebana:
> Prevent a kernel panic by avoiding the use of the BUG_ON macro.
> Checkpatch detected this issue.
>
> Signed-off-by: Laura Garcia Liebana
Acked-by: Marc Dietrich
> ---
> Changes in v2:
>
nction.
>
> Signed-off-by: Hari Prasath Gujulan Elango
Thanks!
Acked-by: Marc Dietrich
> ---
> drivers/staging/nvec/nvec_paz00.c | 12 +---
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec_paz00.c
> b/drivers/stagi
Hi Simon,
Am Mittwoch, 9. Dezember 2015, 08:14:06 schrieb Simon Guinot:
> This patch fixes a couple of checkpatch warnings about block comments.
>
> Signed-off-by: Simon Guinot
> ---
> drivers/staging/nvec/nvec.c | 6 --
> drivers/staging/nvec/nvec_power.c | 14 +-
> 2 fi
Am Donnerstag, 15. Oktober 2015, 11:48:12 schrieb Dan Carpenter:
> On Thu, Oct 15, 2015 at 10:39:02AM +0200, Marc Dietrich wrote:
> > > > - if (unlikely(nvec->rx == NULL)) {
> > > > + if (!unlikely(nvec->rx)) {
&g
Am Mittwoch, 14. Oktober 2015, 21:12:36 schrieb Dan Carpenter:
> On Wed, Oct 14, 2015 at 07:38:22PM +0530, Sakshi Bansal wrote:
> > Fixed allignmnet issues and block comments usage
>
> Split it apart by type of fix.
>
> > @@ -617,7 +618,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>
Am Dienstag, 21. Juli 2015, 11:51:15 schrieb Andrey Danin:
> On 21.07.2015 11:25, Marc Dietrich wrote:
> > I think in this case it would be better to leave nvec and dt as it is for
> > now, and just add the slave function to tegra-i2c. Otherwise we will
> > again have two d
Am Dienstag, 21. Juli 2015, 09:35:21 schrieb Andrey Danin:
> On 21.07.2015 1:19, Stephen Warren wrote:
> > On 07/20/2015 02:35 PM, Andrey Danin wrote:
> >> NVEC driver was reimplemented to use tegra i2c. Use common i2c bindings
> >> for NVEC node.
> >>
> >> diff --git a/arch/arm/boot/dts/tegra20-p
Am Dienstag, 16. Juni 2015, 23:13:21 schrieb Peng Fan:
> Sparse checking warning:
> "drivers/staging/nvec/nvec_ps2.c:172:14: warning: duplicate const".
> Remove the duplicated const to fix the warning.
>
> Signed-off-by: Peng Fan
Thanks!
Acked-by: Marc Dietrich
>
Am Mittwoch, 27. Mai 2015, 07:00:54 schrieb Shailendra Verma:
> Fix spelling error in comment in function tegra_nvec_remove.
>
> Signed-off-by: Shailendra Verma
Acked-by: Marc Dietrich
> ---
> drivers/staging/nvec/nvec.c |2 +-
> 1 file changed, 1 insertion(+), 1 del
Hi Shailendra,
you should fill the patch description with something, even if trivial, and
trim the subject line a bit, e.g.
---
staging: nvec: fix typo in comment (all lowercase, no full stop at the end)
Fix spelling error in comment in function tegra_nvec_remove.
S-o-b
-
Thanks,
Marc
A
_supply: Change ownership from driver to core
>
> These are huge.
Patches 2 and 11 are Reviewed-By: Marc Dietrich # for the
nvec part.
Thanks!
Marc
signature.asc
Description: This is a digitally signed message part.
___
d
Am Samstag 31 Januar 2015, 20:11:29 schrieb Julian Andres Klode:
> On 31 January 2015 at 17:29, Greg KH wrote:
> > On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote:
> >> The task was to fix a warning which was shown while compiling a driver
> >> called NVEC. I wrote a brief description
t; + GPIOF_OUT_INIT_HIGH,
> + "nvec gpio");
> + if (ret < 0) {
> dev_err(nvec->dev, "couldn't request gpio\n");
> return -ENODEV;
> }
>
> - err = devm_request_irq(&pdev-
).
Reported-by: Misha Komarovskiy
Signed-off-by: Marc Dietrich
---
drivers/staging/nvec/nvec.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 093535c..120b70d 100644
--- a/drivers/staging/nvec/nvec.c
+++ b
Am Donnerstag 06 November 2014, 08:43:17 schrieb Guenter Roeck:
> Register with kernel power-off handler instead of setting pm_power_off
> directly. Register with default priority since we don't know any better.
>
> Cc: Julian Andres Klode
> Cc: Marc Dietrich
> Cc: Greg
Am Montag 06 Oktober 2014, 22:28:31 schrieb Guenter Roeck:
> Register with kernel poweroff handler instead of setting pm_power_off
> directly. Register with default priority value of 128 since we don't know
> any better.
I just tested this change and it seems to break power off. What the driver
d
been registered yet. While this
> is unlikely to become an issue for nvec, platform_get_irq() is the
> recommended way to get at interrupts.
>
> Signed-off-by: Thierry Reding
Thanks again, Thierry!
Acked-by: Marc Dietrich
> ---
> drivers/staging/nvec/nvec.c | 5 ++---
> 1 f
directly access
> the registers.
>
> Since subdevices never need to access the registers we can simply pass
> NULL instead.
>
> Signed-off-by: Thierry Reding
Acked-by: Marc Dietrich
> ---
> drivers/staging/nvec/nvec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 del
On Mon, 21 Jul 2014 13:54:41 +0200
Thierry Reding wrote:
> From: Thierry Reding
>
> The SIMPLE_DEV_PM_OPS macro already uses the const qualifier, so there's
> no need to repeat it.
>
> Signed-off-by: Thierry Reding
Acked-by: Marc Dietrich
> ---
> drivers/st
ARRAY_SIZE(nvec_devices), base, 0, NULL);
> + ARRAY_SIZE(nvec_devices), res, 0, NULL);
> if (ret)
> dev_err(nvec->dev, "error adding subdevices\n");
>
> --
> 2.0.1
>
--
Marc Dietrich
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
our time.
Marc
Marc Dietrich
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
nneccessary 'out of memory' message
>
> drivers/staging/nvec/nvec.c | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
thanks for fixing, so for this series
Acked-by: Marc Dietrich
signature.asc
Description: This is a digitally signed message part.
___
e apply-burdon from Greg. Ideally,
you would combine all patches (one patch per checkpatch warning)
in a common thread like this:
git-format-patch --cover-letter --thread -s
This way you could add some comments (if any) to the cover letter
and just keep the plain checkpatch message in th
text looks like a bit overkill though.
> Signed-off-by: Pawel Lebioda
> drivers/staging/nvec/nvec_paz00.c | 1 +
> drivers/staging/nvec/nvec_power.c | 1 +
> drivers/staging/nvec/nvec_ps2.c | 2 ++
> 3 files changed, 4 insertions(+)
Acked-by: Marc Dietrich
signature.asc
Descriptio
gt; Cc: tred...@nvidia.com
> Cc: pdeschrij...@nvidia.com
> Cc: linux-te...@vger.kernel.org
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: Julian Andres Klode
> Cc: Marc Dietrich
> Cc: ac...@lists.launchpad.net
> Cc: Greg Kroah-Hartman
> Cc: de...@driverdev.osuosl.or
or by not disabling the clock after initialization.
This didn't striked us yet because suspend/resume hasn't landed in mainline
yet, but will soon.
Signed-off-by: Marc Dietrich
---
drivers/staging/nvec/nvec.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/stagin
50 matches
Mail list logo
