[PATCH] staging: vc04_services: Remove explicit NULL pointer

Replace direct comparisons to NULL i.e. 'x == NULL' with '!x' 'x != NULL' with 'x' Signed-off-by: Maninder Singh --- .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 32 ++-- .../vc04_services/interface/vchiq_arm/vchiq_core.c

[PATCH] staging: st-cec: add parentheses around complex macros

This patch fixes the following checkpatch.pl error: ERROR: Macros with complex values should be enclosed in parentheses Signed-off-by: Maninder Singh --- drivers/staging/media/st-cec/stih-cec.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/st

[PATCH] Staging: xgifb: Fix NULL pointer comparison warning

Replace direct comparisons to NULL i.e. 'x == NULL' with '!x'. This problem was detected by checkpatch. Signed-off-by: Maninder Singh --- drivers/staging/xgifb/XGI_main_26.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/XGI_

Re: [RESEND PATCH 1/1] staging:vt6655: remove checks around dev_kfree_skb

Hi Dan, >I hate these patches. I have told Markus to stop sending them but he >has issues so now I only complain when they introduce a bug. There was >one bug I have missed because it was a benchmark regression and I knew >it was theoretically possible but I didn't know the code well enough to >

[RESEND PATCH 1/1] staging:vt6655: remove checks around dev_kfree_skb

dev_kfree_skb checks for NULL pointer itself, Thus no need of explicit NULL check. Signed-off-by: Maninder Singh --- drivers/staging/vt6655/device_main.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655

[PATCH 1/1] drivers: hv: hv_utils_transport: Fixing validation of correct pointer

cn_msg should be validated instead of msg after memory allocation. Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- drivers/hv/hv_utils_transport.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hv/hv_utils_transport.c b/drivers/hv

Re: [PATCH 1/1] staging/comedi: remove unnecessary check around pci_dev_put

Hi, >This patch is correct but the motivation is wrong. > >The check in pci_dev_put() is like a sanity check. There are many >functions which have a sanity check and many which do not, it is >impossible for a human to remember the complete list of each. When we >remove explicit checks for NULL a

[PATCH v2] staging/comedi: remove unnecessary check around pci_dev_put

pci_dev_put checks for NULL pointer itself, reported by coccinelle Signed-off-by: Maninder Singh Reviewed-by: Yogesh Gaur --- v2: changelog typo cehcks -> checks drivers/staging/comedi/drivers/adl_pci9118.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/driv

Re: [PATCH 1/1] staging/comedi: remove unnecessary check around pci_dev_put

>> pci_dev_put cehcks for NULL pointer itself, >did you mean checks? Yes did some typo, send v2 of the patch. Thanks -- ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/1] staging/comedi: remove unnecessary check around pci_dev_put

pci_dev_put cehcks for NULL pointer itself, reported by coccinelle Signed-off-by: Maninder Singh Reviewed-by: Yogesh Gaur --- drivers/staging/comedi/drivers/adl_pci9118.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b

[RFC][PATCH 1/1] staging:vt6655: Remove checks around dev_kfree_skb

dev_kfree_skb checks for NULL pointer itself. Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- drivers/staging/vt6655/device_main.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655