Op 08-08-16 om 21:59 schreef Gustavo Padovan:
> 2016-08-08 Maarten Lankhorst :
>
>> Op 20-06-16 om 17:53 schreef Gustavo Padovan:
>>> From: Gustavo Padovan
>>>
>>> When creating a sync_pt the name received wasn't used anywhere.
>>> Now we add
Op 20-06-16 om 17:53 schreef Gustavo Padovan:
> From: Gustavo Padovan
>
> When creating a sync_pt the name received wasn't used anywhere.
> Now we add it to the sync info debug output to make it easier to indetify
> the userspace name of that sync pt.
>
> Signed-off-by: Gustavo Padovan
> ---
> d
by: Gustavo Padovan
Acked-by: Maarten Lankhorst
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Cc: David Airlie
>> Cc: Daniel Vetter
>> Cc: Rob Clark
>> Signed-off-by: Gustavo Padovan
> Acked-by: Rob Clark
>
Looking much better.
Acked-by: Maarten Lankhorst
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Op 19-04-16 om 22:42 schreef Gustavo Padovan:
> From: Gustavo Padovan
>
> This function had copies in 3 different files. Unify them in kernel.h.
>
> Cc: Joe Perches
> Cc: Andrew Morton
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Rob Clark
> Signed-off-by: Gustavo Padovan
> ---
> drivers/gp
t now with the actual value of num_fences
> in the sync_file.
>
> Also, info->sync_fence_info was converted to __u64 pointer to prevent
> 32bit compatibility issues.
For this patch and 6/6:
Reviewed-by: Maarten Lankhorst
___
devel mailin
ctl(fd, SYNC_IOC_FILE_INFO, info);
> }
>
> v2: fix fence_info memory leak
>
> v3: Comments from Emil Velikov
> - improve commit message
> - remove __u64 cast
> - remove check for output fields in file_info
> - clean up sync_fill_fence_i
Op 29-02-16 om 23:08 schreef Gustavo Padovan:
> Hi Maarten,
>
> 2016-02-29 Maarten Lankhorst :
>
>> Op 26-02-16 om 22:00 schreef Gustavo Padovan:
>>> From: Gustavo Padovan
>>>
>>> Change SYNC_IOC_FILE_INFO behaviour to avoid future API breaks a
t; + __s32 fd2;
> + charname[32];
> + __s32 fence;
> };
>
> /**
For the first 3 patches:
Reviewed-by: Maarten Lankhorst
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Op 26-02-16 om 19:31 schreef Gustavo Padovan:
> From: Gustavo Padovan
>
> Play safe and add flags member to all structs. So we don't need to
> break API or create new IOCTL in the future if new features that requires
> flags arises.
>
> v2: check if flags are valid (zero, in this case)
>
> Signed-
Op 26-02-16 om 22:00 schreef Gustavo Padovan:
> From: Gustavo Padovan
>
> Change SYNC_IOC_FILE_INFO behaviour to avoid future API breaks and
> optimize buffer allocation. In the new approach the ioctl needs to be called
> twice to retrieve the array of fence_infos pointed by info->sync_fence_info.
Op 04-02-16 om 14:05 schreef Gustavo Padovan:
> 2016-02-04 Maarten Lankhorst :
>
>> Op 03-02-16 om 21:09 schreef Gustavo Padovan:
>>> Hi Maarten,
>>>
>>> 2016-02-03 Maarten Lankhorst :
>>>
>>>> Op 03-02-16 om 14:25 schreef Gu
Op 03-02-16 om 21:09 schreef Gustavo Padovan:
> Hi Maarten,
>
> 2016-02-03 Maarten Lankhorst :
>
>> Op 03-02-16 om 14:25 schreef Gustavo Padovan:
>>> From: Gustavo Padovan
>>>
>>> Turn sync_fence_info into __u64 type enable us to extend the stru
Op 03-02-16 om 14:25 schreef Gustavo Padovan:
> From: Gustavo Padovan
>
> Turn sync_fence_info into __u64 type enable us to extend the struct in the
> future without breaking the ABI.
>
> v2: use type __u64 for fence_info
>
> v3: fix commit message to reflect the v2 change
>
> Signed-off-by: Gusta
Op 02-02-16 om 21:28 schreef Gustavo Padovan:
> Hi Maarten,
>
> 2016-02-02 Maarten Lankhorst :
>
>> Op 02-02-16 om 14:23 schreef Gustavo Padovan:
>>> From: Gustavo Padovan
>>>
>>> Making fence_info a pointer enables us to extend the struct in the fu
Op 02-02-16 om 14:23 schreef Gustavo Padovan:
> From: Gustavo Padovan
>
> Making fence_info a pointer enables us to extend the struct in the future
> without breaking the ABI.
>
> v2: use type __u64 for fence_info
> Signed-off-by: Gustavo Padovan
> ---
> drivers/staging/android/sync.c | 2 +
Op 02-02-16 om 14:23 schreef Gustavo Padovan:
> From: Gustavo Padovan
>
> As struct sync_pt doesn't exist anymore it is a good idea remove any
> reference to it in the sync_framework. sync_pts were replaced directly by
> fences.
>
rename it to sync_fence_info to prevent polluting the global namesp
Op 02-02-16 om 14:23 schreef Gustavo Padovan:
> From: Gustavo Padovan
>
> The len member of struct sync_file_info was returning the size of the whole
> buffer (struct sync_file_info + fence_infos at the of it). This commit
> change it to return only the size of the array of fence_infos.
>
> It als
Op 29-01-16 om 22:20 schreef Gustavo Padovan:
> From: Gustavo Padovan
>
> Making fence_info a pointer enables us to extend the struct in the future
> without breaking the ABI.
>
> Signed-off-by: Gustavo Padovan
> ---
> drivers/staging/android/sync.c | 2 +-
> drivers/staging/android/uapi/sy
Op 29-01-16 om 22:20 schreef Gustavo Padovan:
> From: Gustavo Padovan
>
> Play safe and add flags member to all structs. So we don't need to
> break API or create new IOCTL in the future if new features that requires
> flags arises.
>
This only helps if you reject flags != 0 in the ioctl, else whe
Hey,
Op 27-01-16 om 14:30 schreef Gustavo Padovan:
> From: Gustavo Padovan
>
> sync_file is useful to connect one or more fences to the file. The file is
> used by userspace to track fences.
>
> Signed-off-by: Gustavo Padovan
>
Is there a value in keeping the abi unchanged?
If not, then Document
e_signal at destroy
> phase
> staging/android: remove sync_fence_create_dma()
>
For whole series:
Reviewed-by: Maarten Lankhorst
Renaming sync_fence to sync_file makes sense, it should hopefully reduce
confusion.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Op 20-01-16 om 15:32 schreef Gustavo Padovan:
> 2016-01-20 Maarten Lankhorst :
>
>> Hey,
>>
>> Op 15-01-16 om 15:55 schreef Gustavo Padovan:
>>> From: Gustavo Padovan
>>>
>>> This patch series de-stage the sync framework, and in order to accomp
Hey,
Op 15-01-16 om 15:55 schreef Gustavo Padovan:
> From: Gustavo Padovan
>
> This patch series de-stage the sync framework, and in order to accomplish that
> a bunch of cleanups/improvements on the sync and fence were made.
>
> The sync framework contained some abstractions around struct fence
Op 15-12-15 om 18:19 schreef Dmitry Torokhov:
> On Tue, Dec 15, 2015 at 2:01 AM, Maarten Lankhorst
> wrote:
>> Op 15-12-15 om 02:29 schreef Dmitry Torokhov:
>>> Userspace can close the sync device while there are still active fence
>>> points, in which case kernel
Op 15-12-15 om 02:29 schreef Dmitry Torokhov:
> Userspace can close the sync device while there are still active fence
> points, in which case kernel produces the following warning:
>
> [ 43.853176] [ cut here ]
> [ 43.857834] WARNING: CPU: 0 PID: 892 at
> /mnt/host/sou
Op 23-11-15 om 14:44 schreef Tvrtko Ursulin:
>
> On 23/11/15 13:38, John Harrison wrote:
>> On 23/11/2015 13:27, Maarten Lankhorst wrote:
>>> Op 23-11-15 om 12:34 schreef john.c.harri...@intel.com:
>>>> From: Maarten Lankhorst
>>>>
>>>>
Tvrtko Ursulin
> Cc: Maarten Lankhorst
> Cc: de...@driverdev.osuosl.org
> Cc: Riley Andrews
> Cc: Greg Kroah-Hartman
> Cc: Arve Hjønnevåg
>
Could this be upstreamed already? It makes the second patch possible and
doesn't break curren
Op 23-11-15 om 12:34 schreef john.c.harri...@intel.com:
> From: Maarten Lankhorst
>
> This allows users of dma fences to create a android fence.
>
> v2: Added kerneldoc. (Tvrtko Ursulin).
>
> Signed-off-by: Maarten Lankhorst
> Signed-off-by: Tvrtko Ursulin
> Cc: Maar
According to the documentation sync_fence_create takes ownership of the point,
not a reference on the point.
This fixes a memory leak introduced in 3.17's android fence rework.
Signed-off-by: Maarten Lankhorst
Cc: Colin Cross
Cc: Dan Carpenter
---
drivers/staging/android/sync.c | 1 -
1
Hey,
Op 28-08-14 om 13:57 schreef Dan Carpenter:
> On Thu, Aug 28, 2014 at 08:54:05AM +0200, Maarten Lankhorst wrote:
>> Hey,
>>
>> On 15-08-14 08:46, Greg Kroah-Hartman wrote:
>>> On Thu, Aug 14, 2014 at 11:54:52AM +0200, Maarten Lankhorst wrote:
>>>> T
Hey,
On 15-08-14 08:46, Greg Kroah-Hartman wrote:
> On Thu, Aug 14, 2014 at 11:54:52AM +0200, Maarten Lankhorst wrote:
>> This allows users of dma fences to create a android fence.
>
> Who is going to use these functions? I need an in-kernel user before I
> can add new api ca
Hey,
Op 18-08-14 om 14:57 schreef Dan Carpenter:
> On Thu, Aug 14, 2014 at 11:53:38AM +0200, Maarten Lankhorst wrote:
>> According to the documentation sync_fence_create takes ownership of the
>> point,
>> not a reference on the point.
>>
> What are the user v
This allows users of dma fences to create a android fence.
Signed-off-by: Maarten Lankhorst
Cc: Daniel Vetter
Cc: Jesse Barnes
---
drivers/staging/android/sync.c | 24
drivers/staging/android/sync.h | 11 +++
2 files changed, 31 insertions(+), 4 deletions
According to the documentation sync_fence_create takes ownership of the point,
not a reference on the point.
Signed-off-by: Maarten Lankhorst
Cc: Colin Cross
---
drivers/staging/android/sync.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/android/sync.c b/drivers/staging
35 matches
Mail list logo
