[PATCH v3 3/8] staging: comedi: ni_usb6501: cleanup response_size

2014-09-19 Thread Luca Ellero
Cleanup response_size in ni6501_send_command (READ_PORT command). No logical/functional change is introduced by this patch. Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi

[PATCH v3 4/8] staging: comedi: ni_usb6501: replace spaces with tabs

2014-09-19 Thread Luca Ellero
ni6501_auto_attach(): replace spaces with tabs to get proper alignment Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi

[PATCH v3 6/8] staging: comedi: ni_usb6501: remove empty lines

2014-09-19 Thread Luca Ellero
ni6501_send_command(): remove empty lines in case statements Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers/ni_usb6501

[PATCH v3 8/8] staging: comedi: ni_usb6501: add counter subdevice

2014-09-19 Thread Luca Ellero
Add counter support for NI USB-6501. The following functions are introduced: - ni6501_counter_command() - ni6501_cnt_insn_config() - ni6501_cnt_insn_read() - ni6501_cnt_insn_write() Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c | 167 ++- 1

[PATCH v3 7/8] staging: comedi: ni_usb6501: rename ni6501_send_command()

2014-09-19 Thread Luca Ellero
Rename ni6501_send_command to ni6501_port_command Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers/ni_usb6501.c

[PATCH v3 5/8] staging: comedi: ni_usb6501: remove useless check

2014-09-19 Thread Luca Ellero
Remove useless test in ni6501_send_command. The check is useless since this function is called only in this driver. Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b

[PATCH v3 0/8] comedi: ni_usb6501: add counter support

2014-09-19 Thread Luca Ellero
quot; to avoid ambiguity with counter number - let ni6501_cnt_insn_config() return the insn->n value if it succeeds - let ni6501_cnt_insn_read read insn->n values - let ni6501_cnt_insn_write be able to handle an array of values Luca Ellero (8): staging: comedi: ni_usb6501: add counter

[PATCH v3 1/8] staging: comedi: ni_usb6501: add counter commands

2014-09-19 Thread Luca Ellero
Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c | 29 ++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers/ni_usb6501.c index 6a4f965..f0b8f11 100644

Re: [PATCH v2 0/9] comedi: ni_usb6501: add counter support

2014-09-18 Thread Luca Ellero
On 17/09/2014 18:10, Hartley Sweeten wrote: On Tuesday, September 16, 2014 4:40 AM, Luca Ellero wrote: This series of patches add counter support for NI USB-6501. I tested it on my device and it works fine. Hartley, Ian, thank you for your comments. I'll collect them all and I'l

[PATCH v2 6/9] staging: comedi: ni_usb6501: add ni6501_cnt_insn_config()

2014-09-16 Thread Luca Ellero
Add function for counter subdevice configuration. Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c | 28 +++ 1 file changed, 28 insertions(+) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers

[PATCH v2 0/9] comedi: ni_usb6501: add counter support

2014-09-16 Thread Luca Ellero
This series of patches add counter support for NI USB-6501. I tested it on my device and it works fine. Changes for v2: - rewrite patch 3/9 changelog: replace "fix" with "cleanup" - avoid sparse warnings - add SDF_LSAMPL flag to counter subdevice Luca Ellero (9): staging

[PATCH v2 9/9] staging: comedi: ni_usb6501: add counter subdevice

2014-09-16 Thread Luca Ellero
Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers/ni_usb6501.c index 791058d..8299e524 100644 --- a/drivers

[PATCH v2 8/9] staging: comedi: ni_usb6501: add ni6501_cnt_insn_write()

2014-09-16 Thread Luca Ellero
Add function for writing to counter subdevice. Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers/ni_usb6501.c index

[PATCH v2 1/9] staging: comedi: ni_usb6501: add counter commands

2014-09-16 Thread Luca Ellero
Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c | 29 ++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers/ni_usb6501.c index 6a4f965..f0b8f11 100644

[PATCH v2 5/9] staging: comedi: ni_usb6501: add ni6501_counter_command()

2014-09-16 Thread Luca Ellero
Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c | 110 +++ 1 file changed, 110 insertions(+) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers/ni_usb6501.c index f55b9f8..60fc1ee 100644 --- a/drivers

[PATCH v2 4/9] staging: comedi: ni_usb6501: rename ni6501_send_command()

2014-09-16 Thread Luca Ellero
Rename ni6501_send_command to ni6501_port_command Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers/ni_usb6501.c

[PATCH v2 3/9] staging: comedi: ni_usb6501: cleanup response_size

2014-09-16 Thread Luca Ellero
Cleanup response_size in ni6501_send_command (READ_PORT command). No logical/functional change is introduced by this patch. Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi

[PATCH v2 7/9] staging: comedi: ni_usb6501: add ni6501_cnt_insn_read()

2014-09-16 Thread Luca Ellero
Add function for reading from counter subdevice. Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers/ni_usb6501.c index

Re: [PATCH 5/9] staging: comedi: ni_usb6501: add ni6501_counter_command()

2014-09-16 Thread Luca Ellero
Hi Ian, On 15/09/2014 15:11, Ian Abbott wrote: On 2014-09-15 13:59, Luca Ellero wrote: Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c | 110 +++ 1 file changed, 110 insertions(+) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c

Re: [PATCH 3/9] staging: comedi: ni_usb6501: fix response_size

2014-09-16 Thread Luca Ellero
Hi Dan, Il 15/09/2014 15:16, Dan Carpenter wrote: On Mon, Sep 15, 2014 at 02:59:33PM +0200, Luca Ellero wrote: Fix response_size in ni6501_send_command (READ_PORT command) This isn't a fix, it's a cleanup. A fix is something that fixes a bug. We are sloppy about correcting newbi

[PATCH 6/9] staging: comedi: ni_usb6501: add ni6501_cnt_insn_config()

2014-09-15 Thread Luca Ellero
Add function for counter subdevice configuration. Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c | 28 +++ 1 file changed, 28 insertions(+) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers

[PATCH 9/9] staging: comedi: ni_usb6501: add counter subdevice

2014-09-15 Thread Luca Ellero
Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers/ni_usb6501.c index c33d857..711d349 100644 --- a/drivers

[PATCH 5/9] staging: comedi: ni_usb6501: add ni6501_counter_command()

2014-09-15 Thread Luca Ellero
Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c | 110 +++ 1 file changed, 110 insertions(+) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers/ni_usb6501.c index f55b9f8..cef93d2 100644 --- a/drivers

[PATCH 4/9] staging: comedi: ni_usb6501: rename ni6501_send_command()

2014-09-15 Thread Luca Ellero
Rename ni6501_send_command to ni6501_port_command Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers/ni_usb6501.c

[PATCH 1/9] staging: comedi: ni_usb6501: add counter commands

2014-09-15 Thread Luca Ellero
Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c | 29 ++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers/ni_usb6501.c index 6a4f965..f0b8f11 100644

[PATCH 7/9] staging: comedi: ni_usb6501: add ni6501_cnt_insn_read()

2014-09-15 Thread Luca Ellero
Add function for reading from counter subdevice. Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers/ni_usb6501.c index

[PATCH 8/9] staging: comedi: ni_usb6501: add ni6501_cnt_insn_write()

2014-09-15 Thread Luca Ellero
Add function for writing to counter subdevice. Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers/ni_usb6501.c index

[PATCH 0/9] comedi: ni_usb6501: add counter support

2014-09-15 Thread Luca Ellero
This series of patches add counter support for NI USB-6501. I tested it on my device and it works fine. Luca Ellero (9): staging: comedi: ni_usb6501: add counter commands staging: comedi: ni_usb6501: update comments staging: comedi: ni_usb6501: fix response_size staging: comedi

[PATCH 3/9] staging: comedi: ni_usb6501: fix response_size

2014-09-15 Thread Luca Ellero
Fix response_size in ni6501_send_command (READ_PORT command) Signed-off-by: Luca Ellero --- drivers/staging/comedi/drivers/ni_usb6501.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_usb6501.c b/drivers/staging/comedi/drivers

[PATCH v3] staging: comedi: add NI USB-6501 support

2014-08-07 Thread Luca Ellero
Enable support for the National Instruments USB-6501 module. The NI USB-6501 is a Full-Speed USB 2.0 (12 Mbit/s) device that provides 24 digital I/O lines channels and one 32-bit counter. This is a preliminary version: GPIO: works counter: doesn't work Signed-off-by: Luca E

Re: [PATCH v2] staging: comedi: add NI USB-6501 support

2014-08-06 Thread Luca Ellero
Il 06/08/2014 13:58, Dan Carpenter ha scritto: Some minor style nits. On Wed, Aug 06, 2014 at 01:35:32PM +0200, Luca Ellero wrote: +static int ni6501_send_command(struct comedi_device *dev, int command, + const u8 *port, u8 *bitmap) +{ + struct usb_device

Re: [PATCH] staging: comedi: add NI USB-6501 initial support

2014-08-06 Thread Luca Ellero
On 06/08/2014 11:29, Ian Abbott wrote: On 2014-08-06 09:49, Luca Ellero wrote: A question only: apart from renaming file from ni_6501.c to ni_usb6501.c, should I rename functions/variables as well? For example: ni6501_auto_attach -> niusb6501_auto_attach ni6501_private -> niusb6501_p

Re: [PATCH] staging: comedi: add NI USB-6501 initial support

2014-08-06 Thread Luca Ellero
On 05/08/2014 17:58, Ian Abbott wrote: On 2014-08-05 15:22, Luca Ellero wrote: This is a preliminary version, some features are not implemented yet: GPIO: works counter: doesn't work Signed-off-by: Luca Ellero --- This is a preliminary version of the NI USB-6501 driver. Every co

Re: Anybody working on ced1401?

2014-07-14 Thread Luca Ellero
On 13/07/2014 18:46, Greg KH wrote: On Fri, Jun 27, 2014 at 05:11:45PM +0200, Luca Ellero wrote: Hi Greg, On 27/06/2014 16:55, Greg KH wrote: On Fri, Jun 27, 2014 at 03:04:43PM +0200, Luca Ellero wrote: Il 26/06/2014 21:23, Greg KH ha scritto: On Thu, Jun 26, 2014 at 09:36:17AM +0200, Alois

[PATCH v4 08/12] staging: ced1401: usb1401.c: add blank line after declarations

2014-07-11 Thread Luca Ellero
Fix checkpatch warnings "Missing a blank line after declarations" in file usb1401.c Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb14

[PATCH v4 09/12] staging: ced1401: usb1401.c: fix code indent

2014-07-11 Thread Luca Ellero
Fix checkpatch warning "suspect code indent for conditional statements" in file usb1401.c Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/stagi

[PATCH v4 03/12] staging: ced1401: ced_ioc.c: add blank line after declarations

2014-07-11 Thread Luca Ellero
Fix checkpatch warnings "Missing a blank line after declarations" in file ced_ioc.c Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/stagi

[PATCH v4 12/12] staging: ced1401: usb1401.c: join quoted strings

2014-07-11 Thread Luca Ellero
Fix checkpatch warnings "quoted string split across lines" in file usb1401.c Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drive

[PATCH v4 04/12] staging: ced1401: ced_ioc.c: remove space before tabs

2014-07-11 Thread Luca Ellero
Fix checkpatch warning "please, no space before tabs" in file ced_ioc.c Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c ind

[PATCH v4 00/12] staging: ced1401: rename camel case function and vars

2014-07-11 Thread Luca Ellero
ether. Changes for v3: reworking of patches 111 to 115 (57-60 in v2): - split them on multiple patches - add more verbose comment Changes for v4: change subjects of patches to more specific ones Luca Ellero (12): staging: ced1401: usb1401.c: change spaces to tabs staging: ced1401: usb1401.h:

[PATCH v4 10/12] staging: ced1401: usb1401.c rename camel case variable

2014-07-11 Thread Luca Ellero
Rename camel case variable dwCount in function ced_writechar_callback Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb1401.c index

[PATCH v4 11/12] staging: ced1401: usb1401.c: split long lines

2014-07-11 Thread Luca Ellero
Fix checkpatch warnings "line over 80 characters" in file usb1401.c Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c | 168 +++-- 1 file changed, 105 insertions(+), 63 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c

[PATCH v4 05/12] staging: ced1401: ced_ioc.c: remove else branch in ced_set_event

2014-07-11 Thread Luca Ellero
Fix checkpatch warning "else is not generally useful after a break or return" in file ced_ioc.c, function ced_set_event() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) di

[PATCH v4 01/12] staging: ced1401: usb1401.c: change spaces to tabs

2014-07-11 Thread Luca Ellero
Fix checkpatch errors "code indent should use tabs where possible" in file usb1401.c Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/stagi

[PATCH v4 07/12] staging: ced1401: ced_ioc.c : split long lines

2014-07-11 Thread Luca Ellero
Fix checkpatch warnings "line over 80 characters" in file ced_ioc.c Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 66 +++-- 1 file changed, 42 insertions(+), 24 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drive

[PATCH v4 06/12] staging: ced1401: ced_ioc.c: remove else branch in ced_wait_event

2014-07-11 Thread Luca Ellero
Fix checkpatch warning "else is not generally useful after a break or return" in file ced_ioc.c, function ced_wait_event() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 65 +++-- 1 file changed, 33 insertions(+), 32 deletions(-)

[PATCH v4 02/12] staging: ced1401: usb1401.h: fix "foo * bar"

2014-07-11 Thread Luca Ellero
Fix checkpatch error "foo * bar" should be "foo *bar" in file usb1401.h Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ced1401/usb1401.h b/drivers/staging/ced1401/usb

Re: [PATCH v3 04/12] staging: ced1401: ced_ioc.c fix checkpatch warning

2014-07-11 Thread Luca Ellero
Il 11/07/2014 16:17, Dan Carpenter ha scritto: You have a lot of patches with the exact same subject. Use different subjects like: [patch] staging: ced1401: ced_ioc.c: change spaces to tabs or whatever. regards, dan carpeneter Hi Dan, OK, I'll resend regards Luca E

[PATCH v3 02/12] staging: ced1401: usb1401.h fix checkpatch errors

2014-07-11 Thread Luca Ellero
Fix checkpatch error "foo * bar" should be "foo *bar" in file usb1401.h Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ced1401/usb1401.h b/drivers/staging/ced1401/usb

[PATCH v3 05/12] staging: ced1401: ced_ioc.c fix checkpatch warning

2014-07-11 Thread Luca Ellero
Fix checkpatch warning "else is not generally useful after a break or return" in file ced_ioc.c, function ced_set_event() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) di

[PATCH v3 12/12] staging: ced1401: usb1401.c fix checkpatch warnings

2014-07-11 Thread Luca Ellero
Fix checkpatch warnings "quoted string split across lines" in file usb1401.c Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drive

[PATCH v3 10/12] staging: ced1401: rename camel case varialble

2014-07-11 Thread Luca Ellero
Rename camel case variable dwCount in function ced_writechar_callback Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb1401.c index

[PATCH v3 08/12] staging: ced1401: usb1401.c fix checkpatch warnings

2014-07-11 Thread Luca Ellero
Fix checkpatch warnings "Missing a blank line after declarations" in file usb1401.c Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb14

[PATCH v3 03/12] staging: ced1401: ced_ioc.c fix checkpatch warnings

2014-07-11 Thread Luca Ellero
Fix checkpatch warnings "Missing a blank line after declarations" in file ced_ioc.c Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/stagi

[PATCH v3 01/12] staging: ced1401: usb1401.c fix checkpatch errors

2014-07-11 Thread Luca Ellero
Fix checkpatch errors "code indent should use tabs where possible" in file usb1401.c Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/stagi

[PATCH v3 11/12] staging: ced1401: usb1401.c fix checkpatch warnings

2014-07-11 Thread Luca Ellero
Fix checkpatch warnings "line over 80 characters" in file usb1401.c Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c | 168 +++-- 1 file changed, 105 insertions(+), 63 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c

[PATCH v3 00/12] staging: ced1401: rename camel case function and vars

2014-07-11 Thread Luca Ellero
ether. Changes for v3: reworking of patches 111 to 115 (57-60 in v2): - split them on multiple patches - add more verbose comment Luca Ellero (12): staging: ced1401: usb1401.c fix checkpatch errors staging: ced1401: usb1401.h fix checkpatch errors staging: ced1401: ced_ioc.c fix checkpatch war

[PATCH v3 07/12] staging: ced1401: ced_ioc.c fix checkpatch warnings

2014-07-11 Thread Luca Ellero
Fix checkpatch warnings "line over 80 characters" in file ced_ioc.c Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 66 +++-- 1 file changed, 42 insertions(+), 24 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drive

[PATCH v3 04/12] staging: ced1401: ced_ioc.c fix checkpatch warning

2014-07-11 Thread Luca Ellero
Fix checkpatch warning "please, no space before tabs" in file ced_ioc.c Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c ind

[PATCH v3 09/12] staging: ced1401: usb1401.c fix checkpatch warning

2014-07-11 Thread Luca Ellero
Fix checkpatch warning "suspect code indent for conditional statements" in file usb1401.c Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/stagi

[PATCH v3 06/12] staging: ced1401: ced_ioc.c fix checkpatch warning

2014-07-11 Thread Luca Ellero
Fix checkpatch warning "else is not generally useful after a break or return" in file ced_ioc.c, function ced_wait_event() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 65 +++-- 1 file changed, 33 insertions(+), 32 deletions(-)

Re: [PATCH v2 59/60] staging: ced1401: ced_ioc.c fix checkpatch warnings

2014-07-11 Thread Luca Ellero
On 11/07/2014 00:12, Greg KH wrote: On Thu, Jul 10, 2014 at 11:04:15AM +0200, Luca Ellero wrote: Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 212 +++-- 1 file changed, 131 insertions(+), 81 deletions(-) That's a lot of changes a

[PATCH v2 60/60] staging: ced1401: usb1401.c fix checkpatch warnings

2014-07-10 Thread Luca Ellero
Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c | 263 +++-- 1 file changed, 167 insertions(+), 96 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb1401.c index a3d1ed6..f362859 100644 --- a/drivers

[PATCH v2 55/60] staging: ced1401: fix ced_get_circ_block()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_get_circ_block() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 34 +- drivers/staging/ced1401/usb1401.h |2 +- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a

[PATCH v2 52/60] staging: ced1401: fix ced_dbg_get_data()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_dbg_get_data() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 19 ++- drivers/staging/ced1401/usb1401.h |2 +- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/staging

[PATCH v2 57/60] staging: ced1401: usb1401.c fix checkpatch errors

2014-07-10 Thread Luca Ellero
Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb1401.c index 26e5f1b..a3d1ed6 100644 --- a/drivers/staging/ced1401/usb1401.c +++ b

[PATCH v2 58/60] staging: ced1401: usb1401.h fix checkpatch errors

2014-07-10 Thread Luca Ellero
Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ced1401/usb1401.h b/drivers/staging/ced1401/usb1401.h index 8e800c3..da4d90c 100644 --- a/drivers/staging/ced1401/usb1401.h +++ b/drivers

[PATCH v2 38/60] staging: ced1401: fix ced_set_transfer()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_set_transfer() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 19 +++ drivers/staging/ced1401/usb1401.h |3 ++- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/staging

[PATCH v2 51/60] staging: ced1401: fix ced_dbg_ramp_data/addr()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_dbg_ramp_data() and ced_dbg_ramp_addr() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 56 ++--- drivers/staging/ced1401/usb1401.h |4 +-- 2 files changed, 30 insertions(+), 30

[PATCH v2 48/60] staging: ced1401: fix ced_transfer_flags()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_transfer_flags() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c index

[PATCH v2 40/60] staging: ced1401: fix ced_set_event()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_set_event() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 33 - drivers/staging/ced1401/usb1401.h |3 ++- 2 files changed, 22 insertions(+), 14 deletions(-) diff --git a/drivers

[PATCH v2 47/60] staging: ced1401: fix ced_type_of_1401()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_type_of_1401() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c

[PATCH v2 44/60] staging: ced1401: fix ced_state_of_1401()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_state_of_1401() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c index

[PATCH v2 54/60] staging: ced1401: fix ced_set_circular()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_set_circular() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 25 ++--- drivers/staging/ced1401/usb1401.h |3 ++- 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/staging

[PATCH v2 50/60] staging: ced1401: fix ced_dbg_peek/poke()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_dbg_peek() and ced_dbg_poke() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 44 ++--- drivers/staging/ced1401/usb1401.h |4 ++-- 2 files changed, 24 insertions(+), 24 deletions

[PATCH v2 45/60] staging: ced1401: fix ced_start_self_test()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_start_self_test() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c

[PATCH v2 56/60] staging: ced1401: fix ced_free_circ_block()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_free_circ_block() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 103 - drivers/staging/ced1401/usb1401.h |2 +- 2 files changed, 58 insertions(+), 47 deletions(-) diff --git a

[PATCH v2 39/60] staging: ced1401: fix ced_unset_transfer()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_unset_transfer() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 10 +- drivers/staging/ced1401/usb1401.h |2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ced1401

[PATCH v2 59/60] staging: ced1401: ced_ioc.c fix checkpatch warnings

2014-07-10 Thread Luca Ellero
Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 212 +++-- 1 file changed, 131 insertions(+), 81 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c index fb4e8a3..717b4ce 100644 --- a/drivers

[PATCH v2 53/60] staging: ced1401: fix ced_dbg_stop_loop()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_dbg_stop_loop() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c index

[PATCH v2 43/60] staging: ced1401: fix ced_get_transfer()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_get_transfer() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 18 ++ drivers/staging/ced1401/usb1401.h |2 +- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/staging/ced1401

[PATCH v2 42/60] staging: ced1401: fix ced_test_event()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_test_event() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 20 +++- drivers/staging/ced1401/usb1401.h |2 +- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/staging/ced1401

[PATCH v2 46/60] staging: ced1401: fix ced_check_self_test()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_check_self_test() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 40 +++-- drivers/staging/ced1401/usb1401.h |3 ++- 2 files changed, 23 insertions(+), 20 deletions(-) diff --git a

[PATCH v2 37/60] staging: ced1401: fix ced_set_area()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_set_area() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 109 +++-- 1 file changed, 57 insertions(+), 52 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging

[PATCH v2 41/60] staging: ced1401: fix ced_wait_event()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_wait_event() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 58 - drivers/staging/ced1401/usb1401.h |2 +- 2 files changed, 33 insertions(+), 27 deletions(-) diff --git a

[PATCH v2 49/60] staging: ced1401: fix ced_dbg_cmd()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_dbg_cmd() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c index

[PATCH v2 33/60] staging: ced1401: fix ced_stat_1401()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_stat_1401() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c index 28697c0

[PATCH v2 23/60] staging: ced1401: fix comment

2014-07-10 Thread Luca Ellero
Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c index 60a671e..1b7ed4f 100644 --- a/drivers/staging/ced1401/ced_ioc.c +++ b/drivers

[PATCH v2 36/60] staging: ced1401: fix ced_clear_area()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_clear_area() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 90 - drivers/staging/ced1401/usb1401.h |2 +- 2 files changed, 51 insertions(+), 41 deletions(-) diff --git a

[PATCH v2 26/60] staging: ced1401: fix ced_send_char()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_send_char() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c index 0c96202

[PATCH v2 22/60] staging: ced1401: fix ced_disconnect()

2014-07-10 Thread Luca Ellero
Rename camel case locals in function ced_disconnect() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb1401.c index c8685c1..26e5f1b 100644

[PATCH v2 29/60] staging: ced1401: fix ced_is_1401()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_is_1401() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 48 + 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging

[PATCH v2 28/60] staging: ced1401: fix ced_in_self_test()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_in_self_test() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c

[PATCH v2 24/60] staging: ced1401: fix ced_put_chars()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_put_chars() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c

[PATCH v2 34/60] staging: ced1401: fix ced_line_count()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_line_count() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401

[PATCH v2 14/60] staging: ced1401: fix ced_read_char()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_read_char() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401

[PATCH v2 17/60] staging: ced1401: fix ced_read_dma_info()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_read_dma_info() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c | 90 - 1 file changed, 48 insertions(+), 42 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers

[PATCH v2 27/60] staging: ced1401: fix ced_get_state()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_get_state() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/ced_ioc.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401

[PATCH v2 19/60] staging: ced1401: fix ced_readchar_callback()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_readchar_callback() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c | 63 ++--- 1 file changed, 37 insertions(+), 26 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers

[PATCH v2 16/60] staging: ced1401: fix ced_read_huff()

2014-07-10 Thread Luca Ellero
Rename camel case arguments and locals in function ced_read_huff() Signed-off-by: Luca Ellero --- drivers/staging/ced1401/usb1401.c | 45 - 1 file changed, 24 insertions(+), 21 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging

  1   2   3   >