Re: [PATCH 1/2] mm: add locked parameter to get_user_pages()

On Mon, Nov 07, 2016 at 11:49:18AM +0100, Jesper Nilsson wrote: > For the cris-part: > Acked-by: Jesper Nilsson Thanks very much for that, however just to avoid any confusion, I realised this series was not not the right way forward after discussion with Paolo and rather it makes more sense to ke

Re: [PATCH 2/2] mm: remove get_user_pages_locked()

On Mon, Oct 31, 2016 at 06:55:33PM +0100, Paolo Bonzini wrote: > > 2. There is currently only one caller of get_user_pages_locked() in > >mm/frame_vector.c which seems to suggest this function isn't widely > >used/known. > > Or not widely necessary. :) Well, quite :) > > > 3. This change r

Re: [PATCH 2/2] mm: remove get_user_pages_locked()

On Mon, Oct 31, 2016 at 12:45:36PM +0100, Paolo Bonzini wrote: > > > On 31/10/2016 11:02, Lorenzo Stoakes wrote: > > - * > > - * get_user_pages should be phased out in favor of > > - * get_user_pages_locked|unlocked or get_user_pages_fast. Nothing > > - * sho

[PATCH 1/2] mm: add locked parameter to get_user_pages()

behaviour when faulting in pages. It should not introduce any functional changes, however it does allow for subsequent changes to get_user_pages() callers to take advantage of VM_FAULT_RETRY. Signed-off-by: Lorenzo Stoakes --- arch/cris/arch-v32/drivers/cryptocop.c| 2

[PATCH 2/2] mm: remove get_user_pages_locked()

get_user_pages() now has an int *locked parameter which renders get_user_pages_locked() redundant, so remove it. This patch should not introduce any functional changes. Signed-off-by: Lorenzo Stoakes --- include/linux/mm.h | 2 -- mm/frame_vector.c | 4 ++-- mm/gup.c | 56

[PATCH 0/2] mm: remove get_user_pages_locked()

. Lorenzo Stoakes (2): mm: add locked parameter to get_user_pages() mm: remove get_user_pages_locked() arch/cris/arch-v32/drivers/cryptocop.c | 2 + arch/ia64/kernel/err_inject.c | 2 +- arch/x86/mm/mpx.c | 2 +- drivers/gpu

Re: [PATCH RESEND 2 1/5] staging: sm750fb: Use memset_io instead of memset

On 23 March 2015 at 13:21, Lorenzo Stoakes wrote: > Sigh. Checking the emails I actually sent, I seem to *somehow* have > sent old files in this resend :S I really don't know how this > happened. My copies of the patches all apply perfectly correctly, but > these are not the

Re: [PATCH RESEND 2 1/5] staging: sm750fb: Use memset_io instead of memset

On 23 March 2015 at 13:16, Lorenzo Stoakes wrote: > I've tried applying resend 2 patches to both linux-next and > staging-testing in Greg's staging.git tree, they apply in both places. Sigh. Checking the emails I actually sent, I seem to *somehow* have sent old files in this re

Re: [PATCH RESEND 2 1/5] staging: sm750fb: Use memset_io instead of memset

On 23 March 2015 at 13:14, Sudip Mukherjee wrote: > On Mon, Mar 23, 2015 at 01:02:52PM +0000, Lorenzo Stoakes wrote: >> On 23 March 2015 at 12:55, Sudip Mukherjee >> wrote: >> >> > and you need to send v3 now :( >> > your series is not applying. Pl

Re: [PATCH RESEND 2 1/5] staging: sm750fb: Use memset_io instead of memset

On 23 March 2015 at 12:55, Sudip Mukherjee wrote: > and you need to send v3 now :( > your series is not applying. Please refresh it against staging-testing Applies to staging-testing for me. Are you sure you're applying the correct 'RESEND 2' patches? -- Lorenzo

Re: [PATCH RESEND 2 1/5] staging: sm750fb: Use memset_io instead of memset

ook at the --in-reply-to flag. Will do, apologies for the mess up, it makes sense that the v2's should be replies to their respective v1s. Best, -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdr

Re: [PATCH RESEND 2 1/5] staging: sm750fb: Use memset_io instead of memset

gt; Otherwise this set looks ok. Thanks! > > Reviewed-by: Dan Carpenter > Thanks for that, appreciated! Best, -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH RESEND 2 1/5] staging: sm750fb: Use memset_io instead of memset

) drivers/staging/sm750fb/sm750.c:1154:9: warning: incorrect type in argument 1 (different address spaces) Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/sm750.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/driver

[PATCH RESEND 2 3/5] staging: sm750fb: Remove unused function

This patch removes the unused hw712_fillrect function. This patch fixes the following sparse warning:- drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect' was not declared. Should it be static? Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/sm7

[PATCH RESEND 2 4/5] staging: sm750fb: Fix __iomem pointer types

byte-sized. This fixes the following sparse warnings:- drivers/staging/sm750fb/sm750_cursor.c:113:19: warning: cast removes address space of expression drivers/staging/sm750fb/sm750_cursor.c:204:19: warning: cast removes address space of expression Signed-off-by: Lorenzo Stoakes --- drivers

Re: [PATCH RESEND v2 4/5] staging: sm750fb: Fix __iomem pointer types

dating them to apply against staging-testing. Best, -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH RESEND 2 5/5] staging: sm750fb: Remove spinlock helper function

This patch removes the unnecessary spinlock helper function and instead calls spin_lock and spin_unlock directly. This does *not* resolve sparse warnings about context imbalances but these are spurious. Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/sm750.c | 53

[PATCH RESEND 2 2/5] staging: sm750fb: Make internal functions static

ng: symbol 'hwI2CWriteData' was not declared. Should it be static? drivers/staging/sm750fb/ddk750_hwi2c.c:160:14: warning: symbol 'hwI2CReadData' was not declared. Should it be static? Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/ddk750_hwi2c.c | 6 +++--- 1 files changed

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

need changes. Let me know if you'd like this done differently! Best, -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

On 18 March 2015 at 11:25, Dan Carpenter wrote: > Could you read your patches again and find other similar white space > issues. Done. Best, -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverproject.or

[PATCH RESEND v2 1/5] staging: sm750fb: Use memset_io instead of memset

) drivers/staging/sm750fb/sm750.c:1154:9: warning: incorrect type in argument 1 (different address spaces) Signed-off-by: Lorenzo Stoakes --- v2: Whitespace fixups, updated commit message drivers/staging/sm750fb/sm750.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) dif

[PATCH RESEND v2 4/5] staging: sm750fb: Fix __iomem pointer types

byte-sized. This fixes the following sparse warnings:- drivers/staging/sm750fb/sm750_cursor.c:113:19: warning: cast removes address space of expression drivers/staging/sm750fb/sm750_cursor.c:204:19: warning: cast removes address space of expression Signed-off-by: Lorenzo Stoakes --- v2

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

and see it as a means to improve my contributions :) > > Call it a v2 patch. Put a note under the --- cut off line: > v2: updated to apply to latest linux-next > > http://kernelnewbies.org/PatchTipsAndTricks > Great, thanks, will do! Very useful link! Best, --

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

to fix these on the lines I'm changing, will fix these! Best, -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

I will learn to do things a little more sanely in time, the hard way :) Best, -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

the ANSI C function prototype fixes having already been applied. Best, -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

omem or __user pointers > but they used them in non-standard ways so the pointers were actually > normal kernel pointers. So it wasn't clear *to me* you wanted me to change that, given you asked me *not* to redo it explicitly (which I assumed applied to the message too) - a

[PATCH RESEND 5/5] staging: sm750fb: Remove spinlock helper function

This patch removes the unnecessary spinlock helper function and instead calls spin_lock and spin_unlock directly. This does *not* resolve sparse warnings about context imbalances but these are spurious. Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/sm750.c | 53

[PATCH RESEND 3/5] staging: sm750fb: Remove unused function

This patch removes the unused hw712_fillrect function. This patch fixes the following sparse warning:- drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect' was not declared. Should it be static? Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/sm7

[PATCH RESEND 4/5] staging: sm750fb: Fix __iomem pointer types

byte-sized. This fixes the following sparse warnings:- drivers/staging/sm750fb/sm750_cursor.c:113:19: warning: cast removes address space of expression drivers/staging/sm750fb/sm750_cursor.c:204:19: warning: cast removes address space of expression Signed-off-by: Lorenzo Stoakes --- drivers

[PATCH RESEND 2/5] staging: sm750fb: Make internal functions static

/ddk750_hwi2c.c:93:14: warning: symbol 'hwI2CWriteData' was not declared. Should it be static? drivers/staging/sm750fb/ddk750_hwi2c.c:160:14: warning: symbol 'hwI2CReadData' was not declared. Should it be static? Signed-off-by: Lorenzo Stoakes --- drivers/staging

[PATCH RESEND 1/5] staging: sm750fb: Use memset_io instead of memset

: warning: incorrect type in argument 1 (different address spaces) drivers/staging/sm750fb/sm750.c:1154:9: warning: incorrect type in argument 1 (different address spaces) Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/sm750.c | 12 ++-- 1 file changed, 6 insertions(+), 6

Re: [PATCH v2 6/6] staging: sm750fb: Remove spinlock helper function

for me to resend the whole series to make it clear which is applicable right now. Best, -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging/sm75fb: Declare static functions as such

s not been covered already. Additionally, your subject line is 'staging/sm75fb: Declare static functions as such' which ought to be 'staging: sm750fb: Declare static functions as such' - there's a typo in the device name and I think the convention is always to use colons in

[PATCH v2 6/6] staging: sm750fb: Remove spinlock helper function

This patch removes the unnecessary spinlock helper function and instead calls spin_lock and spin_unlock directly. This does *not* resolve sparse warnings about context imbalances but these are spurious. Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/sm750.c | 47

Re: [PATCH v2 6/6] staging: sm750fb: Remove spinlock helper function

find the v2 resubmits of unchanged code to be confusing. I am absolutely happy to do whatever works for Greg of course! Best, -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 4/6] staging: sm750fb: Remove unused function

On 11 March 2015 at 10:57, Sudip Mukherjee wrote: > but function prototype still remains in sm750_accel.h No it doesn't, v2 of patch 3 in the series no longer puts it there :) -- Lorenzo Stoakes https:/ljs.io ___ devel mailing

[PATCH v2 4/6] staging: sm750fb: Remove unused function

This patch removes the unused hw712_fillrect function. This patch fixes the following sparse warning:- drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect' was not declared. Should it be static? Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/sm7

[PATCH v2 3/6] staging: sm750fb: Make internal functions static

/ddk750_hwi2c.c:93:14: warning: symbol 'hwI2CWriteData' was not declared. Should it be static? drivers/staging/sm750fb/ddk750_hwi2c.c:160:14: warning: symbol 'hwI2CReadData' was not declared. Should it be static? Signed-off-by: Lorenzo Stoakes --- drivers/staging

Re: [PATCH 1/6] staging: sm750fb: Use memset_io instead of memset

r limit throughout? Best, -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 4/6] staging: sm750fb: Expose hw712_fillrect externally

mistake :) I'll fix it shortly. > anyways, like Dan said, delete this function, its not used anywhere. > it will not be used also, i missed removing this function from the > vendor crude drver. Will do! Best, -- Lorenzo Stoakes https:/ljs.io

Re: [PATCH 3/6] staging: sm750fb: Make internal functions static

s patch. In a later patch I expose this function in the header file. I'll update this patch not to touch hw712_fillrect then remove it in a later patch altogether. Best, -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@lin

Re: [PATCH 1/6] staging: sm750fb: Use memset_io instead of memset

Sudip? If it isn't too presumptuous of me to ask, perhaps you might be able to check patches that are successfully merged into staging-testing? Best, -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverproject.org http:/

[PATCH 6/6] staging: sm750fb: Spinlock and unlock in the same block

lock contexts for basic block Unfortunately this change involves code (and comment) duplication. Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/sm750.c | 76 +++-- 1 file changed, 43 insertions(+), 33 deletions(-) diff --git a/drivers/staging/sm7

[PATCH 5/6] staging: sm750fb: Fix __iomem pointer types

byte-sized. This fixes the following sparse warnings:- drivers/staging/sm750fb/sm750_cursor.c:113:19: warning: cast removes address space of expression drivers/staging/sm750fb/sm750_cursor.c:204:19: warning: cast removes address space of expression Signed-off-by: Lorenzo Stoakes --- drivers

[PATCH 4/6] staging: sm750fb: Expose hw712_fillrect externally

t declared. Should it be static? Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/sm750_accel.c | 2 +- drivers/staging/sm750fb/sm750_accel.h | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_acc

[PATCH 2/6] staging: sm750fb: Fix non-ANSI function declarations

750fb/ddk750_sii164.c:54:34: warning: non-ANSI function declaration of function 'sii164GetDeviceID' drivers/staging/sm750fb/ddk750_dvi.c:65:31: warning: non-ANSI function declaration of function 'dviGetVendorID' drivers/staging/sm750fb/ddk750_dvi.c:85:31: warning: non-ANSI function de

[PATCH 3/6] staging: sm750fb: Make internal functions static

/ddk750_hwi2c.c:93:14: warning: symbol 'hwI2CWriteData' was not declared. Should it be static? drivers/staging/sm750fb/ddk750_hwi2c.c:160:14: warning: symbol 'hwI2CReadData' was not declared. Should it be static? Signed-off-by: Lorenzo Stoakes --- drivers/staging

[PATCH 1/6] staging: sm750fb: Use memset_io instead of memset

: warning: incorrect type in argument 1 (different address spaces) drivers/staging/sm750fb/sm750.c:1154:9: warning: incorrect type in argument 1 (different address spaces) Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/sm750.c | 12 ++-- 1 file changed, 6 insertions(+), 6

Re: [PATCH v2] staging: sm750fb: Fix sparse warning

ke a look at this later today when I have the opportunity to do so :) -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3] staging: sm750fb: Cleanup the type of mmio750

lynx_share->pvReg field which is passed to the ddk750_set_mmio method. As a consequence, this patch fixes the following sparse warning:- drivers/staging/sm750fb/ddk750_help.c:12:17: warning: incorrect type in assignment (different address spaces) Signed-off-by: Lorenzo Stoakes --- drivers/stag

Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750

pdated version of this patch. Best, -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2] staging: sm750fb: Cleanup the type of mmio750

lynx_share->pvReg field which is passed to the ddk750_set_mmio method. As a consequence, this patch fixes the following sparse warning:- drivers/staging/sm750fb/ddk750_help.c:12:17: warning: incorrect type in assignment (different address spaces) Signed-off-by: Lorenzo Stoakes --- drivers/stag

Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750

ust send? In > that case just fold it in and don't do the temporary casting. > > The next patch after that could get rid of all the ramaining "volatile" > keywords. It seems that we can in fact fix this problem with a single additional change, I wi

Re: [PATCH] staging: sm750fb: Cleanup the type of mmio750

with this variable, but also code that indirectly interacts with it, so I felt that should perhaps be a separate patch. I'd love to additionally provide some further patches to help out with issues here too, incidentally! I will try to prepare some further

[PATCH] staging: sm750fb: Cleanup the type of mmio750

fixes the following sparse warning:- drivers/staging/sm750fb/ddk750_help.c:12:17: warning: incorrect type in assignment (different address spaces) Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/ddk750_chip.h | 4 +++- drivers/staging/sm750fb/ddk750_help.c | 4 ++-- drivers/staging

Re: [PATCH] staging: sm750fb: Fix sparse warning

le problem instead of half a thing per patch. > > regards, > dan carpenter > Sure, sorry saw the patch as purely a sparse fixup, will adapt to be an overall mmio750 cleanup and resubmit! Best, -- Lorenzo Stoakes https:/ljs.io ___ devel

[PATCH v2] staging: sm750fb: Fix sparse warning

This patch fixes the following sparse warning:- drivers/staging/sm750fb/ddk750_help.c: warning: incorrect type in assignment (different address spaces) In addition it eliminates an unnecessary volatile. Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/ddk750_chip.h | 4

Re: [PATCH] staging: sm750fb: Fix sparse warning

han happy to do this and make the appropriate changes to the macros in ddk750_help.h. -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: sm750fb: Fix sparse warning

d if your patch series is applied first, I will keep an eye out for this, additionally if you ping me if this occurs I will fix it right away. Best, -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverproject

[PATCH] staging: sm750fb: Fix sparse warning

This patch fixes the following sparse warning:- drivers/staging/sm750fb/ddk750_help.c: warning: incorrect type in assignment (different address spaces) Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/ddk750_chip.h | 4 +++- drivers/staging/sm750fb/ddk750_help.c | 2 +- 2 files

[PATCH RESEND 3 2/4] staging: rtl8192u: fix whitespace and alignment

This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace in r8192U_dm.c, removes inconsistent whitespace, and additionally fixes some vertical alignment issues. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 1604

[PATCH RESEND 3 3/4] staging: rtl8192u: remove redundant code

This patch fixes warnings/errors raised by checkpatch.pl relating to redundant code in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 153 --- 1 file changed, 68 insertions(+), 85 deletions(-) diff --git a/drivers/staging

[PATCH RESEND 3 4/4] staging: rtl8192u: Refactor heavy nesting

This patch fixes warnings raised by checkpatch.pl relating to heavily indented lines in r8192U_dm.c by refactoring code to achieve the same outcome indented by one less tab. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 27 --- 1 file changed

[PATCH RESEND 3 1/4] staging: rtl8192u: fix comments

This patch fixes errors raised by checkpatch.pl relating to use of C99 comments in r8192U_dm.c, and cleans up existing ANSI C comments. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 807 ++- 1 file changed, 416 insertions(+), 391

Re: [PATCH RESEND 2 1/4] staging: rtl8192u: fix comments

test branch instead of staging-testing as you actually requested :) I will fix now. -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH RESEND 2 2/4] staging: rtl8192u: fix whitespace and alignment

This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace in r8192U_dm.c, removes inconsistent whitespace, and additionally fixes some vertical alignment issues. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 1697

[PATCH RESEND 2 1/4] staging: rtl8192u: fix comments

This patch fixes errors raised by checkpatch.pl relating to use of C99 comments in r8192U_dm.c, and cleans up existing ANSI C comments. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 811 ++- 1 file changed, 420 insertions(+), 391

[PATCH RESEND 2 3/4] staging: rtl8192u: remove redundant code

This patch fixes warnings/errors raised by checkpatch.pl relating to redundant code in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 165 --- 1 file changed, 74 insertions(+), 91 deletions(-) diff --git a/drivers/staging

[PATCH RESEND 2 4/4] staging: rtl8192u: Refactor heavy nesting

This patch fixes warnings raised by checkpatch.pl relating to heavily indented lines in r8192U_dm.c by refactoring code to achieve the same outcome indented by one less tab. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 27 --- 1 file changed

[PATCH RESEND 2/4] staging: rtl8192u: fix whitespace and alignment

This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace in r8192U_dm.c, removes inconsistent whitespace, and additionally fixes some vertical alignment issues. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 1606

[PATCH RESEND 3/4] staging: rtl8192u: remove redundant code

This patch fixes warnings/errors raised by checkpatch.pl relating to redundant code in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 176 +-- 1 file changed, 84 insertions(+), 92 deletions(-) diff --git a/drivers/staging

[PATCH RESEND 4/4] staging: rtl8192u: Refactor heavy nesting

This patch fixes warnings raised by checkpatch.pl relating to heavily indented lines in r8192U_dm.c by refactoring code to achieve the same outcome indented by one less tab. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 27 --- 1 file changed

[PATCH RESEND 1/4] staging: rtl8192u: fix comments

This patch fixes errors raised by checkpatch.pl relating to use of C99 comments in r8192U_dm.c, and cleans up existing ANSI C comments. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 811 ++- 1 file changed, 420 insertions(+), 391

Re: [PATCH v2 3/4] staging: rtl8192u: remove redundant code

On 1 January 2015 at 04:58, Sudip Mukherjee wrote: > On Thu, Jan 01, 2015 at 10:19:56AM +0530, Sudip Mukherjee wrote: >> but this is just removal of unnecessary braces. this is not removal of >> redundant code. Hi Sudip, Again in the same theme as the whitespace changes I felt I could fairly re

Re: [PATCH v3 2/4] staging: rtl8192u: fix whitespace

On 1 January 2015 at 06:28, Sudip Mukherjee wrote: >> > i may be wrong, but looks like you are doing many different things in the >> > patch, not just whitespace errors. >> > marked a few, please see inline - ... > sorry for not trimming that. I noticed the big size while sending, but at > that

[PATCH v3 2/4] staging: rtl8192u: fix whitespace

This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace in r8192U_dm.c and additionally it removes inconsistent whitespace throughout. Additionally some 0x00... padding has been added for alignment to the edca_setting_* variables. Signed-off-by: Lorenzo Stoakes

Re: [PATCH v2 2/4] staging: rtl8192u: fix whitespace

On 31 December 2014 at 21:20, Joe Perches wrote: > It'd be nicer to use the same form and indentation > for both entries. > > Probably be nicer to use: > > static u32 edca_setting_DL[HT_IOT_PEER_MAX] = { > 0x5e4322, 0x5e4322, 0x5e4322, 0x604322, 0x00a44f, 0x5ea44f > }; > static u32 edca_s

[PATCH v2 2/4] staging: rtl8192u: fix whitespace

This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace in r8192U_dm.c and additionally it removes inconsistent whitespace throughout. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 1606 +- 1 file changed, 625

[PATCH v2 4/4] staging: rtl8192u: Refactor heavy nesting

: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c index ed566bb..bae8511 100644 --- a/drivers/staging/rtl8192u

[PATCH v2 3/4] staging: rtl8192u: remove redundant code

This patch fixes warnings/errors raised by checkpatch.pl relating to redundant code in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 176 +-- 1 file changed, 84 insertions(+), 92 deletions(-) diff --git a/drivers/staging

[PATCH v2 1/4] staging: rtl8192u: fix comments

This patch fixes errors raised by checkpatch.pl relating to use of C99 comments in r8192U_dm.c and cleans up existing ANSI C comments. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 811 ++- 1 file changed, 420 insertions(+), 391

Re: [PATCH 1/4] staging: rtl8192u: fix comments

On 31 December 2014 at 19:23, Jeremiah Mahler wrote: > But this change is not related to C99 comments and you didn't > explain why this change was made in your log message. > It should probably be in a separate patch. Absolutely, I am currently fixing this and checking for any other instances whe

Re: [PATCH 1/4] staging: rtl8192u: fix comments

On 31 December 2014 at 19:00, Konrad Zapalowicz wrote: > > You also fix the line length here which shall be the subject of a > separate patch as this is not C99 comments related change. > Apologies - I missed this, will prepare a v2 with this separated out into a different patch. Relatedly, the i

[PATCH 2/4] staging: rtl8192u: fix whitespace

This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 1409 +- 1 file changed, 530 insertions(+), 879 deletions(-) diff --git a/drivers/staging

[PATCH 3/4] staging: rtl8192u: remove redundant code

This patch fixes warnings/errors raised by checkpatch.pl relating to redundant code in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 160 +-- 1 file changed, 77 insertions(+), 83 deletions(-) diff --git a/drivers/staging

[PATCH 4/4] staging: rtl8192u: Refactor heavy nesting

: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c index 0839ea7..72d1f47 100644 --- a/drivers/staging/rtl8192u

[PATCH 1/4] staging: rtl8192u: fix comments

This patch fixes errors raised by checkpatch.pl relating to use of C99 comments in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 841 ++- 1 file changed, 432 insertions(+), 409 deletions(-) diff --git a/drivers/staging